usb: atm: ueagle: fix use-after-free in uea_upload_pre_firmware()
Subsystems (5)
PATCH 1/1 usb: atm: ueagle: fix use-after-free in uea_upload_pre_firmware()
uea_load_firmware() calls request_firmware_nowait() passing a raw struct usb_device pointer as context, without holding a reference to it.
If the USB device is disconnected before the firmware workqueue fires, the usb_device and its usb_interface objects are freed while uea_upload_pre_firmware() is still pending on the workqueue. When the callback eventually runs, it accesses the freed memory causing a slab-use-after-free:
BUG: KASAN: slab-use-after-free in __intf_to_usbdev include/linux/usb.h:752 [inline] BUG: KASAN: slab-use-after-free in uea_upload_pre_firmware+0x8d/0x640 drivers/usb/atm/ueagle-atm.c:598 Read of size 8 at addr ffff88802b0710b8 by task kworker/0:2/1664
Fix by calling usb_get_dev() before queuing the firmware request to pin the usb_device in memory for the lifetime of the async operation, and usb_put_dev() in the callback once it is finished with the pointer. On the error path where request_firmware_nowait() itself fails, drop the reference immediately since the callback will never fire.
--- drivers/usb/atm/ueagle-atm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/usb/atm/ueagle-atm.c +5 -2
@@ -663,6 +663,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry,uea_err (usb,"firmware is corrupted\n" ); err:release_firmware (fw_entry); +usb_put_dev (usb); }/*
@@ -693,12 +694,14 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)break ; } +usb_get_dev (usb); ret =request_firmware_nowait (THIS_MODULE ,1 , fw_name, &usb->dev,GFP_KERNEL , usb, uea_upload_pre_firmware); -if (ret) +if (ret) {uea_err (usb,"firmware %s is not available\n" , fw_name); -else +usb_put_dev (usb); + }else uea_info (usb,"loading firmware %s\n" , fw_name);return ret;
Signature · 1 line
2.43.0
Stanislaw Gruszka
maintainerHi, thanks for working at this,
Quoted 16 lines · Deepanshu Kartikey
uea_load_firmware()callsrequest_firmware_nowait()passing a raw structusb_devicepointer as context, without holding a reference to it.If the USB device is disconnected before the firmware workqueue fires, the
usb_deviceand itsusb_interfaceobjects are freed whileuea_upload_pre_firmware()is still pending on the workqueue. When the callback eventually runs, it accesses the freed memory causing a slab-use-after-free:BUG: KASAN: slab-use-after-free in __intf_to_usbdev include/linux/usb.h:752 [inline] BUG: KASAN: slab-use-after-free in uea_upload_pre_firmware+0x8d/0x640 drivers/usb/atm/ueagle-atm.c:598 Read of size 8 at addr ffff88802b0710b8 by task kworker/0:2/1664
Quoted 8 lines
Fix by calling
usb_get_dev()before queuing the firmware request to pin theusb_devicein memory for the lifetime of the async operation, andusb_put_dev()in the callback once it is finished with the pointer. On the error path whererequest_firmware_nowait()itself fails, drop the reference immediately since the callback will never fire.
I think the problem is not lack of usb device reference. request_firmware_nowait() does get_device() and after fw work finish - put_device().
I suspect the issue is that syskaller corrupt descriptor such the below condition:
else if (usb->config->desc.bNumInterfaces == 1)
is not met for pre-firmware device.
Adding Mauricio, who has setup for reproducing syskaller bugs on ueagle. Hopefully he can confirm the diagnostic. If it's correct, we could either save flag to recognize pre-firmware device, or separate driver probe/disconnect for pre-firmware and post-firmware, to fix the issue.
Regards
Stanislaw
Quoted 37 lines
Signed-off-by Deepanshu Kartikey <[email protected]>--- drivers/usb/atm/ueagle-atm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)drivers/usb/atm/ueagle-atm.c +5
-2@@ -663,6 +663,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry,uea_err (usb,"firmware is corrupted\n" ); err:release_firmware (fw_entry); +usb_put_dev (usb); }/* @@ -693,12 +694,14 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)break ; } +usb_get_dev (usb); ret =request_firmware_nowait (THIS_MODULE ,1 , fw_name, &usb->dev,GFP_KERNEL , usb, uea_upload_pre_firmware); -if (ret) +if (ret) {uea_err (usb,"firmware %s is not available\n" , fw_name); -else +usb_put_dev (usb); + }else uea_info (usb,"loading firmware %s\n" , fw_name);return ret;Signature · 1 line
2.43.0