media: atomisp: clean up block comment formatting
Subsystems (4)
cover media: atomisp: clean up block comment formatting
This patch series addresses the block comment formatting issues across several header files in the atomisp driver, as suggested in previous reviews. The comments have been reformatted to comply with the Linux kernel coding style guidelines.
Checkpatch reports no remaining errors or warnings for these files.
Bohdan D. Marcus (3):
media: atomisp: fix block comment formatting in atomisp_internal.h
media: atomisp: fix block comment formatting in ia_css_mipi.h
media: atomisp: fix block comment formatting in ia_css_timer.h
.../media/atomisp/pci/atomisp_internal.h | 3 +- .../staging/media/atomisp/pci/ia_css_mipi.h | 6 ++- .../staging/media/atomisp/pci/ia_css_timer.h | 49 +++++++++++-------- 3 files changed, 34 insertions(+), 24 deletions(-)
Signature · 1 line
2.55.0
PATCH 1/3 media: atomisp: fix block comment formatting in atomisp_internal.h
Fix a block comment formatting issue reported by checkpatch.pl in atomisp_internal.h by moving the opening '/*' and closing '*/' lines to conform to the Linux kernel coding style guidelines.
--- drivers/staging/media/atomisp/pci/atomisp_internal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/atomisp/pci/atomisp_internal.h +2 -1
@@ -182,7 +182,8 @@ struct atomisp_device {struct atomisp_mipi_csi2_device csi2_port[ATOMISP_CAMERA_NR_PORTS ];/* Purpose of mutex is to protect and serialize use of isp data -* structures and css API calls. */ +* structures and css API calls. +*/ struct mutex mutex;/*
Signature · 1 line
2.55.0
PATCH 2/3 media: atomisp: fix block comment formatting in ia_css_mipi.h
In reply to Bohdan D. MarcusFix block comment formatting issues reported by checkpatch.pl in ia_css_mipi.h by moving the opening '/*' to a separate line to conform to the Linux kernel coding style guidelines.
--- drivers/staging/media/atomisp/pci/ia_css_mipi.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_mipi.h +4 -2
@@ -7,7 +7,8 @@#ifndef __IA_CSS_MIPI_H#define __IA_CSS_MIPI_H -/* @file +/* +* @file * This file contains MIPI support functionality */
@@ -16,7 +17,8 @@#include "ia_css_stream_format.h" #include "ia_css_input_port.h" -/* @brief Calculate the size of a mipi frame. +/* +* @brief Calculate the size of a mipi frame. * * @param[in] width The width (in pixels) of the frame. * @param[in] height The height (in lines) of the frame.
Signature · 1 line
2.55.0
PATCH 3/3 media: atomisp: fix block comment formatting in ia_css_timer.h
In reply to Bohdan D. MarcusFix block comment formatting issues reported by checkpatch.pl in ia_css_timer.h by ensuring block comments use '*' on subsequent lines and aligning them properly to conform to the Linux kernel coding style guidelines. Also, remove misplaced Kernel-doc tags from macro definitions and correct function signature formatting.
--- .../staging/media/atomisp/pci/ia_css_timer.h | 49 +++++++++++-------- 1 file changed, 28 insertions(+), 21 deletions(-)
drivers/staging/media/atomisp/pci/ia_css_timer.h +28 -21
@@ -1,23 +1,28 @@/* SPDX-License-Identifier: GPL-2.0 */ /** -Support for Intel Camera Imaging ISP subsystem. -Copyright (c) 2010 - 2015, Intel Corporation. - -*/ +* Support for Intel Camera Imaging ISP subsystem. +* Copyright (c) 2010 - 2015, Intel Corporation. +*/ #ifndef __IA_CSS_TIMER_H#define __IA_CSS_TIMER_H -/* @file +/* +* @file * Timer interface definitions */ -#include <type_support.h> /* for uint32_t */ +#include <type_support.h> /* for uint32_t */ #include "ia_css_err.h" -/* @brief timer reading definition */ +/* +* @brief timer reading definition +*/ typedef u32 clock_value_t ; -/* @brief 32 bit clock tick,(timestamp based on timer-value of CSS-internal timer)*/ +/* +* @brief 32 bit clock tick, (timestamp based on timer-value of +* CSS-internal timer) +*/ struct ia_css_clock_tick {clock_value_t ticks;/** measured time in ticks.*/ };
@@ -38,24 +43,26 @@ enum ia_css_tm_event {/* @brief code measurement common struct */ struct ia_css_time_meas { -clock_value_t start_timer_value;/** measured time in ticks */ -clock_value_t end_timer_value;/** measured time in ticks */ +clock_value_t start_timer_value;/** measured time in ticks */ +clock_value_t end_timer_value;/** measured time in ticks */ }; -/**@brief SIZE_OF_IA_CSS_CLOCK_TICK_STRUCT checks to ensure correct alignment for struct ia_css_clock_tick. */ +/* +* SIZE_OF_IA_CSS_CLOCK_TICK_STRUCT checks to ensure correct +* alignment for struct ia_css_clock_tick. +*/ #define SIZE_OF_IA_CSS_CLOCK_TICK_STRUCT sizeof(clock_value_t) -/* @brief checks to ensure correct alignment for ia_css_time_meas. */ + +/* checks to ensure correct alignment for ia_css_time_meas. */ #define SIZE_OF_IA_CSS_TIME_MEAS_STRUCT (sizeof(clock_value_t) \ + sizeof(clock_value_t)) -/* @brief API to fetch timer count directly -* -* @param curr_ts [out] measured count value -* @return 0 if success -* -*/ -int -ia_css_timer_get_current_tick ( -struct ia_css_clock_tick *curr_ts); +/* +* @brief API to fetch timer count directly +* +* @param curr_ts [out] measured count value +* @return 0 if success +*/ +int ia_css_timer_get_current_tick (struct ia_css_clock_tick *curr_ts);#endif /* __IA_CSS_TIMER_H */
Signature · 1 line
2.55.0
Quoted 4 lines · Bohdan D. Marcus
This patch series addresses the block comment formatting issues across several header files in the atomisp driver, as suggested in previous reviews. The comments have been reformatted to comply with the Linux kernel coding style guidelines.
Just no.
There are still issues after your series.
Become familiar with what has been already send in the past half a year to linux-media@ mailing list regarding to atomisp driver and what comments were given. lore.kernel.org will help you with that.
Signature · 2 lines
With Best Regards, Andy Shevchenko