lib/cpumask: get rid of cpumap_print_to_pagebuf()
Subsystems (32)
v2 cover lib/cpumask: get rid of cpumap_print_to_pagebuf()
cpumap_print_to_pagebuf() is the equivalent for the "&*pb[l]" notation in printk-like functions. In some cases, it makes people to create temporary buffers for the printed cpumasks, where it can be avoided.
Get rid of it in a favor of more standard printing API.
Each patch, except for the last one, is independent and may be moved with the corresponding subsystem. Or I can take it in bitmap-for-next, at maintainers' discretion.
On top of -next.
This is the resend of:
https://lore.kernel.org/all/[email protected]/
Except the patches merged in 7.1 cycle. I'm going to apply the material in 7.2 unless explicit NAKs received.
Yury Norov (11):
arm: Use sysfs_emit() for cpumask show callbacks
powerpc: Use sysfs_emit() for cpumask show callbacks x86/events: Use sysfs_emit() for cpumask show callbacks
cpu: Use sysfs_emit() for cpumask show callback
devfreq: Use sysfs_emit() for cpumask show callbacks
fpga: dfl-fme-perf: Use sysfs_emit() for cpumask show
hwtracing: hisi_ptt: Use sysfs_emit() for cpumask show RDMA/hfi1: Use sysfs_emit() for cpumask show helper PCI/sysfs: Use sysfs_emit() for cpumask show callbacks
perf: Use sysfs_emit() for cpumask show callbacks lib/bitmap-str: get rid of cpumap_print_to_pagebuf()
arch/arm/mach-imx/mmdc.c | 2 +- arch/arm/mm/cache-l2x0-pmu.c | 2 +- arch/powerpc/kernel/cacheinfo.c | 3 ++- arch/powerpc/perf/hv-24x7.c | 2 +- arch/powerpc/perf/hv-gpci.c | 2 +- arch/powerpc/perf/imc-pmu.c | 2 +- arch/x86/events/amd/iommu.c | 2 +- arch/x86/events/amd/power.c | 2 +- arch/x86/events/amd/uncore.c | 2 +- arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/uncore.c | 2 +- drivers/base/cpu.c | 2 +- drivers/devfreq/event/rockchip-dfi.c | 2 +- drivers/devfreq/hisi_uncore_freq.c | 2 +- drivers/fpga/dfl-fme-perf.c | 2 +- drivers/hwtracing/ptt/hisi_ptt.c | 2 +- drivers/infiniband/hw/hfi1/sdma.c | 3 ++- drivers/pci/pci-sysfs.c | 7 ++++--- drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +- drivers/perf/arm-cci.c | 2 +- drivers/perf/arm-ccn.c | 2 +- drivers/perf/arm-cmn.c | 2 +- drivers/perf/arm-ni.c | 2 +- drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- drivers/perf/arm_dmc620_pmu.c | 4 ++-- drivers/perf/arm_dsu_pmu.c | 2 +- drivers/perf/arm_pmu.c | 2 +- drivers/perf/arm_smmuv3_pmu.c | 2 +- drivers/perf/arm_spe_pmu.c | 2 +- drivers/perf/cxl_pmu.c | 2 +- drivers/perf/dwc_pcie_pmu.c | 2 +- drivers/perf/fsl_imx8_ddr_perf.c | 2 +- drivers/perf/fsl_imx9_ddr_perf.c | 2 +- drivers/perf/fujitsu_uncore_pmu.c | 2 +- drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +- drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +- drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +- drivers/perf/marvell_cn10k_tad_pmu.c | 2 +- drivers/perf/marvell_pem_pmu.c | 2 +- drivers/perf/nvidia_t410_c2c_pmu.c | 2 +- drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +- drivers/perf/qcom_l2_pmu.c | 2 +- drivers/perf/qcom_l3_pmu.c | 2 +- drivers/perf/starfive_starlink_pmu.c | 2 +- drivers/perf/thunderx2_pmu.c | 2 +- drivers/perf/xgene_pmu.c | 2 +- include/linux/cpumask.h | 19 ------------------- kernel/events/core.c | 2 +- lib/bitmap-str.c | 9 ++++----- 50 files changed, 58 insertions(+), 75 deletions(-)
Signature · 1 line
2.53.0
PATCH v2 1/11 arm: Use sysfs_emit() for cpumask show callbacks
These callbacks are sysfs show paths.
Use sysfs_emit() and cpumask_pr_args() to emit the masks.
This prepares for removing cpumap_print_to_pagebuf().
--- arch/arm/mach-imx/mmdc.c | 2 +- arch/arm/mm/cache-l2x0-pmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/mmdc.c +1 -1
@@ -127,7 +127,7 @@ static ssize_t mmdc_pmu_cpumask_show(struct device *dev, {struct mmdc_pmu *pmu_mmdc =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf, &pmu_mmdc->cpu); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu_mmdc->cpu)); } static struct device_attribute mmdc_pmu_cpumask_attr =
arch/arm/mm/cache-l2x0-pmu.c +1 -1
@@ -390,7 +390,7 @@ static struct attribute_group l2x0_pmu_event_attrs_group = {static ssize_t l2x0_pmu_cpumask_show (struct device *dev,struct device_attribute *attr,char *buf) { -return cpumap_print_to_pagebuf (true, buf, &pmu_cpu); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu_cpu)); } static struct device_attribute l2x0_pmu_cpumask_attr =
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 01/11] arm: Use sysfs_emit() for cpumask show callbacks
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
These callbacks are sysfs show paths.
Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Greg Kroah-Hartman
maintainerRe: [PATCH v2 01/11] arm: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovQuoted 17 lines · Yury Norov
These callbacks are sysfs show paths.
Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>--- arch/arm/mach-imx/mmdc.c | 2 +- arch/arm/mm/cache-l2x0-pmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-imx/mmdc.c +0
-0
arch/arm/mach-imx/mmdc.c static ssize_t mmdc_pmu_cpumask_show(struct device *dev, · line 130
Quoted 5 lines
arch/arm/mach-imx/mmdc.c +1
-1@@ -127,7 +127,7 @@ static ssize_t mmdc_pmu_cpumask_show(struct device *dev, {struct mmdc_pmu *pmu_mmdc =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf, &pmu_mmdc->cpu); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu_mmdc->cpu));
Really? Looks like the original is much simpler to understand, why must this function go away?
thanks,
greg k-h
Re: [PATCH v2 01/11] arm: Use sysfs_emit() for cpumask show callbacks
Quoted 21 lines · Greg Kroah-Hartman
Quoted 20 lines · Yury Norov
These callbacks are sysfs show paths.
Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>--- arch/arm/mach-imx/mmdc.c | 2 +- arch/arm/mm/cache-l2x0-pmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-imx/mmdc.c +0
-0@@ -127,7 +127,7 @@ static ssize_t mmdc_pmu_cpumask_show(struct device *dev, {struct mmdc_pmu *pmu_mmdc =dev_get_drvdata (dev);
Quoted 5 lines
arch/arm/mach-imx/mmdc.c static ssize_t mmdc_pmu_cpumask_show(struct device *dev, · line 130
Quoted 2 lines
arch/arm/mach-imx/mmdc.c +1
-1-return cpumap_print_to_pagebuf (true, buf, &pmu_mmdc->cpu); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu_mmdc->cpu));Really? Looks like the original is much simpler to understand, why must this function go away?
Because it's a duplicate of printk("*pbl"), and nothing is simpler in practice.
Because the 'true' vs 'false' parameter in cpumap_print_to_pagebuf() is much harder to remember, comparing to "*pbl" vs "*pb" in the standard printk-like API. And because the 'print_to_pagebuf' has a record of misuse.
For more details, see:
https://lore.kernel.org/all/akANJ-AT7nHpRMq-@yury/
Thanks,
Yury
PATCH v2 2/11 powerpc: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovThese callbacks are sysfs show paths.
Use sysfs_emit() and cpumask_pr_args() to emit the masks.
This prepares for removing cpumap_print_to_pagebuf().
--- arch/powerpc/kernel/cacheinfo.c | 3 ++- arch/powerpc/perf/hv-24x7.c | 2 +- arch/powerpc/perf/hv-gpci.c | 2 +- arch/powerpc/perf/imc-pmu.c | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-)
arch/powerpc/kernel/cacheinfo.c +2 -1
@@ -690,7 +690,8 @@ show_shared_cpumap(struct kobject *k, struct kobj_attribute *attr, char *buf, bo mask = &cache->shared_cpu_map; -return cpumap_print_to_pagebuf (list, buf, mask); +return sysfs_emit (buf, list ?"%*pbl\n" :"%*pb\n" , +cpumask_pr_args (mask)); }static ssize_t shared_cpu_map_show (struct kobject *k,struct kobj_attribute *attr,char *buf)
arch/powerpc/perf/hv-24x7.c +1 -1
@@ -429,7 +429,7 @@ static char *memdup_to_str(char *maybe_str, int max_len, gfp_t gfp)static ssize_t cpumask_show (struct device *dev,struct device_attribute *attr,char *buf) { -return cpumap_print_to_pagebuf (true, buf, &hv_24x7_cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&hv_24x7_cpumask)); } static ssize_t sockets_show(struct device *dev,
arch/powerpc/perf/hv-gpci.c +1 -1
@@ -100,7 +100,7 @@ static ssize_t kernel_version_show(struct device *dev,static ssize_t cpumask_show (struct device *dev,struct device_attribute *attr,char *buf) { -return cpumap_print_to_pagebuf (true, buf, &hv_gpci_cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&hv_gpci_cpumask)); }/* Interface attribute array index to store system information */
arch/powerpc/perf/imc-pmu.c +1 -1
@@ -117,7 +117,7 @@ static ssize_t imc_pmu_cpumask_get_attr(struct device *dev,return 0 ; } -return cpumap_print_to_pagebuf (true, buf, active_mask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (active_mask)); } static DEVICE_ATTR(cpumask, S_IRUGO, imc_pmu_cpumask_get_attr, NULL);
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 02/11] powerpc: Use sysfs_emit() for cpumask show callbacks
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
These callbacks are sysfs show paths.
Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
PATCH v2 3/11 x86/events: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovThese callbacks are sysfs show paths.
Use sysfs_emit() and cpumask_pr_args() to emit the masks.
This prepares for removing cpumap_print_to_pagebuf().
--- arch/x86/events/amd/iommu.c | 2 +- arch/x86/events/amd/power.c | 2 +- arch/x86/events/amd/uncore.c | 2 +- arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/uncore.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
arch/x86/events/amd/iommu.c +1 -1
@@ -137,7 +137,7 @@ static ssize_t _iommu_cpumask_show(struct device *dev,struct device_attribute *attr, char *buf) { - return cpumap_print_to_pagebuf(true, buf, &iommu_cpumask); + return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(&iommu_cpumask)); } static DEVICE_ATTR(cpumask, S_IRUGO, _iommu_cpumask_show, NULL);
arch/x86/events/amd/power.c +1 -1
@@ -150,7 +150,7 @@ static void pmu_event_read(struct perf_event *event)static ssize_t get_attr_cpumask (struct device *dev,struct device_attribute *attr,char *buf) { -return cpumap_print_to_pagebuf (true, buf, &cpu_mask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&cpu_mask)); } static DEVICE_ATTR(cpumask, S_IRUGO, get_attr_cpumask, NULL);
arch/x86/events/amd/uncore.c +1 -1
@@ -322,7 +322,7 @@ static ssize_t amd_uncore_attr_show_cpumask(struct device *dev,struct pmu *ptr =dev_get_drvdata (dev); struct amd_uncore_pmu *pmu = container_of(ptr, struct amd_uncore_pmu, pmu); -return cpumap_print_to_pagebuf (true, buf, &pmu->active_mask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu->active_mask)); } static DEVICE_ATTR(cpumask, S_IRUGO, amd_uncore_attr_show_cpumask, NULL);
arch/x86/events/intel/core.c +1 -1
@@ -7564,7 +7564,7 @@ static ssize_t intel_hybrid_get_attr_cpus(struct device *dev,struct x86_hybrid_pmu *pmu = container_of(dev_get_drvdata(dev), struct x86_hybrid_pmu, pmu); -return cpumap_print_to_pagebuf (true, buf, &pmu->supported_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu->supported_cpus)); } static DEVICE_ATTR(cpus, S_IRUGO, intel_hybrid_get_attr_cpus, NULL);
arch/x86/events/intel/uncore.c +1 -1
@@ -861,7 +861,7 @@ static ssize_t uncore_get_attr_cpumask(struct device *dev, { struct intel_uncore_pmu *pmu = container_of(dev_get_drvdata(dev), struct intel_uncore_pmu, pmu); -return cpumap_print_to_pagebuf (true, buf, &pmu->cpu_mask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu->cpu_mask)); } static DEVICE_ATTR(cpumask, S_IRUGO, uncore_get_attr_cpumask, NULL);
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 03/11] x86/events: Use sysfs_emit() for cpumask show callbacks
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
These callbacks are sysfs show paths.
Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
PATCH v2 4/11 cpu: Use sysfs_emit() for cpumask show callback
In reply to Yury Norovshow_cpus_attr() is a sysfs show callback. Use sysfs_emit() and cpumask_pr_args() to emit the mask.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/base/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/cpu.c +1 -1
@@ -218,7 +218,7 @@ static ssize_t show_cpus_attr(struct device *dev, { struct cpu_attr *ca = container_of(attr, struct cpu_attr, attr); -return cpumap_print_to_pagebuf (true, buf, ca->map); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (ca->map)); }#define _CPU_ATTR (name, map) \
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 04/11] cpu: Use sysfs_emit() for cpumask show callback
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
show_cpus_attr()is a sysfs show callback. Usesysfs_emit()andcpumask_pr_args()to emit the mask.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
PATCH v2 5/11 devfreq: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovThese callbacks are sysfs show paths. Use sysfs_emit() and cpumask_pr_args() to emit the masks.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/devfreq/event/rockchip-dfi.c | 2 +- drivers/devfreq/hisi_uncore_freq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/devfreq/event/rockchip-dfi.c +1 -1
@@ -354,7 +354,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev,struct pmu *pmu =dev_get_drvdata (dev); struct rockchip_dfi *dfi = container_of(pmu, struct rockchip_dfi, pmu); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (dfi->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (dfi->cpu))); } static struct device_attribute ddr_perf_cpumask_attr =
drivers/devfreq/hisi_uncore_freq.c +1 -1
@@ -541,7 +541,7 @@ static ssize_t related_cpus_show(struct device *dev, {struct hisi_uncore_freq *uncore =dev_get_drvdata (dev->parent); -return cpumap_print_to_pagebuf (true, buf, &uncore->related_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&uncore->related_cpus)); }static DEVICE_ATTR_RO (related_cpus);
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 05/11] devfreq: Use sysfs_emit() for cpumask show callbacks
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
These callbacks are sysfs show paths. Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
PATCH v2 6/11 fpga: dfl-fme-perf: Use sysfs_emit() for cpumask show
In reply to Yury Norovcpumask_show() is a sysfs show callback. Use sysfs_emit() and cpumask_pr_args() to emit the mask.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/fpga/dfl-fme-perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/fpga/dfl-fme-perf.c +1 -1
@@ -183,7 +183,7 @@ static ssize_t cpumask_show(struct device *dev, priv =to_fme_perf_priv (pmu); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (priv->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (priv->cpu))); }static DEVICE_ATTR_RO (cpumask);
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 06/11] fpga: dfl-fme-perf: Use sysfs_emit() for cpumask show
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
cpumask_show()is a sysfs show callback. Usesysfs_emit()andcpumask_pr_args()to emit the mask.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
PATCH v2 7/11 hwtracing: hisi_ptt: Use sysfs_emit() for cpumask show
In reply to Yury Norovcpumask_show() is a sysfs show callback. Use sysfs_emit() and cpumask_pr_args() to emit the mask.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/hwtracing/ptt/hisi_ptt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwtracing/ptt/hisi_ptt.c +1 -1
@@ -780,7 +780,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,struct hisi_ptt *hisi_ptt =to_hisi_ptt (dev_get_drvdata (dev));const cpumask_t *cpumask =cpumask_of_node (dev_to_node (&hisi_ptt->pdev->dev)); -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }static DEVICE_ATTR_RO (cpumask);
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 07/11] hwtracing: hisi_ptt: Use sysfs_emit() for cpumask show
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines
cpumask_show()is a sysfs show callback. Usesysfs_emit()andcpumask_pr_args()to emit the mask.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7
PATCH v2 8/11 RDMA/hfi1: Use sysfs_emit() for cpumask show helper
In reply to Yury Norovsdma_get_cpu_to_sde_map() is used by a sysfs show callback.
Use sysfs_emit() and cpumask_pr_args() to emit the mask.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/infiniband/hw/hfi1/sdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/hw/hfi1/sdma.c +2 -1
@@ -11,6 +11,7 @@#include <linux/timer.h> #include <linux/vmalloc.h> #include <linux/highmem.h> +#include <linux/sysfs.h> #include "hfi.h" #include "common.h"
@@ -1049,7 +1050,7 @@ ssize_t sdma_get_cpu_to_sde_map(struct sdma_engine *sde, char *buf)if (cpumask_empty (&sde->cpu_mask))snprintf (buf,PAGE_SIZE ,"%s\n" ,"empty" );else -cpumap_print_to_pagebuf (true, buf, &sde->cpu_mask); +sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&sde->cpu_mask));mutex_unlock (&process_to_sde_mutex);return strnlen (buf,PAGE_SIZE ); }
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 08/11] RDMA/hfi1: Use sysfs_emit() for cpumask show helper
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
sdma_get_cpu_to_sde_map()is used by a sysfs show callback.Use
sysfs_emit()andcpumask_pr_args()to emit the mask.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
PATCH v2 9/11 PCI/sysfs: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovThese callbacks are sysfs show paths.
Use sysfs_emit() and cpumask_pr_args() to emit the masks.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/pci/pci-sysfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/pci/pci-sysfs.c +4 -3
@@ -112,7 +112,8 @@ static ssize_t pci_dev_show_local_cpu(struct device *dev, bool list,#else mask =cpumask_of_pcibus (to_pci_dev (dev)->bus);#endif -return cpumap_print_to_pagebuf (list, buf, mask); +return sysfs_emit (buf, list ?"%*pbl\n" :"%*pb\n" , +cpumask_pr_args (mask)); } static ssize_t local_cpus_show(struct device *dev,
@@ -137,7 +138,7 @@ static ssize_t cpuaffinity_show(struct device *dev, {const struct cpumask *cpumask =cpumask_of_pcibus (to_pci_bus (dev)); -return cpumap_print_to_pagebuf (false, buf, cpumask); +return sysfs_emit (buf,"%*pb\n" ,cpumask_pr_args (cpumask)); }static DEVICE_ATTR_RO (cpuaffinity);
@@ -146,7 +147,7 @@ static ssize_t cpulistaffinity_show(struct device *dev, {const struct cpumask *cpumask =cpumask_of_pcibus (to_pci_bus (dev)); -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }static DEVICE_ATTR_RO (cpulistaffinity);
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 09/11] PCI/sysfs: Use sysfs_emit() for cpumask show callbacks
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
These callbacks are sysfs show paths.
Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().Signed-off-by Yury Norov <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9
PATCH v2 10/11 perf: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovThese callbacks are sysfs show paths. Use sysfs_emit() and cpumask_pr_args() to emit the masks.
This prepares for removing cpumap_print_to_pagebuf().
--- drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +- drivers/perf/arm-cci.c | 2 +- drivers/perf/arm-ccn.c | 2 +- drivers/perf/arm-cmn.c | 2 +- drivers/perf/arm-ni.c | 2 +- drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- drivers/perf/arm_dmc620_pmu.c | 4 ++-- drivers/perf/arm_dsu_pmu.c | 2 +- drivers/perf/arm_pmu.c | 2 +- drivers/perf/arm_smmuv3_pmu.c | 2 +- drivers/perf/arm_spe_pmu.c | 2 +- drivers/perf/cxl_pmu.c | 2 +- drivers/perf/dwc_pcie_pmu.c | 2 +- drivers/perf/fsl_imx8_ddr_perf.c | 2 +- drivers/perf/fsl_imx9_ddr_perf.c | 2 +- drivers/perf/fujitsu_uncore_pmu.c | 2 +- drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +- drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +- drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +- drivers/perf/marvell_cn10k_tad_pmu.c | 2 +- drivers/perf/marvell_pem_pmu.c | 2 +- drivers/perf/nvidia_t410_c2c_pmu.c | 2 +- drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +- drivers/perf/qcom_l2_pmu.c | 2 +- drivers/perf/qcom_l3_pmu.c | 2 +- drivers/perf/starfive_starlink_pmu.c | 2 +- drivers/perf/thunderx2_pmu.c | 2 +- drivers/perf/xgene_pmu.c | 2 +- kernel/events/core.c | 2 +- 30 files changed, 31 insertions(+), 31 deletions(-)
drivers/perf/alibaba_uncore_drw_pmu.c +1 -1
@@ -221,7 +221,7 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev, {struct ali_drw_pmu *drw_pmu =to_ali_drw_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (drw_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (drw_pmu->cpu))); } static struct device_attribute ali_drw_pmu_cpumask_attr =
drivers/perf/amlogic/meson_ddr_pmu_core.c +1 -1
@@ -191,7 +191,7 @@ static ssize_t meson_ddr_perf_cpumask_show(struct device *dev, {struct ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute meson_ddr_perf_cpumask_attr =
drivers/perf/arm-cci.c +1 -1
@@ -1351,7 +1351,7 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev,struct pmu *pmu =dev_get_drvdata (dev);struct cci_pmu *cci_pmu =to_cci_pmu (pmu); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (cci_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (cci_pmu->cpu))); } static struct device_attribute pmu_cpumask_attr =
drivers/perf/arm-ccn.c +1 -1
@@ -538,7 +538,7 @@ static ssize_t arm_ccn_pmu_cpumask_show(struct device *dev, {struct arm_ccn *ccn =pmu_to_arm_ccn (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (ccn->dt.cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (ccn->dt.cpu))); } static struct device_attribute arm_ccn_pmu_cpumask_attr =
drivers/perf/arm-cmn.c +1 -1
@@ -1327,7 +1327,7 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev, {struct arm_cmn *cmn =to_cmn (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (cmn->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (cmn->cpu))); } static struct device_attribute arm_cmn_cpumask_attr =
drivers/perf/arm-ni.c +1 -1
@@ -239,7 +239,7 @@ static ssize_t arm_ni_cpumask_show(struct device *dev, {struct arm_ni *ni =cd_to_ni (pmu_to_cd (dev_get_drvdata (dev))); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (ni->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (ni->cpu))); } static struct device_attribute arm_ni_cpumask_attr =
drivers/perf/arm_cspmu/arm_cspmu.c +1 -1
@@ -305,7 +305,7 @@ static ssize_t arm_cspmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }static struct attribute *arm_cspmu_cpumask_attrs[] = {
drivers/perf/arm_dmc620_pmu.c +2 -2
@@ -237,8 +237,8 @@ static ssize_t dmc620_pmu_cpumask_show(struct device *dev, {struct dmc620_pmu *dmc620_pmu =to_dmc620_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, -cpumask_of (dmc620_pmu->irq->cpu)); +return sysfs_emit (buf,"%*pbl\n" , +cpumask_pr_args (cpumask_of (dmc620_pmu->irq->cpu))); } static struct device_attribute dmc620_pmu_cpumask_attr =
drivers/perf/arm_dsu_pmu.c +1 -1
@@ -157,7 +157,7 @@ static ssize_t dsu_pmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }static struct attribute *dsu_pmu_format_attrs[] = {
drivers/perf/arm_pmu.c +1 -1
@@ -570,7 +570,7 @@ static ssize_t cpus_show(struct device *dev, struct device_attribute *attr, char *buf) { struct arm_pmu *armpmu = to_arm_pmu(dev_get_drvdata(dev)); -return cpumap_print_to_pagebuf (true, buf, &armpmu->supported_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&armpmu->supported_cpus)); }static DEVICE_ATTR_RO (cpus);
drivers/perf/arm_smmuv3_pmu.c +1 -1
@@ -537,7 +537,7 @@ static ssize_t smmu_pmu_cpumask_show(struct device *dev, {struct smmu_pmu *smmu_pmu =to_smmu_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (smmu_pmu->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (smmu_pmu->on_cpu))); } static struct device_attribute smmu_pmu_cpumask_attr =
drivers/perf/arm_spe_pmu.c +1 -1
@@ -343,7 +343,7 @@ static ssize_t cpumask_show(struct device *dev, {struct arm_spe_pmu *spe_pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf, &spe_pmu->supported_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&spe_pmu->supported_cpus)); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/cxl_pmu.c +1 -1
@@ -493,7 +493,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, {struct cxl_pmu_info *info =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (info->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (info->on_cpu))); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/dwc_pcie_pmu.c +1 -1
@@ -117,7 +117,7 @@ static ssize_t cpumask_show(struct device *dev, {struct dwc_pcie_pmu *pcie_pmu =to_dwc_pcie_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pcie_pmu->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pcie_pmu->on_cpu))); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/fsl_imx8_ddr_perf.c +1 -1
@@ -237,7 +237,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, {struct ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute ddr_perf_cpumask_attr =
drivers/perf/fsl_imx9_ddr_perf.c +1 -1
@@ -159,7 +159,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, {struct ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute ddr_perf_cpumask_attr =
drivers/perf/fujitsu_uncore_pmu.c +1 -1
@@ -374,7 +374,7 @@ static ssize_t cpumask_show(struct device *dev, {struct uncore_pmu *uncorepmu =to_uncore_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (uncorepmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (uncorepmu->cpu))); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/hisilicon/hisi_pcie_pmu.c +1 -1
@@ -121,7 +121,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, c {struct hisi_pcie_pmu *pcie_pmu =to_pcie_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pcie_pmu->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pcie_pmu->on_cpu))); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/hisilicon/hisi_uncore_pmu.c +1 -1
@@ -56,7 +56,7 @@ static ssize_t hisi_associated_cpus_sysfs_show(struct device *dev, {struct hisi_pmu *hisi_pmu =to_hisi_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &hisi_pmu->associated_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&hisi_pmu->associated_cpus)); } static DEVICE_ATTR(associated_cpus, 0444, hisi_associated_cpus_sysfs_show, NULL);
drivers/perf/marvell_cn10k_ddr_pmu.c +1 -1
@@ -364,7 +364,7 @@ static ssize_t cn10k_ddr_perf_cpumask_show(struct device *dev, {struct cn10k_ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute cn10k_ddr_perf_cpumask_attr =
drivers/perf/marvell_cn10k_tad_pmu.c +1 -1
@@ -258,7 +258,7 @@ static ssize_t tad_pmu_cpumask_show(struct device *dev, {struct tad_pmu *tad_pmu =to_tad_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (tad_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (tad_pmu->cpu))); } static DEVICE_ATTR(cpumask, 0444, tad_pmu_cpumask_show, NULL);
drivers/perf/marvell_pem_pmu.c +1 -1
@@ -164,7 +164,7 @@ static ssize_t pem_perf_cpumask_show(struct device *dev, {struct pem_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute pem_perf_cpumask_attr =
drivers/perf/nvidia_t410_c2c_pmu.c +1 -1
@@ -658,7 +658,7 @@ static ssize_t nv_c2c_pmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }#define NV_C2C_PMU_CPUMASK_ATTR (_name, _config) \
drivers/perf/nvidia_t410_cmem_latency_pmu.c +1 -1
@@ -501,7 +501,7 @@ static ssize_t cmem_lat_pmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }#define NV_PMU_CPUMASK_ATTR (_name, _config) \
drivers/perf/qcom_l2_pmu.c +1 -1
@@ -638,7 +638,7 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev, {struct l2cache_pmu *l2cache_pmu =to_l2cache_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &l2cache_pmu->cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&l2cache_pmu->cpumask)); } static struct device_attribute l2_cache_pmu_cpumask_attr =
drivers/perf/qcom_l3_pmu.c +1 -1
@@ -663,7 +663,7 @@ static ssize_t cpumask_show(struct device *dev, {struct l3cache_pmu *l3pmu =to_l3cache_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &l3pmu->cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&l3pmu->cpumask)); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/starfive_starlink_pmu.c +1 -1
@@ -131,7 +131,7 @@ cpumask_show(struct device *dev, struct device_attribute *attr, char *buf) {struct starlink_pmu *starlink_pmu =to_starlink_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &starlink_pmu->cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&starlink_pmu->cpumask)); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/thunderx2_pmu.c +1 -1
@@ -254,7 +254,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,struct tx2_uncore_pmu *tx2_pmu; tx2_pmu =pmu_to_tx2_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (tx2_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (tx2_pmu->cpu))); }static DEVICE_ATTR_RO (cpumask);
drivers/perf/xgene_pmu.c +1 -1
@@ -595,7 +595,7 @@ static ssize_t cpumask_show(struct device *dev, {struct xgene_pmu_dev *pmu_dev =to_pmu_dev (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &pmu_dev->parent->cpu); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu_dev->parent->cpu)); }static DEVICE_ATTR_RO (cpumask);
kernel/events/core.c +1 -1
@@ -12694,7 +12694,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,struct cpumask *mask =perf_scope_cpumask (pmu->scope);if (mask) -return cpumap_print_to_pagebuf (true, buf, mask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (mask));return 0 ; }
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 10/11] perf: Use sysfs_emit() for cpumask show callbacks
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 7 lines
These callbacks are sysfs show paths. Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().
Sashiko has reviewed this patch and found no issues. It looks great!
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
Re: [PATCH v2 10/11] perf: Use sysfs_emit() for cpumask show callbacks
In reply to Yury NorovQuoted 4 lines · Yury Norov
These callbacks are sysfs show paths. Use
sysfs_emit()andcpumask_pr_args()to emit the masks.This prepares for removing
cpumap_print_to_pagebuf().
FWIW,
I'm now working on a way to remove all of these entirely (other than the core one), so I declare myself not particularly fussed any more :D
Cheers,
Robin.
Quoted 427 lines
Signed-off-by Yury Norov <[email protected]>--- drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +- drivers/perf/arm-cci.c | 2 +- drivers/perf/arm-ccn.c | 2 +- drivers/perf/arm-cmn.c | 2 +- drivers/perf/arm-ni.c | 2 +- drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- drivers/perf/arm_dmc620_pmu.c | 4 ++-- drivers/perf/arm_dsu_pmu.c | 2 +- drivers/perf/arm_pmu.c | 2 +- drivers/perf/arm_smmuv3_pmu.c | 2 +- drivers/perf/arm_spe_pmu.c | 2 +- drivers/perf/cxl_pmu.c | 2 +- drivers/perf/dwc_pcie_pmu.c | 2 +- drivers/perf/fsl_imx8_ddr_perf.c | 2 +- drivers/perf/fsl_imx9_ddr_perf.c | 2 +- drivers/perf/fujitsu_uncore_pmu.c | 2 +- drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +- drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +- drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +- drivers/perf/marvell_cn10k_tad_pmu.c | 2 +- drivers/perf/marvell_pem_pmu.c | 2 +- drivers/perf/nvidia_t410_c2c_pmu.c | 2 +- drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +- drivers/perf/qcom_l2_pmu.c | 2 +- drivers/perf/qcom_l3_pmu.c | 2 +- drivers/perf/starfive_starlink_pmu.c | 2 +- drivers/perf/thunderx2_pmu.c | 2 +- drivers/perf/xgene_pmu.c | 2 +- kernel/events/core.c | 2 +- 30 files changed, 31 insertions(+), 31 deletions(-)drivers/perf/alibaba_uncore_drw_pmu.c +1
-1@@ -221,7 +221,7 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev, {struct ali_drw_pmu *drw_pmu =to_ali_drw_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (drw_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (drw_pmu->cpu))); } static struct device_attribute ali_drw_pmu_cpumask_attr =drivers/perf/amlogic/meson_ddr_pmu_core.c +1
-1@@ -191,7 +191,7 @@ static ssize_t meson_ddr_perf_cpumask_show(struct device *dev, {struct ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute meson_ddr_perf_cpumask_attr =drivers/perf/arm-cci.c +1
-1@@ -1351,7 +1351,7 @@ static ssize_t pmu_cpumask_attr_show(struct device *dev,struct pmu *pmu =dev_get_drvdata (dev);struct cci_pmu *cci_pmu =to_cci_pmu (pmu); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (cci_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (cci_pmu->cpu))); } static struct device_attribute pmu_cpumask_attr =drivers/perf/arm-ccn.c +1
-1@@ -538,7 +538,7 @@ static ssize_t arm_ccn_pmu_cpumask_show(struct device *dev, {struct arm_ccn *ccn =pmu_to_arm_ccn (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (ccn->dt.cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (ccn->dt.cpu))); } static struct device_attribute arm_ccn_pmu_cpumask_attr =drivers/perf/arm-cmn.c +1
-1@@ -1327,7 +1327,7 @@ static ssize_t arm_cmn_cpumask_show(struct device *dev, {struct arm_cmn *cmn =to_cmn (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (cmn->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (cmn->cpu))); } static struct device_attribute arm_cmn_cpumask_attr =drivers/perf/arm-ni.c +1
-1@@ -239,7 +239,7 @@ static ssize_t arm_ni_cpumask_show(struct device *dev, {struct arm_ni *ni =cd_to_ni (pmu_to_cd (dev_get_drvdata (dev))); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (ni->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (ni->cpu))); } static struct device_attribute arm_ni_cpumask_attr =drivers/perf/arm_cspmu/arm_cspmu.c +1
-1@@ -305,7 +305,7 @@ static ssize_t arm_cspmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }static struct attribute *arm_cspmu_cpumask_attrs[] = {drivers/perf/arm_dmc620_pmu.c +2
-2@@ -237,8 +237,8 @@ static ssize_t dmc620_pmu_cpumask_show(struct device *dev, {struct dmc620_pmu *dmc620_pmu =to_dmc620_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, -cpumask_of (dmc620_pmu->irq->cpu)); +return sysfs_emit (buf,"%*pbl\n" , +cpumask_pr_args (cpumask_of (dmc620_pmu->irq->cpu))); } static struct device_attribute dmc620_pmu_cpumask_attr =drivers/perf/arm_dsu_pmu.c +1
-1@@ -157,7 +157,7 @@ static ssize_t dsu_pmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }static struct attribute *dsu_pmu_format_attrs[] = {drivers/perf/arm_pmu.c +1
-1@@ -570,7 +570,7 @@ static ssize_t cpus_show(struct device *dev, struct device_attribute *attr, char *buf) { struct arm_pmu *armpmu = to_arm_pmu(dev_get_drvdata(dev)); -return cpumap_print_to_pagebuf (true, buf, &armpmu->supported_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&armpmu->supported_cpus)); }static DEVICE_ATTR_RO (cpus);drivers/perf/arm_smmuv3_pmu.c +1
-1@@ -537,7 +537,7 @@ static ssize_t smmu_pmu_cpumask_show(struct device *dev, {struct smmu_pmu *smmu_pmu =to_smmu_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (smmu_pmu->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (smmu_pmu->on_cpu))); } static struct device_attribute smmu_pmu_cpumask_attr =drivers/perf/arm_spe_pmu.c +1
-1@@ -343,7 +343,7 @@ static ssize_t cpumask_show(struct device *dev, {struct arm_spe_pmu *spe_pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf, &spe_pmu->supported_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&spe_pmu->supported_cpus)); }static DEVICE_ATTR_RO (cpumask);drivers/perf/cxl_pmu.c +1
-1@@ -493,7 +493,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, {struct cxl_pmu_info *info =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (info->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (info->on_cpu))); }static DEVICE_ATTR_RO (cpumask);drivers/perf/dwc_pcie_pmu.c +1
-1@@ -117,7 +117,7 @@ static ssize_t cpumask_show(struct device *dev, {struct dwc_pcie_pmu *pcie_pmu =to_dwc_pcie_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pcie_pmu->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pcie_pmu->on_cpu))); }static DEVICE_ATTR_RO (cpumask);drivers/perf/fsl_imx8_ddr_perf.c +1
-1@@ -237,7 +237,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, {struct ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute ddr_perf_cpumask_attr =drivers/perf/fsl_imx9_ddr_perf.c +1
-1@@ -159,7 +159,7 @@ static ssize_t ddr_perf_cpumask_show(struct device *dev, {struct ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute ddr_perf_cpumask_attr =drivers/perf/fujitsu_uncore_pmu.c +1
-1@@ -374,7 +374,7 @@ static ssize_t cpumask_show(struct device *dev, {struct uncore_pmu *uncorepmu =to_uncore_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (uncorepmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (uncorepmu->cpu))); }static DEVICE_ATTR_RO (cpumask);drivers/perf/hisilicon/hisi_pcie_pmu.c +1
-1@@ -121,7 +121,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr, c {struct hisi_pcie_pmu *pcie_pmu =to_pcie_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pcie_pmu->on_cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pcie_pmu->on_cpu))); }static DEVICE_ATTR_RO (cpumask);drivers/perf/hisilicon/hisi_uncore_pmu.c +1
-1@@ -56,7 +56,7 @@ static ssize_t hisi_associated_cpus_sysfs_show(struct device *dev, {struct hisi_pmu *hisi_pmu =to_hisi_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &hisi_pmu->associated_cpus); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&hisi_pmu->associated_cpus)); } static DEVICE_ATTR(associated_cpus, 0444, hisi_associated_cpus_sysfs_show, NULL);drivers/perf/marvell_cn10k_ddr_pmu.c +1
-1@@ -364,7 +364,7 @@ static ssize_t cn10k_ddr_perf_cpumask_show(struct device *dev, {struct cn10k_ddr_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute cn10k_ddr_perf_cpumask_attr =drivers/perf/marvell_cn10k_tad_pmu.c +1
-1@@ -258,7 +258,7 @@ static ssize_t tad_pmu_cpumask_show(struct device *dev, {struct tad_pmu *tad_pmu =to_tad_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (tad_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (tad_pmu->cpu))); } static DEVICE_ATTR(cpumask, 0444, tad_pmu_cpumask_show, NULL);drivers/perf/marvell_pem_pmu.c +1
-1@@ -164,7 +164,7 @@ static ssize_t pem_perf_cpumask_show(struct device *dev, {struct pem_pmu *pmu =dev_get_drvdata (dev); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (pmu->cpu))); } static struct device_attribute pem_perf_cpumask_attr =drivers/perf/nvidia_t410_c2c_pmu.c +1
-1@@ -658,7 +658,7 @@ static ssize_t nv_c2c_pmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }#define NV_C2C_PMU_CPUMASK_ATTR (_name, _config) \drivers/perf/nvidia_t410_cmem_latency_pmu.c +1
-1@@ -501,7 +501,7 @@ static ssize_t cmem_lat_pmu_cpumask_show(struct device *dev,default :return 0 ; } -return cpumap_print_to_pagebuf (true, buf, cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask)); }#define NV_PMU_CPUMASK_ATTR (_name, _config) \drivers/perf/qcom_l2_pmu.c +1
-1@@ -638,7 +638,7 @@ static ssize_t l2_cache_pmu_cpumask_show(struct device *dev, {struct l2cache_pmu *l2cache_pmu =to_l2cache_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &l2cache_pmu->cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&l2cache_pmu->cpumask)); } static struct device_attribute l2_cache_pmu_cpumask_attr =drivers/perf/qcom_l3_pmu.c +1
-1@@ -663,7 +663,7 @@ static ssize_t cpumask_show(struct device *dev, {struct l3cache_pmu *l3pmu =to_l3cache_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &l3pmu->cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&l3pmu->cpumask)); }static DEVICE_ATTR_RO (cpumask);drivers/perf/starfive_starlink_pmu.c +1
-1@@ -131,7 +131,7 @@ cpumask_show(struct device *dev, struct device_attribute *attr, char *buf) {struct starlink_pmu *starlink_pmu =to_starlink_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &starlink_pmu->cpumask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&starlink_pmu->cpumask)); }static DEVICE_ATTR_RO (cpumask);drivers/perf/thunderx2_pmu.c +1
-1@@ -254,7 +254,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,struct tx2_uncore_pmu *tx2_pmu; tx2_pmu =pmu_to_tx2_pmu (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf,cpumask_of (tx2_pmu->cpu)); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (cpumask_of (tx2_pmu->cpu))); }static DEVICE_ATTR_RO (cpumask);drivers/perf/xgene_pmu.c +1
-1@@ -595,7 +595,7 @@ static ssize_t cpumask_show(struct device *dev, {struct xgene_pmu_dev *pmu_dev =to_pmu_dev (dev_get_drvdata (dev)); -return cpumap_print_to_pagebuf (true, buf, &pmu_dev->parent->cpu); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (&pmu_dev->parent->cpu)); }static DEVICE_ATTR_RO (cpumask);kernel/events/core.c +1
-1@@ -12694,7 +12694,7 @@ static ssize_t cpumask_show(struct device *dev, struct device_attribute *attr,struct cpumask *mask =perf_scope_cpumask (pmu->scope);if (mask) -return cpumap_print_to_pagebuf (true, buf, mask); +return sysfs_emit (buf,"%*pbl\n" ,cpumask_pr_args (mask));return 0 ; }
PATCH v2 11/11 lib/bitmap-str: get rid of cpumap_print_to_pagebuf()
In reply to Yury NorovNow that all users of the function are switched to the alternatives, drop the function.
--- include/linux/cpumask.h | 19 ------------------- lib/bitmap-str.c | 9 ++++----- 2 files changed, 4 insertions(+), 24 deletions(-)
include/linux/cpumask.h +0 -19
@@ -13,7 +13,6 @@#include <linux/cpumask_types.h> #include <linux/gfp_types.h> #include <linux/numa.h> -#include <linux/sprintf.h> #include <linux/threads.h> #include <linux/types.h> #include <vdso/page.h>
@@ -1315,24 +1314,6 @@ static __always_inline bool cpu_dying(unsigned int cpu) }#endif /* NR_CPUS > BITS_PER_LONG */ -/** -* cpumap_print_to_pagebuf - copies the cpumask into the buffer either -* as comma-separated list of cpus or hex values of cpumask -* @list: indicates whether the cpumap must be list -* @mask: the cpumask to copy -* @buf: the buffer to copy into -* -* Return: the length of the (null-terminated) @buf string, zero if -* nothing is copied. -*/ -static __always_inline ssize_t -cpumap_print_to_pagebuf (bool list,char *buf,const struct cpumask *mask) -{ -/* Opencode offset_in_page(buf) to not include linux/mm.h */ -return scnprintf (buf,PAGE_SIZE - ((unsigned long )buf & ~PAGE_MASK ), - list ?"%*pbl\n" :"%*pb\n" ,cpumask_pr_args (mask)); -} -/** * cpumap_print_bitmask_to_buf - copies the cpumask into the buffer as * hex values of cpumask
lib/bitmap-str.c +4 -5
@@ -75,8 +75,7 @@ static int bitmap_print_to_buf(bool list, char *buf, const unsigned long *maskp,* @off: in the string from which we are copying, We copy to @buf * @count: the maximum number of bytes to print * -* The sprintf("%*pb[l]") is used indirectly via its cpumap wrapper -* cpumap_print_to_pagebuf() or directly by drivers to export hexadecimal +* The sprintf("%*pb[l]") format is used by drivers to export hexadecimal * bitmask and decimal list to userspace by sysfs ABI. * Drivers might be using a normal attribute for this kind of ABIs. A * normal attribute typically has show entry as below::
@@ -115,9 +114,9 @@ static int bitmap_print_to_buf(bool list, char *buf, const unsigned long *maskp,* parameters such as off, count from bin_attribute show entry to this API. * * The role of cpumap_print_bitmask_to_buf() and cpumap_print_list_to_buf() -* is similar with cpumap_print_to_pagebuf(), the difference is that -* scnprintf("%*pb[l]") mainly serves sysfs attribute with the assumption -* the destination buffer is exactly one page and won't be more than one page. +* is similar to direct sysfs_emit("%*pb[l]") formatting, but the latter +* assumes the destination buffer is exactly one page and won't be more than +* one page. * cpumap_print_bitmask_to_buf() and cpumap_print_list_to_buf(), on the other * hand, mainly serves bin_attribute which doesn't work with exact one page, * and it can break the size limit of converted decimal list and hexadecimal
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH v2 11/11] lib/bitmap-str: get rid of cpumap_print_to_pagebuf()
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The function `cpumap_print_to_pagebuf()` is deleted but still called in…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function cpumap_print_to_pagebuf() is deleted but still called in drivers/firmware/psci/psci_checker.c, causing a build failure for ARM configurations. --
commit 905d23faa26c3dcaccb88eda3b8626258147c495
Author: Yury Norov <[email protected]>
lib/bitmap-str: get rid of cpumap_print_to_pagebuf()
This commit removes cpumap_print_to_pagebuf(), stating that all users of the function have been switched to alternatives.
Quoted 3 lines
include/linux/cpumask.h +0
-0
[ ... ]
Quoted 7 lines
include/linux/cpumask.h +0
-3@@ -1315,24 +1314,6 @@ static __always_inline bool cpu_dying(unsigned int cpu) }#endif /* NR_CPUS > BITS_PER_LONG */ -/** -* cpumap_print_to_pagebuf - copies the cpumask into the buffer either -* as comma-separated list of cpus or hex values of cpumask
include/linux/cpumask.h static __always_inline bool cpu_dying(unsigned int cpu) · line 1330
Quoted 10 lines
include/linux/cpumask.h +0
-10-* @list: indicates whether the cpumap must be list -* @mask: the cpumask to copy -* @buf: the buffer to copy into -* -* Return: the length of the (null-terminated) @buf string, zero if -* nothing is copied. -*/ -static __always_inline ssize_t -cpumap_print_to_pagebuf (bool list,char *buf,const struct cpumask *mask) -{
[Severity: Low]
Will this removal cause a build break for ARM configurations?
It appears there is still at least one remaining caller of this function that was not migrated in drivers/firmware/psci/psci_checker.c:
drivers/firmware/psci/psci_checker.c:hotplug_tests() {
...
ssize_t len = cpumap_print_to_pagebuf(true, page_buf,
cpu_groups[i]);
...
}Does this remaining callsite need to be updated to an alternative before dropping the function?
Quoted 4 lines
include/linux/cpumask.h +0
-4-/* Opencode offset_in_page(buf) to not include linux/mm.h */ -return scnprintf (buf,PAGE_SIZE - ((unsigned long )buf & ~PAGE_MASK ), - list ?"%*pbl\n" :"%*pb\n" ,cpumask_pr_args (mask)); -}
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=11
Added in bitmap-for-next. Thanks.
Quoted 86 lines · Yury Norov
cpumap_print_to_pagebuf()is the equivalent for the "&*pb[l]" notation in printk-like functions. In some cases, it makes people to create temporary buffers for the printed cpumasks, where it can be avoided.Get rid of it in a favor of more standard printing API.
Each patch, except for the last one, is independent and may be moved with the corresponding subsystem. Or I can take it in bitmap-for-next, at maintainers' discretion.
On top of -next.
This is the resend of:
https://lore.kernel.org/all/[email protected]/
Except the patches merged in 7.1 cycle. I'm going to apply the material in 7.2 unless explicit NAKs received.
Yury Norov (11):
arm: Usesysfs_emit()for cpumask show callbacks
powerpc: Usesysfs_emit()for cpumask show callbacks x86/events: Usesysfs_emit()for cpumask show callbacks
cpu: Usesysfs_emit()for cpumask show callback
devfreq: Usesysfs_emit()for cpumask show callbacks
fpga: dfl-fme-perf: Usesysfs_emit()for cpumask show
hwtracing:hisi_ptt: Usesysfs_emit()for cpumask show RDMA/hfi1: Usesysfs_emit()for cpumask show helper PCI/sysfs: Usesysfs_emit()for cpumask show callbacks
perf: Usesysfs_emit()for cpumask show callbackslib/bitmap-str: get rid ofcpumap_print_to_pagebuf()arch/arm/mach-imx/mmdc.c | 2 +- arch/arm/mm/cache-l2x0-pmu.c | 2 +- arch/powerpc/kernel/cacheinfo.c | 3 ++- arch/powerpc/perf/hv-24x7.c | 2 +- arch/powerpc/perf/hv-gpci.c | 2 +- arch/powerpc/perf/imc-pmu.c | 2 +- arch/x86/events/amd/iommu.c | 2 +- arch/x86/events/amd/power.c | 2 +- arch/x86/events/amd/uncore.c | 2 +- arch/x86/events/intel/core.c | 2 +- arch/x86/events/intel/uncore.c | 2 +- drivers/base/cpu.c | 2 +- drivers/devfreq/event/rockchip-dfi.c | 2 +- drivers/devfreq/hisi_uncore_freq.c | 2 +- drivers/fpga/dfl-fme-perf.c | 2 +- drivers/hwtracing/ptt/hisi_ptt.c | 2 +- drivers/infiniband/hw/hfi1/sdma.c | 3 ++- drivers/pci/pci-sysfs.c | 7 ++++--- drivers/perf/alibaba_uncore_drw_pmu.c | 2 +- drivers/perf/amlogic/meson_ddr_pmu_core.c | 2 +- drivers/perf/arm-cci.c | 2 +- drivers/perf/arm-ccn.c | 2 +- drivers/perf/arm-cmn.c | 2 +- drivers/perf/arm-ni.c | 2 +- drivers/perf/arm_cspmu/arm_cspmu.c | 2 +- drivers/perf/arm_dmc620_pmu.c | 4 ++-- drivers/perf/arm_dsu_pmu.c | 2 +- drivers/perf/arm_pmu.c | 2 +- drivers/perf/arm_smmuv3_pmu.c | 2 +- drivers/perf/arm_spe_pmu.c | 2 +- drivers/perf/cxl_pmu.c | 2 +- drivers/perf/dwc_pcie_pmu.c | 2 +- drivers/perf/fsl_imx8_ddr_perf.c | 2 +- drivers/perf/fsl_imx9_ddr_perf.c | 2 +- drivers/perf/fujitsu_uncore_pmu.c | 2 +- drivers/perf/hisilicon/hisi_pcie_pmu.c | 2 +- drivers/perf/hisilicon/hisi_uncore_pmu.c | 2 +- drivers/perf/marvell_cn10k_ddr_pmu.c | 2 +- drivers/perf/marvell_cn10k_tad_pmu.c | 2 +- drivers/perf/marvell_pem_pmu.c | 2 +- drivers/perf/nvidia_t410_c2c_pmu.c | 2 +- drivers/perf/nvidia_t410_cmem_latency_pmu.c | 2 +- drivers/perf/qcom_l2_pmu.c | 2 +- drivers/perf/qcom_l3_pmu.c | 2 +- drivers/perf/starfive_starlink_pmu.c | 2 +- drivers/perf/thunderx2_pmu.c | 2 +- drivers/perf/xgene_pmu.c | 2 +- include/linux/cpumask.h | 19 ------------------- kernel/events/core.c | 2 +- lib/bitmap-str.c | 9 ++++----- 50 files changed, 58 insertions(+), 75 deletions(-)Signature · 1 line
2.53.0