Skip to contentSkip to conversation

iio: adc: ad7779: Remove dead code and redundant error message

PATCH Applied Moksh Panicker 3 participants 7 messages Jul 2

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover iio: adc: ad7779: Remove dead code and redundant error message

These two patches address review feedback from Joshua Crofts on the ad7779 driver.

v3: Fix double blank line left after removing the completion field
v2: Add cover letter; send as fresh thread (not as reply to v1)
v1: Initial submission

Moksh Panicker (2):
iio: adc: ad7779: Remove unused completion field
iio: adc: ad7779: Remove redundant dev_err_probe() after
devm_request_irq()

 drivers/iio/adc/ad7779.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH v3 1/2 iio: adc: ad7779: Remove unused completion field

struct ad7779_state contains a completion field that is initialized in ad7779_setup_without_backend() but never waited on or signaled anywhere in the driver. Remove the dead code.

---
 drivers/iio/adc/ad7779.c | 2 --
 1 file changed, 2 deletions(-)
drivers/iio/adc/ad7779.c +0 -2
index 695cc79e78da..c1a99b4c1256 100644
@@ -143,7 +143,6 @@ struct ad7779_state {
 	const struct ad7779_chip_info *chip_info;
 	struct clk *mclk;
 	struct iio_trigger *trig;
-	struct completion completion;
 	unsigned int sampling_freq;
 	enum ad7779_filter filter_enabled;
 	struct iio_backend *back;
@@ -852,7 +851,6 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
 
 	indio_dev->trig = iio_trigger_get(st->trig);
 
-	init_completion(&st->completion);
 
 	ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
 					      &iio_pollfunc_store_time,
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH v3 1/2] iio: adc: ad7779: Remove unused completion field

Quoted 23 lines · On Thu, 2 Jul 2026 11:46:48 +0000 Moksh Panicker <[email protected]>…

struct ad7779_state contains a completion field that is initialized in ad7779_setup_without_backend() but never waited on or signaled anywhere in the driver. Remove the dead code.

---
 drivers/iio/adc/ad7779.c | 2 --
 1 file changed, 2 deletions(-)
drivers/iio/adc/ad7779.c +0 -1
index 695cc79e78da..c1a99b4c1256 100644
@@ -143,7 +143,6 @@ struct ad7779_state {
 	const struct ad7779_chip_info *chip_info;
 	struct clk *mclk;
 	struct iio_trigger *trig;
-	struct completion completion;
 	unsigned int sampling_freq;
 	enum ad7779_filter filter_enabled;
 	struct iio_backend *back;

drivers/iio/adc/ad7779.c static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev · line 854

Quoted 5 lines
drivers/iio/adc/ad7779.c +0 -1
@@ -852,7 +851,6 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
 
 	indio_dev->trig = iio_trigger_get(st->trig);
 
-	init_completion(&st->completion);
 

Remove the blank line here as well.

Quoted 2 lines
drivers/iio/adc/ad7779.c +0 -0
 	ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
 					      &iio_pollfunc_store_time,
Signature · 3 lines
Kind regards

CJD
maintainer
#3 lore raw

Re: [PATCH v3 1/2] iio: adc: ad7779: Remove unused completion field

Quoted 27 lines · On Thu, 2 Jul 2026 13:54:28 +0200 Joshua Crofts <[email protected]>…
Quoted 24 lines · On Thu, 2 Jul 2026 11:46:48 +0000 Moksh Panicker <[email protected]>…

struct ad7779_state contains a completion field that is initialized in ad7779_setup_without_backend() but never waited on or signaled anywhere in the driver. Remove the dead code.

---
 drivers/iio/adc/ad7779.c | 2 --
 1 file changed, 2 deletions(-)
drivers/iio/adc/ad7779.c +0 -1
index 695cc79e78da..c1a99b4c1256 100644
@@ -143,7 +143,6 @@ struct ad7779_state {
 	const struct ad7779_chip_info *chip_info;
 	struct clk *mclk;
 	struct iio_trigger *trig;
-	struct completion completion;
 	unsigned int sampling_freq;
 	enum ad7779_filter filter_enabled;
 	struct iio_backend *back;
@@ -852,7 +851,6 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
 
Quoted 6 lines

drivers/iio/adc/ad7779.c static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev · line 854

Quoted 4 lines
drivers/iio/adc/ad7779.c +0 -1
 	indio_dev->trig = iio_trigger_get(st->trig);
 
-	init_completion(&st->completion);
 

Remove the blank line here as well.

Fixed up and applied.

Quoted 6 lines
Quoted 3 lines
drivers/iio/adc/ad7779.c +0 -0
 	ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
 					      &iio_pollfunc_store_time,  
#4 lore raw

PATCH v3 2/2 iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq()

In reply to Moksh Panicker

devm_request_irq() already prints an error message on failure via the IRQ core, so wrapping its return value in dev_err_probe() results in a duplicate error message. Return the error directly instead.

---
 drivers/iio/adc/ad7779.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/ad7779.c +1 -2
index c1a99b4c1256..a5b8bfa99a74 100644
@@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
 			       IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name,
 			       st->trig);
 	if (ret)
-		return dev_err_probe(dev, ret, "request IRQ %d failed\n",
-				     st->spi->irq);
+		return ret;
 
 	ret = devm_iio_trigger_register(dev, st->trig);
 	if (ret)
Signature · 1 line
2.34.1
Reviewed-by on v3 2/2
#5 lore raw

Re: [PATCH v3 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq()

Quoted 15 lines · On Thu, 2 Jul 2026 11:46:49 +0000 Moksh Panicker <[email protected]>…

devm_request_irq() already prints an error message on failure via the IRQ core, so wrapping its return value in dev_err_probe() results in a duplicate error message. Return the error directly instead.

---
 drivers/iio/adc/ad7779.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/ad7779.c +0 -0
index c1a99b4c1256..a5b8bfa99a74 100644

drivers/iio/adc/ad7779.c static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev · line 848

Quoted 9 lines
drivers/iio/adc/ad7779.c +1 -2
@@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
 			       IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name,
 			       st->trig);
 	if (ret)
-		return dev_err_probe(dev, ret, "request IRQ %d failed\n",
-				     st->spi->irq);
+		return ret;
 
 	ret = devm_iio_trigger_register(dev, st->trig);
 	if (ret)
Signature · 3 lines
Kind regards

CJD
maintainer Applied
#6 lore raw

Re: [PATCH v3 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq()

Quoted 25 lines · On Thu, 2 Jul 2026 13:54:54 +0200 Joshua Crofts <[email protected]>…
Quoted 22 lines · On Thu, 2 Jul 2026 11:46:49 +0000 Moksh Panicker <[email protected]>…

devm_request_irq() already prints an error message on failure via the IRQ core, so wrapping its return value in dev_err_probe() results in a duplicate error message. Return the error directly instead.

---
 drivers/iio/adc/ad7779.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/adc/ad7779.c +1 -2
index c1a99b4c1256..a5b8bfa99a74 100644
@@ -842,8 +842,7 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
 			       IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name,
 			       st->trig);
 	if (ret)
-		return dev_err_probe(dev, ret, "request IRQ %d failed\n",
-				     st->spi->irq);
+		return ret;
 
Quoted 5 lines

drivers/iio/adc/ad7779.c static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev · line 848

Quoted 2 lines
drivers/iio/adc/ad7779.c +0 -0
 	ret = devm_iio_trigger_register(dev, st->trig);
 	if (ret)  

Applied.