Skip to contentSkip to conversation

Add devicetree for the Graperain G3568 v2

PATCH Superseded Coia Prant 2 participants 6 messages Jul 2

Subsystems (2)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Coia Prant

author
#0 lore raw

v4 cover Add devicetree for the Graperain G3568 v2

Changes in v2:
- Fix trailing whitespaces and other formatting issues.

Changes in v3:
- Picked up Acked-by tag for patch 1.
- Fixed text wrapping in the commit message of patch 2.
- Replace the legacy 'gpio' label with 'gpios'.
- Add the basic WiFi child node.
- Add the Bluetooth UART child node.

Changes in v4:
- Fix incorrect pinctrl bluetooth node name.
- Disable bluetooth sound since rk3568-codec-digital unavailable.
- Add WiFi fallback compatible string.
- Add WiFi host wake interrupt.

Notes/Unchanged from v1:
- ADC keys have been verified with evtest and works fine; kept unchanged.
- The 'regulator-off-in-suspend' property for vqmmc-supply is retained. This is a known issue shared by most similar boards and should be addressed globally later.
---
Coia Prant (3):
dt-bindings: vendor-prefixes: Add graperain
dt-bindings: arm: rockchip: Add Graperain G3568 series
arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

 .../devicetree/bindings/arm/rockchip.yaml     |   6 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../rockchip/rk3568-graperain-g3568-v2.dts    | 943 ++++++++++++++++++
 4 files changed, 952 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts
Signature · 1 line
2.47.3
author
#1 lore raw

PATCH v4 1/3 dt-bindings: vendor-prefixes: Add graperain

Add graperain to the vendor prefixes.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 396044f368e7c..641a37c0debc9 100644
@@ -682,6 +682,8 @@ patternProperties:
     description: Goramo Gorecki
   "^gplus,.*":
     description: GPLUS
+  "^graperain,.*":
+    description: Shenzhen Graperain Technology Co., Ltd.
   "^grinn,.*":
     description: Grinn
   "^grmn,.*":
Signature · 1 line
2.47.3
author
#2 lore raw

PATCH v4 2/3 dt-bindings: arm: rockchip: Add Graperain G3568 series

In reply to Coia Prant

Document the Graperain G3568 v2, which is a development board based on the Rockchip RK3568 SoC.

Graperain G3568 series also have an SBC series with the suffix "box".

Graperain G3568 v2 belongs to development board series, not SBC series.

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +6 -0
index 1a9dde18626d0..9eb2f66ba3856 100644
@@ -684,6 +684,12 @@ properties:
           - const: google,veyron
           - const: rockchip,rk3288
 
+      - description: Graperain G3568 series board
+        items:
+          - enum:
+              - graperain,g3568-v2
+          - const: rockchip,rk3568
+
       - description: H96 Max V58 TV Box
         items:
           - const: haochuangyi,h96-max-v58
Signature · 1 line
2.47.3
author
#3 lore raw

PATCH v4 3/3 arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

In reply to Coia Prant

The Graperain G3568 v2 is an RK3568-based development board, just like the RK3568-EVB.
It always uses soldered connections between the GR3568CV2 core board and the RK3568BV2/GR3568BV2 I/O board.

The G3568 board has multiple hardware revisions, and we currently support v2 (I/O board).

Specification:
- SoC: RockChip RK3568 ARM64 (4 cores)
- eMMC: 16-128 GB
- RAM: 2-16 GB
- Power: DC 12V 2A
- Ethernet: 2x RTL8211F RGMII (10/100/1000 Mbps)
- Wireless radio: 802.11b/g/n/ac dual-band
- LED:
Power: AlwaysOn
User: GPIO
- Button:
ESC: SARADC/0 <1100k µV>
MENU: SARADC/0 <1400k µV>
VOL-: SARADC/0 <430k µV>
VOL+: SARADC/0 <50k µV>
Power/Reset: PMIC RK809
- CAN
CAN/1: 4-pin (PH 2.0)
- PWM
PWM/4: Backlight
PWM/5: Backlight
PWM/7: IR Receiver
- UART:
UART/2: Debug TTL - 1500000 8N1 (1.25mm)
UART/3: TTL (PH 2.0)
UART/4: TTL (PH 2.0)
UART/8: AP6356S Bluetooth
UART/9: TTL (PH 2.0)
- I2C:
I2C/0: PMIC RK809
I2C/1: Touchscreen
I2C/4: Camera
I2C/5: RTC@51 PCF8563
- I2S:
I2S/0: HDMI Sound
I2S/1: RK809 Audio Codec
I2S/3: AP6356S Bluetooth Sound
- SDMMC:
SDMMC/0: microSD (TF) slot
SDMMC/2: AP6356S SDIO WiFi card
- Camera: 1x CSI
- Video: HDMI / DSI0 (MIPI/LVDS) / DSI1 (MIPI/EDP)
- Audio: HDMI / MIC / Speaker / SPDIF / 3.5mm Headphones / AP6356S Bluetooth
- USB:
USB 2.0 HOST x2
USB 2.0 OTG x1 (shared with USB 3.0 OTG/HOST)
USB 3.0 HOST x1
USB 3.0 OTG/HOST x1
- SATA: 1x SATA 3.0 with Power/4-pin
- PCIe: 1x PCIe 3.0 x2 (x4 connector)

Link:
- https://image.chukouplus.com/upload/C_153/product_file/20211022/6daddec9e400458816dd4c57ba807fc3.pdf
- https://blog.gov.cooking/archives/research-graperain-g3568-v2-and-flash.html

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../rockchip/rk3568-graperain-g3568-v2.dts    | 943 ++++++++++++++++++
 2 files changed, 944 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index 761d82b4f4f2a..6e9d049e8ddaf 100644
@@ -144,6 +144,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-easepi-r1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r68s.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-graperain-g3568-v2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-hinlink-h66k.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-hinlink-h68k.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-lubancat-2.dtb
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +943 -0

943 lines not on this page · raw message

Signature · 1 line
2.47.3
#4 lore raw

Re: [PATCH v4 3/3] arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Contradictory IRQ polarity and internal pull-down resistor for the WiFi host-wake interrupt. --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Contradictory IRQ polarity and internal pull-down resistor for the WiFi host-wake interrupt. --

commit 5e0547ff442a7edaa2500fa690169e0535d25791
Author: Coia Prant <[email protected]>

arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

This commit introduces the devicetree for the Graperain G3568 v2, an RK3568-based development board. It configures the hardware description for various components including ethernet, wireless radio, and peripherals.

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +0 -0
new file mode 100644
index 0000000000000..5fc043b352042

[ ... ]

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +6 -0
+	wifi-irq {
+		wifi_host_wake_irq: wifi-host-wake-irq {
+			rockchip,pins = <3 RK_PD4 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+	};
+};

[ ... ]

arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts line 816

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +5 -0
+	wifi@1 {
+		compatible = "brcm,bcm4356-fmac", "brcm,bcm4329-fmac";
+		reg = <1>;
+		interrupt-parent = <&gpio3>;
+		interrupts = <RK_PD4 IRQ_TYPE_LEVEL_LOW>;

[Severity: High]
Will this combination of an active-low level-triggered interrupt and a pull-down resistor cause an interrupt storm?

If the WiFi module enters a sleep state and leaves the pin floating, the pull-down configured in wifi_host_wake_irq will drive the pin low. Because the interrupt is configured as IRQ_TYPE_LEVEL_LOW, won't the kernel continuously fire the interrupt handler?

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +5 -0
+		interrupt-names = "host-wake";
+		pinctrl-names = "default";
+		pinctrl-0 = <&wifi_host_wake_irq>;
+	};
+};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
author
#5 lore raw

Re: [PATCH v4 3/3] arm64: dts: rockchip: Add devicetree for the Graperain G3568 v2

Quoted 15 lines
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +6 -0
+     wifi-irq {
+             wifi_host_wake_irq: wifi-host-wake-irq {
+                     rockchip,pins = <3 RK_PD4 RK_FUNC_GPIO &pcfg_pull_down>;
+             };
+     };
+};

[ ... ]

arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts line 816

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +5 -0
+     wifi@1 {
+             compatible = "brcm,bcm4356-fmac", "brcm,bcm4329-fmac";
+             reg = <1>;
+             interrupt-parent = <&gpio3>;
+             interrupts = <RK_PD4 IRQ_TYPE_LEVEL_LOW>;
Quoted 14 lines

[Severity: High]
Will this combination of an active-low level-triggered interrupt and a pull-down resistor cause an interrupt storm?

If the WiFi module enters a sleep state and leaves the pin floating, the pull-down configured in wifi_host_wake_irq will drive the pin low. Because the interrupt is configured as IRQ_TYPE_LEVEL_LOW, won't the kernel continuously fire the interrupt handler?

Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-graperain-g3568-v2.dts new file +5 -0
+             interrupt-names = "host-wake";
+             pinctrl-names = "default";
+             pinctrl-0 = <&wifi_host_wake_irq>;
+     };
+};

It should be IRQ_TYPE_LEVEL_HIGH, wrong value in OEM SDK.