Skip to contentSkip to conversation

rockchip: arm64: dts: rockchip: Fix incorrect interrupt for the 9Tripod X3568 v4

PATCH Applied Coia Prant 2 participants 2 messages Jul 2 – Jul 7

Subsystems (2)
lore
Share & tools
lore

Coia Prant

author
#0 lore raw

PATCH 1/1 rockchip: arm64: dts: rockchip: Fix incorrect interrupt for the 9Tripod X3568 v4

The recently changes for 9Tripod X3568 mistakenly configured the WiFi host-wake interrupt trigger type as IRQ_TYPE_LEVEL_LOW.

However, the associated pin wifi_host_wake_irq is configured with an internal pull-down resistor.

When the WiFi module enters a low-power sleep state and leaves the pin floating, this pull-down bias drives the pin low.

Since the interrupt is incorrectly set to level-low, this combination traps the kernel in an endless interrupt loop.

Correct the interrupt trigger type to IRQ_TYPE_LEVEL_HIGH based on the actual hardware logic: the pin is kept low by default and driven high by the WiFi module to wake up the host.

Fixes 993555b5476c ("arm64: dts: rockchip: Add AP6275S support for 9Tripod X3568 v4")
---
 arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts +1 -1
index e3f53fcf80e0..b48c0c9ba112 100644
@@ -799,7 +799,7 @@ wifi@1 {
 		compatible = "brcm,bcm43752-fmac", "brcm,bcm4329-fmac";
 		reg = <1>;
 		interrupt-parent = <&gpio3>;
-		interrupts = <RK_PD4 IRQ_TYPE_LEVEL_LOW>;
+		interrupts = <RK_PD4 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "host-wake";
 		pinctrl-names = "default";
 		pinctrl-0 = <&wifi_host_wake_irq>;
Signature · 1 line
2.47.3
maintainer Applied
#1 lore raw
Quoted 10 lines · Coia Prant

The recently changes for 9Tripod X3568 mistakenly configured the WiFi host-wake interrupt trigger type as IRQ_TYPE_LEVEL_LOW.

However, the associated pin wifi_host_wake_irq is configured with an internal pull-down resistor.

When the WiFi module enters a low-power sleep state and leaves the pin floating, this pull-down bias drives the pin low.

[...]

Applied, thanks!

[1/1] rockchip: arm64: dts: rockchip: Fix incorrect interrupt for the 9Tripod X3568 v4

      commit: c22f566c82f59a46adaf7404b78a9617307afe0a

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>