gpio: cdev: Drop redundant nonseekable_open() return check
PATCH 1/1 gpio: cdev: Drop redundant nonseekable_open() return check
From: bui duc phuc <[email protected]>
nonseekable_open() never fails, so the error check is unnecessary. Remove the dead error handling path.
Signed-off-by bui duc phuc <[email protected]>
--- drivers/gpio/gpiolib-cdev.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/gpio/gpiolib-cdev.c +1 -8
@@ -2682,15 +2682,8 @@ static int gpio_chrdev_open(struct inode *inode, struct file *file) file->private_data = cdev; cdev->fp = file; - ret =nonseekable_open (inode, file); -if (ret) - goto out_unregister_device_notifier; - -return ret; +return nonseekable_open (inode, file); -out_unregister_device_notifier: -blocking_notifier_chain_unregister (&gdev->device_notifier, - &cdev->device_unregistered_nb); out_unregister_line_notifier: scoped_guard(write_lock_irqsave, &gdev->line_state_lock) raw_notifier_chain_unregister(&gdev->line_state_notifier,
Signature · 1 line
2.43.0
Bartosz Golaszewski
AppliedQuoted 4 lines · On Fri, 03 Jul 2026 09:09:46 +0700, [email protected] wrote:
nonseekable_open()never fails, so the error check is unnecessary. Remove the dead error handling path.
Applied, thanks!
[1/1] gpio: cdev: Drop redundant nonseekable_open() return check
https://git.kernel.org/brgl/c/44d75ed98ddde54edc55e9300bb70ea9a7c62f4b
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>