fanotify: initialize permission event watchdog state
Subsystems (3)
PATCH 1/1 fanotify: initialize permission event watchdog state
From: Xuanqiang Luo <[email protected]>
fanotify permission events are allocated with kmem_cache_alloc(), but fanotify_alloc_perm_event() does not initialize watchdog_cnt.
The watchdog reads watchdog_cnt after the event is moved to access_list. A stale value can make it warn too early or skip the warning.
Initialize watchdog_cnt when allocating a permission event.
--- fs/notify/fanotify/fanotify.c | 1 + 1 file changed, 1 insertion(+)
fs/notify/fanotify/fanotify.c +1 -0
@@ -599,6 +599,7 @@ static struct fanotify_event *fanotify_alloc_perm_event(const void *data, pevent->hdr.pad =0 ; pevent->hdr.len =0 ; pevent->state =FAN_EVENT_INIT ; + pevent->watchdog_cnt =0 ; pevent->path = *path;/* NULL ppos means no range info */ pevent->ppos = range ? &range->pos :NULL ;
Signature · 1 line
2.43.0
Jan Kara
maintainerQuoted 5 lines · On Fri 03-07-26 11:13:45, [email protected] wrote:
From: Xuanqiang Luo <[email protected]>
fanotify permission events are allocated with
kmem_cache_alloc(), butfanotify_alloc_perm_event()does not initializewatchdog_cnt.
Quoted 7 lines
The watchdog reads
watchdog_cntafter the event is moved toaccess_list. A stale value can make it warn too early or skip the warning.Initialize
watchdog_cntwhen allocating a permission event.Fixes b8cf8fda522d ("fanotify: add watchdog for permission events")Signed-off-by Xuanqiang Luo <[email protected]>
Thanks. I've added the patch to my tree.
Honza
Quoted 19 lines
--- fs/notify/fanotify/fanotify.c | 1 + 1 file changed, 1 insertion(+)fs/notify/fanotify/fanotify.c +1
-0@@ -599,6 +599,7 @@ static struct fanotify_event *fanotify_alloc_perm_event(const void *data, pevent->hdr.pad =0 ; pevent->hdr.len =0 ; pevent->state =FAN_EVENT_INIT ; + pevent->watchdog_cnt =0 ; pevent->path = *path;/* NULL ppos means no range info */ pevent->ppos = range ? &range->pos :NULL ;Signature · 1 line
2.43.0
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR