media: synopsys: hdmirx: use request_any_context_irq() for 5V detection IRQ
Subsystems (2)
PATCH 1/1 media: synopsys: hdmirx: use request_any_context_irq() for 5V detection IRQ
Replace devm_request_irq() with devm_request_any_context_irq() for the 5V detection interrupt handler. This allows the kernel to choose the appropriate execution context (hardirq or threaded) depending on the underlying interrupt controller. On some platforms, the interrupt may be nested or require a threaded handler, and using the fixed hardirq version can cause probe failures. Switching to the more flexible function improves driver portability without affecting functionality.
--- drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c +5 -4
@@ -2609,10 +2609,11 @@ static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev,irq_set_status_flags (irq,IRQ_NOAUTOEN ); hdmirx_dev->det_irq = irq; - ret =devm_request_irq (dev, irq, hdmirx_5v_det_irq_handler, -IRQF_TRIGGER_FALLING |IRQF_TRIGGER_RISING , -"rk_hdmirx-5v" , hdmirx_dev); -if (ret) { + ret =devm_request_any_context_irq (dev, irq, hdmirx_5v_det_irq_handler, +IRQF_TRIGGER_FALLING | +IRQF_TRIGGER_RISING , +"rk_hdmirx-5v" , hdmirx_dev); +if (ret <0 ) {dev_err_probe (dev, ret,"failed to request hdmirx-5v irq\n" );return ret; }
Signature · 1 line
2.52.0
Quoted 25 lines · Alexander Shiyan
Replace
devm_request_irq()withdevm_request_any_context_irq()for the 5V detection interrupt handler. This allows the kernel to choose the appropriate execution context (hardirq or threaded) depending on the underlying interrupt controller. On some platforms, the interrupt may be nested or require a threaded handler, and using the fixed hardirq version can cause probe failures. Switching to the more flexible function improves driver portability without affecting functionality.Fixes 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")Signed-off-by Alexander Shiyan <[email protected]>--- drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c +0
-2@@ -2609,10 +2609,11 @@ static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev,irq_set_status_flags (irq,IRQ_NOAUTOEN ); hdmirx_dev->det_irq = irq; - ret = devm_request_irq(dev, irq, hdmirx_5v_det_irq_handler, - IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c static int hdmirx_setup_irq(struct snps_hdmirx_dev *hdmirx_dev, · line 2619
Quoted 10 lines
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c +5
-2- "rk_hdmirx-5v", hdmirx_dev); -if (ret) { + ret =devm_request_any_context_irq (dev, irq, hdmirx_5v_det_irq_handler, +IRQF_TRIGGER_FALLING | +IRQF_TRIGGER_RISING , +"rk_hdmirx-5v" , hdmirx_dev); +if (ret <0 ) {dev_err_probe (dev, ret,"failed to request hdmirx-5v irq\n" );return ret; }
Signature · 2 lines
Best regards, Dmitry