Skip to contentSkip to conversation

mtd: spi-nor: Add Dosilicon DS25Q4BB support

PATCH Superseded Ssunk 3 participants 7 messages Jun 14 – Oct 22 Memory technology devices (MTD)

lore
Share & tools
lore

Ssunk

author
#0 lore raw

PATCH 1/1 mtd: spi-nor: Add Dosilicon DS25Q4BB support

Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.

Datasheet:
https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view

---
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -0
index c0fa98424aa..b370e782627 100644
@@ -87,6 +87,8 @@ const struct flash_info spi_nor_ids[] = {
 		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("ds25q4dn", 0xe5301b, 0, 64 * 1024, 2048,
 		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+	{ INFO("ds25q4bb", 0xe53019, 0, 64 * 1024, 512,
+		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_EON		/* EON */
 	/* EON -- en25xxx */
Signature · 1 line
2.43.0
#1 lore raw

Hi,

Quoted 4 lines

Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.

Datasheet:
https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view

Do you have a link to vendor's site? If you have, use Link: tag just above your Signed-off-by: tag. If not, please write this after the '---' separator. I don't think it's good to add a link to share drive in commit description.

Quoted 2 lines

Could you sign with full name?

Quoted 18 lines
---
 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -1
index c0fa98424aa..b370e782627 100644
@@ -87,6 +87,8 @@ const struct flash_info spi_nor_ids[] = {
                    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("ds25q4dn", 0xe5301b, 0, 64 * 1024, 2048,
                    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+       { INFO("ds25q4bb", 0xe53019, 0, 64 * 1024, 512,
+                   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_EON            /* EON */
        /* EON -- en25xxx */
--
Quoted 1 line

2.43.0

Thanks,
Takahiro

#2 lore raw
Quoted 10 lines · On Fri, Jul 03, 2026 at 08:11:48AM +0000, [email protected] wrote:

Hi,

Quoted 4 lines

Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.

Datasheet:
https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view

Do you have a link to vendor's site? If you have, use Link: tag just above your Signed-off-by: tag. If not, please write this after the '---' separator. I don't think it's good to add a link to share drive in commit description.

Yes, this is not a good idea, we need a link to the vendor, somewhere.

Quoted 3 lines
Quoted 1 line

Could you sign with full name?

Just like the linux kernel, we don't have a "full name" policy anymore, so this part is fine.

Signature · 1 line
Tom
#3 lore raw
Quoted 19 lines

-----Original Message-----
From: Tom Rini <[email protected]>
Sent: Friday, July 3, 2026 11:12 PM
To: Kuwano Takahiro (ATV MS MPL PAE - MS) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] mtd: spi-nor: Add Dosilicon DS25Q4BB support

Quoted 10 lines · On Fri, Jul 03, 2026 at 08:11:48AM +0000, [email protected] wrote:

Hi,

Quoted 4 lines

Add support for dosilicon ds25q4bb (256M-bit) SPI NOR flash.

Datasheet:
https://drive.google.com/file/d/17UFJa5_3imH0YmWlRGTQYhO2JBXf4Klk/view

Do you have a link to vendor's site? If you have, use Link: tag just above your Signed-off-by: tag. If not, please write this after the '---' separator. I don't think it's good to add a link to share drive in commit description.

Quoted 8 lines

Yes, this is not a good idea, we need a link to the vendor, somewhere.

Quoted 3 lines
Quoted 1 line

Could you sign with full name?

Just like the linux kernel, we don't have a "full name" policy anymore, so this part is fine.

Well noted with thanks.

Takahiro

author
#4 lore raw

PATCH v2 1/1 mtd: spi-nor: Add Dosilicon DS25Q4BB support

In reply to Ssunk

Add support for Dosilicon DS25Q4BB (256M-bit) SPI NOR flash.

---
Changes in v2:
- Replace Google Drive datasheet link with the official Dosilicon link.

 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -0
index 31a2ba4..0a63e50 100644
@@ -87,6 +87,8 @@ const struct flash_info spi_nor_ids[] = {
 		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 	{ INFO("ds25q4dn", 0xe5301b, 0, 64 * 1024, 2048,
 		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+	{ INFO("ds25q4bb", 0xe53019, 0, 64 * 1024, 512,
+		    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_EON		/* EON */
 	/* EON -- en25xxx */
Signature · 1 line
2.53.0.windows.2
Reviewed-by on v2 1/1
#5 lore raw
Quoted 26 lines

Add support for Dosilicon DS25Q4BB (256M-bit) SPI NOR flash.

---
Changes in v2:
- Replace Google Drive datasheet link with the official Dosilicon link.

 drivers/mtd/spi/spi-nor-ids.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +2 -1
index 31a2ba4..0a63e50 100644
@@ -87,6 +87,8 @@ const struct flash_info spi_nor_ids[] = {
                    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
        { INFO("ds25q4dn", 0xe5301b, 0, 64 * 1024, 2048,
                    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
+       { INFO("ds25q4bb", 0xe53019, 0, 64 * 1024, 512,
+                   SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES) },
 #endif
 #ifdef CONFIG_SPI_FLASH_EON            /* EON */
        /* EON -- en25xxx */
--
Quoted 1 line

2.53.0.windows.2

#6 lore raw
In reply to Ssunk
Quoted 3 lines · Ssunk

Add support for Dosilicon DS25Q4BB (256M-bit) SPI NOR flash.

Applied to u-boot/main, thanks!

[1/1] mtd: spi-nor: Add Dosilicon DS25Q4BB support

      commit: 411065073ad5d0a02ee6765026aedad1661b746d
Signature · 1 line
Tom