selftests/filesystems: fix missing and stale TARGETS entries
PATCH 1/1 selftests/filesystems: fix missing and stale TARGETS entries
filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr were never added to TARGETS when introduced. filesystems/openat2 was moved from selftests/openat2/ but the TARGETS entry was never updated, leaving a stale entry pointing at a directory that no longer exists.
Fix this by adding the four missing subdirectories to TARGETS and removing the stale openat2 entry.
--- tools/testing/selftests/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/testing/selftests/Makefile +4 -1
@@ -33,7 +33,10 @@ TARGETS += fchmodat2 TARGETS += filesystems TARGETS += filesystems/binderfs TARGETS += filesystems/epoll +TARGETS += filesystems/eventfd TARGETS += filesystems/fat +TARGETS += filesystems/openat2 +TARGETS += filesystems/open_tree_ns TARGETS += filesystems/overlayfs TARGETS += filesystems/statmount TARGETS += filesystems/mount-notify
@@ -42,6 +45,7 @@ TARGETS += filesystems/fuse TARGETS += filesystems/move_mount TARGETS += filesystems/empty_mntns TARGETS += filesystems/fsmount_ns +TARGETS += filesystems/xattr TARGETS += firmware TARGETS += fpu TARGETS += ftrace
@@ -98,7 +102,6 @@ TARGETS += prctl TARGETS += proc TARGETS += pstore TARGETS += ptrace -TARGETS += openat2 TARGETS += rdma TARGETS += resctrl TARGETS += riscv
Signature · 1 line
2.45.1
Quoted 5 lines
filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr were never added to TARGETS when introduced. filesystems/openat2 was moved from selftests/openat2/ but the TARGETS entry was never updated, leaving a stale entry pointing at a directory that no longer exists.
Quoted 8 lines
Fix this by adding the four missing subdirectories to TARGETS and removing the stale openat2 entry.
Fixes 7c37857fc23a ("selftests: add eventfd selftests")Fixes b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")Fixes 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")Fixes fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")Signed-off-by Disha Goel <[email protected]>
Seems fine,
Signature · 1 line
Christian Brauner <[email protected]>
Gentle ping — is this patch merged or queued for a future merge window.
Quoted 17 lines · Christian Brauner
Quoted 5 lines
filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr were never added to TARGETS when introduced. filesystems/openat2 was moved from selftests/openat2/ but the TARGETS entry was never updated, leaving a stale entry pointing at a directory that no longer exists.
Quoted 8 lines
Fix this by adding the four missing subdirectories to TARGETS and removing the stale openat2 entry.
Fixes 7c37857fc23a ("selftests: add eventfd selftests")Fixes b8f7622aa6e3 ("selftests/open_tree: add OPEN_TREE_NAMESPACE tests")Fixes 7e28fef5d4db ("selftests/xattr: path-based AF_UNIX socket xattr tests")Fixes fe087927046c ("selftests: move openat2 tests to selftests/filesystems/")Signed-off-by Disha Goel <[email protected]>Seems fine,
Reviewed-by Christian Brauner (Amutable) <[email protected]>
Signature · 2 lines
Regards, Disha
Andrew Morton
Reviewed-by Christian Brauner (Amutable)Quoted 2 lines · On Mon, 31 Aug 2026 15:16:45 +0530 Disha Goel <[email protected]> wrote:
Gentle ping — is this patch merged or queued for a future merge window.
I can help with that ;)
The four Fixes: targets are problematic. How are backporters to figure out what kernel version(s) need the patch?
I guess these things crept in over time and a four-patch series would be too elaborate.
I'll just queue it for 7.3-rcX and will let others figure out the fallout.
The underlying code has changed somewhat, but the fixups were simple.
From: Disha Goel <[email protected]>
Subject: selftests/filesystems: fix missing and stale TARGETS entries
Date: Fri, 3 Jul 2026 20:37:42 +0530
filesystems/eventfd, filesystems/open_tree_ns and filesystems/xattr were never added to TARGETS when introduced. filesystems/openat2 was moved from selftests/openat2/ but the TARGETS entry was never updated, leaving a stale entry pointing at a directory that no longer exists.
Fix this by adding the four missing subdirectories to TARGETS and removing the stale openat2 entry.
---
tools/testing/selftests/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
tools/testing/selftests/Makefile renamed from tools/testing/selftests/Makefile~selftests-filesystems-fix-missing-and-stale-targets-entries +4 -1
@@ -35,8 +35,11 @@ TARGETS += fchmodat2 TARGETS += filesystems TARGETS += filesystems/binderfs TARGETS += filesystems/epoll +TARGETS += filesystems/eventfd TARGETS += filesystems/failfs TARGETS += filesystems/fat +TARGETS += filesystems/openat2 +TARGETS += filesystems/open_tree_ns TARGETS += filesystems/overlayfs TARGETS += filesystems/statmount TARGETS += filesystems/mount-notify
@@ -47,6 +50,7 @@ TARGETS += filesystems/empty_mntns TARGETS += filesystems/fsmount_ns TARGETS += filesystems/fscontext_ns TARGETS += filesystems/mntns_cleanup +TARGETS += filesystems/xattr TARGETS += firmware TARGETS += fpu TARGETS += ftrace
@@ -103,7 +107,6 @@ TARGETS += prctl TARGETS += proc TARGETS += pstore TARGETS += ptrace -TARGETS += openat2 TARGETS += rdma TARGETS += resctrl TARGETS += riscv
_
Christian Brauner
maintainerQuoted 6 lines · Andrew Morton
Quoted 2 lines · On Mon, 31 Aug 2026 15:16:45 +0530 Disha Goel <[email protected]> wrote:
Gentle ping — is this patch merged or queued for a future merge window.
I can help with that ;)
No, that's already picked up in the vfs tree where it belongs.