netfs: handle single writeback rolling buffer allocation failure
Subsystems (2)
PATCH 1/1 netfs: handle single writeback rolling buffer allocation failure
netfs_write_folio_single() takes an extra folio reference before appending the folio to the rolling buffer.
rolling_buffer_append() can fail if it cannot allocate another folio_queue. Check the return value and drop the extra folio reference before returning the error.
Signed-off-by Yichong Chen <[email protected]>
--- fs/netfs/write_issue.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
fs/netfs/write_issue.c +6 -1
@@ -721,6 +721,7 @@ static int netfs_write_folio_single(struct netfs_io_request *wreq,size_t iter_off =0 ;size_t fsize =folio_size (folio), flen;loff_t fpos =folio_pos (folio); +ssize_t ret;bool to_eof = false;bool no_debug = false;
@@ -749,7 +750,11 @@ static int netfs_write_folio_single(struct netfs_io_request *wreq,/* Attach the folio to the rolling buffer. */ folio_get (folio); -rolling_buffer_append (&wreq->buffer, folio,NETFS_ROLLBUF_PUT_MARK ); + ret =rolling_buffer_append (&wreq->buffer, folio,NETFS_ROLLBUF_PUT_MARK ); +if (ret <0 ) { +folio_put (folio); +return ret; + }/* Move the submission point forward to allow for write-streaming data * not starting at the front of the page. We don't do write-streaming
Signature · 1 line
2.51.0