Skip to contentSkip to conversation

timers/migration: Fix memory leak in tmigr_setup_groups() error path

PATCH Applied Malaya Kumar Rout 2 participants 2 messages Jul 4 – Jul 7 High-resolution timers, timer wheel, clockevents

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 timers/migration: Fix memory leak in tmigr_setup_groups() error path

When the WARN_ON_ONCE(i >= tmigr_hierarchy_levels) assertion triggers, the function returns -EINVAL without freeing the 'stack' memory allocated via kzalloc_objs() at the beginning of the function.

Add kfree(stack) before returning to prevent the memory leak.

Fixes 6c181b5667ee ("timers/migration: Convert "while" loops to use "for"")
---
 kernel/time/timer_migration.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/time/timer_migration.c +3 -2
index 806c23cf71fc..d2654abfdef7 100644
@@ -1847,9 +1847,10 @@ static int tmigr_setup_groups(struct tmigr_hierarchy *hier, unsigned int cpu,
 	}
 
 	/* Assert single root without parent */
-	if (WARN_ON_ONCE(i >= tmigr_hierarchy_levels))
+	if (WARN_ON_ONCE(i >= tmigr_hierarchy_levels)) {
+		kfree(stack);
 		return -EINVAL;
-
+	}
 	for (; i >= start_lvl; i--) {
 		group = stack[i];
 
Signature · 1 line
2.54.0
#1 lore raw
The following commit has been merged into the timers/core branch of tip:

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     eddfded4196542deda7cb2da3d7ebef83f7ccfa4
Gitweb:        https://git.kernel.org/tip/eddfded4196542deda7cb2da3d7ebef83f7ccfa4
Author:        Malaya Kumar Rout <[email protected]>
AuthorDate:    Sat, 04 Jul 2026 14:25:33 +05:30
Committer:     Thomas Gleixner <[email protected]>
CommitterDate: Tue, 07 Jul 2026 23:26:58 +02:00

timers/migration: Fix memory leak in tmigr_setup_groups() error path

When the WARN_ON_ONCE(i >= tmigr_hierarchy_levels) assertion triggers, the function returns -EINVAL without freeing the 'stack' memory allocated via kzalloc_objs() at the beginning of the function.

Add kfree(stack) before returning to prevent the memory leak.

Fixes 6c181b5667ee ("timers/migration: Convert "while" loops to use "for"")
---
 kernel/time/timer_migration.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
kernel/time/timer_migration.c +3 -1
index 806c23c..059d433 100644
@@ -1847,8 +1847,10 @@ static int tmigr_setup_groups(struct tmigr_hierarchy *hier, unsigned int cpu,
 	}
 
 	/* Assert single root without parent */
-	if (WARN_ON_ONCE(i >= tmigr_hierarchy_levels))
+	if (WARN_ON_ONCE(i >= tmigr_hierarchy_levels)) {
+		kfree(stack);
 		return -EINVAL;
+	}
 
 	for (; i >= start_lvl; i--) {
 		group = stack[i];