selftests/statmount: Fix file descriptor leak in setup_namespace
PATCH 1/1 selftests/statmount: Fix file descriptor leak in setup_namespace
In setup_namespace(), f_mountinfo is opened with fopen() at line 115 but is never closed. Multiple ksft_exit_fail_msg() calls exit the program without closing this file descriptor, and the cleanup_namespace() function registered with atexit() also doesn't close it.
Add fclose(f_mountinfo) in cleanup_namespace() to ensure the file descriptor is properly closed on both normal and error exit paths, since cleanup_namespace() is already registered as an atexit handler.
--- tools/testing/selftests/filesystems/statmount/statmount_test.c | 3 +++ 1 file changed, 3 insertions(+)
tools/testing/selftests/filesystems/statmount/statmount_test.c +3 -0
@@ -82,6 +82,9 @@ static void cleanup_namespace(void) {int ret; +if (f_mountinfo) +fclose (f_mountinfo); + ret =fchdir (orig_root);if (ret ==-1 )ksft_perror ("fchdir to original root" );
Signature · 1 line
2.54.0
Christian Brauner
AppliedQuoted 1 line · Malaya Kumar Rout
selftests/statmount: Fix file descriptor leak in
setup_namespace
Applied to the vfs-7.3.misc branch of the vfs/vfs.git tree. Patches in the vfs-7.3.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-7.3.misc
[1/1] selftests/statmount: Fix file descriptor leak in setup_namespace
https://git.kernel.org/vfs/vfs/c/38e48ee20792
Quoted 9 lines · On Sat, 4 Jul 2026 17:34:36 +0530 Malaya Kumar Rout <[email protected]>…
In
setup_namespace(),f_mountinfois opened withfopen()at line 115 but is never closed. Multipleksft_exit_fail_msg()calls exit the program without closing this file descriptor, and thecleanup_namespace()function registered withatexit()also doesn't close it.Add
fclose(f_mountinfo)incleanup_namespace()to ensure the file descriptor is properly closed on both normal and error exit paths, sincecleanup_namespace()is already registered as an atexit handler.
Thanks.
get_maintainer totally sucks with selftests/, alas. When determining who should be cc'ed it's best to poke around in git-blame.
I did that. Hi, Miklos!
tools/testing/selftests/filesystems/statmount/statmount_test.c static void cleanup_namespace(void) · line 90
Quoted 12 lines
tools/testing/selftests/filesystems/statmount/statmount_test.c +3
-0@@ -82,6 +82,9 @@ static void cleanup_namespace(void) {int ret; +if (f_mountinfo) +fclose (f_mountinfo); + ret =fchdir (orig_root);if (ret ==-1 )ksft_perror ("fchdir to original root" );
AI review suggests that the patch is good, but the leak is not fully resolved:
https://sashiko.dev/#/patchset/[email protected]
All that being said, we don't care much about leaks in selftests/. Because exit() handles them pretty darn well. So fixing this is mainly a matter of pride and of setting a good example.