Skip to contentSkip to conversation

Add NVL CVS/IPU8 camera support

PATCH In review Arun T 3 participants 8 messages Jul 4 – Jul 8

Subsystems (3)
lore
Share & tools
lore

Arun T

author
#0 lore raw

v2 cover Add NVL CVS/IPU8 camera support

This series adds NVL CVS support to the ACPI dependency handling, the IPU bridge, and the CVS driver. It also adds the IPU8 PCI device ID needed for the CVS driver to bind on NVL camera hardware.

Changes in v2:
- Add a cover letter for the multi-patch series.
- Add Reviewed-by from Sakari Ailus to patch 1.

Arun T (4):
ACPI: scan: Honor ACPI _DEP dependency for NVL CVS
media: pci: ipu-bridge: Add NVL CVS ACPI ID
media: i2c: cvs: Add IPU8 PCI device ID
media: i2c: cvs: Add NVL ACPI ID

 drivers/acpi/scan.c                  | 1 +
 drivers/media/i2c/cvs/core.c         | 3 +++
 drivers/media/pci/intel/ipu-bridge.c | 1 +
 3 files changed, 5 insertions(+)
Signature · 1 line
2.43.0
author
#1 lore raw

PATCH v2 1/4 ACPI: scan: Honor ACPI _DEP dependency for NVL CVS

Add INTC10FA to the ACPI dependency honor list so the CVS driver is loaded before dependent camera devices are probed on NVL platforms.

This matches the camera dependency handling already used for IVSC-based platforms and ensures the camera streaming path is initialized before sensor access or pipeline setup depends on it.

---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/scan.c +1 -0
index 9a7ac2eb9ce0..21937912a1a5 100644
@@ -862,6 +862,7 @@ static const char * const acpi_honor_dep_ids[] = {
 	"INTC10DE", /* CVS (LNL) driver must be loaded to allow camera streaming */
 	"INTC10E0", /* CVS (ARL) driver must be loaded to allow camera streaming */
 	"INTC10E1", /* CVS (PTL) driver must be loaded to allow camera streaming */
+	"INTC10FA", /* CVS (NVL) driver must be loaded to allow camera streaming */
 	"RSCV0001", /* RISC-V PLIC */
 	"RSCV0002", /* RISC-V APLIC */
 	"RSCV0005", /* RISC-V SBI MPXY MBOX */
Signature · 1 line
2.43.0
maintainer Acked-by on v2 1/4
#2 lore raw

Re: [PATCH v2 1/4] ACPI: scan: Honor ACPI _DEP dependency for NVL CVS

Quoted 10 lines · Arun T

Add INTC10FA to the ACPI dependency honor list so the CVS driver is loaded before dependent camera devices are probed on NVL platforms.

This matches the camera dependency handling already used for IVSC-based platforms and ensures the camera streaming path is initialized before sensor access or pipeline setup depends on it.

unless you want me to apply this patch, in which case please let me know. Otherwise, I'll assume it to go in via the media tree.

Thanks!

Quoted 19 lines
---
 drivers/acpi/scan.c | 1 +
 1 file changed, 1 insertion(+)
drivers/acpi/scan.c +1 -1
index 9a7ac2eb9ce0..21937912a1a5 100644
@@ -862,6 +862,7 @@ static const char * const acpi_honor_dep_ids[] = {
        "INTC10DE", /* CVS (LNL) driver must be loaded to allow camera streaming */
        "INTC10E0", /* CVS (ARL) driver must be loaded to allow camera streaming */
        "INTC10E1", /* CVS (PTL) driver must be loaded to allow camera streaming */
+       "INTC10FA", /* CVS (NVL) driver must be loaded to allow camera streaming */
        "RSCV0001", /* RISC-V PLIC */
        "RSCV0002", /* RISC-V APLIC */
        "RSCV0005", /* RISC-V SBI MPXY MBOX */
--

2.43.0

#3 lore raw

Re: [PATCH v2 1/4] ACPI: scan: Honor ACPI _DEP dependency for NVL CVS

Hi Rafael,

Quoted 9 lines · Rafael J. Wysocki (Intel)
Quoted 8 lines · Arun T

Add INTC10FA to the ACPI dependency honor list so the CVS driver is loaded before dependent camera devices are probed on NVL platforms.

This matches the camera dependency handling already used for IVSC-based platforms and ensures the camera streaming path is initialized before sensor access or pipeline setup depends on it.

Quoted 7 lines
Quoted 2 lines

unless you want me to apply this patch, in which case please let me know. Otherwise, I'll assume it to go in via the media tree.

I'll take this via the media tree.

Thanks!

Signature · 3 lines
Kind regards,

Sakari Ailus
author
#4 lore raw

PATCH v2 2/4 media: pci: ipu-bridge: Add NVL CVS ACPI ID

In reply to Arun T

Add INTC10FA to the IPU bridge ACPI match table so the bridge can recognize NVL CVS devices.

This enables the camera bridge path to bind on NVL platforms where the CVS device is exposed through the INTC10FA ACPI ID.

---
 drivers/media/pci/intel/ipu-bridge.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/pci/intel/ipu-bridge.c +1 -0
index 88581a4c081d..23bd29b7a393 100644
@@ -171,6 +171,7 @@ static const struct acpi_device_id ivsc_acpi_ids[] = {
 	{ "INTC10DE" }, /* LNL */
 	{ "INTC10E0" }, /* ARL */
 	{ "INTC10E1" }, /* PTL */
+	{ "INTC10FA" }, /* NVL */
 };
 
 static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device *adev)
Signature · 1 line
2.43.0
author
#5 lore raw

PATCH v2 3/4 media: i2c: cvs: Add IPU8 PCI device ID

In reply to Arun T

Add the NVL IPU8 PCI device ID to the CVS driver match table so the CVS driver can bind to IPU8 camera hardware.

---
 drivers/media/i2c/cvs/core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/media/i2c/cvs/core.c +2 -0
index 4282f33c7295..8270d93f1abe 100644
@@ -32,6 +32,7 @@
 
 #define PCI_DEVICE_ID_INTEL_IPU7		0x645d	/* MTL / LNL */
 #define PCI_DEVICE_ID_INTEL_IPU7P5		0xb05d	/* ARL / PTL */
+#define PCI_DEVICE_ID_INTEL_IPU8		0xd719	/* NVL */
 
 /*
  * IPU7 PCI device IDs not covered by ipu6_pci_tbl in ipu6-pci-table.h.
@@ -40,6 +41,7 @@
 static const struct pci_device_id icvs_ipu7_tbl[] = {
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IPU7) },
 	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IPU7P5) },
+	{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_IPU8) },
 	{ }
 };
 
Signature · 1 line
2.43.0
author
#6 lore raw

PATCH v2 4/4 media: i2c: cvs: Add NVL ACPI ID

In reply to Arun T

Add INTC10FA to the CVS ACPI match table so the driver can bind to CVS devices exposed on NVL platforms.

---
 drivers/media/i2c/cvs/core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/media/i2c/cvs/core.c +1 -0
index 8270d93f1abe..7486815b16bd 100644
@@ -965,6 +965,7 @@ static const struct acpi_device_id intel_cvs_acpi_match[] = {
 	{ "INTC10DE" }, /* LNL */
 	{ "INTC10E0" }, /* ARL */
 	{ "INTC10E1" }, /* PTL */
+	{ "INTC10FA" }, /* NVL */
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, intel_cvs_acpi_match);
Signature · 1 line
2.43.0
#7 lore raw
In reply to Arun T

Hi Arun,

Quoted 7 lines · Arun T

This series adds NVL CVS support to the ACPI dependency handling, the IPU bridge, and the CVS driver. It also adds the IPU8 PCI device ID needed for the CVS driver to bind on NVL camera hardware.

Changes in v2:
- Add a cover letter for the multi-patch series.
- Add Reviewed-by from Sakari Ailus to patch 1.

There's no need to send further versions of these patches; patches 2--4 are already in my tree.

Signature · 3 lines
Regards,

Sakari Ailus