Skip to contentSkip to conversation

usb: typec: class: drop PD lookup reference

PATCH In review Shuangpeng Bai 2 participants 2 messages Jul 4 – Jul 13

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 usb: typec: class: drop PD lookup reference

usb_power_delivery_find() wraps class_find_device_by_name(). That helper returns a device reference that must be released by the caller.

select_usb_power_delivery_store() only needs this reference while calling the pd_set callback. Drop it once the callback returns. Otherwise the sysfs write can pin the selected USB Power Delivery object and prevent it from being released on unregister.

Fixes a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")

---
v2:
- Cc [email protected] as requested.

 drivers/usb/typec/class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/class.c +1 -0
index 0977581ad1b6..0595e8cb83aa 100644
@@ -1619,6 +1619,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 		return -EINVAL;
 
 	ret = port->ops->pd_set(port, pd);
+	put_device(&pd->dev);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 11 lines · Shuangpeng Bai

usb_power_delivery_find() wraps class_find_device_by_name(). That helper returns a device reference that must be released by the caller.

select_usb_power_delivery_store() only needs this reference while calling the pd_set callback. Drop it once the callback returns. Otherwise the sysfs write can pin the selected USB Power Delivery object and prevent it from being released on unregister.

Fixes a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Quoted 21 lines

---
v2:
- Cc [email protected] as requested.

 drivers/usb/typec/class.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/typec/class.c +1 -0
index 0977581ad1b6..0595e8cb83aa 100644
@@ -1619,6 +1619,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 		return -EINVAL;
 
 	ret = port->ops->pd_set(port, pd);
+	put_device(&pd->dev);
 	if (ret)
 		return ret;
 
Signature · 1 line
2.43.0
Signature · 1 line
heikki