selftests/alsa: Fix format specifier and function mismatch in mixer-test
Subsystems (3)
PATCH 1/1 selftests/alsa: Fix format specifier and function mismatch in mixer-test
In the ctl_value_index_valid() function, when validating 64-bit integer controls (SND_CTL_ELEM_TYPE_INTEGER64), the error message for maximum value validation has two bugs:
1. Uses snd_ctl_elem_info_get_max() instead of the 64-bit variant snd_ctl_elem_info_get_max64()
2. Uses %ld format specifier instead of %lld for long long type
This is inconsistent with the minimum value validation (line 335-339) which correctly uses get_min64() and %lld. The mismatch can cause:
- Incorrect maximum values being reported on some architectures
- Undefined behavior due to format specifier mismatch
- Potential crashes when printing the error message
Fix by using snd_ctl_elem_info_get_max64() and %lld format specifier to match the data type and be consistent with the minimum value check.
--- tools/testing/selftests/alsa/mixer-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/alsa/mixer-test.c +2 -2
@@ -339,9 +339,9 @@ static bool ctl_value_index_valid(struct ctl_data *ctl, }if (int64_val >snd_ctl_elem_info_get_max64 (ctl->info)) { -ksft_print_msg ("%s.%d value %lld more than maximum %ld\n" , +ksft_print_msg ("%s.%d value %lld more than maximum %lld\n" , ctl->name, index, int64_val, -snd_ctl_elem_info_get_max (ctl->info)); +snd_ctl_elem_info_get_max64 (ctl->info));return false; }
Signature · 1 line
2.54.0
Takashi Iwai
AppliedQuoted 15 lines · Malaya Kumar Rout
In the
ctl_value_index_valid()function, when validating 64-bit integer controls (SND_CTL_ELEM_TYPE_INTEGER64), the error message for maximum value validation has two bugs:1. Uses
snd_ctl_elem_info_get_max()instead of the 64-bit variantsnd_ctl_elem_info_get_max64()
2. Uses %ld format specifier instead of %lld for long long typeThis is inconsistent with the minimum value validation (line 335-339) which correctly uses
get_min64()and %lld. The mismatch can cause:
- Incorrect maximum values being reported on some architectures
- Undefined behavior due to format specifier mismatch
- Potential crashes when printing the error message
Quoted 4 lines
Fix by using
snd_ctl_elem_info_get_max64()and %lld format specifier to match the data type and be consistent with the minimum value check.Signed-off-by Malaya Kumar Rout <[email protected]>
Thanks, applied now.
Takashi