imx93_frdm: Add OP-TEE device tree node
Subsystems (2)
PATCH 1/1 imx93_frdm: Add OP-TEE device tree node
Add missing firmware/optee node, so is can be both used and copied into Linux device tree by optee_copy_firmware_node(). This is consistent with other i.MX93 boards.
--- arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi +7 -0
@@ -12,6 +12,13 @@ bootph-pre-ram; bootph-some-ram; }; + + firmware { + optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; }; &A55_0 {
---
base-commit: 780084d7c07f511da4a39b43277c573156ed42e0
change-id: 20260706-master-c71a02f504f0
Best regards,
Signature · 1 line
Mathieu Dubois-Briand <[email protected]>
Quoted 4 lines · Mathieu Dubois-Briand
Add missing
firmware/opteenode, so is can be both used and copied into Linux device tree byoptee_copy_firmware_node(). This is consistent with other i.MX93 boards.
Shouldn't this be going to the upstream Linux DT at which point get it when we resync?
Quoted 32 lines
Signed-off-by Mathieu Dubois-Briand <[email protected]>--- arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi +7
-1@@ -12,6 +12,13 @@ bootph-pre-ram; bootph-some-ram; }; + + firmware { + optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; }; &A55_0 { ---base-commit:
780084d7c07f511da4a39b43277c573156ed42e0
change-id: 20260706-master-c71a02f504f0Best regards,
--
Mathieu Dubois-Briand <[email protected]>
Hi,
Quoted 9 lines · Peter Robinson
Quoted 4 lines · Mathieu Dubois-Briand
Add missing
firmware/opteenode, so is can be both used and copied into Linux device tree byoptee_copy_firmware_node(). This is consistent with other i.MX93 boards.Shouldn't this be going to the upstream Linux DT at which point get it when we resync?
I don't think it should. Or maybe it should, but then we are doing wrong things for other boards, particularly for the i.MX family.
We have this node in the -u-boot.dtsi file for various other boards:
git grep "linaro,optee-tz" -- '*-u-boot.dtsi'
arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz";
arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz";
Thanks,
Mathieu
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 21 lines · Mathieu Dubois-Briand
Hi,
Quoted 9 lines · Peter Robinson
Quoted 4 lines · Mathieu Dubois-Briand
Add missing
firmware/opteenode, so is can be both used and copied into Linux device tree byoptee_copy_firmware_node(). This is consistent with other i.MX93 boards.Shouldn't this be going to the upstream Linux DT at which point get it when we resync?
I don't think it should. Or maybe it should, but then we are doing wrong things for other boards, particularly for the i.MX family.
We have this node in the
-u-boot.dtsifile for various other boards:git grep "linaro,optee-tz" -- '*-u-boot.dtsi'
arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz";
Quoted 13 lines
arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz";
Since I assume this would still pass validation in the Linux kernel, yes, it looks like a lot of platforms are doing it wrong here and should be pushing this upstream. Thanks.
Signature · 1 line
Tom
Quoted 36 lines · Tom Rini
Quoted 21 lines · Mathieu Dubois-Briand
Hi,
Quoted 9 lines · Peter Robinson
Quoted 4 lines · Mathieu Dubois-Briand
Add missing
firmware/opteenode, so is can be both used and copied into Linux device tree byoptee_copy_firmware_node(). This is consistent with other i.MX93 boards.Shouldn't this be going to the upstream Linux DT at which point get it when we resync?
I don't think it should. Or maybe it should, but then we are doing wrong things for other boards, particularly for the i.MX family.
We have this node in the
-u-boot.dtsifile for various other boards:git grep "linaro,optee-tz" -- '*-u-boot.dtsi'
arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz";Quoted 13 lines
arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz";
Quoted 3 lines
Since I assume this would still pass validation in the Linux kernel, yes, it looks like a lot of platforms are doing it wrong here and should be pushing this upstream. Thanks.
Ok, so I suspect I should instead submit a similar patch against the Kernel.
Should I try to add something similar for other i.MX boards and stm32 boards at the same time? So they could later be removed from u-boot.
Signature · 3 lines
Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Quoted 41 lines · Mathieu Dubois-Briand
Quoted 36 lines · Tom Rini
Quoted 21 lines · Mathieu Dubois-Briand
Hi,
Quoted 9 lines · Peter Robinson
Quoted 4 lines · Mathieu Dubois-Briand
Add missing
firmware/opteenode, so is can be both used and copied into Linux device tree byoptee_copy_firmware_node(). This is consistent with other i.MX93 boards.Shouldn't this be going to the upstream Linux DT at which point get it when we resync?
I don't think it should. Or maybe it should, but then we are doing wrong things for other boards, particularly for the i.MX family.
We have this node in the
-u-boot.dtsifile for various other boards:git grep "linaro,optee-tz" -- '*-u-boot.dtsi'
arch/arm/dts/imx8mm-u-boot.dtsi: compatible = "linaro,optee-tz"; arch/arm/dts/imx8mn-u-boot.dtsi: compatible = "linaro,optee-tz";Quoted 13 lines
arch/arm/dts/imx8mp-debix-model-a-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-navqp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx8mp-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx91-93-phyboard-segin-common-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-evk-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-11x11-frdm-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-9x9-qsb-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-kontron-bl-osm-s-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/imx93-var-som-symphony-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi: compatible = "linaro,optee-tz";arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi: compatible = "linaro,optee-tz";Quoted 3 lines
Since I assume this would still pass validation in the Linux kernel, yes, it looks like a lot of platforms are doing it wrong here and should be pushing this upstream. Thanks.
Quoted 5 lines
Ok, so I suspect I should instead submit a similar patch against the Kernel.
Should I try to add something similar for other i.MX boards and stm32 boards at the same time? So they could later be removed from u-boot.
That would be much appreciated, thanks again!
Signature · 1 line
Tom