Use drm_exec to lock TTM buffers, respin
Subsystems (6)
Natalie Vock
maintainerv2 cover Use drm_exec to lock TTM buffers, respin
Hi all,
this is a respin of Christian's patchset to make TTM use drm_exec for evicting buffers.
I've been investigating VRAM management for amdgpu quite a bit in recent times, and under really strong VRAM contention I observed frequent instabilities/random crashes that I traced back to TTM being unable to evict buffers properly. The typical failure case was one game squatting more or less all of VRAM while also being rather spammy with submits. In that case, trylocking fails because concurrent submits from the game already hold buffer locks, and since there isn't much else to evict, allocation just fails.
The original patchset ended up fizzling out in previous attempts to upstream it, but I think it's worth retrying to upstream this, so I took over and rebased it on top of current drm-misc-next. Aside from that, while testing the patchset I found two bugs causing rather random issues ranging from kernel crashes to random GPU hangs in it, which I fixed for this respin. The two bugs were:
1. The ttm_buffer_object duplication in ttm_buffer_object_transfer did not alter the GEM object's driver function pointers, so the transferred object erroneously inherited the free() function of the source buffer. When the transferred object was freed, the driver's free function was invoked and treated the transferred TTM bo as if it was a driver BO. Hilarity ensued.
2. drm_exec LRU walks were missing handling for already-locked objects. If the incoming exec object was created without DRM_EXEC_IGNORE_DUPLICATES, drm_exec_lock_obj would return -EALREADY and the buffer would be skipped even if ctx->allow_res_evict was set (funkiness level: moderate).
If the exec did have DRM_EXEC_IGNORE_DUPLICATES
set, the buffer would be processed, and then unlocked, silently dropping the lock of some random object that the caller expected to stay locked (funkiness level: off the charts).
With those two bugs fixed, VRAM overcommit works considerably more stable - there are no random eviction failures and related fallouts at all anymore.
---
Changes in v2:
- Switched to my new email
- Reworked drm_exec patch for always reporting duplicates (Christian)
- Removed spurious continue; rebase artifact in swapout
- Removed incorrect trylock_only for evict_all
- Link to v1: https://patch.msgid.link/[email protected]
---
Natalie Vock (10):
drm/exec: Add helper to bypass IGNORE_DUPLICATES flag drm/ttm: replace TTMs refcount with the DRM refcount v4 drm/ttm: remove ttm_lru_walk_ops
drm/ttm: grab BO reference before locking it
drm/ttm: switch to ttm_bo_lru_for_each_reserved_guarded for swapout drm/ttm: move zombie handling into ttm_bo_evict drm/ttm: use ttm_bo_lru_for_each_reserved_guarded in evict_all drm/xe: remove workaround for TTM internals
drm/ttm: support using drm_exec during eviction v4 drm/amdgpu: use drm_exec during BO validation
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 80 +++---- drivers/gpu/drm/drm_exec.c | 54 +++-- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 35 ++- drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 8 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 2 - drivers/gpu/drm/ttm/ttm_bo.c | 272 +++++++---------------- drivers/gpu/drm/ttm/ttm_bo_internal.h | 17 +- drivers/gpu/drm/ttm/ttm_bo_util.c | 58 +++-- drivers/gpu/drm/ttm/ttm_device.c | 18 +- drivers/gpu/drm/ttm/ttm_resource.c | 21 +- drivers/gpu/drm/xe/xe_bo.c | 32 +-- include/drm/drm_exec.h | 2 + include/drm/ttm/ttm_bo.h | 50 ++--- 13 files changed, 295 insertions(+), 354 deletions(-)
---
base-commit: 44d19b8a7548aa25cbc6ebd5f27e958f7142c36b
change-id: 20260703-ttm_2_drm_exec-2dbdb1fb9d43
Best regards,
Signature · 1 line
Natalie Vock <[email protected]>
Natalie Vock
maintainerPATCH v2 1/10 drm/exec: Add helper to bypass IGNORE_DUPLICATES flag
TTM is about to switch to drm_exec for locking objects
in the LRU list. When we're done processing the object, we want to unlock it only if the caller doesn't already hold that lock. If DRM_EXEC_IGNORE_DUPLICATES is set on the exec object (which callers may require for unrelated reasons), we have no way of knowing whether the lock is already held.
To remedy this, add a separate helper that forcefully bypasses the IGNORE_DUPLICATES flag for only a single locking operation.
--- drivers/gpu/drm/drm_exec.c | 54 ++++++++++++++++++++++++++++++++++------------ include/drm/drm_exec.h | 2 ++ 2 files changed, 42 insertions(+), 14 deletions(-)
drivers/gpu/drm/drm_exec.c +40 -14
@@ -190,18 +190,9 @@ static int drm_exec_lock_contended(struct drm_exec *exec)return ret; } -/** -* drm_exec_lock_obj - lock a GEM object for use -* @exec: the drm_exec object with the state -* @obj: the GEM object to lock -* -* Lock a GEM object for use and grab a reference to it. -* -* Returns: -EDEADLK if a contention is detected, -EALREADY when object is -* already locked (can be suppressed by setting the DRM_EXEC_IGNORE_DUPLICATES -* flag), -ENOMEM when memory allocation failed and zero for success. -*/ -int drm_exec_lock_obj (struct drm_exec *exec,struct drm_gem_object *obj) +static int __drm_exec_lock_obj (struct drm_exec *exec, +struct drm_gem_object *obj, +bool ignore_duplicates) {int ret;
@@ -226,8 +217,7 @@ int drm_exec_lock_obj(struct drm_exec *exec, struct drm_gem_object *obj)return -EDEADLK ; } -if (unlikely (ret == -EALREADY ) && - exec->flags &DRM_EXEC_IGNORE_DUPLICATES ) +if (unlikely (ret == -EALREADY ) && ignore_duplicates)return 0 ;if (unlikely (ret))
@@ -243,8 +233,44 @@ int drm_exec_lock_obj(struct drm_exec *exec, struct drm_gem_object *obj)dma_resv_unlock (obj->resv);return ret; } + +/** +* drm_exec_lock_obj - lock a GEM object for use +* @exec: the drm_exec object with the state +* @obj: the GEM object to lock +* +* Lock a GEM object for use and grab a reference to it. +* +* Returns: -EDEADLK if a contention is detected, -EALREADY when object is +* already locked (can be suppressed by setting the DRM_EXEC_IGNORE_DUPLICATES +* flag), -ENOMEM when memory allocation failed and zero for success. +*/ +int drm_exec_lock_obj (struct drm_exec *exec,struct drm_gem_object *obj) +{ +return __drm_exec_lock_obj (exec, obj, + exec->flags &DRM_EXEC_IGNORE_DUPLICATES ); +}EXPORT_SYMBOL (drm_exec_lock_obj); +/** +* drm_exec_lock_obj_report_dup - lock a GEM object for use, but always report duplicates +* @exec: the drm_exec object with the state +* @obj: the GEM object to lock +* +* Like drm_exec_lock_obj, lock a GEM object for use and grab a reference to it. +* Unlike drm_exec_lock_obj, DRM_EXEC_IGNORE_DUPLICATES is ignored and duplicates are +* always reported. +* +* Returns: -EDEADLK if a contention is detected, -EALREADY when object is +* already locked, -ENOMEM when memory allocation failed and zero for success. +*/ +int drm_exec_lock_obj_report_dup (struct drm_exec *exec, +struct drm_gem_object *obj) +{ +return __drm_exec_lock_obj (exec, obj, false); +} +EXPORT_SYMBOL (drm_exec_lock_obj_report_dup); +/** * drm_exec_unlock_obj - unlock a GEM object in this exec context * @exec: the drm_exec object with the state
include/drm/drm_exec.h +2 -0
@@ -176,6 +176,8 @@ void drm_exec_init(struct drm_exec *exec, u32 flags, unsigned nr);void drm_exec_fini (struct drm_exec *exec);bool drm_exec_cleanup (struct drm_exec *exec);int drm_exec_lock_obj (struct drm_exec *exec,struct drm_gem_object *obj); +int drm_exec_lock_obj_report_dup (struct drm_exec *exec, +struct drm_gem_object *obj);void drm_exec_unlock_obj (struct drm_exec *exec,struct drm_gem_object *obj);int drm_exec_prepare_obj (struct drm_exec *exec,struct drm_gem_object *obj,unsigned int num_fences);
Signature · 1 line
2.55.0
Re: [PATCH v2 01/10] drm/exec: Add helper to bypass IGNORE_DUPLICATES flag
Quoted 11 lines · Natalie Vock
TTM is about to switch to
drm_execfor locking objects
in the LRU list. When we're done processing the object, we want to unlock it only if the caller doesn't already hold that lock. IfDRM_EXEC_IGNORE_DUPLICATESis set on the exec object (which callers may require for unrelated reasons), we have no way of knowing whether the lock is already held.To remedy this, add a separate helper that forcefully bypasses the
IGNORE_DUPLICATESflag for only a single locking operation.Signed-off-by Natalie Vock <[email protected]>
Quoted 100 lines
--- drivers/gpu/drm/drm_exec.c | 54 ++++++++++++++++++++++++++++++++++------------ include/drm/drm_exec.h | 2 ++ 2 files changed, 42 insertions(+), 14 deletions(-)drivers/gpu/drm/drm_exec.c +40
-14@@ -190,18 +190,9 @@ static int drm_exec_lock_contended(struct drm_exec *exec)return ret; } -/** -* drm_exec_lock_obj - lock a GEM object for use -* @exec: the drm_exec object with the state -* @obj: the GEM object to lock -* -* Lock a GEM object for use and grab a reference to it. -* -* Returns: -EDEADLK if a contention is detected, -EALREADY when object is -* already locked (can be suppressed by setting the DRM_EXEC_IGNORE_DUPLICATES -* flag), -ENOMEM when memory allocation failed and zero for success. -*/ -int drm_exec_lock_obj (struct drm_exec *exec,struct drm_gem_object *obj) +static int __drm_exec_lock_obj (struct drm_exec *exec, +struct drm_gem_object *obj, +bool ignore_duplicates) {int ret;@@ -226,8 +217,7 @@ int drm_exec_lock_obj(struct drm_exec *exec, struct drm_gem_object *obj)return -EDEADLK ; } -if (unlikely (ret == -EALREADY ) && - exec->flags &DRM_EXEC_IGNORE_DUPLICATES ) +if (unlikely (ret == -EALREADY ) && ignore_duplicates)return 0 ;if (unlikely (ret))@@ -243,8 +233,44 @@ int drm_exec_lock_obj(struct drm_exec *exec, struct drm_gem_object *obj)dma_resv_unlock (obj->resv);return ret; } + +/** +* drm_exec_lock_obj - lock a GEM object for use +* @exec: the drm_exec object with the state +* @obj: the GEM object to lock +* +* Lock a GEM object for use and grab a reference to it. +* +* Returns: -EDEADLK if a contention is detected, -EALREADY when object is +* already locked (can be suppressed by setting the DRM_EXEC_IGNORE_DUPLICATES +* flag), -ENOMEM when memory allocation failed and zero for success. +*/ +int drm_exec_lock_obj (struct drm_exec *exec,struct drm_gem_object *obj) +{ +return __drm_exec_lock_obj (exec, obj, + exec->flags &DRM_EXEC_IGNORE_DUPLICATES ); +}EXPORT_SYMBOL (drm_exec_lock_obj); +/** +* drm_exec_lock_obj_report_dup - lock a GEM object for use, but always report duplicates +* @exec: the drm_exec object with the state +* @obj: the GEM object to lock +* +* Like drm_exec_lock_obj, lock a GEM object for use and grab a reference to it. +* Unlike drm_exec_lock_obj, DRM_EXEC_IGNORE_DUPLICATES is ignored and duplicates are +* always reported. +* +* Returns: -EDEADLK if a contention is detected, -EALREADY when object is +* already locked, -ENOMEM when memory allocation failed and zero for success. +*/ +int drm_exec_lock_obj_report_dup (struct drm_exec *exec, +struct drm_gem_object *obj) +{ +return __drm_exec_lock_obj (exec, obj, false); +} +EXPORT_SYMBOL (drm_exec_lock_obj_report_dup); +/** * drm_exec_unlock_obj - unlock a GEM object in this exec context * @exec: the drm_exec object with the state include/drm/drm_exec.h +2
-0@@ -176,6 +176,8 @@ void drm_exec_init(struct drm_exec *exec, u32 flags, unsigned nr);void drm_exec_fini (struct drm_exec *exec);bool drm_exec_cleanup (struct drm_exec *exec);int drm_exec_lock_obj (struct drm_exec *exec,struct drm_gem_object *obj); +int drm_exec_lock_obj_report_dup (struct drm_exec *exec, +struct drm_gem_object *obj);void drm_exec_unlock_obj (struct drm_exec *exec,struct drm_gem_object *obj);int drm_exec_prepare_obj (struct drm_exec *exec,struct drm_gem_object *obj,unsigned int num_fences);
Natalie Vock
maintainerPATCH v2 2/10 drm/ttm: replace TTMs refcount with the DRM refcount v4
In reply to Natalie VockInstead of keeping a separate reference count for the TTM object also use the reference count for DRM GEM objects inside TTM.
Apart from avoiding two reference counts for one object this approach has the clear advantage of being able to use drm_exec inside TTM.
v2: adjust XE assert as well and re-enable disabled test
v3: handle another case in i915
v4: set GEM driver funcs of transfer BOs to point to the TTM free callback (Natalie)
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 35 +++--- drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 8 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 2 - drivers/gpu/drm/ttm/ttm_bo.c | 135 +++++++++++------------ drivers/gpu/drm/ttm/ttm_bo_internal.h | 17 ++- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- drivers/gpu/drm/xe/xe_bo.c | 2 +- include/drm/ttm/ttm_bo.h | 9 -- 8 files changed, 111 insertions(+), 112 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +13 -22
@@ -939,7 +939,7 @@ void i915_ttm_adjust_lru(struct drm_i915_gem_object *obj)* Don't manipulate the TTM LRUs while in TTM bo destruction. * We're called through i915_ttm_delete_mem_notify(). */ -if (!kref_read (&bo->kref)) +if (!kref_read (&bo->base.refcount))return ;/*
@@ -957,30 +957,21 @@ void i915_ttm_adjust_lru(struct drm_i915_gem_object *obj)* * TODO: consider maybe also bumping the shrinker list here when we have * already unpinned it, which should give us something more like an LRU. -* -* TODO: There is a small window of opportunity for this function to -* get called from eviction after we've dropped the last GEM refcount, -* but before the TTM deleted flag is set on the object. Avoid -* adjusting the shrinker list in such cases, since the object is -* not available to the shrinker anyway due to its zero refcount. -* To fix this properly we should move to a TTM shrinker LRU list for -* these objects. */ -if (kref_get_unless_zero (&obj->base.refcount)) { -if (shrinkable != obj->mm.ttm_shrinkable) { -if (shrinkable) { -if (obj->mm.madv ==I915_MADV_WILLNEED ) -__i915_gem_object_make_shrinkable (obj); -else -__i915_gem_object_make_purgeable (obj); - }else { -i915_gem_object_make_unshrinkable (obj); - } - - obj->mm.ttm_shrinkable = shrinkable; +i915_gem_object_get (obj); +if (shrinkable != obj->mm.ttm_shrinkable) { +if (shrinkable) { +if (obj->mm.madv ==I915_MADV_WILLNEED ) +__i915_gem_object_make_shrinkable (obj); +else +__i915_gem_object_make_purgeable (obj); + }else { +i915_gem_object_make_unshrinkable (obj); } -i915_gem_object_put (obj); + + obj->mm.ttm_shrinkable = shrinkable; } +i915_gem_object_put (obj);/* * Put on the correct LRU list depending on the MADV status
drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c +5 -3
@@ -127,7 +127,7 @@ static void ttm_bo_init_reserved_sys_man(struct kunit *test)dma_resv_unlock (bo->base.resv);KUNIT_EXPECT_EQ (test, err,0 ); -KUNIT_EXPECT_EQ (test,kref_read (&bo->kref),1 ); +KUNIT_EXPECT_EQ (test,kref_read (&bo->base.refcount),1 );KUNIT_EXPECT_PTR_EQ (test, bo->bdev, priv->ttm_dev);KUNIT_EXPECT_EQ (test, bo->type, bo_type);KUNIT_EXPECT_EQ (test, bo->page_alignment,PAGE_SIZE );
@@ -176,7 +176,7 @@ static void ttm_bo_init_reserved_mock_man(struct kunit *test)dma_resv_unlock (bo->base.resv);KUNIT_EXPECT_EQ (test, err,0 ); -KUNIT_EXPECT_EQ (test,kref_read (&bo->kref),1 ); +KUNIT_EXPECT_EQ (test,kref_read (&bo->base.refcount),1 );KUNIT_EXPECT_PTR_EQ (test, bo->bdev, priv->ttm_dev);KUNIT_EXPECT_EQ (test, bo->type, bo_type);KUNIT_EXPECT_EQ (test, ctx.bytes_moved, size);
@@ -969,6 +969,8 @@ static void ttm_bo_validate_allowed_only_evict(struct kunit *test)ttm_mock_manager_fini (priv->ttm_dev, mem_multihop); } +extern const struct drm_gem_object_funcs ttm_deleted_object_funcs; +static void ttm_bo_validate_deleted_evict (struct kunit *test) {struct ttm_operation_ctx ctx_init = { }, ctx_val = { };
@@ -999,7 +1001,7 @@ static void ttm_bo_validate_deleted_evict(struct kunit *test)KUNIT_EXPECT_EQ (test,ttm_resource_manager_usage (man), big);dma_resv_unlock (bo_big->base.resv); - bo_big->deleted = true; + bo_big->base.funcs = &ttm_deleted_object_funcs; bo_small =ttm_bo_kunit_init (test, test->priv, small,NULL ); bo_small->type = bo_type;
drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +0 -2
@@ -189,8 +189,6 @@ struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, bo->bdev = devs->ttm_dev; bo->destroy = dummy_ttm_bo_destroy; -kref_init (&bo->kref); -return bo; }EXPORT_SYMBOL_GPL (ttm_bo_kunit_init);
drivers/gpu/drm/ttm/ttm_bo.c +64 -71
195 lines not on this page · raw message
drivers/gpu/drm/ttm/ttm_bo_internal.h +14 -3
@@ -27,6 +27,14 @@#include <drm/ttm/ttm_bo.h> +static inline void ttm_bo_free (struct drm_gem_object *gobj) +{ +struct ttm_buffer_object *bo =container_of (gobj,typeof (*bo), base); + +atomic_dec (&ttm_glob.bo_count); + bo->destroy (bo); +} +/** * ttm_bo_get - reference a struct ttm_buffer_object *
@@ -34,7 +42,7 @@*/ static inline void ttm_bo_get (struct ttm_buffer_object *bo) { -kref_get (&bo->kref); +drm_gem_object_get (&bo->base); }/**
@@ -50,11 +58,14 @@ static inline void ttm_bo_get(struct ttm_buffer_object *bo)static inline __must_check struct ttm_buffer_object *ttm_bo_get_unless_zero (struct ttm_buffer_object *bo) { -if (!kref_get_unless_zero (&bo->kref)) +if (!kref_get_unless_zero (&bo->base.refcount))return NULL ;return bo; } -void ttm_bo_put (struct ttm_buffer_object *bo); +static inline void ttm_bo_put (struct ttm_buffer_object *bo) +{ +drm_gem_object_put (&bo->base); +}#endif
drivers/gpu/drm/ttm/ttm_bo_util.c +14 -1
@@ -41,6 +41,18 @@#include "ttm_bo_internal.h" +static void ttm_transfer_object_free (struct drm_gem_object *obj) +{ +struct ttm_buffer_object *bo = + container_of(obj, struct ttm_buffer_object, base); + +ttm_bo_fini (bo); +} + +const struct drm_gem_object_funcs ttm_transfer_object_funcs = { + .free = ttm_transfer_object_free, +}; +struct ttm_transfer_obj {struct ttm_buffer_object base;struct ttm_buffer_object *bo;
@@ -247,7 +259,8 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo,atomic_inc (&ttm_glob.bo_count);drm_vma_node_reset (&fbo->base.base.vma_node); -kref_init (&fbo->base.kref); +kref_init (&fbo->base.base.refcount); + fbo->base.base.funcs = &ttm_transfer_object_funcs; fbo->base.destroy = &ttm_transfered_destroy; fbo->base.pin_count =0 ;if (bo->type != ttm_bo_type_sg)
drivers/gpu/drm/xe/xe_bo.c +1 -1
@@ -1651,7 +1651,7 @@ static bool xe_ttm_bo_lock_in_destructor(struct ttm_buffer_object *ttm_bo)struct xe_device *xe =ttm_to_xe_device (ttm_bo->bdev);bool locked; -xe_assert (xe, !kref_read (&ttm_bo->kref)); +xe_assert (xe, !kref_read (&ttm_bo->base.refcount));/* * We can typically only race with TTM trylocking under the
include/drm/ttm/ttm_bo.h +0 -9
@@ -78,11 +78,8 @@ enum ttm_bo_type {* @type: The bo type. * @page_alignment: Page alignment. * @destroy: Destruction function. If NULL, kfree is used. -* @kref: Reference count of this buffer object. When this refcount reaches -* zero, the object is destroyed or put on the delayed delete list. * @resource: structure describing current placement. * @ttm: TTM structure holding system pages. -* @deleted: True if the object is only a zombie and already deleted. * @bulk_move: The bulk move object. * @priority: Priority for LRU, BOs with lower priority are evicted first. * @pin_count: Pin count.
@@ -109,17 +106,11 @@ struct ttm_buffer_object {uint32_t page_alignment;void (*destroy) (struct ttm_buffer_object *); -/* -* Members not needing protection. -*/ -struct kref kref; -/* * Members protected by the bo::resv::reserved lock. */ struct ttm_resource *resource;struct ttm_tt *ttm; -bool deleted;struct ttm_lru_bulk_move *bulk_move;unsigned priority;unsigned pin_count;
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH v2 02/10] drm/ttm: replace TTMs refcount with the DRM refcount v4
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Resurrecting TTM BOs with the unified GEM refcount exposes partially-destroyed zombie objects to…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Resurrecting TTM BOs with the unified GEM refcount exposes partially-destroyed zombie objects to xe_drm_client debugfs, leading to a NULL pointer dereference. --
commit a805e1b4ddde0006d8b373c7aed2f75ce95ec7db
Author: Natalie Vock <[email protected]>
drm/ttm: replace TTMs refcount with the DRM refcount v4
This commit replaces the separate TTM object reference count with the DRM GEM object reference count. This allows the use of drm_exec inside TTM and avoids maintaining two reference counts for one object.
Quoted 4 lines
drivers/gpu/drm/ttm/ttm_bo.c +0
-0
[ ... ]
Quoted 1 line
drivers/gpu/drm/ttm/ttm_bo.c +0
-0@@ -246,88 +246,84 @@ static void ttm_bo_delayed_delete(struct work_struct *work)
[ ... ]
drivers/gpu/drm/ttm/ttm_bo.c static void ttm_bo_delayed_delete(struct work_struct *work) · line 310
Quoted 5 lines
drivers/gpu/drm/ttm/ttm_bo.c +3
-2-kref_init (&bo->kref); -spin_unlock (&bdev->lru_lock); +kref_init (&bo->base.refcount); + bo->base.funcs = &ttm_deleted_object_funcs; +spin_unlock (&bo->bdev->lru_lock);
[Severity: High]
By resurrecting the GEM refcount here to 1, could this expose partially-destroyed zombie objects to subsystems like the xe_drm_client?
For example, the client list might still hold the BO, and xe_drm_client.c:show_meminfo() attempts to grab a reference:
if (!kref_get_unless_zero(&bo->ttm.base.refcount))
continue;Since the GEM refcount is now resurrected instead of a separate TTM refcount, this check will succeed on a zombie BO.
If show_meminfo() then acquires the BO's resv lock after the ttm_bo_delayed_delete() worker has called ttm_bo_cleanup_memtype_use() (which sets bo->resource to NULL), it will dereference the NULL resource in bo_meminfo():
u32 mem_type = bo->ttm.resource->mem_type;
Can this lead to a NULL pointer dereference kernel panic when reading the debugfs file?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Re: [PATCH v2 02/10] drm/ttm: replace TTMs refcount with the DRM refcount v4
In reply to Natalie VockQuoted 6 lines · Natalie Vock
Instead of keeping a separate reference count for the TTM object also use the reference count for DRM GEM objects inside TTM.
Apart from avoiding two reference counts for one object this approach has the clear advantage of being able to use
drm_execinside TTM.
Quoted 6 lines
v2: adjust XE assert as well and re-enable disabled test
v3: handle another case in i915
v4: set GEM driver funcs of transfer BOs to point to the TTM free callback (Natalie)Signed-off-by Christian König <[email protected]>
Since you also made changes to the code you should probably add Co-developed-by: Natalie Vock <[email protected]>. Apart from that good catch with the transfer BOs.
Can somebody else review this now?
Regards,
Christian.
Quoted 453 lines
Signed-off-by Natalie Vock <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 35 +++--- drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c | 8 +- drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 2 - drivers/gpu/drm/ttm/ttm_bo.c | 135 +++++++++++------------ drivers/gpu/drm/ttm/ttm_bo_internal.h | 17 ++- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 ++- drivers/gpu/drm/xe/xe_bo.c | 2 +- include/drm/ttm/ttm_bo.h | 9 -- 8 files changed, 111 insertions(+), 112 deletions(-)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +13
-22@@ -939,7 +939,7 @@ void i915_ttm_adjust_lru(struct drm_i915_gem_object *obj)* Don't manipulate the TTM LRUs while in TTM bo destruction. * We're called through i915_ttm_delete_mem_notify(). */ -if (!kref_read (&bo->kref)) +if (!kref_read (&bo->base.refcount))return ;/* @@ -957,30 +957,21 @@ void i915_ttm_adjust_lru(struct drm_i915_gem_object *obj)* * TODO: consider maybe also bumping the shrinker list here when we have * already unpinned it, which should give us something more like an LRU. -* -* TODO: There is a small window of opportunity for this function to -* get called from eviction after we've dropped the last GEM refcount, -* but before the TTM deleted flag is set on the object. Avoid -* adjusting the shrinker list in such cases, since the object is -* not available to the shrinker anyway due to its zero refcount. -* To fix this properly we should move to a TTM shrinker LRU list for -* these objects. */ -if (kref_get_unless_zero (&obj->base.refcount)) { -if (shrinkable != obj->mm.ttm_shrinkable) { -if (shrinkable) { -if (obj->mm.madv ==I915_MADV_WILLNEED ) -__i915_gem_object_make_shrinkable (obj); -else -__i915_gem_object_make_purgeable (obj); - }else { -i915_gem_object_make_unshrinkable (obj); - } - - obj->mm.ttm_shrinkable = shrinkable; +i915_gem_object_get (obj); +if (shrinkable != obj->mm.ttm_shrinkable) { +if (shrinkable) { +if (obj->mm.madv ==I915_MADV_WILLNEED ) +__i915_gem_object_make_shrinkable (obj); +else +__i915_gem_object_make_purgeable (obj); + }else { +i915_gem_object_make_unshrinkable (obj); } -i915_gem_object_put (obj); + + obj->mm.ttm_shrinkable = shrinkable; } +i915_gem_object_put (obj);/* * Put on the correct LRU list depending on the MADV status drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c +5
-3@@ -127,7 +127,7 @@ static void ttm_bo_init_reserved_sys_man(struct kunit *test)dma_resv_unlock (bo->base.resv);KUNIT_EXPECT_EQ (test, err,0 ); -KUNIT_EXPECT_EQ (test,kref_read (&bo->kref),1 ); +KUNIT_EXPECT_EQ (test,kref_read (&bo->base.refcount),1 );KUNIT_EXPECT_PTR_EQ (test, bo->bdev, priv->ttm_dev);KUNIT_EXPECT_EQ (test, bo->type, bo_type);KUNIT_EXPECT_EQ (test, bo->page_alignment,PAGE_SIZE );@@ -176,7 +176,7 @@ static void ttm_bo_init_reserved_mock_man(struct kunit *test)dma_resv_unlock (bo->base.resv);KUNIT_EXPECT_EQ (test, err,0 ); -KUNIT_EXPECT_EQ (test,kref_read (&bo->kref),1 ); +KUNIT_EXPECT_EQ (test,kref_read (&bo->base.refcount),1 );KUNIT_EXPECT_PTR_EQ (test, bo->bdev, priv->ttm_dev);KUNIT_EXPECT_EQ (test, bo->type, bo_type);KUNIT_EXPECT_EQ (test, ctx.bytes_moved, size);@@ -969,6 +969,8 @@ static void ttm_bo_validate_allowed_only_evict(struct kunit *test)ttm_mock_manager_fini (priv->ttm_dev, mem_multihop); } +extern const struct drm_gem_object_funcs ttm_deleted_object_funcs; +static void ttm_bo_validate_deleted_evict (struct kunit *test) {struct ttm_operation_ctx ctx_init = { }, ctx_val = { };@@ -999,7 +1001,7 @@ static void ttm_bo_validate_deleted_evict(struct kunit *test)KUNIT_EXPECT_EQ (test,ttm_resource_manager_usage (man), big);dma_resv_unlock (bo_big->base.resv); - bo_big->deleted = true; + bo_big->base.funcs = &ttm_deleted_object_funcs; bo_small =ttm_bo_kunit_init (test, test->priv, small,NULL ); bo_small->type = bo_type;drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c +0
-2@@ -189,8 +189,6 @@ struct ttm_buffer_object *ttm_bo_kunit_init(struct kunit *test, bo->bdev = devs->ttm_dev; bo->destroy = dummy_ttm_bo_destroy; -kref_init (&bo->kref); -return bo; }EXPORT_SYMBOL_GPL (ttm_bo_kunit_init);drivers/gpu/drm/ttm/ttm_bo.c +64
-71@@ -246,88 +246,84 @@ static void ttm_bo_delayed_delete(struct work_struct *work)ttm_bo_put (bo); } -static void ttm_bo_release (struct kref *kref) +/* +* All other callbacks should never ever be called on a deleted TTM object. +*/ +const struct drm_gem_object_funcs ttm_deleted_object_funcs = { + .free = ttm_bo_free +}; +EXPORT_SYMBOL_FOR_TESTS_ONLY (ttm_deleted_object_funcs); + +/* Returns true if the BO is about to get deleted */ +static bool ttm_bo_is_zombie (struct ttm_buffer_object *bo) +{ +return bo->base.funcs == &ttm_deleted_object_funcs; +} + +void ttm_bo_fini (struct ttm_buffer_object *bo) { -struct ttm_buffer_object *bo = - container_of(kref, struct ttm_buffer_object, kref);struct ttm_device *bdev = bo->bdev;int ret;WARN_ON_ONCE (bo->pin_count);WARN_ON_ONCE (bo->bulk_move); -if (!bo->deleted) { - ret =ttm_bo_individualize_resv (bo); -if (ret) { -/* Last resort, if we fail to allocate memory for the -* fences block for the BO to become idle -*/ -dma_resv_wait_timeout (bo->base.resv, -DMA_RESV_USAGE_BOOKKEEP , false, -30 *HZ ); - } + ret =ttm_bo_individualize_resv (bo); +if (ret) { +/* Last resort, if we fail to allocate memory for the +* fences block for the BO to become idle +*/ +dma_resv_wait_timeout (bo->base.resv,DMA_RESV_USAGE_BOOKKEEP , + false,30 *HZ ); + } -if (bdev->funcs->release_notify) - bdev->funcs->release_notify (bo); +if (bo->bdev->funcs->release_notify) + bo->bdev->funcs->release_notify (bo); -drm_vma_offset_remove (bdev->vma_manager, &bo->base.vma_node); -ttm_mem_io_free (bdev, bo->resource); +drm_vma_offset_remove (bdev->vma_manager, &bo->base.vma_node); +ttm_mem_io_free (bdev, bo->resource); -if (!dma_resv_test_signaled (&bo->base._resv, -DMA_RESV_USAGE_BOOKKEEP ) || - (want_init_on_free () && (bo->ttm !=NULL )) || - bo->type == ttm_bo_type_sg || - !dma_resv_trylock (bo->base.resv)) { -/* The BO is not idle, resurrect it for delayed destroy */ -ttm_bo_flush_all_fences (bo); - bo->deleted = true; +if (!dma_resv_test_signaled (&bo->base._resv,DMA_RESV_USAGE_BOOKKEEP ) || + (want_init_on_free () && (bo->ttm !=NULL )) || + bo->type == ttm_bo_type_sg || + !dma_resv_trylock (bo->base.resv)) { +/* The BO is not idle, resurrect it for delayed destroy */ +ttm_bo_flush_all_fences (bo); -spin_lock (&bdev->lru_lock); - -/* -* Make pinned bos immediately available to -* shrinkers, now that they are queued for -* destruction. -* -* FIXME: QXL is triggering this. Can be removed when the -* driver is fixed. -*/ -if (bo->pin_count) { - bo->pin_count =0 ; -ttm_resource_move_to_lru_tail (bo->resource); - } +spin_lock (&bo->bdev->lru_lock); -kref_init (&bo->kref); -spin_unlock (&bdev->lru_lock); +/* +* Make pinned bos immediately available to +* shrinkers, now that they are queued for +* destruction. +* +* FIXME: QXL is triggering this. Can be removed when the +* driver is fixed. +*/ +if (bo->pin_count) { + bo->pin_count =0 ; +ttm_resource_move_to_lru_tail (bo->resource); + } -INIT_WORK (&bo->delayed_delete, ttm_bo_delayed_delete); +kref_init (&bo->base.refcount); + bo->base.funcs = &ttm_deleted_object_funcs; +spin_unlock (&bo->bdev->lru_lock); -/* Schedule the worker on the closest NUMA node. This -* improves performance since system memory might be -* cleared on free and that is best done on a CPU core -* close to it. -*/ -queue_work_node (bdev->pool.nid, bdev->wq, &bo->delayed_delete); -return ; - } +INIT_WORK (&bo->delayed_delete, ttm_bo_delayed_delete); +/* Schedule the worker on the closest NUMA node. This +* improves performance since system memory might be +* cleared on free and that is best done on a CPU core +* close to it. +*/ +queue_work_node (bdev->pool.nid, bdev->wq, &bo->delayed_delete); + }else {ttm_bo_cleanup_memtype_use (bo);dma_resv_unlock (bo->base.resv); - } -atomic_dec (&ttm_glob.bo_count); - bo->destroy (bo); -} - -/* TODO: remove! */ -void ttm_bo_put (struct ttm_buffer_object *bo) -{ -kref_put (&bo->kref, ttm_bo_release); -} - -void ttm_bo_fini (struct ttm_buffer_object *bo) -{ -ttm_bo_put (bo); +atomic_dec (&ttm_glob.bo_count); + bo->destroy (bo); + } }EXPORT_SYMBOL (ttm_bo_fini);@@ -470,7 +466,7 @@ int ttm_bo_evict_first(struct ttm_device *bdev, struct ttm_resource_manager *manif (!bo->resource || bo->resource->mem_type != mem_type) goto out_bo_moved; -if (bo->deleted) { +if (ttm_bo_is_zombie (bo)) { ret =ttm_bo_wait_ctx (bo, ctx);if (!ret)ttm_bo_cleanup_memtype_use (bo);@@ -524,7 +520,7 @@ static s64 ttm_bo_evict_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *if (bo->pin_count || !bo->bdev->funcs->eviction_valuable (bo, evict_walk->place))return 0 ; -if (bo->deleted) { +if (ttm_bo_is_zombie (bo)) { lret =ttm_bo_wait_ctx (bo, walk->arg.ctx);if (!lret)ttm_bo_cleanup_memtype_use (bo);@@ -624,7 +620,6 @@ static int ttm_bo_evict_alloc(struct ttm_device *bdev,void ttm_bo_pin (struct ttm_buffer_object *bo) {dma_resv_assert_held (bo->base.resv); -WARN_ON_ONCE (!kref_read (&bo->kref));spin_lock (&bo->bdev->lru_lock);if (bo->resource)ttm_resource_del_bulk_move (bo->resource, bo);@@ -643,7 +638,6 @@ EXPORT_SYMBOL(ttm_bo_pin);void ttm_bo_unpin (struct ttm_buffer_object *bo) {dma_resv_assert_held (bo->base.resv); -WARN_ON_ONCE (!kref_read (&bo->kref));if (WARN_ON_ONCE (!bo->pin_count))return ;@@ -934,7 +928,6 @@ int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo, {int ret; -kref_init (&bo->kref); bo->bdev = bdev; bo->type = type; bo->page_alignment = alignment;@@ -1131,8 +1124,8 @@ ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo) goto out; } -if (bo->deleted) { -pgoff_t num_pages = tt->num_pages; +if (ttm_bo_is_zombie (bo)) { +pgoff_t num_pages = bo->ttm->num_pages; ret =ttm_bo_wait_ctx (bo, ctx);if (ret)drivers/gpu/drm/ttm/ttm_bo_internal.h +14
-3@@ -27,6 +27,14 @@#include <drm/ttm/ttm_bo.h> +static inline void ttm_bo_free (struct drm_gem_object *gobj) +{ +struct ttm_buffer_object *bo =container_of (gobj,typeof (*bo), base); + +atomic_dec (&ttm_glob.bo_count); + bo->destroy (bo); +} +/** * ttm_bo_get - reference a struct ttm_buffer_object * @@ -34,7 +42,7 @@*/ static inline void ttm_bo_get (struct ttm_buffer_object *bo) { -kref_get (&bo->kref); +drm_gem_object_get (&bo->base); }/** @@ -50,11 +58,14 @@ static inline void ttm_bo_get(struct ttm_buffer_object *bo)static inline __must_check struct ttm_buffer_object *ttm_bo_get_unless_zero (struct ttm_buffer_object *bo) { -if (!kref_get_unless_zero (&bo->kref)) +if (!kref_get_unless_zero (&bo->base.refcount))return NULL ;return bo; } -void ttm_bo_put (struct ttm_buffer_object *bo); +static inline void ttm_bo_put (struct ttm_buffer_object *bo) +{ +drm_gem_object_put (&bo->base); +}#endif drivers/gpu/drm/ttm/ttm_bo_util.c +14
-1@@ -41,6 +41,18 @@#include "ttm_bo_internal.h" +static void ttm_transfer_object_free (struct drm_gem_object *obj) +{ +struct ttm_buffer_object *bo = + container_of(obj, struct ttm_buffer_object, base); + +ttm_bo_fini (bo); +} + +const struct drm_gem_object_funcs ttm_transfer_object_funcs = { + .free = ttm_transfer_object_free, +}; +struct ttm_transfer_obj {struct ttm_buffer_object base;struct ttm_buffer_object *bo;@@ -247,7 +259,8 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo,atomic_inc (&ttm_glob.bo_count);drm_vma_node_reset (&fbo->base.base.vma_node); -kref_init (&fbo->base.kref); +kref_init (&fbo->base.base.refcount); + fbo->base.base.funcs = &ttm_transfer_object_funcs; fbo->base.destroy = &ttm_transfered_destroy; fbo->base.pin_count =0 ;if (bo->type != ttm_bo_type_sg)drivers/gpu/drm/xe/xe_bo.c +1
-1@@ -1651,7 +1651,7 @@ static bool xe_ttm_bo_lock_in_destructor(struct ttm_buffer_object *ttm_bo)struct xe_device *xe =ttm_to_xe_device (ttm_bo->bdev);bool locked; -xe_assert (xe, !kref_read (&ttm_bo->kref)); +xe_assert (xe, !kref_read (&ttm_bo->base.refcount));/* * We can typically only race with TTM trylocking under the include/drm/ttm/ttm_bo.h +0
-9@@ -78,11 +78,8 @@ enum ttm_bo_type {* @type: The bo type. * @page_alignment: Page alignment. * @destroy: Destruction function. If NULL, kfree is used. -* @kref: Reference count of this buffer object. When this refcount reaches -* zero, the object is destroyed or put on the delayed delete list. * @resource: structure describing current placement. * @ttm: TTM structure holding system pages. -* @deleted: True if the object is only a zombie and already deleted. * @bulk_move: The bulk move object. * @priority: Priority for LRU, BOs with lower priority are evicted first. * @pin_count: Pin count. @@ -109,17 +106,11 @@ struct ttm_buffer_object {uint32_t page_alignment;void (*destroy) (struct ttm_buffer_object *); -/* -* Members not needing protection. -*/ -struct kref kref; -/* * Members protected by the bo::resv::reserved lock. */ struct ttm_resource *resource;struct ttm_tt *ttm; -bool deleted;struct ttm_lru_bulk_move *bulk_move;unsigned priority;unsigned pin_count;
Natalie Vock
maintainerPATCH v2 3/10 drm/ttm: remove ttm_lru_walk_ops
In reply to Natalie VockIt's just another layer of indirection.
--- drivers/gpu/drm/ttm/ttm_bo.c | 12 ++---------- drivers/gpu/drm/ttm/ttm_bo_util.c | 2 +- include/drm/ttm/ttm_bo.h | 34 ++++++++++++++-------------------- 3 files changed, 17 insertions(+), 31 deletions(-)
drivers/gpu/drm/ttm/ttm_bo.c +2 -10
@@ -545,10 +545,6 @@ static s64 ttm_bo_evict_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *return lret; } -static const struct ttm_lru_walk_ops ttm_evict_walk_ops = { - .process_bo = ttm_bo_evict_cb, -}; - static int ttm_bo_evict_alloc(struct ttm_device *bdev, struct ttm_resource_manager *man, const struct ttm_place *place,
@@ -560,7 +556,7 @@ static int ttm_bo_evict_alloc(struct ttm_device *bdev, {struct ttm_bo_evict_walk evict_walk = { .walk = { - .ops = &ttm_evict_walk_ops, + .process_bo = ttm_bo_evict_cb, .arg = { .ctx = ctx, .ticket = ticket,
@@ -1187,10 +1183,6 @@ ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo)return ret; } -const struct ttm_lru_walk_ops ttm_swap_ops = { - .process_bo = ttm_bo_swapout_cb, -}; -/** * ttm_bo_swapout() - Swap out buffer objects on the LRU list to shmem. * @bdev: The ttm device.
@@ -1209,7 +1201,7 @@ s64 ttm_bo_swapout(struct ttm_device *bdev, struct ttm_operation_ctx *ctx, {struct ttm_bo_swapout_walk swapout_walk = { .walk = { - .ops = &ttm_swap_ops, + .process_bo = ttm_bo_swapout_cb, .arg = { .ctx = ctx, .trylock_only = true,
drivers/gpu/drm/ttm/ttm_bo_util.c +1 -1
@@ -919,7 +919,7 @@ s64 ttm_lru_walk_for_evict(struct ttm_lru_walk *walk, struct ttm_device *bdev,s64 lret;ttm_bo_lru_for_each_reserved_guarded (&cursor, man, &walk->arg, bo) { - lret = walk->ops->process_bo (walk, bo); + lret = walk->process_bo (walk, bo);if (lret == -EBUSY || lret == -EALREADY ) lret =0 ; progress = (lret <0 ) ? lret : progress + lret;
include/drm/ttm/ttm_bo.h +14 -20
@@ -189,24 +189,6 @@ struct ttm_operation_ctx {uint64_t bytes_moved; }; -struct ttm_lru_walk ; - -/** struct ttm_lru_walk_ops - Operations for a LRU walk. */ -struct ttm_lru_walk_ops { -/** -* process_bo - Process this bo. -* @walk: struct ttm_lru_walk describing the walk. -* @bo: A locked and referenced buffer object. -* -* Return: Negative error code on error, User-defined positive value -* (typically, but not always, size of the processed bo) on success. -* On success, the returned values are summed by the walk and the -* walk exits when its target is met. -* 0 also indicates success, -EBUSY means this bo was skipped. -*/ -s64 (*process_bo)(struct ttm_lru_walk *walk,struct ttm_buffer_object *bo); -}; -/** * struct ttm_lru_walk_arg - Common part for the variants of BO LRU walk. */
@@ -223,8 +205,20 @@ struct ttm_lru_walk_arg {* struct ttm_lru_walk - Structure describing a LRU walk. */ struct ttm_lru_walk { -/** @ops: Pointer to the ops structure. */ -const struct ttm_lru_walk_ops *ops; +/** +* process_bo - Process this bo. +* @walk: struct ttm_lru_walk describing the walk. +* @bo: A locked and referenced buffer object. +* +* Return: Negative error code on error, User-defined positive value +* (typically, but not always, size of the processed bo) on success. +* On success, the returned values are summed by the walk and the +* walk exits when its target is met. +* 0 also indicates success, -EBUSY means this bo was skipped. +*/ +s64 (*process_bo)(struct ttm_lru_walk *walk, +struct ttm_buffer_object *bo); +/** @arg: Common bo LRU walk arguments. */ struct ttm_lru_walk_arg arg; };
Signature · 1 line
2.55.0
Natalie Vock
maintainerPATCH v2 4/10 drm/ttm: grab BO reference before locking it
In reply to Natalie VockPreviously we always grabbed the BO reference after taking the lock, but that isn't necessary any more.
So avoid doing that and cleanup the handling here.
--- drivers/gpu/drm/ttm/ttm_bo_util.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/gpu/drm/ttm/ttm_bo_util.c +9 -6
@@ -1010,14 +1010,17 @@ __ttm_bo_lru_cursor_next(struct ttm_bo_lru_cursor *curs)break ; bo = res->bo; -if (ttm_lru_walk_trylock (curs, bo)) - bo_locked = true; -else if (!arg->ticket || arg->ctx->no_wait_gpu || arg->trylock_only) +if (!ttm_bo_get_unless_zero (bo))continue ; -if (!ttm_bo_get_unless_zero (bo)) { -if (curs->needs_unlock) -dma_resv_unlock (bo->base.resv); +if (ttm_lru_walk_trylock (curs, bo)) { + bo_locked = true; + + }else if (!arg->ticket || arg->ctx->no_wait_gpu || + arg->trylock_only) { +spin_unlock (lru_lock); +ttm_bo_put (bo); +spin_lock (lru_lock);continue ; }
Signature · 1 line
2.55.0
Natalie Vock
maintainerPATCH v2 5/10 drm/ttm: switch to ttm_bo_lru_for_each_reserved_guarded for swapout
In reply to Natalie VockInstead of the walker wrapper use the underlying foreach. Saves us quite a bunch of complexity and loc.
--- drivers/gpu/drm/ttm/ttm_bo.c | 58 +++++++--------------------------------- drivers/gpu/drm/ttm/ttm_device.c | 18 ++++++++++--- include/drm/ttm/ttm_bo.h | 5 ++-- 3 files changed, 26 insertions(+), 55 deletions(-)
drivers/gpu/drm/ttm/ttm_bo.c +10 -48
@@ -1080,25 +1080,18 @@ int ttm_bo_wait_ctx(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx)EXPORT_SYMBOL (ttm_bo_wait_ctx);/** -* struct ttm_bo_swapout_walk - Parameters for the swapout walk +* ttm_bo_swapout() - Swap out buffer objects on the LRU list to shmem. +* @bo: The buffer to swap out. +* @ctx: The ttm_operation_ctx governing the swapout operation. +* @gfp_flags: The gfp flags used for shmem page allocations. +* +* Return: The number of bytes actually swapped out, or negative error code +* on error. */ -struct ttm_bo_swapout_walk { -/** @walk: The walk base parameters. */ -struct ttm_lru_walk walk; -/** @gfp_flags: The gfp flags to use for ttm_tt_swapout() */ -gfp_t gfp_flags; -/** @hit_low: Whether we should attempt to swap BO's with low watermark threshold */ -/** @evict_low: If we cannot swap a bo when @try_low is false (first pass) */ -bool hit_low, evict_low; -}; - -static s64 -ttm_bo_swapout_cb (struct ttm_lru_walk *walk,struct ttm_buffer_object *bo) +s64 ttm_bo_swapout (struct ttm_buffer_object *bo,struct ttm_operation_ctx *ctx, +gfp_t gfp_flags) {struct ttm_place place = { .mem_type = bo->resource->mem_type }; -struct ttm_bo_swapout_walk *swapout_walk = -container_of (walk,typeof (*swapout_walk), walk); -struct ttm_operation_ctx *ctx = walk->arg.ctx;struct ttm_device *bdev = bo->bdev;struct ttm_tt *tt = bo->ttm;s64 ret;
@@ -1166,7 +1159,7 @@ ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo) bdev->funcs->swap_notify (bo);if (ttm_tt_is_populated (tt)) { - ret =ttm_tt_swapout (bdev, tt, swapout_walk->gfp_flags); + ret =ttm_tt_swapout (bdev, tt, gfp_flags);if (!ret) {spin_lock (&bdev->lru_lock);ttm_resource_del_bulk_move_unevictable (bo->resource, bo);
@@ -1183,37 +1176,6 @@ ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo)return ret; } -/** -* ttm_bo_swapout() - Swap out buffer objects on the LRU list to shmem. -* @bdev: The ttm device. -* @ctx: The ttm_operation_ctx governing the swapout operation. -* @man: The resource manager whose resources / buffer objects are -* goint to be swapped out. -* @gfp_flags: The gfp flags used for shmem page allocations. -* @target: The desired number of pages to swap out. -* -* Return: The number of pages actually swapped out, or negative error code -* on error. -*/ -s64 ttm_bo_swapout (struct ttm_device *bdev,struct ttm_operation_ctx *ctx, -struct ttm_resource_manager *man,gfp_t gfp_flags, -s64 target) -{ -struct ttm_bo_swapout_walk swapout_walk = { - .walk = { - .process_bo = ttm_bo_swapout_cb, - .arg = { - .ctx = ctx, - .trylock_only = true, - }, - }, - .gfp_flags = gfp_flags, - }; - -return ttm_lru_walk_for_evict (&swapout_walk.walk, bdev, man, target); -} -EXPORT_SYMBOL_FOR_TESTS_ONLY (ttm_bo_swapout); -void ttm_bo_tt_destroy (struct ttm_buffer_object *bo) {if (bo->ttm ==NULL )
drivers/gpu/drm/ttm/ttm_device.c +14 -4
@@ -171,6 +171,12 @@ int ttm_device_swapout(struct ttm_device *bdev, struct ttm_operation_ctx *ctx, gfp_t gfp_flags) {struct ttm_resource_manager *man; +struct ttm_bo_lru_cursor cursor; +struct ttm_buffer_object *bo; +struct ttm_lru_walk_arg arg = { + .ctx = ctx, + .trylock_only = true + };unsigned i;s64 lret;
@@ -179,10 +185,14 @@ int ttm_device_swapout(struct ttm_device *bdev, struct ttm_operation_ctx *ctx,if (!man || !man->use_tt)continue ; - lret =ttm_bo_swapout (bdev, ctx, man, gfp_flags,1 ); -/* Can be both positive (num_pages) and negative (error) */ -if (lret) -return lret; +ttm_bo_lru_for_each_reserved_guarded (&cursor, man, &arg, bo) { + lret =ttm_bo_swapout (bo, ctx, gfp_flags); +/* Can be both positive (num_pages) and negative (error) */ +if (lret && lret != -EBUSY && lret != -EALREADY ) +return lret; + } +if (IS_ERR (bo)) +return PTR_ERR (bo); }return 0 ; }
include/drm/ttm/ttm_bo.h +2 -3
@@ -408,9 +408,8 @@ void *ttm_bo_kmap_try_from_panic(struct ttm_buffer_object *bo, unsigned long pagint ttm_bo_vmap (struct ttm_buffer_object *bo,struct iosys_map *map);void ttm_bo_vunmap (struct ttm_buffer_object *bo,struct iosys_map *map);int ttm_bo_mmap_obj (struct vm_area_struct *vma,struct ttm_buffer_object *bo); -s64 ttm_bo_swapout (struct ttm_device *bdev,struct ttm_operation_ctx *ctx, -struct ttm_resource_manager *man,gfp_t gfp_flags, -s64 target); +s64 ttm_bo_swapout (struct ttm_buffer_object *bo,struct ttm_operation_ctx *ctx, +gfp_t gfp_flags);void ttm_bo_pin (struct ttm_buffer_object *bo);void ttm_bo_unpin (struct ttm_buffer_object *bo); int ttm_bo_evict_first(struct ttm_device *bdev,
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH v2 05/10] drm/ttm: switch to ttm_bo_lru_for_each_reserved_guarded for swapout
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Build breakage in DRM TTM KUnit tests due to updated `ttm_bo_swapout` signature and removed export.…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build breakage in DRM TTM KUnit tests due to updated ttm_bo_swapout signature and removed export. --
commit 67fbda553ce1493a6719acbdcf118e37c03311c8
Author: Natalie Vock <[email protected]>
drm/ttm: switch to ttm_bo_lru_for_each_reserved_guarded for swapout
This commit refactors the TTM BO swapout path to use the guarded LRU foreach iterator instead of the wrapper walk callback. It simplifies the code and reduces lines of code by removing the ttm_bo_swapout_walk struct and ttm_bo_swapout_cb.
Quoted 4 lines
drivers/gpu/drm/ttm/ttm_bo.c +0
-0
[ ... ]
Quoted 8 lines
drivers/gpu/drm/ttm/ttm_bo.c +0
-8-s64 ttm_bo_swapout (struct ttm_device *bdev,struct ttm_operation_ctx *ctx, -struct ttm_resource_manager *man,gfp_t gfp_flags, -s64 target) -{ -struct ttm_bo_swapout_walk swapout_walk = { - .walk = { - .process_bo = ttm_bo_swapout_cb, - .arg = {
drivers/gpu/drm/ttm/ttm_bo.c ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo) · line 1215
Quoted 10 lines
drivers/gpu/drm/ttm/ttm_bo.c +0
-10- .ctx = ctx, - .trylock_only = true, - }, - }, - .gfp_flags = gfp_flags, - }; - -return ttm_lru_walk_for_evict (&swapout_walk.walk, bdev, man, target); -} -EXPORT_SYMBOL_FOR_TESTS_ONLY (ttm_bo_swapout);
[Severity: Low]
Will this break the KUnit tests? Looking at ttm_bo_validate_swapout() in drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c, it still attempts to call ttm_bo_swapout() with the old 5-argument signature:
swapped = ttm_bo_swapout(priv->ttm_dev, &ctx_init, man, GFP_KERNEL, MANAGER_SIZE / PAGE_SIZE);
With the removal of EXPORT_SYMBOL_FOR_TESTS_ONLY and the signature change, this appears to cause a build failure when KUnit tests are enabled.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
Natalie Vock
maintainerPATCH v2 6/10 drm/ttm: move zombie handling into ttm_bo_evict
In reply to Natalie VockBoth callers do the same thing, so we can trivially unify that.
--- drivers/gpu/drm/ttm/ttm_bo.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-)
drivers/gpu/drm/ttm/ttm_bo.c +9 -15
@@ -359,6 +359,13 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo,struct ttm_place hop;int ret =0 ; +if (ttm_bo_is_zombie (bo)) { + ret =ttm_bo_wait_ctx (bo, ctx); +if (!ret) +ttm_bo_cleanup_memtype_use (bo); +return ret; + } +memset (&hop,0 ,sizeof (hop));dma_resv_assert_held (bo->base.resv);
@@ -466,13 +473,7 @@ int ttm_bo_evict_first(struct ttm_device *bdev, struct ttm_resource_manager *manif (!bo->resource || bo->resource->mem_type != mem_type) goto out_bo_moved; -if (ttm_bo_is_zombie (bo)) { - ret =ttm_bo_wait_ctx (bo, ctx); -if (!ret) -ttm_bo_cleanup_memtype_use (bo); - }else { - ret =ttm_bo_evict (bo, ctx); - } + ret =ttm_bo_evict (bo, ctx); out_bo_moved:dma_resv_unlock (bo->base.resv); out_no_lock:
@@ -520,14 +521,7 @@ static s64 ttm_bo_evict_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *if (bo->pin_count || !bo->bdev->funcs->eviction_valuable (bo, evict_walk->place))return 0 ; -if (ttm_bo_is_zombie (bo)) { - lret =ttm_bo_wait_ctx (bo, walk->arg.ctx); -if (!lret) -ttm_bo_cleanup_memtype_use (bo); - }else { - lret =ttm_bo_evict (bo, walk->arg.ctx); - } - + lret =ttm_bo_evict (bo, walk->arg.ctx);if (lret) goto out;
Signature · 1 line
2.55.0
Natalie Vock
maintainerPATCH v2 7/10 drm/ttm: use ttm_bo_lru_for_each_reserved_guarded in evict_all
In reply to Natalie VockUse the for_each loop to evict all BOs of an resource manager as well.
Greately simplifying the handling and finally allows us to remove ttm_bo_evict_first().
--- drivers/gpu/drm/ttm/ttm_bo.c | 51 +------------------------------------- drivers/gpu/drm/ttm/ttm_resource.c | 21 ++++++++++------ include/drm/ttm/ttm_bo.h | 1 + 3 files changed, 16 insertions(+), 57 deletions(-)
drivers/gpu/drm/ttm/ttm_bo.c +1 -50
@@ -351,8 +351,7 @@ static int ttm_bo_bounce_temp_buffer(struct ttm_buffer_object *bo,return 0 ; } -static int ttm_bo_evict (struct ttm_buffer_object *bo, -struct ttm_operation_ctx *ctx) +int ttm_bo_evict (struct ttm_buffer_object *bo,struct ttm_operation_ctx *ctx) {struct ttm_resource *evict_mem;struct ttm_placement placement;
@@ -437,54 +436,6 @@ bool ttm_bo_eviction_valuable(struct ttm_buffer_object *bo, }EXPORT_SYMBOL (ttm_bo_eviction_valuable); -/** -* ttm_bo_evict_first() - Evict the first bo on the manager's LRU list. -* @bdev: The ttm device. -* @man: The manager whose bo to evict. -* @ctx: The TTM operation ctx governing the eviction. -* -* Return: 0 if successful or the resource disappeared. Negative error code on error. -*/ -int ttm_bo_evict_first (struct ttm_device *bdev,struct ttm_resource_manager *man, -struct ttm_operation_ctx *ctx) -{ -struct ttm_resource_cursor cursor; -struct ttm_buffer_object *bo; -struct ttm_resource *res; -unsigned int mem_type; -int ret =0 ; - -spin_lock (&bdev->lru_lock); -ttm_resource_cursor_init (&cursor, man); - res =ttm_resource_manager_first (&cursor); -ttm_resource_cursor_fini (&cursor); -if (!res) { - ret = -ENOENT ; - goto out_no_ref; - } - bo = res->bo; -if (!ttm_bo_get_unless_zero (bo)) - goto out_no_ref; - mem_type = res->mem_type; -spin_unlock (&bdev->lru_lock); - ret =ttm_bo_reserve (bo, ctx->interruptible, ctx->no_wait_gpu,NULL ); -if (ret) - goto out_no_lock; -if (!bo->resource || bo->resource->mem_type != mem_type) - goto out_bo_moved; - - ret =ttm_bo_evict (bo, ctx); -out_bo_moved: -dma_resv_unlock (bo->base.resv); -out_no_lock: -ttm_bo_put (bo); -return ret; - -out_no_ref: -spin_unlock (&bdev->lru_lock); -return ret; -} -/** * struct ttm_bo_evict_walk - Parameters for the evict walk. */
drivers/gpu/drm/ttm/ttm_resource.c +14 -7
@@ -561,17 +561,24 @@ EXPORT_SYMBOL(ttm_resource_manager_init);int ttm_resource_manager_evict_all (struct ttm_device *bdev,struct ttm_resource_manager *man) { -struct ttm_operation_ctx ctx = { }; +struct ttm_bo_lru_cursor cursor; +struct ttm_buffer_object *bo; +struct ttm_operation_ctx ctx = { + .interruptible = false, + .no_wait_gpu = false, + }; +struct ttm_lru_walk_arg arg = { + .ctx = &ctx, + };struct dma_fence *fence;int ret, i; -do { - ret =ttm_bo_evict_first (bdev, man, &ctx); +ttm_bo_lru_for_each_reserved_guarded (&cursor, man, &arg, bo) { + ret =ttm_bo_evict (bo, &ctx); +if (ret) +return ret;cond_resched (); - }while (!ret); - -if (ret && ret != -ENOENT ) -return ret; + } ret =0 ;
include/drm/ttm/ttm_bo.h +1 -0
@@ -389,6 +389,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo,void ttm_bo_fini (struct ttm_buffer_object *bo);void ttm_bo_set_bulk_move (struct ttm_buffer_object *bo,struct ttm_lru_bulk_move *bulk); +int ttm_bo_evict (struct ttm_buffer_object *bo,struct ttm_operation_ctx *ctx);bool ttm_bo_eviction_valuable (struct ttm_buffer_object *bo,const struct ttm_place *place); int ttm_bo_init_reserved(struct ttm_device *bdev, struct ttm_buffer_object *bo,
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH v2 07/10] drm/ttm: use ttm_bo_lru_for_each_reserved_guarded in evict_all
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] ttm_resource_manager_evict_all silently skips locked and zero-refcount BOs, failing to completely…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] ttm_resource_manager_evict_all silently skips locked and zero-refcount BOs, failing to completely evict the manager.
- [Medium] cond_resched() is called while the buffer object's dma_resv lock is held.
--
commit ff3394ed91bf06ac0115f1da5665b9edeeb4a66b
Author: Natalie Vock <[email protected]>
drm/ttm: use ttm_bo_lru_for_each_reserved_guarded in evict_all
Use the for_each loop to evict all BOs of an resource manager as well. Greately simplifying the handling and finally allows us to remove ttm_bo_evict_first().
Quoted 4 lines
drivers/gpu/drm/ttm/ttm_resource.c +0
-0
[ ... ]
Quoted 13 lines
drivers/gpu/drm/ttm/ttm_resource.c +8
-1@@ -561,17 +561,24 @@ EXPORT_SYMBOL(ttm_resource_manager_init);int ttm_resource_manager_evict_all (struct ttm_device *bdev,struct ttm_resource_manager *man) { -struct ttm_operation_ctx ctx = { }; +struct ttm_bo_lru_cursor cursor; +struct ttm_buffer_object *bo; +struct ttm_operation_ctx ctx = { + .interruptible = false, + .no_wait_gpu = false, + }; +struct ttm_lru_walk_arg arg = { + .ctx = &ctx,
drivers/gpu/drm/ttm/ttm_resource.c EXPORT_SYMBOL(ttm_resource_manager_init); · line 579
Quoted 10 lines
drivers/gpu/drm/ttm/ttm_resource.c +5
-2+ };struct dma_fence *fence;int ret, i; - do { - ret = ttm_bo_evict_first(bdev, man, &ctx); +ttm_bo_lru_for_each_reserved_guarded (&cursor, man, &arg, bo) { + ret =ttm_bo_evict (bo, &ctx); +if (ret) +return ret;
[Severity: High]
Does this new loop successfully evict all buffers if some are locked by other threads?
With the previous do/while loop using ttm_bo_evict_first(), it would keep retrying until the manager was genuinely empty.
Using ttm_bo_lru_for_each_reserved_guarded() with an arg where arg.ticket = NULL, __ttm_bo_lru_cursor_next() skips locked or zero-refcount BOs:
drivers/gpu/drm/ttm/ttm_bo_util.c:__ttm_bo_lru_cursor_next() {
...
} else if (!arg->ticket || arg->ctx->no_wait_gpu ||
arg->trylock_only) {
spin_unlock(lru_lock);
ttm_bo_put(bo);
spin_lock(lru_lock);
continue;
}
...
}Because the new loop is a single-pass iteration, will these skipped BOs be left permanently in the resource manager, potentially causing resource leaks or kernel crashes (like a WARN_ON for non-empty LRU lists) during driver unload or device suspend?
drivers/gpu/drm/ttm/ttm_resource.c EXPORT_SYMBOL(ttm_resource_manager_init);
Quoted 6 lines
drivers/gpu/drm/ttm/ttm_resource.c +1
-5-cond_resched (); - }while (!ret); - -if (ret && ret != -ENOENT ) -return ret; +cond_resched ();
[Severity: Medium]
Is cond_resched() being called here while holding the buffer object's dma_resv lock?
The ttm_bo_lru_for_each_reserved_guarded iterator yields each BO with its dma_resv lock held, and only releases it during the implicit next call at the end of the loop.
Yielding the CPU while holding this lock might stall other kernel paths waiting for the lock.
In the previous implementation, the lock was explicitly released inside ttm_bo_evict_first() before cond_resched() was invoked.
Quoted 3 lines
drivers/gpu/drm/ttm/ttm_resource.c +1
-0+ } ret =0 ;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7
Natalie Vock
maintainerPATCH v2 8/10 drm/xe: remove workaround for TTM internals
In reply to Natalie VockThis should no longer be necessary, TTM doesn't lock the BO without a reference any more.
Only compile tested!
--- drivers/gpu/drm/xe/xe_bo.c | 32 +++++--------------------------- 1 file changed, 5 insertions(+), 27 deletions(-)
drivers/gpu/drm/xe/xe_bo.c +5 -27
@@ -1642,31 +1642,6 @@ static unsigned long xe_ttm_io_mem_pfn(struct ttm_buffer_object *ttm_bo,static void __xe_bo_vunmap (struct xe_bo *bo); -/* -* TODO: Move this function to TTM so we don't rely on how TTM does its -* locking, thereby abusing TTM internals. -*/ -static bool xe_ttm_bo_lock_in_destructor (struct ttm_buffer_object *ttm_bo) -{ -struct xe_device *xe =ttm_to_xe_device (ttm_bo->bdev); -bool locked; - -xe_assert (xe, !kref_read (&ttm_bo->base.refcount)); - -/* -* We can typically only race with TTM trylocking under the -* lru_lock, which will immediately be unlocked again since -* the ttm_bo refcount is zero at this point. So trylocking *should* -* always succeed here, as long as we hold the lru lock. -*/ -spin_lock (&ttm_bo->bdev->lru_lock); - locked =dma_resv_trylock (&ttm_bo->base._resv); -spin_unlock (&ttm_bo->bdev->lru_lock); -xe_assert (xe, locked); - -return locked; -} -static void xe_ttm_bo_release_notify (struct ttm_buffer_object *ttm_bo) {struct dma_resv_iter cursor;
@@ -1680,8 +1655,11 @@ static void xe_ttm_bo_release_notify(struct ttm_buffer_object *ttm_bo) bo =ttm_to_xe_bo (ttm_bo);xe_assert (xe_bo_device (bo), !(bo->created &&kref_read (&ttm_bo->base.refcount))); -if (!xe_ttm_bo_lock_in_destructor (ttm_bo)) -return ; +/* +* This should never fail since there are no other references to the BO +* any more. +*/ +WARN_ON (!dma_resv_trylock (ttm_bo->base.resv));/* * Scrub the preempt fences if any. The unbind fence is already
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH v2 08/10] drm/xe: remove workaround for TTM internals
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Critical] Locking mismatch and missing error handling in `xe_ttm_bo_release_notify` lead to deadlocks…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Locking mismatch and missing error handling in xe_ttm_bo_release_notify lead to deadlocks, state corruption, and kernel panics for imported dma-buf objects. --
commit 654aea229ee4882cf8f04774d507ece22e8921fd
Author: Natalie Vock <[email protected]>
drm/xe: remove workaround for TTM internals
This commit removes the xe_ttm_bo_lock_in_destructor() workaround and replaces it with a WARN_ON() check in xe_ttm_bo_release_notify().
Quoted 4 lines
drivers/gpu/drm/xe/xe_bo.c +0
-0
[ ... ]
drivers/gpu/drm/xe/xe_bo.c static void xe_ttm_bo_release_notify(struct ttm_buffer_object *ttm_bo) · line 1662
Quoted 11 lines
drivers/gpu/drm/xe/xe_bo.c +5
-2@@ -1680,8 +1655,11 @@ static void xe_ttm_bo_release_notify(struct ttm_buffer_object *ttm_bo) bo =ttm_to_xe_bo (ttm_bo);xe_assert (xe_bo_device (bo), !(bo->created &&kref_read (&ttm_bo->base.refcount))); -if (!xe_ttm_bo_lock_in_destructor (ttm_bo)) -return ; +/* +* This should never fail since there are no other references to the BO +* any more. +*/ +WARN_ON (!dma_resv_trylock (ttm_bo->base.resv));
[Severity: Critical]
Since WARN_ON() does not return on failure, if the trylock fails, won't execution fall through and modify fences without holding the lock?
Also, there appears to be a mismatch in the resv pointer being locked and unlocked. We are locking ttm_bo->base.resv here, but later in this same function it acts on ttm_bo->base._resv:
dma_resv_for_each_fence(&cursor, &ttm_bo->base._resv,
DMA_RESV_USAGE_BOOKKEEP, fence) {
...
}
dma_resv_unlock(&ttm_bo->base._resv);For imported dma-buf objects, base.resv might not equal &base._resv. Could this lock the exporter's shared resv but attempt to unlock the local embedded _resv? This might cause a deadlock on the shared resv and an attempt to unlock an unheld mutex.
Quoted 3 lines
drivers/gpu/drm/xe/xe_bo.c +0
-0/* * Scrub the preempt fences if any. The unbind fence is already
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
Natalie Vock
maintainerPATCH v2 9/10 drm/ttm: support using drm_exec during eviction v4
In reply to Natalie VockAllow specifying a drm_exec object in TTMs operation context which is used to lock objects during eviction.
This allows to handle deadlocks much more gracefully and with that avoid returning -ENOMEM on heavily contended domains.
v2: rebased on top of Thomas work
v3: rebased again
v4: rebased, fixed locks of already-reserved buffers being dropped
--- drivers/gpu/drm/ttm/ttm_bo_util.c | 30 ++++++++++++++++++++++-------- include/drm/ttm/ttm_bo.h | 5 +++++ 2 files changed, 27 insertions(+), 8 deletions(-)
drivers/gpu/drm/ttm/ttm_bo_util.c +22 -8
@@ -38,6 +38,7 @@#include <drm/ttm/ttm_tt.h> #include <drm/drm_cache.h> +#include <drm/drm_exec.h> #include "ttm_bo_internal.h"
@@ -837,6 +838,8 @@ static bool ttm_lru_walk_trylock(struct ttm_bo_lru_cursor *curs,struct ttm_operation_ctx *ctx = curs->arg->ctx; curs->needs_unlock = false; +if (ctx->exec) +return false;if (dma_resv_trylock (bo->base.resv)) { curs->needs_unlock = true;
@@ -857,7 +860,9 @@ static int ttm_lru_walk_ticketlock(struct ttm_bo_lru_cursor *curs,struct ttm_lru_walk_arg *arg = curs->arg;int ret; -if (arg->ctx->interruptible) +if (arg->ctx->exec) + ret =drm_exec_lock_obj_report_dup (arg->ctx->exec, &bo->base); +else if (arg->ctx->interruptible) ret =dma_resv_lock_interruptible (bo->base.resv, arg->ticket);else ret =dma_resv_lock (bo->base.resv, arg->ticket);
@@ -871,7 +876,11 @@ static int ttm_lru_walk_ticketlock(struct ttm_bo_lru_cursor *curs,* trylocking for this walk. */ arg->ticket =NULL ; - }else if (ret == -EDEADLK ) { + + }else if (arg->ctx->exec && arg->ctx->allow_res_evict && + ret == -EALREADY ) { + ret =0 ; + }else if (!arg->ctx->exec && ret == -EDEADLK ) {/* Caller needs to exit the ww transaction. */ ret = -ENOSPC ; }
@@ -937,12 +946,17 @@ static void ttm_bo_lru_cursor_cleanup_bo(struct ttm_bo_lru_cursor *curs) {struct ttm_buffer_object *bo = curs->bo; -if (bo) { -if (curs->needs_unlock) +if (!bo) +return ; + +if (curs->needs_unlock) { +if (curs->arg->ctx->exec) +drm_exec_unlock_obj (curs->arg->ctx->exec, &bo->base); +else dma_resv_unlock (bo->base.resv); -ttm_bo_put (bo); - curs->bo =NULL ; } +ttm_bo_put (bo); + curs->bo =NULL ; }/**
@@ -1016,8 +1030,8 @@ __ttm_bo_lru_cursor_next(struct ttm_bo_lru_cursor *curs)if (ttm_lru_walk_trylock (curs, bo)) { bo_locked = true; - }else if (!arg->ticket || arg->ctx->no_wait_gpu || - arg->trylock_only) { + }else if ((!arg->ticket || arg->ctx->no_wait_gpu || + arg->trylock_only) && !arg->ctx->exec) {spin_unlock (lru_lock);ttm_bo_put (bo);spin_lock (lru_lock);
include/drm/ttm/ttm_bo.h +5 -0
@@ -187,6 +187,11 @@ struct ttm_operation_ctx {* @bytes_moved: Statistics on how many bytes have been moved. */ uint64_t bytes_moved; +/** +* @exec: optional drm_exec object to use for locking BOs and +* tracking which are locked. +*/ +struct drm_exec *exec; };/**
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH v2 09/10] drm/ttm: support using drm_exec during eviction v4
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] The logic change silently overrides `trylock_only` and `no_wait_gpu` flags when `ctx->exec` is…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The logic change silently overrides trylock_only and no_wait_gpu flags when ctx->exec is provided, forcing blocking locks instead of trylocks. --
commit 5fb376340fb1686ce3b629a364137351ecc0b343
Author: Natalie Vock <[email protected]>
drm/ttm: support using drm_exec during eviction v4
Allow specifying a drm_exec object in TTMs operation context which is used to lock objects during eviction.
Quoted 4 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +0
-0
[ ... ]
drivers/gpu/drm/ttm/ttm_bo_util.c static bool ttm_lru_walk_trylock(struct ttm_bo_lru_cursor *curs, · line 842
Quoted 6 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +2
-0@@ -837,6 +838,8 @@ static bool ttm_lru_walk_trylock(struct ttm_bo_lru_cursor *curs,struct ttm_operation_ctx *ctx = curs->arg->ctx; curs->needs_unlock = false; +if (ctx->exec) +return false;
[Severity: High]
Does returning false here when ctx->exec is set force the walk to bypass trylocking and push the logic into a blocking fallback?
Quoted 3 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +0
-0if (dma_resv_trylock (bo->base.resv)) { curs->needs_unlock = true;
[ ... ]
drivers/gpu/drm/ttm/ttm_bo_util.c static int ttm_lru_walk_ticketlock(struct ttm_bo_lru_cursor *curs, · line 864
Quoted 7 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +2
-1@@ -857,7 +860,9 @@ static int ttm_lru_walk_ticketlock(struct ttm_bo_lru_cursor *curs,struct ttm_lru_walk_arg *arg = curs->arg;int ret; -if (arg->ctx->interruptible) +if (arg->ctx->exec) + ret =drm_exec_lock_obj_report_dup (arg->ctx->exec, &bo->base);
[Severity: High]
Does this perform a blocking WW mutex lock via drm_exec, completely ignoring the trylock_only intent of the caller?
Quoted 4 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +1
-0+else if (arg->ctx->interruptible) ret =dma_resv_lock_interruptible (bo->base.resv, arg->ticket);else ret =dma_resv_lock (bo->base.resv, arg->ticket);
[ ... ]
drivers/gpu/drm/ttm/ttm_bo_util.c __ttm_bo_lru_cursor_next(struct ttm_bo_lru_cursor *curs) · line 1034
Quoted 8 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +2
-2@@ -1016,8 +1030,8 @@ __ttm_bo_lru_cursor_next(struct ttm_bo_lru_cursor *curs)if (ttm_lru_walk_trylock (curs, bo)) { bo_locked = true; - }else if (!arg->ticket || arg->ctx->no_wait_gpu || - arg->trylock_only) { + }else if ((!arg->ticket || arg->ctx->no_wait_gpu || + arg->trylock_only) && !arg->ctx->exec) {
[Severity: High]
Does negating the non-blocking flags when ctx->exec is present force the walk to fall through to a blocking lock attempt?
This appears to silently override the trylock_only and no_wait_gpu flags. When amdgpu_cs_bo_validate() triggers TTM eviction under memory pressure, it passes an operation context with ctx->exec set. ttm_bo_evict_first() initiates its first pass with trylock_only = true to find an idle buffer.
Because of these changes, the walk bypasses the trylock_only check and falls through to ttm_lru_walk_ticketlock(), which calls drm_exec_lock_obj_report_dup() and performs a blocking WW mutex lock.
Could this cause the eviction to block and wait on the first busy buffer in the LRU instead of skipping it, potentially breaking the two-pass eviction strategy and leading to unnecessary command submission backoffs or serialization of independent workloads?
Quoted 3 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +0
-0spin_unlock (lru_lock);ttm_bo_put (bo);spin_lock (lru_lock);
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9
Natalie Vock
maintainerPATCH v2 10/10 drm/amdgpu: use drm_exec during BO validation
In reply to Natalie VockThis allows to detect deadlocks happening because of resource constraints.
Especially submissions which want to use all of GDS doesn't result in sporadic -ENOMEM any more.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 80 ++++++++++++++++++---------------- 1 file changed, 42 insertions(+), 38 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +42 -38
@@ -793,7 +793,7 @@ static int amdgpu_cs_bo_validate(void *param, struct amdgpu_bo *bo)struct ttm_operation_ctx ctx = { .interruptible = true, .no_wait_gpu = false, - .resv = bo->tbo.base.resv + .exec = &p->exec, };uint32_t domain;int r;
@@ -845,7 +845,8 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, union drm_amdgpu_cs *cs) {struct amdgpu_fpriv *fpriv = p->filp->driver_priv; -struct ttm_operation_ctx ctx = { true, false }; +struct ttm_operation_ctx ctx = { .interruptible = true, + .exec = &p->exec };struct amdgpu_vm *vm = &fpriv->vm;struct amdgpu_bo_list_entry *e;struct drm_gem_object *obj;
@@ -922,47 +923,53 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,if (unlikely (r)) goto out_free_user_pages; } - } - -amdgpu_bo_list_for_each_userptr_entry (e, p->bo_list) { -struct mm_struct *usermm; - usermm =amdgpu_ttm_tt_get_usermm (e->bo->tbo.ttm); -if (usermm && usermm != current->mm) { - r = -EPERM ; - goto out_free_user_pages; - } +amdgpu_bo_list_for_each_userptr_entry (e, p->bo_list) { +struct mm_struct *usermm; -if (amdgpu_ttm_tt_is_userptr (e->bo->tbo.ttm) && - e->user_invalidated) { -amdgpu_bo_placement_from_domain (e->bo, -AMDGPU_GEM_DOMAIN_CPU ); - r =ttm_bo_validate (&e->bo->tbo, &e->bo->placement, - &ctx); -if (r) + usermm =amdgpu_ttm_tt_get_usermm (e->bo->tbo.ttm); +if (usermm && usermm != current->mm) { + r = -EPERM ; goto out_free_user_pages; + } -amdgpu_ttm_tt_set_user_pages (e->bo->tbo.ttm, - e->range); +if (amdgpu_ttm_tt_is_userptr (e->bo->tbo.ttm) && + e->user_invalidated) { +amdgpu_bo_placement_from_domain (e->bo, +AMDGPU_GEM_DOMAIN_CPU ); + r =ttm_bo_validate (&e->bo->tbo, &e->bo->placement, + &ctx); +drm_exec_retry_on_contention (&p->exec); +if (r) + goto out_free_user_pages; + +amdgpu_ttm_tt_set_user_pages (e->bo->tbo.ttm, + e->range); + } } - } -amdgpu_cs_get_threshold_for_moves (p->adev, &p->bytes_moved_threshold, - &p->bytes_moved_vis_threshold); - p->bytes_moved =0 ; - p->bytes_moved_vis =0 ; - - r =amdgpu_vm_validate (p->adev, &fpriv->vm,NULL , - amdgpu_cs_bo_validate, p); -if (r) { -drm_err (adev_to_drm (p->adev),"amdgpu_vm_validate() failed.\n" ); - goto out_free_user_pages; - } +amdgpu_cs_get_threshold_for_moves (p->adev, &p->bytes_moved_threshold, + &p->bytes_moved_vis_threshold); + p->bytes_moved =0 ; + p->bytes_moved_vis =0 ; -drm_exec_for_each_locked_object (&p->exec, obj) { - r =amdgpu_cs_bo_validate (p,gem_to_amdgpu_bo (obj)); -if (unlikely (r)) + r =amdgpu_vm_validate (p->adev, &fpriv->vm,NULL , + amdgpu_cs_bo_validate, p); +drm_exec_retry_on_contention (&p->exec); +if (r) { +drm_err (adev_to_drm (p->adev),"amdgpu_vm_validate() failed.\n" ); goto out_free_user_pages; + } + +drm_exec_for_each_locked_object (&p->exec, obj) { + r =amdgpu_cs_bo_validate (p,gem_to_amdgpu_bo (obj)); +drm_exec_retry_on_contention (&p->exec); +if (unlikely (r)) + goto out_free_user_pages; + } + +amdgpu_cs_report_moved_bytes (p->adev, p->bytes_moved, + p->bytes_moved_vis); }if (p->uf_bo) {
@@ -973,9 +980,6 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, p->gang_leader->uf_addr +=amdgpu_bo_gpu_offset (p->uf_bo); } -amdgpu_cs_report_moved_bytes (p->adev, p->bytes_moved, - p->bytes_moved_vis); -for (i =0 ; i < p->gang_size; ++i) amdgpu_job_set_resources(p->jobs[i], p->bo_list->gds_obj, p->bo_list->gws_obj,
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCH v2 10/10] drm/amdgpu: use drm_exec during BO validation
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [High] Resource Accounting Leak / Throttle Bypass via loop state reset - [High] Eviction Ping-Pong and…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Resource Accounting Leak / Throttle Bypass via loop state reset
- [High] Eviction Ping-Pong and Mass Locking via blind drm_exec iteration --
commit 55fa3886644544ae8f5e3d97c8a80ceba452b3ca
Author: Natalie Vock <[email protected]>
Subject: drm/amdgpu: use drm_exec during BO validation
This commit updates the BO validation in amdgpu_cs to use drm_exec, aiming to prevent deadlocks caused by resource constraints and avoid sporadic -ENOMEM issues when using GDS.
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c static int amdgpu_cs_bo_validate(void *param, struct amdgpu_bo *bo) · line 799
Quoted 13 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +1
-1@@ -793,7 +793,7 @@ static int amdgpu_cs_bo_validate(void *param, struct amdgpu_bo *bo)struct ttm_operation_ctx ctx = { .interruptible = true, .no_wait_gpu = false, - .resv = bo->tbo.base.resv + .exec = &p->exec, };uint32_t domain;int r;
[Severity: High]
Does setting .exec to &p->exec cause TTM to add evicted victim buffers to the transaction's locked object list?
If so, later when drm_exec_for_each_locked_object() iterates over all objects in p->exec, will it inadvertently re-validate these victim BOs and attempt to move them back into VRAM?
[ ... ]
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +0
-0@@ -922,47 +923,53 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,if (unlikely (r)) goto out_free_user_pages; }
[ ... ]
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +0
-5-amdgpu_cs_get_threshold_for_moves (p->adev, &p->bytes_moved_threshold, - &p->bytes_moved_vis_threshold); - p->bytes_moved =0 ; - p->bytes_moved_vis =0 ; -
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, · line 954
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +4
-6- r =amdgpu_vm_validate (p->adev, &fpriv->vm,NULL , - amdgpu_cs_bo_validate, p); -if (r) { -drm_err (adev_to_drm (p->adev),"amdgpu_vm_validate() failed.\n" ); - goto out_free_user_pages; - } +amdgpu_cs_get_threshold_for_moves (p->adev, &p->bytes_moved_threshold, + &p->bytes_moved_vis_threshold); + p->bytes_moved =0 ; + p->bytes_moved_vis =0 ;
[Severity: High]
Is it intentional to unconditionally reset these accumulators inside the retry loop?
Since this block is inside the drm_exec_until_all_locked() loop, if a later validation causes WW lock contention and triggers a retry, the loop will restart and these counters will be zeroed.
Because TTM does not rollback physical moves when dropping locks, this appears to discard the accounting for BOs that were already moved, potentially bypassing the migration bandwidth throttle.
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +4
-3-drm_exec_for_each_locked_object (&p->exec, obj) { - r =amdgpu_cs_bo_validate (p,gem_to_amdgpu_bo (obj)); -if (unlikely (r)) + r =amdgpu_vm_validate (p->adev, &fpriv->vm,NULL , + amdgpu_cs_bo_validate, p); +drm_exec_retry_on_contention (&p->exec); +if (r) {
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p, · line 969
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +9
-0+drm_err (adev_to_drm (p->adev),"amdgpu_vm_validate() failed.\n" ); goto out_free_user_pages; + } + +drm_exec_for_each_locked_object (&p->exec, obj) { + r =amdgpu_cs_bo_validate (p,gem_to_amdgpu_bo (obj)); +drm_exec_retry_on_contention (&p->exec); +if (unlikely (r)) + goto out_free_user_pages; + }
[Severity: High]
Could this iteration cause an eviction ping-pong?
Because TTM eviction adds victim buffers to p->exec, this loop will iterate over those newly added victims. amdgpu_cs_bo_validate() might then see the victim's preferred domains and try to move it back into VRAM, forcing another eviction and trapping the validation in an infinite loop until the threshold is hit or VRAM is exhausted.
Quoted 4 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +3
-0+ +amdgpu_cs_report_moved_bytes (p->adev, p->bytes_moved, + p->bytes_moved_vis); }
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=10
Patchwork
CI✗ LGCI.VerificationFailed: failure for Use drm_exec to lock TTM buffers, respin (rev2)
In reply to Natalie Vock== Series Details ==
== Series Details ==
Series: Use drm_exec to lock TTM buffers, respin (rev2)
URL : https://patchwork.freedesktop.org/series/169776/
State : failure
== Summary ==
Series author address '[email protected]' is not on the allowlist, which prevents CI from being automatically triggered. If you want CI to run for this series, ask Patchwork project owners to click 'retest' on the series in Patchwork. Exception occurred during validation, bailing out!
Build URL: http://intel-gfx-ci-public.igk.intel.com:8080/job/xe_pw_trigger/1207556/ (on master)
Patchwork
CI✗ LGCI.VerificationFailed: failure for Use drm_exec to lock TTM buffers, respin (rev2)
In reply to Natalie Vock== Series Details ==
== Series Details ==
Series: Use drm_exec to lock TTM buffers, respin (rev2)
URL : https://patchwork.freedesktop.org/series/169777/
State : failure
== Summary ==
Series author address '[email protected]' is not on the allowlist, which prevents CI from being automatically triggered. If you want CI to run for this series, ask Patchwork project owners to click 'retest' on the series in Patchwork. Exception occurred during validation, bailing out!
Build URL: http://gfx-ci.igk.intel.com:8080/job/CI_PW_kernel/180803/ (on built-in)
Patchwork
CI✗ CI.checkpatch: warning for Use drm_exec to lock TTM buffers, respin (rev3)
In reply to Natalie Vock== Series Details ==
== Series Details ==
Series: Use drm_exec to lock TTM buffers, respin (rev3)
URL : https://patchwork.freedesktop.org/series/169776/
State : warning
== Summary ==
+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master 061140b9bc586ae7f40abc1249c97e1cc72d1b9d
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit fc0b9ce5e4d5f8a044fb2fbe42719a6dc8d06040
Author: Natalie Vock <[email protected]> Date: Mon Jul 6 12:07:52 2026 +0200
drm/amdgpu: use drm_exec during BO validation
This allows to detect deadlocks happening because of resource constraints.
Especially submissions which want to use all of GDS doesn't result in sporadic -ENOMEM any more.
+ /mt/dim checkpatch ccdb0b149a232379f321fcece3e98b7cf831c427 drm-intel 85e8a5913131 drm/exec: Add helper to bypass IGNORE_DUPLICATES flag 334e215e50be drm/ttm: replace TTMs refcount with the DRM refcount v4 -:202: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'bo->ttm != NULL' #202: FILE: drivers/gpu/drm/ttm/ttm_bo.c:286:
+ if (!dma_resv_test_signaled(&bo->base._resv, DMA_RESV_USAGE_BOOKKEEP) ||
+ (want_init_on_free() && (bo->ttm != NULL)) ||
+ bo->type == ttm_bo_type_sg ||
+ !dma_resv_trylock(bo->base.resv)) {-:203: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "bo->ttm" #203: FILE: drivers/gpu/drm/ttm/ttm_bo.c:287:
+ (want_init_on_free() && (bo->ttm != NULL)) ||
total: 0 errors, 0 warnings, 2 checks, 386 lines checked 1100f3595cc7 drm/ttm: remove ttm_lru_walk_ops43cc4c5dcddf drm/ttm: grab BO reference before locking it 4b7180893669 drm/ttm: switch to ttm_bo_lru_for_each_reserved_guarded for swapout 3a9767d184ad drm/ttm: move zombie handling into ttm_bo_evict a22217fbc787 drm/ttm: use ttm_bo_lru_for_each_reserved_guarded in evict_all 4d4ad1356d05 drm/xe: remove workaround for TTM internals 3c8ad854c542 drm/ttm: support using drm_exec during eviction v4 fc0b9ce5e4d5 drm/amdgpu: use drm_exec during BO validation
Patchwork
CI✗ CI.KUnit: failure for Use drm_exec to lock TTM buffers, respin (rev3)
In reply to Natalie Vock== Series Details ==
== Series Details ==
Series: Use drm_exec to lock TTM buffers, respin (rev3)
URL : https://patchwork.freedesktop.org/series/169776/
State : failure
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [14:41:23] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:41:27] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
../drivers/gpu/drm/xe/xe_pt.c:1430:13: warning: ‘xe_pt_svm_userptr_notifier_lock’ defined but not used [-Wunused-function]
1430 | static void xe_pt_svm_userptr_notifier_lock(struct xe_vm *vm)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[14:41:59] Starting KUnit Kernel (1/1)...
[14:41:59] ============================================================ Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [14:42:00] ================== guc_buf (11 subtests) =================== [14:42:00] [PASSED] test_smallest [14:42:00] [PASSED] test_largest [14:42:00] [PASSED] test_granular [14:42:00] [PASSED] test_unique [14:42:00] [PASSED] test_overlap [14:42:00] [PASSED] test_reusable [14:42:00] [PASSED] test_too_big [14:42:00] [PASSED] test_flush [14:42:00] [PASSED] test_lookup [14:42:00] [PASSED] test_data [14:42:00] [PASSED] test_class [14:42:00] ===================== [PASSED] guc_buf ===================== [14:42:00] =================== guc_dbm (7 subtests) =================== [14:42:00] [PASSED] test_empty [14:42:00] [PASSED] test_default [14:42:00] ======================== test_size ======================== [14:42:00] [PASSED] 4 [14:42:00] [PASSED] 8 [14:42:00] [PASSED] 32 [14:42:00] [PASSED] 256 [14:42:00] ==================== [PASSED] test_size ==================== [14:42:00] ======================= test_reuse ======================== [14:42:00] [PASSED] 4 [14:42:00] [PASSED] 8 [14:42:00] [PASSED] 32 [14:42:00] [PASSED] 256 [14:42:00] =================== [PASSED] test_reuse ==================== [14:42:00] =================== test_range_overlap ==================== [14:42:00] [PASSED] 4 [14:42:00] [PASSED] 8 [14:42:00] [PASSED] 32 [14:42:00] [PASSED] 256 [14:42:00] =============== [PASSED] test_range_overlap ================ [14:42:00] =================== test_range_compact ==================== [14:42:00] [PASSED] 4 [14:42:00] [PASSED] 8 [14:42:00] [PASSED] 32 [14:42:00] [PASSED] 256 [14:42:00] =============== [PASSED] test_range_compact ================ [14:42:00] ==================== test_range_spare ===================== [14:42:00] [PASSED] 4 [14:42:00] [PASSED] 8 [14:42:00] [PASSED] 32 [14:42:00] [PASSED] 256 [14:42:00] ================ [PASSED] test_range_spare ================= [14:42:00] ===================== [PASSED] guc_dbm ===================== [14:42:00] =================== guc_idm (6 subtests) =================== [14:42:00] [PASSED] bad_init [14:42:00] [PASSED] no_init [14:42:00] [PASSED] init_fini [14:42:00] [PASSED] check_used [14:42:00] [PASSED] check_quota [14:42:00] [PASSED] check_all [14:42:00] ===================== [PASSED] guc_idm ===================== [14:42:00] ================== no_relay (3 subtests) =================== [14:42:00] [PASSED] xe_drops_guc2pf_if_not_ready [14:42:00] [PASSED] xe_drops_guc2vf_if_not_ready [14:42:00] [PASSED] xe_rejects_send_if_not_ready [14:42:00] ==================== [PASSED] no_relay ===================== [14:42:00] ================== pf_relay (14 subtests) ================== [14:42:00] [PASSED] pf_rejects_guc2pf_too_short [14:42:00] [PASSED] pf_rejects_guc2pf_too_long [14:42:00] [PASSED] pf_rejects_guc2pf_no_payload [14:42:00] [PASSED] pf_fails_no_payload [14:42:00] [PASSED] pf_fails_bad_origin [14:42:00] [PASSED] pf_fails_bad_type [14:42:00] [PASSED] pf_txn_reports_error [14:42:00] [PASSED] pf_txn_sends_pf2guc [14:42:00] [PASSED] pf_sends_pf2guc [14:42:00] [SKIPPED] pf_loopback_nop (requires CONFIG_DRM_XE_DEBUG_SRIOV) [14:42:00] [SKIPPED] pf_loopback_echo (requires CONFIG_DRM_XE_DEBUG_SRIOV) [14:42:00] [SKIPPED] pf_loopback_fail (requires CONFIG_DRM_XE_DEBUG_SRIOV) [14:42:00] [SKIPPED] pf_loopback_busy (requires CONFIG_DRM_XE_DEBUG_SRIOV) [14:42:00] [SKIPPED] pf_loopback_retry (requires CONFIG_DRM_XE_DEBUG_SRIOV) [14:42:00] ==================== [PASSED] pf_relay ===================== [14:42:00] ================== vf_relay (3 subtests) =================== [14:42:00] [PASSED] vf_rejects_guc2vf_too_short [14:42:00] [PASSED] vf_rejects_guc2vf_too_long [14:42:00] [PASSED] vf_rejects_guc2vf_no_payload [14:42:00] ==================== [PASSED] vf_relay ===================== [14:42:00] ================ pf_gt_config (9 subtests) ================= [14:42:00] [PASSED] fair_contexts_1vf [14:42:00] [PASSED] fair_doorbells_1vf [14:42:00] [PASSED] fair_ggtt_1vf [14:42:00] ====================== fair_vram_1vf ====================== [14:42:00] [PASSED] 3.50 GiB [14:42:00] [PASSED] 11.5 GiB [14:42:00] [PASSED] 15.5 GiB [14:42:00] [PASSED] 31.5 GiB [14:42:00] [PASSED] 63.5 GiB [14:42:00] [PASSED] 1.91 GiB [14:42:00] ================== [PASSED] fair_vram_1vf ================== [14:42:00] ================ fair_vram_1vf_admin_only ================= [14:42:00] [PASSED] 3.50 GiB [14:42:00] [PASSED] 11.5 GiB [14:42:00] [PASSED] 15.5 GiB [14:42:00] [PASSED] 31.5 GiB [14:42:00] [PASSED] 63.5 GiB [14:42:00] [PASSED] 1.91 GiB [14:42:00] ============ [PASSED] fair_vram_1vf_admin_only ============= [14:42:00] ====================== fair_contexts ====================== [14:42:00] [PASSED] 1 VF [14:42:00] [PASSED] 2 VFs [14:42:00] [PASSED] 3 VFs [14:42:00] [PASSED] 4 VFs [14:42:00] [PASSED] 5 VFs [14:42:00] [PASSED] 6 VFs [14:42:00] [PASSED] 7 VFs [14:42:00] [PASSED] 8 VFs [14:42:00] [PASSED] 9 VFs [14:42:00] [PASSED] 10 VFs [14:42:00] [PASSED] 11 VFs [14:42:00] [PASSED] 12 VFs [14:42:00] [PASSED] 13 VFs [14:42:00] [PASSED] 14 VFs [14:42:00] [PASSED] 15 VFs [14:42:00] [PASSED] 16 VFs [14:42:00] [PASSED] 17 VFs [14:42:00] [PASSED] 18 VFs [14:42:00] [PASSED] 19 VFs [14:42:00] [PASSED] 20 VFs [14:42:00] [PASSED] 21 VFs [14:42:00] [PASSED] 22 VFs [14:42:00] [PASSED] 23 VFs [14:42:00] [PASSED] 24 VFs [14:42:00] [PASSED] 25 VFs [14:42:00] [PASSED] 26 VFs [14:42:00] [PASSED] 27 VFs [14:42:00] [PASSED] 28 VFs [14:42:00] [PASSED] 29 VFs [14:42:00] [PASSED] 30 VFs [14:42:00] [PASSED] 31 VFs [14:42:00] [PASSED] 32 VFs [14:42:00] [PASSED] 33 VFs [14:42:00] [PASSED] 34 VFs [14:42:00] [PASSED] 35 VFs [14:42:00] [PASSED] 36 VFs [14:42:00] [PASSED] 37 VFs [14:42:00] [PASSED] 38 VFs [14:42:00] [PASSED] 39 VFs [14:42:00] [PASSED] 40 VFs [14:42:00] [PASSED] 41 VFs [14:42:00] [PASSED] 42 VFs [14:42:00] [PASSED] 43 VFs [14:42:00] [PASSED] 44 VFs [14:42:00] [PASSED] 45 VFs [14:42:00] [PASSED] 46 VFs [14:42:00] [PASSED] 47 VFs [14:42:00] [PASSED] 48 VFs [14:42:00] [PASSED] 49 VFs [14:42:00] [PASSED] 50 VFs [14:42:00] [PASSED] 51 VFs [14:42:00] [PASSED] 52 VFs [14:42:00] [PASSED] 53 VFs [14:42:00] [PASSED] 54 VFs [14:42:00] [PASSED] 55 VFs [14:42:00] [PASSED] 56 VFs [14:42:00] [PASSED] 57 VFs [14:42:00] [PASSED] 58 VFs [14:42:00] [PASSED] 59 VFs [14:42:00] [PASSED] 60 VFs [14:42:00] [PASSED] 61 VFs [14:42:00] [PASSED] 62 VFs [14:42:00] [PASSED] 63 VFs [14:42:00] ================== [PASSED] fair_contexts ================== [14:42:00] ===================== fair_doorbells ====================== [14:42:00] [PASSED] 1 VF [14:42:00] [PASSED] 2 VFs [14:42:00] [PASSED] 3 VFs [14:42:00] [PASSED] 4 VFs [14:42:00] [PASSED] 5 VFs [14:42:00] [PASSED] 6 VFs [14:42:00] [PASSED] 7 VFs [14:42:00] [PASSED] 8 VFs [14:42:00] [PASSED] 9 VFs [14:42:00] [PASSED] 10 VFs [14:42:00] [PASSED] 11 VFs [14:42:00] [PASSED] 12 VFs [14:42:00] [PASSED] 13 VFs [14:42:00] [PASSED] 14 VFs [14:42:00] [PASSED] 15 VFs [14:42:00] [PASSED] 16 VFs [14:42:00] [PASSED] 17 VFs [14:42:00] [PASSED] 18 VFs [14:42:00] [PASSED] 19 VFs [14:42:00] [PASSED] 20 VFs [14:42:00] [PASSED] 21 VFs [14:42:00] [PASSED] 22 VFs [14:42:00] [PASSED] 23 VFs [14:42:00] [PASSED] 24 VFs [14:42:00] [PASSED] 25 VFs [14:42:00] [PASSED] 26 VFs [14:42:00] [PASSED] 27 VFs [14:42:00] [PASSED] 28 VFs [14:42:00] [PASSED] 29 VFs [14:42:00] [PASSED] 30 VFs [14:42:00] [PASSED] 31 VFs [14:42:00] [PASSED] 32 VFs [14:42:00] [PASSED] 33 VFs [14:42:00] [PASSED] 34 VFs [14:42:00] [PASSED] 35 VFs [14:42:00] [PASSED] 36 VFs [14:42:00] [PASSED] 37 VFs [14:42:00] [PASSED] 38 VFs [14:42:00] [PASSED] 39 VFs [14:42:00] [PASSED] 40 VFs [14:42:00] [PASSED] 41 VFs [14:42:00] [PASSED] 42 VFs [14:42:00] [PASSED] 43 VFs [14:42:00] [PASSED] 44 VFs [14:42:00] [PASSED] 45 VFs [14:42:00] [PASSED] 46 VFs [14:42:00] [PASSED] 47 VFs [14:42:00] [PASSED] 48 VFs [14:42:00] [PASSED] 49 VFs [14:42:00] [PASSED] 50 VFs [14:42:00] [PASSED] 51 VFs [14:42:00] [PASSED] 52 VFs [14:42:00] [PASSED] 53 VFs [14:42:00] [PASSED] 54 VFs [14:42:00] [PASSED] 55 VFs [14:42:00] [PASSED] 56 VFs [14:42:00] [PASSED] 57 VFs [14:42:00] [PASSED] 58 VFs [14:42:00] [PASSED] 59 VFs [14:42:00] [PASSED] 60 VFs [14:42:00] [PASSED] 61 VFs [14:42:00] [PASSED] 62 VFs [14:42:00] [PASSED] 63 VFs [14:42:00] ================= [PASSED] fair_doorbells ================== [14:42:00] ======================== fair_ggtt ======================== [14:42:00] [PASSED] 1 VF [14:42:00] [PASSED] 2 VFs [14:42:00] [PASSED] 3 VFs [14:42:00] [PASSED] 4 VFs [14:42:00] [PASSED] 5 VFs [14:42:00] [PASSED] 6 VFs [14:42:00] [PASSED] 7 VFs [14:42:00] [PASSED] 8 VFs [14:42:00] [PASSED] 9 VFs [14:42:00] [PASSED] 10 VFs [14:42:00] [PASSED] 11 VFs [14:42:00] [PASSED] 12 VFs [14:42:00] [PASSED] 13 VFs [14:42:00] [PASSED] 14 VFs [14:42:00] [PASSED] 15 VFs [14:42:00] [PASSED] 16 VFs [14:42:00] [PASSED] 17 VFs [14:42:00] [PASSED] 18 VFs [14:42:00] [PASSED] 19 VFs [14:42:00] [PASSED] 20 VFs [14:42:00] [PASSED] 21 VFs [14:42:00] [PASSED] 22 VFs [14:42:00] [PASSED] 23 VFs [14:42:00] [PASSED] 24 VFs [14:42:00] [PASSED] 25 VFs [14:42:00] [PASSED] 26 VFs [14:42:00] [PASSED] 27 VFs [14:42:00] [PASSED] 28 VFs [14:42:00] [PASSED] 29 VFs [14:42:00] [PASSED] 30 VFs [14:42:00] [PASSED] 31 VFs [14:42:00] [PASSED] 32 VFs [14:42:00] [PASSED] 33 VFs [14:42:00] [PASSED] 34 VFs [14:42:00] [PASSED] 35 VFs [14:42:00] [PASSED] 36 VFs [14:42:00] [PASSED] 37 VFs [14:42:00] [PASSED] 38 VFs [14:42:00] [PASSED] 39 VFs [14:42:00] [PASSED] 40 VFs [14:42:00] [PASSED] 41 VFs [14:42:00] [PASSED] 42 VFs [14:42:00] [PASSED] 43 VFs [14:42:00] [PASSED] 44 VFs [14:42:00] [PASSED] 45 VFs [14:42:00] [PASSED] 46 VFs [14:42:00] [PASSED] 47 VFs [14:42:00] [PASSED] 48 VFs [14:42:00] [PASSED] 49 VFs [14:42:00] [PASSED] 50 VFs [14:42:00] [PASSED] 51 VFs [14:42:00] [PASSED] 52 VFs [14:42:00] [PASSED] 53 VFs [14:42:00] [PASSED] 54 VFs [14:42:00] [PASSED] 55 VFs [14:42:00] [PASSED] 56 VFs [14:42:00] [PASSED] 57 VFs [14:42:00] [PASSED] 58 VFs [14:42:00] [PASSED] 59 VFs [14:42:00] [PASSED] 60 VFs [14:42:00] [PASSED] 61 VFs [14:42:00] [PASSED] 62 VFs [14:42:00] [PASSED] 63 VFs [14:42:00] ==================== [PASSED] fair_ggtt ==================== [14:42:00] ======================== fair_vram ======================== [14:42:00] [PASSED] 1 VF [14:42:00] [PASSED] 2 VFs [14:42:00] [PASSED] 3 VFs [14:42:00] [PASSED] 4 VFs [14:42:00] [PASSED] 5 VFs [14:42:00] [PASSED] 6 VFs [14:42:00] [PASSED] 7 VFs [14:42:00] [PASSED] 8 VFs [14:42:00] [PASSED] 9 VFs [14:42:00] [PASSED] 10 VFs [14:42:00] [PASSED] 11 VFs [14:42:00] [PASSED] 12 VFs [14:42:00] [PASSED] 13 VFs [14:42:00] [PASSED] 14 VFs [14:42:00] [PASSED] 15 VFs [14:42:00] [PASSED] 16 VFs [14:42:00] [PASSED] 17 VFs [14:42:00] [PASSED] 18 VFs [14:42:00] [PASSED] 19 VFs [14:42:00] [PASSED] 20 VFs [14:42:00] [PASSED] 21 VFs [14:42:00] [PASSED] 22 VFs [14:42:00] [PASSED] 23 VFs [14:42:00] [PASSED] 24 VFs [14:42:00] [PASSED] 25 VFs [14:42:00] [PASSED] 26 VFs [14:42:00] [PASSED] 27 VFs [14:42:00] [PASSED] 28 VFs [14:42:00] [PASSED] 29 VFs [14:42:00] [PASSED] 30 VFs [14:42:00] [PASSED] 31 VFs [14:42:00] [PASSED] 32 VFs [14:42:00] [PASSED] 33 VFs [14:42:00] [PASSED] 34 VFs [14:42:00] [PASSED] 35 VFs [14:42:00] [PASSED] 36 VFs [14:42:00] [PASSED] 37 VFs [14:42:00] [PASSED] 38 VFs [14:42:00] [PASSED] 39 VFs [14:42:00] [PASSED] 40 VFs [14:42:00] [PASSED] 41 VFs [14:42:00] [PASSED] 42 VFs [14:42:00] [PASSED] 43 VFs [14:42:00] [PASSED] 44 VFs [14:42:00] [PASSED] 45 VFs [14:42:00] [PASSED] 46 VFs [14:42:00] [PASSED] 47 VFs [14:42:00] [PASSED] 48 VFs [14:42:00] [PASSED] 49 VFs [14:42:00] [PASSED] 50 VFs [14:42:00] [PASSED] 51 VFs [14:42:00] [PASSED] 52 VFs [14:42:00] [PASSED] 53 VFs [14:42:00] [PASSED] 54 VFs [14:42:00] [PASSED] 55 VFs [14:42:00] [PASSED] 56 VFs [14:42:00] [PASSED] 57 VFs [14:42:00] [PASSED] 58 VFs [14:42:00] [PASSED] 59 VFs [14:42:00] [PASSED] 60 VFs [14:42:00] [PASSED] 61 VFs [14:42:00] [PASSED] 62 VFs [14:42:00] [PASSED] 63 VFs [14:42:00] ==================== [PASSED] fair_vram ==================== [14:42:00] ================== [PASSED] pf_gt_config =================== [14:42:00] ===================== lmtt (1 subtest) ===================== [14:42:00] ======================== test_ops ========================= [14:42:00] [PASSED] 2-level [14:42:00] [PASSED] multi-level [14:42:00] ==================== [PASSED] test_ops ===================== [14:42:00] ====================== [PASSED] lmtt ======================= [14:42:00] ================= pf_service (11 subtests) ================= [14:42:00] [PASSED] pf_negotiate_any [14:42:00] [PASSED] pf_negotiate_base_match [14:42:00] [PASSED] pf_negotiate_base_newer [14:42:00] [PASSED] pf_negotiate_base_next [14:42:00] [SKIPPED] pf_negotiate_base_older (no older minor) [14:42:00] [PASSED] pf_negotiate_base_prev [14:42:00] [PASSED] pf_negotiate_latest_match [14:42:00] [PASSED] pf_negotiate_latest_newer [14:42:00] [PASSED] pf_negotiate_latest_next [14:42:00] [SKIPPED] pf_negotiate_latest_older (no older minor) [14:42:00] [SKIPPED] pf_negotiate_latest_prev (no prev major) [14:42:00] =================== [PASSED] pf_service ==================== [14:42:00] ================= xe_guc_g2g (2 subtests) ================== [14:42:00] ============== xe_live_guc_g2g_kunit_default ============== [14:42:00] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [14:42:00] ============== xe_live_guc_g2g_kunit_allmem =============== [14:42:00] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [14:42:00] =================== [SKIPPED] xe_guc_g2g =================== [14:42:00] =================== xe_mocs (2 subtests) =================== [14:42:00] ================ xe_live_mocs_kernel_kunit ================ [14:42:00] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [14:42:00] ================ xe_live_mocs_reset_kunit ================= [14:42:00] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [14:42:00] ==================== [SKIPPED] xe_mocs ===================== [14:42:00] ================= xe_migrate (2 subtests) ================== [14:42:00] ================= xe_migrate_sanity_kunit ================= [14:42:00] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [14:42:00] ================== xe_validate_ccs_kunit ================== [14:42:00] ============= [SKIPPED] xe_validate_ccs_kunit ============== [14:42:00] =================== [SKIPPED] xe_migrate =================== [14:42:00] ================== xe_dma_buf (1 subtest) ================== [14:42:00] ==================== xe_dma_buf_kunit ===================== [14:42:00] ================ [SKIPPED] xe_dma_buf_kunit ================ [14:42:00] =================== [SKIPPED] xe_dma_buf =================== [14:42:00] ================= xe_bo_shrink (1 subtest) ================= [14:42:00] =================== xe_bo_shrink_kunit ==================== [14:42:00] =============== [SKIPPED] xe_bo_shrink_kunit =============== [14:42:00] ================== [SKIPPED] xe_bo_shrink ================== [14:42:00] ==================== xe_bo (2 subtests) ==================== [14:42:00] ================== xe_ccs_migrate_kunit =================== [14:42:00] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [14:42:00] ==================== xe_bo_evict_kunit ==================== [14:42:00] =============== [SKIPPED] xe_bo_evict_kunit ================ [14:42:00] ===================== [SKIPPED] xe_bo ====================== [14:42:00] ==================== args (13 subtests) ==================== [14:42:00] [PASSED] count_args_test [14:42:00] [PASSED] call_args_example [14:42:00] [PASSED] call_args_test [14:42:00] [PASSED] drop_first_arg_example [14:42:00] [PASSED] drop_first_arg_test [14:42:00] [PASSED] first_arg_example [14:42:00] [PASSED] first_arg_test [14:42:00] [PASSED] last_arg_example [14:42:00] [PASSED] last_arg_test [14:42:00] [PASSED] pick_arg_example [14:42:00] [PASSED] if_args_example [14:42:00] [PASSED] if_args_test [14:42:00] [PASSED] sep_comma_example [14:42:00] ====================== [PASSED] args ======================= [14:42:00] =================== xe_pci (3 subtests) ==================== [14:42:00] ==================== check_graphics_ip ==================== [14:42:00] [PASSED] 12.00 Xe_LP [14:42:00] [PASSED] 12.10 Xe_LP+ [14:42:00] [PASSED] 12.55 Xe_HPG [14:42:00] [PASSED] 12.60 Xe_HPC [14:42:00] [PASSED] 12.70 Xe_LPG [14:42:00] [PASSED] 12.71 Xe_LPG [14:42:00] [PASSED] 12.74 Xe_LPG+ [14:42:00] [PASSED] 20.01 Xe2_HPG [14:42:00] [PASSED] 20.02 Xe2_HPG [14:42:00] [PASSED] 20.04 Xe2_LPG [14:42:00] [PASSED] 30.00 Xe3_LPG [14:42:00] [PASSED] 30.01 Xe3_LPG [14:42:00] [PASSED] 30.03 Xe3_LPG [14:42:00] [PASSED] 30.04 Xe3_LPG [14:42:00] [PASSED] 30.05 Xe3_LPG [14:42:00] [PASSED] 35.10 Xe3p_LPG [14:42:00] [PASSED] 35.11 Xe3p_XPC [14:42:00] ================ [PASSED] check_graphics_ip ================ [14:42:00] ===================== check_media_ip ====================== [14:42:00] [PASSED] 12.00 Xe_M [14:42:00] [PASSED] 12.55 Xe_HPM [14:42:00] [PASSED] 13.00 Xe_LPM+ [14:42:00] [PASSED] 13.01 Xe2_HPM [14:42:00] [PASSED] 20.00 Xe2_LPM [14:42:00] [PASSED] 30.00 Xe3_LPM [14:42:00] [PASSED] 30.02 Xe3_LPM [14:42:00] [PASSED] 35.00 Xe3p_LPM [14:42:00] [PASSED] 35.03 Xe3p_HPM [14:42:00] ================= [PASSED] check_media_ip ================== [14:42:00] =================== check_platform_desc =================== [14:42:00] [PASSED] 0x9A60 (TIGERLAKE) [14:42:00] [PASSED] 0x9A68 (TIGERLAKE) [14:42:00] [PASSED] 0x9A70 (TIGERLAKE) [14:42:00] [PASSED] 0x9A40 (TIGERLAKE) [14:42:00] [PASSED] 0x9A49 (TIGERLAKE) [14:42:00] [PASSED] 0x9A59 (TIGERLAKE) [14:42:00] [PASSED] 0x9A78 (TIGERLAKE) [14:42:00] [PASSED] 0x9AC0 (TIGERLAKE) [14:42:00] [PASSED] 0x9AC9 (TIGERLAKE) [14:42:00] [PASSED] 0x9AD9 (TIGERLAKE) [14:42:00] [PASSED] 0x9AF8 (TIGERLAKE) [14:42:00] [PASSED] 0x4C80 (ROCKETLAKE) [14:42:00] [PASSED] 0x4C8A (ROCKETLAKE) [14:42:00] [PASSED] 0x4C8B (ROCKETLAKE) [14:42:00] [PASSED] 0x4C8C (ROCKETLAKE) [14:42:00] [PASSED] 0x4C90 (ROCKETLAKE) [14:42:00] [PASSED] 0x4C9A (ROCKETLAKE) [14:42:00] [PASSED] 0x4680 (ALDERLAKE_S) [14:42:00] [PASSED] 0x4682 (ALDERLAKE_S) [14:42:00] [PASSED] 0x4688 (ALDERLAKE_S) [14:42:00] [PASSED] 0x468A (ALDERLAKE_S) [14:42:00] [PASSED] 0x468B (ALDERLAKE_S) [14:42:00] [PASSED] 0x4690 (ALDERLAKE_S) [14:42:00] [PASSED] 0x4692 (ALDERLAKE_S) [14:42:00] [PASSED] 0x4693 (ALDERLAKE_S) [14:42:00] [PASSED] 0x46A0 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46A1 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46A2 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46A3 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46A6 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46A8 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46AA (ALDERLAKE_P) [14:42:00] [PASSED] 0x462A (ALDERLAKE_P) [14:42:00] [PASSED] 0x4626 (ALDERLAKE_P) [14:42:00] [PASSED] 0x4628 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46B0 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46B1 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46B2 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46B3 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46C0 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46C1 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46C2 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46C3 (ALDERLAKE_P) [14:42:00] [PASSED] 0x46D0 (ALDERLAKE_N) [14:42:00] [PASSED] 0x46D1 (ALDERLAKE_N) [14:42:00] [PASSED] 0x46D2 (ALDERLAKE_N) [14:42:00] [PASSED] 0x46D3 (ALDERLAKE_N) [14:42:00] [PASSED] 0x46D4 (ALDERLAKE_N) [14:42:00] [PASSED] 0xA721 (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7A1 (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7A9 (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7AC (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7AD (ALDERLAKE_P) [14:42:00] [PASSED] 0xA720 (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7A0 (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7A8 (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7AA (ALDERLAKE_P) [14:42:00] [PASSED] 0xA7AB (ALDERLAKE_P) [14:42:00] [PASSED] 0xA780 (ALDERLAKE_S) [14:42:00] [PASSED] 0xA781 (ALDERLAKE_S) [14:42:00] [PASSED] 0xA782 (ALDERLAKE_S) [14:42:00] [PASSED] 0xA783 (ALDERLAKE_S) [14:42:00] [PASSED] 0xA788 (ALDERLAKE_S) [14:42:00] [PASSED] 0xA789 (ALDERLAKE_S) [14:42:00] [PASSED] 0xA78A (ALDERLAKE_S) [14:42:00] [PASSED] 0xA78B (ALDERLAKE_S) [14:42:00] [PASSED] 0x4905 (DG1) [14:42:00] [PASSED] 0x4906 (DG1) [14:42:00] [PASSED] 0x4907 (DG1) [14:42:00] [PASSED] 0x4908 (DG1) [14:42:00] [PASSED] 0x4909 (DG1) [14:42:00] [PASSED] 0x56C0 (DG2) [14:42:00] [PASSED] 0x56C2 (DG2) [14:42:00] [PASSED] 0x56C1 (DG2) [14:42:00] [PASSED] 0x7D51 (METEORLAKE) [14:42:00] [PASSED] 0x7DD1 (METEORLAKE) [14:42:00] [PASSED] 0x7D41 (METEORLAKE) [14:42:00] [PASSED] 0x7D67 (METEORLAKE) [14:42:00] [PASSED] 0xB640 (METEORLAKE) [14:42:00] [PASSED] 0x56A0 (DG2) [14:42:00] [PASSED] 0x56A1 (DG2) [14:42:00] [PASSED] 0x56A2 (DG2) [14:42:00] [PASSED] 0x56BE (DG2) [14:42:00] [PASSED] 0x56BF (DG2) [14:42:00] [PASSED] 0x5690 (DG2) [14:42:00] [PASSED] 0x5691 (DG2) [14:42:00] [PASSED] 0x5692 (DG2) [14:42:00] [PASSED] 0x56A5 (DG2) [14:42:00] [PASSED] 0x56A6 (DG2) [14:42:00] [PASSED] 0x56B0 (DG2) [14:42:00] [PASSED] 0x56B1 (DG2) [14:42:00] [PASSED] 0x56BA (DG2) [14:42:00] [PASSED] 0x56BB (DG2) [14:42:00] [PASSED] 0x56BC (DG2) [14:42:00] [PASSED] 0x56BD (DG2) [14:42:00] [PASSED] 0x5693 (DG2) [14:42:00] [PASSED] 0x5694 (DG2) [14:42:00] [PASSED] 0x5695 (DG2) [14:42:00] [PASSED] 0x56A3 (DG2) [14:42:00] [PASSED] 0x56A4 (DG2) [14:42:00] [PASSED] 0x56B2 (DG2) [14:42:00] [PASSED] 0x56B3 (DG2) [14:42:00] [PASSED] 0x5696 (DG2) [14:42:00] [PASSED] 0x5697 (DG2) [14:42:00] [PASSED] 0xB69 (PVC) [14:42:00] [PASSED] 0xB6E (PVC) [14:42:00] [PASSED] 0xBD4 (PVC) [14:42:00] [PASSED] 0xBD5 (PVC) [14:42:00] [PASSED] 0xBD6 (PVC) [14:42:00] [PASSED] 0xBD7 (PVC) [14:42:00] [PASSED] 0xBD8 (PVC) [14:42:00] [PASSED] 0xBD9 (PVC) [14:42:00] [PASSED] 0xBDA (PVC) [14:42:00] [PASSED] 0xBDB (PVC) [14:42:00] [PASSED] 0xBE0 (PVC) [14:42:00] [PASSED] 0xBE1 (PVC) [14:42:00] [PASSED] 0xBE5 (PVC) [14:42:00] [PASSED] 0x7D40 (METEORLAKE) [14:42:00] [PASSED] 0x7D45 (METEORLAKE) [14:42:00] [PASSED] 0x7D55 (METEORLAKE) [14:42:00] [PASSED] 0x7D60 (METEORLAKE) [14:42:00] [PASSED] 0x7DD5 (METEORLAKE) [14:42:00] [PASSED] 0x6420 (LUNARLAKE) [14:42:00] [PASSED] 0x64A0 (LUNARLAKE) [14:42:00] [PASSED] 0x64B0 (LUNARLAKE) [14:42:00] [PASSED] 0xE202 (BATTLEMAGE) [14:42:00] [PASSED] 0xE209 (BATTLEMAGE) [14:42:00] [PASSED] 0xE20B (BATTLEMAGE) [14:42:00] [PASSED] 0xE20C (BATTLEMAGE) [14:42:00] [PASSED] 0xE20D (BATTLEMAGE) [14:42:00] [PASSED] 0xE210 (BATTLEMAGE) [14:42:00] [PASSED] 0xE211 (BATTLEMAGE) [14:42:00] [PASSED] 0xE212 (BATTLEMAGE) [14:42:00] [PASSED] 0xE216 (BATTLEMAGE) [14:42:00] [PASSED] 0xE220 (BATTLEMAGE) [14:42:00] [PASSED] 0xE221 (BATTLEMAGE) [14:42:00] [PASSED] 0xE222 (BATTLEMAGE) [14:42:00] [PASSED] 0xE223 (BATTLEMAGE) [14:42:00] [PASSED] 0xB080 (PANTHERLAKE) [14:42:00] [PASSED] 0xB081 (PANTHERLAKE) [14:42:00] [PASSED] 0xB082 (PANTHERLAKE) [14:42:00] [PASSED] 0xB083 (PANTHERLAKE) [14:42:00] [PASSED] 0xB084 (PANTHERLAKE) [14:42:00] [PASSED] 0xB085 (PANTHERLAKE) [14:42:00] [PASSED] 0xB086 (PANTHERLAKE) [14:42:00] [PASSED] 0xB087 (PANTHERLAKE) [14:42:00] [PASSED] 0xB08F (PANTHERLAKE) [14:42:00] [PASSED] 0xB090 (PANTHERLAKE) [14:42:00] [PASSED] 0xB0A0 (PANTHERLAKE) [14:42:00] [PASSED] 0xB0B0 (PANTHERLAKE) [14:42:00] [PASSED] 0xFD80 (PANTHERLAKE) [14:42:00] [PASSED] 0xFD81 (PANTHERLAKE) [14:42:00] [PASSED] 0xD740 (NOVALAKE_S) [14:42:00] [PASSED] 0xD741 (NOVALAKE_S) [14:42:00] [PASSED] 0xD742 (NOVALAKE_S) [14:42:00] [PASSED] 0xD743 (NOVALAKE_S) [14:42:00] [PASSED] 0xD745 (NOVALAKE_S) [14:42:00] [PASSED] 0xD74A (NOVALAKE_S) [14:42:00] [PASSED] 0xD74B (NOVALAKE_S) [14:42:00] [PASSED] 0x674C (CRESCENTISLAND) [14:42:00] [PASSED] 0x674D (CRESCENTISLAND) [14:42:00] [PASSED] 0x674E (CRESCENTISLAND) [14:42:00] [PASSED] 0x674F (CRESCENTISLAND) [14:42:00] [PASSED] 0x6750 (CRESCENTISLAND) [14:42:00] [PASSED] 0xD750 (NOVALAKE_P) [14:42:00] [PASSED] 0xD751 (NOVALAKE_P) [14:42:00] [PASSED] 0xD752 (NOVALAKE_P) [14:42:00] [PASSED] 0xD753 (NOVALAKE_P) [14:42:00] [PASSED] 0xD754 (NOVALAKE_P) [14:42:00] [PASSED] 0xD755 (NOVALAKE_P) [14:42:00] [PASSED] 0xD756 (NOVALAKE_P) [14:42:00] [PASSED] 0xD757 (NOVALAKE_P) [14:42:00] [PASSED] 0xD75F (NOVALAKE_P) [14:42:00] =============== [PASSED] check_platform_desc =============== [14:42:00] ===================== [PASSED] xe_pci ====================== [14:42:00] ============= xe_rtp_tables_test (5 subtests) ============== [14:42:00] ================== xe_rtp_table_gt_test =================== [14:42:00] [PASSED] gt_was/14011060649 [14:42:00] [PASSED] gt_was/14011059788 [14:42:00] [PASSED] gt_was/14015795083 [14:42:00] [PASSED] gt_was/16021867713 [14:42:00] [PASSED] gt_was/14019449301 [14:42:00] [PASSED] gt_was/16028005424 [14:42:00] [PASSED] gt_was/14026578760 [14:42:00] [PASSED] gt_was/1409420604 [14:42:00] [PASSED] gt_was/1408615072 [14:42:00] [PASSED] gt_was/22010523718 [14:42:00] [PASSED] gt_was/14011006942 [14:42:00] [PASSED] gt_was/14014830051 [14:42:00] [PASSED] gt_was/18018781329 [14:42:00] [PASSED] gt_was/1509235366 [14:42:00] [PASSED] gt_was/18018781329 [14:42:00] [PASSED] gt_was/16016694945 [14:42:00] [PASSED] gt_was/14018575942 [14:42:00] [PASSED] gt_was/22016670082 [14:42:00] [PASSED] gt_was/22016670082 [14:42:00] [PASSED] gt_was/14017421178 [14:42:00] [PASSED] gt_was/16025250150 [14:42:00] [PASSED] gt_was/14021871409 [14:42:00] [PASSED] gt_was/16021865536 [14:42:00] [PASSED] gt_was/14021486841 [14:42:00] [PASSED] gt_was/14025160223 [14:42:00] [PASSED] gt_was/14026144927, 16029437861, 14026127056 [14:42:00] [PASSED] gt_was/14025635424 [14:42:00] [PASSED] gt_was/16028005424 [14:42:00] ============== [PASSED] xe_rtp_table_gt_test =============== [14:42:00] ================== xe_rtp_table_gt_test =================== [14:42:00] [PASSED] gt_tunings/Tuning: Blend Fill Caching Optimization Disable [14:42:00] [PASSED] gt_tunings/Tuning: 32B Access Enable [14:42:00] [PASSED] gt_tunings/Tuning: L3 cache [14:42:00] [PASSED] gt_tunings/Tuning: L3 cache - media [14:42:00] [PASSED] gt_tunings/Tuning: Compression Overfetch [14:42:00] [PASSED] gt_tunings/Tuning: Compression Overfetch - media [14:42:00] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 [14:42:00] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 - media [14:42:00] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only [14:42:00] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only - media [14:42:00] [PASSED] gt_tunings/Tuning: Stateless compression control [14:42:00] [PASSED] gt_tunings/Tuning: Stateless compression control - media [14:42:00] [PASSED] gt_tunings/Tuning: L3 RW flush all Cache [14:42:00] [PASSED] gt_tunings/Tuning: L3 RW flush all cache - media [14:42:00] [PASSED] gt_tunings/Tuning: Set STLB Bank Hash Mode to 4KB [14:42:00] ============== [PASSED] xe_rtp_table_gt_test =============== [14:42:00] ================== xe_rtp_table_oob_test ================== [14:42:00] [PASSED] oob_was/1607983814 [14:42:00] [PASSED] oob_was/16010904313 [14:42:00] [PASSED] oob_was/18022495364 [14:42:00] [PASSED] oob_was/22012773006 [14:42:00] [PASSED] oob_was/14014475959 [14:42:00] [PASSED] oob_was/22011391025 [14:42:00] [PASSED] oob_was/22012727170 [14:42:00] [PASSED] oob_was/22012727685 [14:42:00] [PASSED] oob_was/22016596838 [14:42:00] [PASSED] oob_was/18020744125 [14:42:00] [PASSED] oob_was/1409600907 [14:42:00] [PASSED] oob_was/22014953428 [14:42:00] [PASSED] oob_was/16017236439 [14:42:00] [PASSED] oob_was/14019821291 [14:42:00] [PASSED] oob_was/14015076503 [14:42:00] [PASSED] oob_was/14018913170 [14:42:00] [PASSED] oob_was/14018094691 [14:42:00] [PASSED] oob_was/18024947630 [14:42:00] [PASSED] oob_was/16022287689 [14:42:00] [PASSED] oob_was/13011645652 [14:42:00] [PASSED] oob_was/14022293748 [14:42:00] [PASSED] oob_was/22019794406 [14:42:00] [PASSED] oob_was/22019338487 [14:42:00] [PASSED] oob_was/16023588340 [14:42:00] [PASSED] oob_was/14019789679 [14:42:00] [PASSED] oob_was/14022866841 [14:42:00] [PASSED] oob_was/16021333562 [14:42:00] [PASSED] oob_was/14016712196 [14:42:00] [PASSED] oob_was/14015568240 [14:42:00] [PASSED] oob_was/18013179988 [14:42:00] [PASSED] oob_was/1508761755 [14:42:00] [PASSED] oob_was/16023105232 [14:42:00] [PASSED] oob_was/16026508708 [14:42:00] [PASSED] oob_was/14020001231 [14:42:00] [PASSED] oob_was/16023683509 [14:42:00] [PASSED] oob_was/14025515070 [14:42:00] [PASSED] oob_was/15015404425_disable [14:42:00] [PASSED] oob_was/16026007364 [14:42:00] [PASSED] oob_was/14020316580 [14:42:00] [PASSED] oob_was/14025883347 [14:42:00] [PASSED] oob_was/16029380221 [14:42:00] ============== [PASSED] xe_rtp_table_oob_test ============== [14:42:00] ================ xe_rtp_table_dev_oob_test ================ [14:42:00] [PASSED] device_oob_was/22010954014 [14:42:00] [PASSED] device_oob_was/15015404425 [14:42:00] [PASSED] device_oob_was/22019338487_display [14:42:00] [PASSED] device_oob_was/14022085890 [14:42:00] [PASSED] device_oob_was/14026539277 [14:42:00] [PASSED] device_oob_was/14026633728 [14:42:00] [PASSED] device_oob_was/14026746987 [14:42:00] [PASSED] device_oob_was/14026779378 [14:42:00] ============ [PASSED] xe_rtp_table_dev_oob_test ============ [14:42:00] ========== xe_rtp_table_missing_upper_bound_test ========== [14:42:00] [PASSED] register_whitelist/WaAllowPMDepthAndInvocationCountAccessFromUMD, 1408556865 [14:42:00] [PASSED] register_whitelist/1508744258, 14012131227, 1808121037 [14:42:00] [PASSED] register_whitelist/1806527549 [14:42:00] [PASSED] register_whitelist/allow_read_ctx_timestamp [14:42:00] [PASSED] register_whitelist/allow_read_queue_timestamp [14:42:00] [PASSED] register_whitelist/16014440446 [14:42:00] [PASSED] register_whitelist/16017236439 [14:42:00] [PASSED] register_whitelist/16020183090 [14:42:00] [PASSED] register_whitelist/14024997852 [14:42:00] [PASSED] register_whitelist/14024997852 [14:42:00] ====== [PASSED] xe_rtp_table_missing_upper_bound_test ====== [14:42:00] =============== [PASSED] xe_rtp_tables_test ================ [14:42:00] =================== xe_rtp (3 subtests) ==================== [14:42:00] =================== xe_rtp_rules_tests ==================== [14:42:00] [PASSED] no [14:42:00] [PASSED] yes [14:42:00] [PASSED] no-and-no [14:42:00] [PASSED] no-and-yes [14:42:00] [PASSED] yes-and-no [14:42:00] [PASSED] yes-and-yes [14:42:00] [PASSED] no-or-no [14:42:00] [PASSED] no-or-yes [14:42:00] [PASSED] yes-or-no [14:42:00] [PASSED] yes-or-yes [14:42:00] [PASSED] no-yes-or-yes-no [14:42:00] [PASSED] no-yes-or-yes-yes [14:42:00] [PASSED] yes-yes-or-no-yes [14:42:00] [PASSED] yes-yes-or-yes-yes [14:42:00] [PASSED] no-no-or-yes-or-no [14:42:00] [PASSED] or [14:42:00] [PASSED] or-yes [14:42:00] [PASSED] or-no [14:42:00] [PASSED] yes-or [14:42:00] [PASSED] no-or [14:42:00] [PASSED] no-or-or-yes [14:42:00] [PASSED] yes-or-or-no [14:42:00] [PASSED] no-or-or-no [14:42:00] [PASSED] missing-context-engine-class [14:42:00] [PASSED] missing-context-engine-class-or-yes [14:42:00] [PASSED] missing-context-engine-class-or-or-yes [14:42:00] =============== [PASSED] xe_rtp_rules_tests ================ [14:42:00] =============== xe_rtp_process_to_sr_tests ================ [14:42:00] [PASSED] coalesce-same-reg [14:42:00] [PASSED] coalesce-same-reg-literal-and-func [14:42:00] [PASSED] no-match-no-add [14:42:00] [PASSED] two-regs-two-entries [14:42:00] [PASSED] clr-one-set-other [14:42:00] [PASSED] set-field [14:42:00] [PASSED] conflict-duplicate [14:42:00] [PASSED] conflict-not-disjoint [14:42:00] [PASSED] conflict-not-disjoint-literal-and-func [14:42:00] [PASSED] conflict-reg-type [14:42:00] [PASSED] bad-mcr-reg-forced-to-regular [14:42:00] [PASSED] bad-regular-reg-forced-to-mcr [14:42:00] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [14:42:00] ================== xe_rtp_process_tests =================== [14:42:00] [PASSED] active1 [14:42:00] [PASSED] active2 [14:42:00] [PASSED] active-inactive [14:42:00] [PASSED] inactive-active [14:42:00] [PASSED] inactive-active-inactive [14:42:00] [PASSED] inactive-inactive-inactive [14:42:00] ============== [PASSED] xe_rtp_process_tests =============== [14:42:00] ===================== [PASSED] xe_rtp ====================== [14:42:00] ==================== xe_wa (1 subtest) ===================== [14:42:00] ======================== xe_wa_gt ========================= [14:42:00] [PASSED] TIGERLAKE B0 [14:42:00] [PASSED] DG1 A0 [14:42:00] [PASSED] DG1 B0 [14:42:00] [PASSED] ALDERLAKE_S A0 [14:42:00] [PASSED] ALDERLAKE_S B0 [14:42:00] [PASSED] ALDERLAKE_S C0 [14:42:00] [PASSED] ALDERLAKE_S D0 [14:42:00] [PASSED] ALDERLAKE_P A0 [14:42:00] [PASSED] ALDERLAKE_P B0 [14:42:00] [PASSED] ALDERLAKE_P C0 [14:42:00] [PASSED] ALDERLAKE_S RPLS D0 [14:42:00] [PASSED] ALDERLAKE_P RPLU E0 [14:42:00] [PASSED] DG2 G10 C0 [14:42:00] [PASSED] DG2 G11 B1 [14:42:00] [PASSED] DG2 G12 A1 [14:42:00] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [14:42:00] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [14:42:00] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [14:42:00] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [14:42:00] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [14:42:00] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [14:42:00] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [14:42:00] ==================== [PASSED] xe_wa_gt ===================== [14:42:00] ====================== [PASSED] xe_wa ====================== [14:42:00] ============================================================ [14:42:00] Testing complete. Ran 729 tests: passed: 711, skipped: 18 [14:42:00] Elapsed time: 36.996s total, 4.410s configuring, 31.920s building, 0.654s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [14:42:00] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [14:42:02] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [14:42:26] Starting KUnit Kernel (1/1)... [14:42:26] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [14:42:26] ============ drm_test_pick_cmdline (2 subtests) ============ [14:42:26] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [14:42:26] =============== drm_test_pick_cmdline_named =============== [14:42:26] [PASSED] NTSC [14:42:26] [PASSED] NTSC-J [14:42:26] [PASSED] PAL [14:42:26] [PASSED] PAL-M [14:42:26] =========== [PASSED] drm_test_pick_cmdline_named =========== [14:42:26] ============== [PASSED] drm_test_pick_cmdline ============== [14:42:26] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [14:42:26] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [14:42:26] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [14:42:26] =========== drm_validate_clone_mode (2 subtests) =========== [14:42:26] ============== drm_test_check_in_clone_mode =============== [14:42:26] [PASSED] in_clone_mode [14:42:26] [PASSED] not_in_clone_mode [14:42:26] ========== [PASSED] drm_test_check_in_clone_mode =========== [14:42:26] =============== drm_test_check_valid_clones =============== [14:42:26] [PASSED] not_in_clone_mode [14:42:26] [PASSED] valid_clone [14:42:26] [PASSED] invalid_clone [14:42:26] =========== [PASSED] drm_test_check_valid_clones =========== [14:42:26] ============= [PASSED] drm_validate_clone_mode ============= [14:42:26] ============= drm_validate_modeset (1 subtest) ============= [14:42:26] [PASSED] drm_test_check_connector_changed_modeset [14:42:26] ============== [PASSED] drm_validate_modeset =============== [14:42:26] ====== drm_test_bridge_get_current_state (2 subtests) ====== [14:42:26] [PASSED] drm_test_drm_bridge_get_current_state_atomic [14:42:26] [PASSED] drm_test_drm_bridge_get_current_state_legacy [14:42:26] ======== [PASSED] drm_test_bridge_get_current_state ======== [14:42:26] ====== drm_test_bridge_helper_reset_crtc (4 subtests) ====== [14:42:26] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [14:42:26] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [14:42:26] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [14:42:26] [PASSED] drm_test_drm_bridge_helper_hdmi_output_bus_fmts [14:42:26] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [14:42:26] ============== drm_bridge_alloc (2 subtests) =============== [14:42:26] [PASSED] drm_test_drm_bridge_alloc_basic [14:42:26] [PASSED] drm_test_drm_bridge_alloc_get_put [14:42:26] ================ [PASSED] drm_bridge_alloc ================= [14:42:26] ============= drm_bridge_bus_fmt (5 subtests) ============== [14:42:26] [PASSED] drm_test_bridge_rgb_yuv_rgb [14:42:26] [PASSED] drm_test_bridge_must_convert_to_yuv444 [14:42:26] [PASSED] drm_test_bridge_hdmi_auto_rgb [14:42:26] [PASSED] drm_test_bridge_auto_first [14:42:26] [PASSED] drm_test_bridge_rgb_yuv_no_path [14:42:26] =============== [PASSED] drm_bridge_bus_fmt ================ [14:42:26] ============= drm_cmdline_parser (40 subtests) ============= [14:42:26] [PASSED] drm_test_cmdline_force_d_only [14:42:26] [PASSED] drm_test_cmdline_force_D_only_dvi [14:42:26] [PASSED] drm_test_cmdline_force_D_only_hdmi [14:42:26] [PASSED] drm_test_cmdline_force_D_only_not_digital [14:42:26] [PASSED] drm_test_cmdline_force_e_only [14:42:26] [PASSED] drm_test_cmdline_res [14:42:26] [PASSED] drm_test_cmdline_res_vesa [14:42:26] [PASSED] drm_test_cmdline_res_vesa_rblank [14:42:26] [PASSED] drm_test_cmdline_res_rblank [14:42:26] [PASSED] drm_test_cmdline_res_bpp [14:42:26] [PASSED] drm_test_cmdline_res_refresh [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [14:42:26] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [14:42:26] [PASSED] drm_test_cmdline_res_margins_force_on [14:42:26] [PASSED] drm_test_cmdline_res_vesa_margins [14:42:26] [PASSED] drm_test_cmdline_name [14:42:26] [PASSED] drm_test_cmdline_name_bpp [14:42:26] [PASSED] drm_test_cmdline_name_option [14:42:26] [PASSED] drm_test_cmdline_name_bpp_option [14:42:26] [PASSED] drm_test_cmdline_rotate_0 [14:42:26] [PASSED] drm_test_cmdline_rotate_90 [14:42:26] [PASSED] drm_test_cmdline_rotate_180 [14:42:26] [PASSED] drm_test_cmdline_rotate_270 [14:42:26] [PASSED] drm_test_cmdline_hmirror [14:42:26] [PASSED] drm_test_cmdline_vmirror [14:42:26] [PASSED] drm_test_cmdline_margin_options [14:42:26] [PASSED] drm_test_cmdline_multiple_options [14:42:26] [PASSED] drm_test_cmdline_bpp_extra_and_option [14:42:26] [PASSED] drm_test_cmdline_extra_and_option [14:42:26] [PASSED] drm_test_cmdline_freestanding_options [14:42:26] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [14:42:26] [PASSED] drm_test_cmdline_panel_orientation [14:42:26] ================ drm_test_cmdline_invalid ================= [14:42:26] [PASSED] margin_only [14:42:26] [PASSED] interlace_only [14:42:26] [PASSED] res_missing_x [14:42:26] [PASSED] res_missing_y [14:42:26] [PASSED] res_bad_y [14:42:26] [PASSED] res_missing_y_bpp [14:42:26] [PASSED] res_bad_bpp [14:42:26] [PASSED] res_bad_refresh [14:42:26] [PASSED] res_bpp_refresh_force_on_off [14:42:26] [PASSED] res_invalid_mode [14:42:26] [PASSED] res_bpp_wrong_place_mode [14:42:26] [PASSED] name_bpp_refresh [14:42:26] [PASSED] name_refresh [14:42:26] [PASSED] name_refresh_wrong_mode [14:42:26] [PASSED] name_refresh_invalid_mode [14:42:26] [PASSED] rotate_multiple [14:42:26] [PASSED] rotate_invalid_val [14:42:26] [PASSED] rotate_truncated [14:42:26] [PASSED] invalid_option [14:42:26] [PASSED] invalid_tv_option [14:42:26] [PASSED] truncated_tv_option [14:42:26] ============ [PASSED] drm_test_cmdline_invalid ============= [14:42:26] =============== drm_test_cmdline_tv_options =============== [14:42:26] [PASSED] NTSC [14:42:26] [PASSED] NTSC_443 [14:42:26] [PASSED] NTSC_J [14:42:26] [PASSED] PAL [14:42:26] [PASSED] PAL_M [14:42:26] [PASSED] PAL_N [14:42:26] [PASSED] SECAM [14:42:26] [PASSED] MONO_525 [14:42:26] [PASSED] MONO_625 [14:42:26] =========== [PASSED] drm_test_cmdline_tv_options =========== [14:42:26] =============== [PASSED] drm_cmdline_parser ================ [14:42:26] ========== drmm_connector_hdmi_init (20 subtests) ========== [14:42:26] [PASSED] drm_test_connector_hdmi_init_valid [14:42:26] [PASSED] drm_test_connector_hdmi_init_bpc_8 [14:42:26] [PASSED] drm_test_connector_hdmi_init_bpc_10 [14:42:26] [PASSED] drm_test_connector_hdmi_init_bpc_12 [14:42:26] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [14:42:26] [PASSED] drm_test_connector_hdmi_init_bpc_null [14:42:26] [PASSED] drm_test_connector_hdmi_init_formats_empty [14:42:26] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [14:42:26] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [14:42:26] [PASSED] supported_formats=0x9 yuv420_allowed=1 [14:42:26] [PASSED] supported_formats=0x9 yuv420_allowed=0 [14:42:26] [PASSED] supported_formats=0x5 yuv420_allowed=1 [14:42:26] [PASSED] supported_formats=0x5 yuv420_allowed=0 [14:42:26] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [14:42:26] [PASSED] drm_test_connector_hdmi_init_null_ddc [14:42:26] [PASSED] drm_test_connector_hdmi_init_null_product [14:42:26] [PASSED] drm_test_connector_hdmi_init_null_vendor [14:42:26] [PASSED] drm_test_connector_hdmi_init_product_length_exact [14:42:26] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [14:42:26] [PASSED] drm_test_connector_hdmi_init_product_valid [14:42:26] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [14:42:26] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [14:42:26] [PASSED] drm_test_connector_hdmi_init_vendor_valid [14:42:26] ========= drm_test_connector_hdmi_init_type_valid ========= [14:42:26] [PASSED] HDMI-A [14:42:26] [PASSED] HDMI-B [14:42:26] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [14:42:26] ======== drm_test_connector_hdmi_init_type_invalid ======== [14:42:26] [PASSED] Unknown [14:42:26] [PASSED] VGA [14:42:26] [PASSED] DVI-I [14:42:26] [PASSED] DVI-D [14:42:26] [PASSED] DVI-A [14:42:26] [PASSED] Composite [14:42:26] [PASSED] SVIDEO [14:42:26] [PASSED] LVDS [14:42:26] [PASSED] Component [14:42:26] [PASSED] DIN [14:42:26] [PASSED] DP [14:42:26] [PASSED] TV [14:42:26] [PASSED] eDP [14:42:26] [PASSED] Virtual [14:42:26] [PASSED] DSI [14:42:26] [PASSED] DPI [14:42:26] [PASSED] Writeback [14:42:26] [PASSED] SPI [14:42:26] [PASSED] USB [14:42:26] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [14:42:26] ============ [PASSED] drmm_connector_hdmi_init ============= [14:42:26] ============= drmm_connector_init (3 subtests) ============= [14:42:26] [PASSED] drm_test_drmm_connector_init [14:42:26] [PASSED] drm_test_drmm_connector_init_null_ddc [14:42:26] ========= drm_test_drmm_connector_init_type_valid ========= [14:42:26] [PASSED] Unknown [14:42:26] [PASSED] VGA [14:42:26] [PASSED] DVI-I [14:42:26] [PASSED] DVI-D [14:42:26] [PASSED] DVI-A [14:42:26] [PASSED] Composite [14:42:26] [PASSED] SVIDEO [14:42:26] [PASSED] LVDS [14:42:26] [PASSED] Component [14:42:26] [PASSED] DIN [14:42:26] [PASSED] DP [14:42:26] [PASSED] HDMI-A [14:42:26] [PASSED] HDMI-B [14:42:26] [PASSED] TV [14:42:26] [PASSED] eDP [14:42:26] [PASSED] Virtual [14:42:26] [PASSED] DSI [14:42:26] [PASSED] DPI [14:42:26] [PASSED] Writeback [14:42:26] [PASSED] SPI [14:42:26] [PASSED] USB [14:42:26] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [14:42:26] =============== [PASSED] drmm_connector_init =============== [14:42:26] ========= drm_connector_dynamic_init (6 subtests) ========== [14:42:26] [PASSED] drm_test_drm_connector_dynamic_init [14:42:26] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [14:42:26] [PASSED] drm_test_drm_connector_dynamic_init_not_added [14:42:26] [PASSED] drm_test_drm_connector_dynamic_init_properties [14:42:26] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [14:42:26] [PASSED] Unknown [14:42:26] [PASSED] VGA [14:42:26] [PASSED] DVI-I [14:42:26] [PASSED] DVI-D [14:42:26] [PASSED] DVI-A [14:42:26] [PASSED] Composite [14:42:26] [PASSED] SVIDEO [14:42:26] [PASSED] LVDS [14:42:26] [PASSED] Component [14:42:26] [PASSED] DIN [14:42:26] [PASSED] DP [14:42:26] [PASSED] HDMI-A [14:42:26] [PASSED] HDMI-B [14:42:26] [PASSED] TV [14:42:26] [PASSED] eDP [14:42:26] [PASSED] Virtual [14:42:26] [PASSED] DSI [14:42:26] [PASSED] DPI [14:42:26] [PASSED] Writeback [14:42:26] [PASSED] SPI [14:42:26] [PASSED] USB [14:42:26] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [14:42:26] ======== drm_test_drm_connector_dynamic_init_name ========= [14:42:26] [PASSED] Unknown [14:42:26] [PASSED] VGA [14:42:26] [PASSED] DVI-I [14:42:26] [PASSED] DVI-D [14:42:26] [PASSED] DVI-A [14:42:26] [PASSED] Composite [14:42:26] [PASSED] SVIDEO [14:42:26] [PASSED] LVDS [14:42:26] [PASSED] Component [14:42:26] [PASSED] DIN [14:42:26] [PASSED] DP [14:42:26] [PASSED] HDMI-A [14:42:26] [PASSED] HDMI-B [14:42:26] [PASSED] TV [14:42:26] [PASSED] eDP [14:42:26] [PASSED] Virtual [14:42:26] [PASSED] DSI [14:42:26] [PASSED] DPI [14:42:26] [PASSED] Writeback [14:42:26] [PASSED] SPI [14:42:26] [PASSED] USB [14:42:26] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [14:42:26] =========== [PASSED] drm_connector_dynamic_init ============ [14:42:26] ==== drm_connector_dynamic_register_early (4 subtests) ===== [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [14:42:26] ====== [PASSED] drm_connector_dynamic_register_early ======= [14:42:26] ======= drm_connector_dynamic_register (7 subtests) ======== [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_on_list [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_no_init [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [14:42:26] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [14:42:26] ========= [PASSED] drm_connector_dynamic_register ========== [14:42:26] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [14:42:26] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [14:42:26] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [14:42:26] === [PASSED] drm_connector_attach_broadcast_rgb_property === [14:42:26] ========== drm_get_tv_mode_from_name (2 subtests) ========== [14:42:26] ========== drm_test_get_tv_mode_from_name_valid =========== [14:42:26] [PASSED] NTSC [14:42:26] [PASSED] NTSC-443 [14:42:26] [PASSED] NTSC-J [14:42:26] [PASSED] PAL [14:42:26] [PASSED] PAL-M [14:42:26] [PASSED] PAL-N [14:42:26] [PASSED] SECAM [14:42:26] [PASSED] Mono [14:42:26] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [14:42:26] [PASSED] drm_test_get_tv_mode_from_name_truncated [14:42:26] ============ [PASSED] drm_get_tv_mode_from_name ============ [14:42:26] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [14:42:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [14:42:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [14:42:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [14:42:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [14:42:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [14:42:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [14:42:26] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [14:42:26] [PASSED] VIC 96 [14:42:26] [PASSED] VIC 97 [14:42:26] [PASSED] VIC 101 [14:42:26] [PASSED] VIC 102 [14:42:26] [PASSED] VIC 106 [14:42:26] [PASSED] VIC 107 [14:42:26] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [14:42:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [14:42:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [14:42:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [14:42:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [14:42:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [14:42:26] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [14:42:26] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [14:42:26] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [14:42:26] [PASSED] Automatic [14:42:26] [PASSED] Full [14:42:26] [PASSED] Limited 16:235 [14:42:26] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [14:42:26] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [14:42:26] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [14:42:26] == drm_hdmi_connector_get_output_format_name (2 subtests) == [14:42:26] === drm_test_drm_hdmi_connector_get_output_format_name ==== [14:42:26] [PASSED] RGB [14:42:26] [PASSED] YUV 4:2:0 [14:42:26] [PASSED] YUV 4:2:2 [14:42:26] [PASSED] YUV 4:4:4 [14:42:26] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [14:42:26] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [14:42:26] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [14:42:26] ============= drm_damage_helper (21 subtests) ============== [14:42:26] [PASSED] drm_test_damage_iter_no_damage [14:42:26] [PASSED] drm_test_damage_iter_no_damage_fractional_src [14:42:26] [PASSED] drm_test_damage_iter_no_damage_src_moved [14:42:26] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [14:42:26] [PASSED] drm_test_damage_iter_no_damage_not_visible [14:42:26] [PASSED] drm_test_damage_iter_no_damage_no_crtc [14:42:26] [PASSED] drm_test_damage_iter_no_damage_no_fb [14:42:26] [PASSED] drm_test_damage_iter_simple_damage [14:42:26] [PASSED] drm_test_damage_iter_single_damage [14:42:26] [PASSED] drm_test_damage_iter_single_damage_intersect_src [14:42:26] [PASSED] drm_test_damage_iter_single_damage_outside_src [14:42:26] [PASSED] drm_test_damage_iter_single_damage_fractional_src [14:42:26] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [14:42:26] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [14:42:26] [PASSED] drm_test_damage_iter_single_damage_src_moved [14:42:26] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [14:42:26] [PASSED] drm_test_damage_iter_damage [14:42:26] [PASSED] drm_test_damage_iter_damage_one_intersect [14:42:26] [PASSED] drm_test_damage_iter_damage_one_outside [14:42:26] [PASSED] drm_test_damage_iter_damage_src_moved [14:42:26] [PASSED] drm_test_damage_iter_damage_not_visible [14:42:26] ================ [PASSED] drm_damage_helper ================ [14:42:26] ============== drm_dp_mst_helper (3 subtests) ============== [14:42:26] ============== drm_test_dp_mst_calc_pbn_mode ============== [14:42:26] [PASSED] Clock 154000 BPP 30 DSC disabled [14:42:26] [PASSED] Clock 234000 BPP 30 DSC disabled [14:42:26] [PASSED] Clock 297000 BPP 24 DSC disabled [14:42:26] [PASSED] Clock 332880 BPP 24 DSC enabled [14:42:26] [PASSED] Clock 324540 BPP 24 DSC enabled [14:42:26] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [14:42:26] ============== drm_test_dp_mst_calc_pbn_div =============== [14:42:26] [PASSED] Link rate 2000000 lane count 4 [14:42:26] [PASSED] Link rate 2000000 lane count 2 [14:42:26] [PASSED] Link rate 2000000 lane count 1 [14:42:26] [PASSED] Link rate 1350000 lane count 4 [14:42:26] [PASSED] Link rate 1350000 lane count 2 [14:42:26] [PASSED] Link rate 1350000 lane count 1 [14:42:26] [PASSED] Link rate 1000000 lane count 4 [14:42:26] [PASSED] Link rate 1000000 lane count 2 [14:42:26] [PASSED] Link rate 1000000 lane count 1 [14:42:26] [PASSED] Link rate 810000 lane count 4 [14:42:26] [PASSED] Link rate 810000 lane count 2 [14:42:26] [PASSED] Link rate 810000 lane count 1 [14:42:26] [PASSED] Link rate 540000 lane count 4 [14:42:26] [PASSED] Link rate 540000 lane count 2 [14:42:26] [PASSED] Link rate 540000 lane count 1 [14:42:26] [PASSED] Link rate 270000 lane count 4 [14:42:26] [PASSED] Link rate 270000 lane count 2 [14:42:26] [PASSED] Link rate 270000 lane count 1 [14:42:26] [PASSED] Link rate 162000 lane count 4 [14:42:26] [PASSED] Link rate 162000 lane count 2 [14:42:26] [PASSED] Link rate 162000 lane count 1 [14:42:26] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [14:42:26] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [14:42:26] [PASSED] DP_ENUM_PATH_RESOURCES with port number [14:42:26] [PASSED] DP_POWER_UP_PHY with port number [14:42:26] [PASSED] DP_POWER_DOWN_PHY with port number [14:42:26] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [14:42:26] [PASSED] DP_ALLOCATE_PAYLOAD with port number [14:42:26] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [14:42:26] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [14:42:26] [PASSED] DP_QUERY_PAYLOAD with port number [14:42:26] [PASSED] DP_QUERY_PAYLOAD with VCPI [14:42:26] [PASSED] DP_REMOTE_DPCD_READ with port number [14:42:26] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [14:42:26] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [14:42:26] [PASSED] DP_REMOTE_DPCD_WRITE with port number [14:42:26] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [14:42:26] [PASSED] DP_REMOTE_DPCD_WRITE with data array [14:42:26] [PASSED] DP_REMOTE_I2C_READ with port number [14:42:26] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [14:42:26] [PASSED] DP_REMOTE_I2C_READ with transactions array [14:42:26] [PASSED] DP_REMOTE_I2C_WRITE with port number [14:42:26] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [14:42:26] [PASSED] DP_REMOTE_I2C_WRITE with data array [14:42:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [14:42:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [14:42:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [14:42:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [14:42:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [14:42:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [14:42:26] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [14:42:26] ================ [PASSED] drm_dp_mst_helper ================ [14:42:26] ================== drm_exec (7 subtests) =================== [14:42:26] [PASSED] sanitycheck [14:42:26] [PASSED] test_lock [14:42:26] [PASSED] test_lock_unlock [14:42:26] [PASSED] test_duplicates [14:42:26] [PASSED] test_prepare [14:42:26] [PASSED] test_prepare_array [14:42:26] [PASSED] test_multiple_loops [14:42:26] ==================== [PASSED] drm_exec ===================== [14:42:26] =========== drm_format_helper_test (17 subtests) =========== [14:42:26] ============== drm_test_fb_xrgb8888_to_gray8 ============== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [14:42:26] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [14:42:26] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [14:42:26] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [14:42:26] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [14:42:26] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [14:42:26] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [14:42:26] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [14:42:26] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [14:42:26] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [14:42:26] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [14:42:26] ============== drm_test_fb_xrgb8888_to_mono =============== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [14:42:26] ==================== drm_test_fb_swab ===================== [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ================ [PASSED] drm_test_fb_swab ================= [14:42:26] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [14:42:26] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [14:42:26] [PASSED] single_pixel_source_buffer [14:42:26] [PASSED] single_pixel_clip_rectangle [14:42:26] [PASSED] well_known_colors [14:42:26] [PASSED] destination_pitch [14:42:26] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [14:42:26] ================= drm_test_fb_clip_offset ================= [14:42:26] [PASSED] pass through [14:42:26] [PASSED] horizontal offset [14:42:26] [PASSED] vertical offset [14:42:26] [PASSED] horizontal and vertical offset [14:42:26] [PASSED] horizontal offset (custom pitch) [14:42:26] [PASSED] vertical offset (custom pitch) [14:42:26] [PASSED] horizontal and vertical offset (custom pitch) [14:42:26] ============= [PASSED] drm_test_fb_clip_offset ============= [14:42:26] =================== drm_test_fb_memcpy ==================== [14:42:26] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [14:42:26] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [14:42:26] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [14:42:26] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [14:42:26] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [14:42:26] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [14:42:26] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [14:42:26] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [14:42:26] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [14:42:26] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [14:42:26] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [14:42:26] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [14:42:26] =============== [PASSED] drm_test_fb_memcpy ================ [14:42:26] ============= [PASSED] drm_format_helper_test ============== [14:42:26] ================= drm_format (18 subtests) ================= [14:42:26] [PASSED] drm_test_format_block_width_invalid [14:42:26] [PASSED] drm_test_format_block_width_one_plane [14:42:26] [PASSED] drm_test_format_block_width_two_plane [14:42:26] [PASSED] drm_test_format_block_width_three_plane [14:42:26] [PASSED] drm_test_format_block_width_tiled [14:42:26] [PASSED] drm_test_format_block_height_invalid [14:42:26] [PASSED] drm_test_format_block_height_one_plane [14:42:26] [PASSED] drm_test_format_block_height_two_plane [14:42:26] [PASSED] drm_test_format_block_height_three_plane [14:42:26] [PASSED] drm_test_format_block_height_tiled [14:42:26] [PASSED] drm_test_format_min_pitch_invalid [14:42:26] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [14:42:26] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [14:42:26] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [14:42:26] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [14:42:26] [PASSED] drm_test_format_min_pitch_two_plane [14:42:26] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [14:42:26] [PASSED] drm_test_format_min_pitch_tiled [14:42:26] =================== [PASSED] drm_format ==================== [14:42:26] ============== drm_framebuffer (10 subtests) =============== [14:42:26] ========== drm_test_framebuffer_check_src_coords ========== [14:42:26] [PASSED] Success: source fits into fb [14:42:26] [PASSED] Fail: overflowing fb with x-axis coordinate [14:42:26] [PASSED] Fail: overflowing fb with y-axis coordinate [14:42:26] [PASSED] Fail: overflowing fb with source width [14:42:26] [PASSED] Fail: overflowing fb with source height [14:42:26] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [14:42:26] [PASSED] drm_test_framebuffer_cleanup [14:42:26] =============== drm_test_framebuffer_create =============== [14:42:26] [PASSED] ABGR8888 normal sizes [14:42:26] [PASSED] ABGR8888 max sizes [14:42:26] [PASSED] ABGR8888 pitch greater than min required [14:42:26] [PASSED] ABGR8888 pitch less than min required [14:42:26] [PASSED] ABGR8888 Invalid width [14:42:26] [PASSED] ABGR8888 Invalid buffer handle [14:42:26] [PASSED] No pixel format [14:42:26] [PASSED] ABGR8888 Width 0 [14:42:26] [PASSED] ABGR8888 Height 0 [14:42:26] [PASSED] ABGR8888 Out of bound height * pitch combination [14:42:26] [PASSED] ABGR8888 Large buffer offset [14:42:26] [PASSED] ABGR8888 Buffer offset for inexistent plane [14:42:26] [PASSED] ABGR8888 Invalid flag [14:42:26] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [14:42:26] [PASSED] ABGR8888 Valid buffer modifier [14:42:26] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [14:42:26] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] NV12 Normal sizes [14:42:26] [PASSED] NV12 Max sizes [14:42:26] [PASSED] NV12 Invalid pitch [14:42:26] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [14:42:26] [PASSED] NV12 different modifier per-plane [14:42:26] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [14:42:26] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] NV12 Modifier for inexistent plane [14:42:26] [PASSED] NV12 Handle for inexistent plane [14:42:26] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [14:42:26] [PASSED] YVU420 Normal sizes [14:42:26] [PASSED] YVU420 Max sizes [14:42:26] [PASSED] YVU420 Invalid pitch [14:42:26] [PASSED] YVU420 Different pitches [14:42:26] [PASSED] YVU420 Different buffer offsets/pitches [14:42:26] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [14:42:26] [PASSED] YVU420 Valid modifier [14:42:26] [PASSED] YVU420 Different modifiers per plane [14:42:26] [PASSED] YVU420 Modifier for inexistent plane [14:42:26] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [14:42:26] [PASSED] X0L2 Normal sizes [14:42:26] [PASSED] X0L2 Max sizes [14:42:26] [PASSED] X0L2 Invalid pitch [14:42:26] [PASSED] X0L2 Pitch greater than minimum required [14:42:26] [PASSED] X0L2 Handle for inexistent plane [14:42:26] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [14:42:26] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [14:42:26] [PASSED] X0L2 Valid modifier [14:42:26] [PASSED] X0L2 Modifier for inexistent plane [14:42:26] =========== [PASSED] drm_test_framebuffer_create =========== [14:42:26] [PASSED] drm_test_framebuffer_free [14:42:26] [PASSED] drm_test_framebuffer_init [14:42:26] [PASSED] drm_test_framebuffer_init_bad_format [14:42:26] [PASSED] drm_test_framebuffer_init_dev_mismatch [14:42:26] [PASSED] drm_test_framebuffer_lookup [14:42:26] [PASSED] drm_test_framebuffer_lookup_inexistent [14:42:26] [PASSED] drm_test_framebuffer_modifiers_not_supported [14:42:26] ================= [PASSED] drm_framebuffer ================= [14:42:26] ================ drm_gem_shmem (8 subtests) ================ [14:42:26] [PASSED] drm_gem_shmem_test_obj_create [14:42:26] [PASSED] drm_gem_shmem_test_obj_create_private [14:42:26] [PASSED] drm_gem_shmem_test_pin_pages [14:42:26] [PASSED] drm_gem_shmem_test_vmap [14:42:26] [PASSED] drm_gem_shmem_test_get_sg_table [14:42:26] [PASSED] drm_gem_shmem_test_get_pages_sgt [14:42:26] [PASSED] drm_gem_shmem_test_madvise [14:42:26] [PASSED] drm_gem_shmem_test_purge [14:42:26] ================== [PASSED] drm_gem_shmem ================== [14:42:26] === drm_atomic_helper_connector_hdmi_check (29 subtests) === [14:42:26] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [14:42:26] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [14:42:26] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [14:42:26] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [14:42:26] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [14:42:26] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [14:42:26] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [14:42:26] [PASSED] Automatic [14:42:26] [PASSED] Full [14:42:26] [PASSED] Limited 16:235 [14:42:26] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [14:42:26] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [14:42:26] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [14:42:26] [PASSED] drm_test_check_disable_connector [14:42:26] [PASSED] drm_test_check_hdmi_funcs_reject_rate [14:42:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [14:42:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [14:42:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [14:42:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [14:42:26] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [14:42:26] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [14:42:26] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [14:42:26] [PASSED] drm_test_check_output_bpc_dvi [14:42:26] [PASSED] drm_test_check_output_bpc_format_vic_1 [14:42:26] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [14:42:26] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [14:42:26] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [14:42:26] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [14:42:26] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [14:42:26] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [14:42:26] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [14:42:26] ============ drm_test_check_hdmi_color_format ============= [14:42:26] [PASSED] AUTO -> RGB [14:42:26] [PASSED] YCBCR422 -> YUV422 [14:42:26] [PASSED] YCBCR420 -> YUV420 [14:42:26] [PASSED] YCBCR444 -> YUV444 [14:42:26] [PASSED] RGB -> RGB [14:42:26] ======== [PASSED] drm_test_check_hdmi_color_format ========= [14:42:26] ======== drm_test_check_hdmi_color_format_420_only ======== [14:42:26] [PASSED] RGB should fail [14:42:26] [PASSED] YUV444 should fail [14:42:26] [PASSED] YUV422 should fail [14:42:26] [PASSED] YUV420 should work [14:42:26] ==== [PASSED] drm_test_check_hdmi_color_format_420_only ==== [14:42:26] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [14:42:26] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [14:42:26] [PASSED] drm_test_check_broadcast_rgb_value [14:42:26] [PASSED] drm_test_check_bpc_8_value [14:42:26] [PASSED] drm_test_check_bpc_10_value [14:42:26] [PASSED] drm_test_check_bpc_12_value [14:42:26] [PASSED] drm_test_check_format_value [14:42:26] [PASSED] drm_test_check_tmds_char_value [14:42:26] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [14:42:26] = drm_atomic_helper_connector_hdmi_mode_valid (7 subtests) = [14:42:26] [PASSED] drm_test_check_mode_valid [14:42:26] [PASSED] drm_test_check_mode_valid_reject [14:42:26] [PASSED] drm_test_check_mode_valid_reject_rate [14:42:26] [PASSED] drm_test_check_mode_valid_reject_max_clock [14:42:26] [PASSED] drm_test_check_mode_valid_yuv420_only_max_clock [14:42:26] [PASSED] drm_test_check_mode_valid_reject_yuv420_only_connector [14:42:26] [PASSED] drm_test_check_mode_valid_accept_yuv420_also_connector_rgb [14:42:26] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [14:42:26] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) = [14:42:26] [PASSED] drm_test_check_infoframes [14:42:26] [PASSED] drm_test_check_reject_avi_infoframe [14:42:26] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8 [14:42:26] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10 [14:42:26] [PASSED] drm_test_check_reject_audio_infoframe [14:42:26] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes === [14:42:26] ================= drm_managed (2 subtests) ================= [14:42:26] [PASSED] drm_test_managed_release_action [14:42:26] [PASSED] drm_test_managed_run_action [14:42:26] =================== [PASSED] drm_managed =================== [14:42:26] =================== drm_mm (6 subtests) ==================== [14:42:26] [PASSED] drm_test_mm_init [14:42:26] [PASSED] drm_test_mm_debug [14:42:26] [PASSED] drm_test_mm_align32 [14:42:26] [PASSED] drm_test_mm_align64 [14:42:26] [PASSED] drm_test_mm_lowest [14:42:26] [PASSED] drm_test_mm_highest [14:42:26] ===================== [PASSED] drm_mm ====================== [14:42:26] ============= drm_modes_analog_tv (5 subtests) ============= [14:42:26] [PASSED] drm_test_modes_analog_tv_mono_576i [14:42:26] [PASSED] drm_test_modes_analog_tv_ntsc_480i [14:42:26] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [14:42:26] [PASSED] drm_test_modes_analog_tv_pal_576i [14:42:26] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [14:42:26] =============== [PASSED] drm_modes_analog_tv =============== [14:42:26] ============== drm_plane_helper (2 subtests) =============== [14:42:26] =============== drm_test_check_plane_state ================ [14:42:26] [PASSED] clipping_simple [14:42:26] [PASSED] clipping_rotate_reflect [14:42:26] [PASSED] positioning_simple [14:42:26] [PASSED] upscaling [14:42:26] [PASSED] downscaling [14:42:26] [PASSED] rounding1 [14:42:26] [PASSED] rounding2 [14:42:26] [PASSED] rounding3 [14:42:26] [PASSED] rounding4 [14:42:26] =========== [PASSED] drm_test_check_plane_state ============ [14:42:26] =========== drm_test_check_invalid_plane_state ============ [14:42:26] [PASSED] positioning_invalid [14:42:26] [PASSED] upscaling_invalid [14:42:26] [PASSED] downscaling_invalid [14:42:26] ======= [PASSED] drm_test_check_invalid_plane_state ======== [14:42:26] ================ [PASSED] drm_plane_helper ================= [14:42:26] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [14:42:26] ====== drm_test_connector_helper_tv_get_modes_check ======= [14:42:26] [PASSED] None [14:42:26] [PASSED] PAL [14:42:26] [PASSED] NTSC [14:42:26] [PASSED] Both, NTSC Default [14:42:26] [PASSED] Both, PAL Default [14:42:26] [PASSED] Both, NTSC Default, with PAL on command-line [14:42:26] [PASSED] Both, PAL Default, with NTSC on command-line [14:42:26] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [14:42:26] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [14:42:26] ================== drm_rect (9 subtests) =================== [14:42:26] [PASSED] drm_test_rect_clip_scaled_div_by_zero [14:42:26] [PASSED] drm_test_rect_clip_scaled_not_clipped [14:42:26] [PASSED] drm_test_rect_clip_scaled_clipped [14:42:26] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [14:42:26] ================= drm_test_rect_intersect ================= [14:42:26] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [14:42:26] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [14:42:26] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [14:42:26] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [14:42:26] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [14:42:26] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [14:42:26] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [14:42:26] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [14:42:26] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [14:42:26] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [14:42:26] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [14:42:26] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [14:42:26] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [14:42:26] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [14:42:26] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [14:42:26] ============= [PASSED] drm_test_rect_intersect ============= [14:42:26] ================ drm_test_rect_calc_hscale ================ [14:42:26] [PASSED] normal use [14:42:26] [PASSED] out of max range [14:42:26] [PASSED] out of min range [14:42:26] [PASSED] zero dst [14:42:26] [PASSED] negative src [14:42:26] [PASSED] negative dst [14:42:26] ============ [PASSED] drm_test_rect_calc_hscale ============ [14:42:26] ================ drm_test_rect_calc_vscale ================ [14:42:26] [PASSED] normal use [14:42:26] [PASSED] out of max range [14:42:26] [PASSED] out of min range [14:42:26] [PASSED] zero dst [14:42:26] [PASSED] negative src [14:42:26] [PASSED] negative dst [14:42:26] ============ [PASSED] drm_test_rect_calc_vscale ============ [14:42:26] ================== drm_test_rect_rotate =================== [14:42:26] [PASSED] reflect-x [14:42:26] [PASSED] reflect-y [14:42:26] [PASSED] rotate-0 [14:42:26] [PASSED] rotate-90 [14:42:26] [PASSED] rotate-180 [14:42:26] [PASSED] rotate-270 [14:42:26] ============== [PASSED] drm_test_rect_rotate =============== [14:42:26] ================ drm_test_rect_rotate_inv ================= [14:42:26] [PASSED] reflect-x [14:42:26] [PASSED] reflect-y [14:42:26] [PASSED] rotate-0 [14:42:26] [PASSED] rotate-90 [14:42:26] [PASSED] rotate-180 [14:42:26] [PASSED] rotate-270 [14:42:26] ============ [PASSED] drm_test_rect_rotate_inv ============= [14:42:26] ==================== [PASSED] drm_rect ===================== [14:42:26] ============ drm_sysfb_modeset_test (1 subtest) ============ [14:42:26] ============ drm_test_sysfb_build_fourcc_list ============= [14:42:26] [PASSED] no native formats [14:42:26] [PASSED] XRGB8888 as native format [14:42:26] [PASSED] remove duplicates [14:42:26] [PASSED] convert alpha formats [14:42:26] [PASSED] random formats [14:42:26] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [14:42:26] ============= [PASSED] drm_sysfb_modeset_test ============== [14:42:26] ================== drm_fixp (2 subtests) =================== [14:42:26] [PASSED] drm_test_int2fixp [14:42:26] [PASSED] drm_test_sm2fixp [14:42:26] ==================== [PASSED] drm_fixp ===================== [14:42:26] ============================================================ [14:42:26] Testing complete. Ran 639 tests: passed: 639 [14:42:26] Elapsed time: 26.272s total, 1.847s configuring, 24.259s building, 0.147s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig ERROR:root:../drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c: In function ‘ttm_bo_validate_swapout’:../drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c:792:38: error: passing argument 1 of ‘ttm_bo_swapout’ from incompatible pointer type [-Werror=incompatible-pointer-types]
792 | swapped = ttm_bo_swapout(priv->ttm_dev, &ctx_init, man, GFP_KERNEL,
| ~~~~^~~~~~~~~
| |
| struct ttm_device *
In file included from ../drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.h:10,
from ../drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c:12:
../include/drm/ttm/ttm_bo.h:417:46: note: expected ‘struct ttm_buffer_object *’ but argument is of type ‘struct ttm_device *’
417 | s64 ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~
../drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c:792:60: warning: passing argument 3 of ‘ttm_bo_swapout’ makes integer from pointer without a cast [-Wint-conversion]
792 | swapped = ttm_bo_swapout(priv->ttm_dev, &ctx_init, man, GFP_KERNEL,
| ^~~
| |
| struct ttm_resource_manager *
../include/drm/ttm/ttm_bo.h:418:26: note: expected ‘gfp_t’ {aka ‘unsigned int’} but argument is of type ‘struct ttm_resource_manager *’
418 | gfp_t gfp_flags);
| ~~~~~~^~~~~~~~~
../drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.c:792:19: error: too many arguments to function ‘ttm_bo_swapout’
792 | swapped = ttm_bo_swapout(priv->ttm_dev, &ctx_init, man, GFP_KERNEL,
| ^~~~~~~~~~~~~~
../include/drm/ttm/ttm_bo.h:417:5: note: declared here
417 | s64 ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx,
| ^~~~~~~~~~~~~~cc1: some warnings being treated as errors
make[8]: *** [../scripts/Makefile.build:289: drivers/gpu/drm/ttm/tests/ttm_bo_validate_test.o] Error 1 make[8]: *** Waiting for unfinished jobs....
make[7]: *** [../scripts/Makefile.build:549: drivers/gpu/drm/ttm/tests] Error 2 make[7]: *** Waiting for unfinished jobs....
make[6]: *** [../scripts/Makefile.build:549: drivers/gpu/drm/ttm] Error 2
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [../scripts/Makefile.build:549: drivers/gpu/drm] Error 2
make[4]: *** [../scripts/Makefile.build:549: drivers/gpu] Error 2
make[3]: *** [../scripts/Makefile.build:549: drivers] Error 2
make[2]: *** [/kernel/Makefile:2184: .] Error 2
make[1]: *** [/kernel/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2
[14:42:27] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [14:42:28] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 + cleanup ++ stat -c %u:%g /kernel + chown -R 1003:1003 /kernel
Patchwork
CI✗ i915.CI.BAT: failure for Use drm_exec to lock TTM buffers, respin (rev3)
In reply to Natalie Vock== Series Details ==
== Series Details ==
Series: Use drm_exec to lock TTM buffers, respin (rev3)
URL : https://patchwork.freedesktop.org/series/169777/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_18771 -> Patchwork_169777v3
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_169777v3 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_169777v3, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/index.html
Participating hosts (41 -> 40)
------------------------------
Additional (1): bat-adls-6
Missing (2): bat-dg2-13 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_169777v3:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live:
- bat-dg2-8: [PASS][1] -> [ABORT][2] +1 other test abort
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-dg2-8/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-dg2-8/igt@[email protected]
* igt@i915_selftest@live@mman:
- bat-dg1-7: [PASS][3] -> [ABORT][4] +1 other test abort
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-dg1-7/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-dg1-7/igt@i915_selftest@[email protected]
- bat-dg2-9: [PASS][5] -> [ABORT][6] +1 other test abort
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-dg2-9/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-dg2-9/igt@i915_selftest@[email protected]
- bat-dg1-6: [PASS][7] -> [ABORT][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-dg1-6/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-dg1-6/igt@i915_selftest@[email protected]
- bat-dg2-14: [PASS][9] -> [ABORT][10] +1 other test abort
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-dg2-14/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-dg2-14/igt@i915_selftest@[email protected]
- bat-atsm-1: [PASS][11] -> [ABORT][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-atsm-1/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-atsm-1/igt@i915_selftest@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_18771 and Patchwork_169777v3:
### New IGT tests (12) ###
* igt@i915_selftest@addfb25-4-tiled:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@bad-pitch-0:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@bad-pitch-32:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@basic-plain-flip:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@basic-with_one_bo_two_files:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@force-connector-state:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@force-edid:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@force-load-detect:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@invalid-get-prop-any:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@size-max:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@small-bo:
- Statuses :
- Exec time: [None] s
* igt@i915_selftest@tile-pitch-mismatch:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in Patchwork_169777v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests:
- bat-adls-6: NOTRUN -> [SKIP][13] ([i915#15931])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adls-6: NOTRUN -> [SKIP][14] ([i915#4613]) +3 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@gem_tiled_pread_basic@basic:
- bat-adls-6: NOTRUN -> [SKIP][15] ([i915#15656])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@i915_selftest@live:
- bat-dg1-6: [PASS][16] -> [ABORT][17] ([i915#16436])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-dg1-6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-dg1-6/igt@[email protected]
- bat-atsm-1: [PASS][18] -> [ABORT][19] ([i915#14564])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-atsm-1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-atsm-1/igt@[email protected]
* igt@intel_hwmon@hwmon-read:
- bat-adls-6: NOTRUN -> [SKIP][20] ([i915#7707]) +1 other test skip
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adls-6: NOTRUN -> [SKIP][21] ([i915#4103]) +1 other test skip
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@kms_dsc@dsc-basic:
- bat-adls-6: NOTRUN -> [SKIP][22] ([i915#16361])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-adls-6: NOTRUN -> [SKIP][23]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@kms_pm_backlight@basic-brightness:
- bat-adls-6: NOTRUN -> [SKIP][24] ([i915#5354])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@kms_psr@psr-primary-mmap-gtt:
- bat-adls-6: NOTRUN -> [SKIP][25] ([i915#1072] / [i915#9732]) +3 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- bat-adls-6: NOTRUN -> [SKIP][26] ([i915#3555])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-adls-6: NOTRUN -> [SKIP][27] ([i915#3291]) +2 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-adls-6/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live:
- bat-arls-5: [DMESG-FAIL][28] ([i915#16528]) -> [PASS][29] +1 other test pass
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_18771/bat-arls-5/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/bat-arls-5/igt@[email protected]
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#14564]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14564
[i915#15656]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15656
[i915#15931]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15931
[i915#16361]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16361
[i915#16436]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16436
[i915#16528]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/16528
[i915#3291]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#4103]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#7707]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7707
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
Build changes
-------------
* Linux: CI_DRM_18771 -> Patchwork_169777v3
CI-20190529: 20190529
CI_DRM_18771: 5f3c5d8ad095d09441648d9f564eaee7d9c30bec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8990: 8990
Patchwork_169777v3: 5f3c5d8ad095d09441648d9f564eaee7d9c30bec @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_169777v3/index.html