bpf: remove artificial limitations on pointer types eligable for spilling
Subsystems (4)
Eduard Zingerman
maintainercover bpf: remove artificial limitations on pointer types eligable for spilling
Track spills for the following register types precisely:
- PTR_TO_TP_BUFFER
- PTR_TO_INSN
- CONST_PTR_TO_DYNPTR
---
Eduard Zingerman (2):
bpf: remove artificial limitations on pointer types eligable for spilling selftests/bpf: test cases for missing spill types
kernel/bpf/verifier.c | 39 +++++--------------- tools/testing/selftests/bpf/progs/verifier_gotox.c | 25 +++++++++++++ .../selftests/bpf/progs/verifier_spill_fill.c | 42 ++++++++++++++++++++++ 3 files changed, 75 insertions(+), 31 deletions(-)
---
base-commit: 602701718649936eb287bf6c7ecf870ec54c6f71
change-id: 20260707-missing-spillable-types-4cd9350dc3d7
Eduard Zingerman
maintainerPATCH 1/2 bpf: remove artificial limitations on pointer types eligable for spilling
The verifier loses precision when simulating stack spills for the following register types:
- PTR_TO_TP_BUFFER
- PTR_TO_INSN
- CONST_PTR_TO_DYNPTR
These types are not allow-listed in the is_spillable_regtype(), because of that check_stack_write_fixed_off() takes the branch that marks the slots STACK_MISC.
There are no technical reasons for this limititation. This commit replaces an explicit list of pointer types in is_spillable_regtype() with explicit list of non-pointer types. The function is renamed to is_pointer_regtype() for clarity.
--- kernel/bpf/verifier.c | 39 ++++++++------------------------------- 1 file changed, 8 insertions(+), 31 deletions(-)
kernel/bpf/verifier.c +8 -31
@@ -3304,34 +3304,6 @@ static int mark_chain_precision_batch(struct bpf_verifier_env *env,return bpf_mark_chain_precision (env, starting_state,-1 ,NULL ); } -static bool is_spillable_regtype (enum bpf_reg_type type) -{ -switch (base_type (type)) { -case PTR_TO_MAP_VALUE : -case PTR_TO_STACK : -case PTR_TO_CTX : -case PTR_TO_PACKET : -case PTR_TO_PACKET_META : -case PTR_TO_PACKET_END : -case PTR_TO_FLOW_KEYS : -case CONST_PTR_TO_MAP : -case PTR_TO_SOCKET : -case PTR_TO_SOCK_COMMON : -case PTR_TO_TCP_SOCK : -case PTR_TO_XDP_SOCK : -case PTR_TO_BTF_ID : -case PTR_TO_BUF : -case PTR_TO_MEM : -case PTR_TO_FUNC : -case PTR_TO_MAP_KEY : -case PTR_TO_ARENA : -return true; -default : -return false; - } -} - -/* check if register is a constant scalar value */ static bool is_reg_const (struct bpf_reg_state *reg,bool subreg32) {
@@ -3345,13 +3317,18 @@ static u64 reg_const_value(struct bpf_reg_state *reg, bool subreg32)return subreg32 ?tnum_subreg (reg->var_off).value : reg->var_off.value; } +static bool is_pointer_regtype (enum bpf_reg_type type) +{ +return type !=SCALAR_VALUE && type !=NOT_INIT ; +} +static bool __is_pointer_value (bool allow_ptr_leaks,const struct bpf_reg_state *reg) {if (allow_ptr_leaks)return false; -return reg->type !=SCALAR_VALUE ; +return is_pointer_regtype (reg->type); }static void clear_scalar_id (struct bpf_reg_state *reg)
@@ -3476,7 +3453,7 @@ static int check_stack_write_fixed_off(struct bpf_verifier_env *env,if (value_regno >=0 ) reg = &cur->regs[value_regno];if (!env->bypass_spec_v4) { -bool sanitize = reg &&is_spillable_regtype (reg->type); +bool sanitize = reg &&is_pointer_regtype (reg->type);for (i =0 ; i < size; i++) { u8 type = state->stack[spi].slot_type[(slot - i) %
@@ -3517,7 +3494,7 @@ static int check_stack_write_fixed_off(struct bpf_verifier_env *env,__mark_reg_known (tmp_reg, insn->imm); tmp_reg->type =SCALAR_VALUE ;save_register_state (env, state, spi, tmp_reg, size); - }else if (reg &&is_spillable_regtype (reg->type)) { + }else if (reg &&is_pointer_regtype (reg->type)) {/* register containing pointer is being spilled into stack */ if (size !=BPF_REG_SIZE ) {verbose_linfo (env, insn_idx,"; " );
Signature · 1 line
2.55.0
[email protected]
AI reviewThis isn't a bug, but could "eligable" be "eligible" here?
Quoted 1 line
bpf: remove artificial limitations on pointer types eligable for spilling
This isn't a bug, but could "eligable" be "eligible" here?
Quoted 1 line
There are no technical reasons for this limititation.
And could "limititation" be "limitation"?
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/28909712027
Kumar Kartikeya Dwivedi
maintainerQuoted 8 lines · bot+bpf-ci
Quoted 1 line
bpf: remove artificial limitations on pointer types eligable for spilling
This isn't a bug, but could "eligable" be "eligible" here?
Quoted 1 line
There are no technical reasons for this limititation.
And could "limititation" be "limitation"?
Fixed while applying.
Quoted 6 lines
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.mdCI run summary: https://github.com/kernel-patches/bpf/actions/runs/28909712027
Eduard Zingerman
maintainerPATCH 2/2 selftests/bpf: test cases for missing spill types
In reply to Eduard ZingermanA few selftests checking that the verifier represents spills for the following pointer types w/o losing precision:
- PTR_TO_INSN
- PTR_TO_TP_BUFFER
- CONST_PTR_TO_DYNPTR
--- tools/testing/selftests/bpf/progs/verifier_gotox.c | 25 +++++++++++++ .../selftests/bpf/progs/verifier_spill_fill.c | 42 ++++++++++++++++++++++ 2 files changed, 67 insertions(+)
tools/testing/selftests/bpf/progs/verifier_gotox.c +25 -0
@@ -384,6 +384,31 @@ jt0_%=: \ : __clobber_all); } +/* check valid spill/fill, ptr to insn */ +SEC("socket") +__success +__naked void spill_fill_ptr_to_insn (void ) +{ + asmvolatile ( +".pushsection .jumptables,\"\",@progbits;" +"jt0_%=:" +".quad ret0_%= - socket;" +".size jt0_%=, 8;" +".global jt0_%=;" +".popsection;" +"r0 = jt0_%= ll;" +"r0 = *(u64 *)(r0 + 0);" +"*(u64 *)(r10 - 8) = r0;" +"r0 = *(u64 *)(r10 - 8);" +".8byte %[gotox_r0];" +"ret0_%=:" +"r0 = 0;" +"exit;" + : + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0, 0)) + : __clobber_all); +} +#endif /* __TARGET_ARCH_x86 || __TARGET_ARCH_arm64 || __TARGET_ARCH_powerpc*/ char _license[] SEC("license") = "GPL";
tools/testing/selftests/bpf/progs/verifier_spill_fill.c +42 -0
46 lines not on this page · raw message
Signature · 1 line
2.55.0
This series was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Hello:
This series was applied to bpf/bpf-next.git (master) by Kumar Kartikeya Dwivedi <[email protected]>:
Quoted 11 lines · On Tue, 7 Jul 2026 17:44:27 -0700 you wrote:
Track spills for the following register types precisely:
-PTR_TO_TP_BUFFER
-PTR_TO_INSN
-CONST_PTR_TO_DYNPTR---
Eduard Zingerman (2):
bpf: remove artificial limitations on pointer types eligable for spilling selftests/bpf: test cases for missing spill types[...]
Here is the summary with links:
- [bpf-next,1/2] bpf: remove artificial limitations on pointer types eligable for spilling
https://git.kernel.org/bpf/bpf-next/c/1f737e46ca6a - [bpf-next,2/2] selftests/bpf: test cases for missing spill types https://git.kernel.org/bpf/bpf-next/c/b6d29b9ba9d6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html