Skip to contentSkip to conversation

staging: rtl8723bs: rtw_sta_mgt cleanup series

PATCH In review Eugene Mavick 3 participants 5 messages Jun 1 – Jul 12 Staging

lore
Share & tools
lore

Eugene Mavick

author
#0 lore raw

cover staging: rtl8723bs: rtw_sta_mgt cleanup series

Fix line length and indentation issues in core/rtw_sta_mgt.c

Eugene Mavick (2):
staging: rtl8723bs: fix line length warning
staging: rtl8723bs: fix alignment

 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Signature · 1 line
2.51.2
author
#1 lore raw

PATCH 1/2 staging: rtl8723bs: fix line length warning

Split comment exceeding 100 columns to improve readability and clear checkpatch warning

Signed-off-by Eugene Mavick <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +2 -1
index a1b7fe843979..02f8564d32a7 100644
@@ -222,7 +222,8 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
 
 	/*  Commented by Albert 2009/08/13 */
 	/*  For the SMC router, the sequence number of first packet of WPS handshake will be 0. */
-	/*  In this case, this packet will be dropped by recv_decache function if we use the 0x00 as the default value for tid_rxseq variable. */
+	/*  This packet will be dropped by recv_decache function */
+	/*  if we use the 0x00 as the default value for tid_rxseq variable. */
 	/*  So, we initialize the tid_rxseq variable as the 0xffff. */
 
 	for (i = 0; i < 16; i++)
Signature · 1 line
2.51.2
maintainer
#2 lore raw

Re: [PATCH 1/2] staging: rtl8723bs: fix line length warning

Quoted 13 lines · Eugene Mavick

Split comment exceeding 100 columns to improve readability and clear checkpatch warning

Signed-off-by Eugene Mavick <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +0 -0
index a1b7fe843979..02f8564d32a7 100644

drivers/staging/rtl8723bs/core/rtw_sta_mgt.c struct sta_info *rtw_alloc_stainfo(struct sta_priv *pstapriv, u8 *hwaddr) · line 227

Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +2 -1
@@ -222,7 +222,8 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
 
 	/*  Commented by Albert 2009/08/13 */
 	/*  For the SMC router, the sequence number of first packet of WPS handshake will be 0. */
-	/*  In this case, this packet will be dropped by recv_decache function if we use the 0x00 as the default value for tid_rxseq variable. */
+	/*  This packet will be dropped by recv_decache function */
+	/*  if we use the 0x00 as the default value for tid_rxseq variable. */
 	/*  So, we initialize the tid_rxseq variable as the 0xffff. */

Why not just turn this into a proper multi-line comment block?

thanks,

greg k-h

author
#3 lore raw

PATCH 2/2 staging: rtl8723bs: fix alignment

In reply to Eugene Mavick

Fix alignment to improve code readability and clear checkpatch warning:
CHECK: Alignment should match open parenthesis

Signed-off-by Eugene Mavick <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +1 -1
index 02f8564d32a7..e534045dd467 100644
@@ -249,7 +249,7 @@ struct	sta_info *rtw_alloc_stainfo(struct	sta_priv *pstapriv, u8 *hwaddr)
 
 		/* init recv timer */
 		timer_setup(&preorder_ctrl->reordering_ctrl_timer,
-				rtw_reordering_ctrl_timeout_handler, 0);
+			    rtw_reordering_ctrl_timeout_handler, 0);
 	}
 
 	/* init for DM */
Signature · 1 line
2.51.2