f2fs: quota: do not use GFP_NOFS in f2fs_quota_read()
Chao Yu
maintainerPATCH v2 1/2 f2fs: quota: do not use GFP_NOFS in f2fs_quota_read()
Commit 02117b8ae9c0 ("f2fs: Set GF_NOFS in read_cache_page_gfp while doing f2fs_quota_read") adds GFP_NOFS in f2fs_quota_read() to avoid below deadlock:
- do_sys_open
- vfs_open
- dquot_file_open
- dquot_initialize
- dqget
- dquot_acquire
: locks &dqopt->dqio_mutex (VFS Quota Mutex)
- qtree_read_dquot
- f2fs_quota_read
- read_mapping_page (GFP_KERNEL / allows GFP_FS)
- __alloc_pages_nodemask
- try_to_free_pages (Direct Reclaim)
- prune_icache_sb
- evict
- f2fs_evict_inode
- dquot_drop
- dqput
- dquot_commit
: tries to lock &dqopt->dqio_mutex again ==> DEADLOCK (waiting for itself)
As Jan Kara mentioned, quota system has fixed this issue w/ commit 537e11cdc7a6 ("quota: Prevent memory allocation recursion while holding dq_lock"), so this GFP_NOFS flag should be relic, let's use GFP_KERNEL instead.
---
v2:
- fix to use GFP_KERNEL instead of 0.
fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/super.c +1 -1
@@ -3168,7 +3168,7 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data, repeat: folio =mapping_read_folio_gfp (mapping, off >>PAGE_SHIFT , -GFP_NOFS ); +GFP_KERNEL );if (IS_ERR (folio)) {if (PTR_ERR (folio) == -ENOMEM ) {memalloc_retry_wait (GFP_NOFS );
Signature · 1 line
2.49.0
Chao Yu
maintainerPATCH v2 2/2 f2fs: drop FGP_NOFS in f2fs_write_begin()
This patch proposes to drop FGP_NOFS from f2fs_filemap_get_folio() in f2fs_write_begin(), I don't see there is potential deadlock issue when __filemap_get_folio() calling into filesystem reclaim interfaces, e.g. .writepages, evict_inode, shrinker.
---
v2:
- just drop FGP_NOFS rather than use memalloc_nofs_* helpers.
fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/data.c +1 -1
@@ -3994,7 +3994,7 @@ static int f2fs_write_begin(const struct kiocb *iocb,* Will wait that below with our IO control. */ folio =f2fs_filemap_get_folio (mapping, index, -FGP_LOCK |FGP_WRITE |FGP_CREAT |FGP_NOFS , +FGP_LOCK |FGP_WRITE |FGP_CREAT ,mapping_gfp_mask (mapping));if (IS_ERR (folio)) { err =PTR_ERR (folio);
Signature · 1 line
2.49.0
Quoted 24 lines · Chao Yu
Commit
02117b8ae9c0("f2fs: SetGF_NOFSinread_cache_page_gfpwhile doingf2fs_quota_read") addsGFP_NOFSinf2fs_quota_read()to avoid below deadlock:-
do_sys_open
-vfs_open
-dquot_file_open
-dquot_initialize
- dqget
-dquot_acquire
: locks&dqopt->dqio_mutex(VFS Quota Mutex)
-qtree_read_dquot
-f2fs_quota_read
-read_mapping_page(GFP_KERNEL/ allowsGFP_FS)
-__alloc_pages_nodemask
-try_to_free_pages(Direct Reclaim)
-prune_icache_sb
- evict
-f2fs_evict_inode
-dquot_drop
- dqput
-dquot_commit
: tries to lock&dqopt->dqio_mutexagain ==> DEADLOCK (waiting for itself)
Quoted 8 lines
As Jan Kara mentioned, quota system has fixed this issue w/ commit
537e11cdc7a6("quota: Prevent memory allocation recursion while holdingdq_lock"), so thisGFP_NOFSflag should be relic, let's useGFP_KERNELinstead.Cc Jan Kara <[email protected]>Cc Matthew Wilcox <[email protected]>Signed-off-by Chao Yu <[email protected]>
Looks sound to me. Feel free to add:
Honza
Quoted 22 lines
---
v2:
- fix to useGFP_KERNELinstead of 0.fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/f2fs/super.c +1
-1@@ -3168,7 +3168,7 @@ static ssize_t f2fs_quota_read(struct super_block *sb, int type, char *data, repeat: folio =mapping_read_folio_gfp (mapping, off >>PAGE_SHIFT , -GFP_NOFS ); +GFP_KERNEL );if (IS_ERR (folio)) {if (PTR_ERR (folio) == -ENOMEM ) {memalloc_retry_wait (GFP_NOFS );Signature · 1 line
2.49.0
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This series was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 24 lines · On Tue, 7 Jul 2026 19:39:33 +0800 you wrote:
Commit
02117b8ae9c0("f2fs: SetGF_NOFSinread_cache_page_gfpwhile doingf2fs_quota_read") addsGFP_NOFSinf2fs_quota_read()to avoid below deadlock:-
do_sys_open
-vfs_open
-dquot_file_open
-dquot_initialize
- dqget
-dquot_acquire
: locks&dqopt->dqio_mutex(VFS Quota Mutex)
-qtree_read_dquot
-f2fs_quota_read
-read_mapping_page(GFP_KERNEL/ allowsGFP_FS)
-__alloc_pages_nodemask
-try_to_free_pages(Direct Reclaim)
-prune_icache_sb
- evict
-f2fs_evict_inode
-dquot_drop
- dqput
-dquot_commit
: tries to lock&dqopt->dqio_mutexagain ==> DEADLOCK (waiting for itself)
Quoted 1 line
[...]
Here is the summary with links:
- [f2fs-dev,v2,1/2] f2fs: quota: do not use GFP_NOFS in f2fs_quota_read()
https://git.kernel.org/jaegeuk/f2fs/c/9f3a37815818 - [f2fs-dev,v2,2/2] f2fs: drop FGP_NOFS in f2fs_write_begin() https://git.kernel.org/jaegeuk/f2fs/c/6e7205a702e2
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html