Skip to contentSkip to conversation

net/enic: fix null dereference in flow query count

PATCH In review Alexey Simakov 2 participants 2 messages Jul 7 – Jul 9 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/enic: fix null dereference in flow query count

begin_fm() can return NULL when the flow manager is not initialized. enic_fm_flow_query_count() did not check the return value, leading to a NULL pointer dereference on flowman_cmd() and end_fm().

Add NULL check that returns -ENOTSUP with a descriptive error message via rte_flow_error_set().

Fixes ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API")
---
 drivers/net/enic/enic_fm_flow.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/enic/enic_fm_flow.c +7 -0
index 4b0a513977..28e2a9c1e4 100644
@@ -2904,6 +2904,13 @@ enic_fm_flow_query_count(struct rte_eth_dev *dev,
 
 	ENICPMD_FUNC_TRACE();
 	fm = begin_fm(pmd_priv(dev));
+
+	if (!fm) {
+		return rte_flow_error_set(error, ENOTSUP,
+			RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+			"enic: flowman is not initialized");
+	}
+
 	query = data;
 	fm_flow = flow->fm;
 	if (!fm_flow->counter_valid) {
Signature · 1 line
2.34.1
#1 lore raw
Quoted 30 lines

-----Original Message-----
From: Alexey Simakov <[email protected]>
Sent: Tuesday, July 7, 2026 8:45 PM
To: John Daley (johndale) <[email protected]>; Hyong Youb Kim (hyonkim) <[email protected]>
Cc: [email protected]; [email protected]; Alexey Simakov <[email protected]>
Subject: [PATCH] net/enic: fix null dereference in flow query count

begin_fm() can return NULL when the flow manager is not initialized. enic_fm_flow_query_count() did not check the return value, leading to a NULL pointer dereference on flowman_cmd() and end_fm().

Add NULL check that returns -ENOTSUP with a descriptive error message via rte_flow_error_set().

Fixes ea7768b5bba8 ("net/enic: add flow implementation based on Flow

Manager API")
Cc: [email protected]

---
 drivers/net/enic/enic_fm_flow.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/enic/enic_fm_flow.c +0 -0
index 4b0a513977..28e2a9c1e4 100644
@@ -2904,6 +2904,13 @@ enic_fm_flow_query_count(struct rte_eth_dev
 *dev,

drivers/net/enic/enic_fm_flow.c enic_fm_flow_query_count(struct rte_eth_dev · line 2914

Quoted 10 lines
drivers/net/enic/enic_fm_flow.c +7 -0
 
 	ENICPMD_FUNC_TRACE();
 	fm = begin_fm(pmd_priv(dev));
+
+	if (!fm) {
+		return rte_flow_error_set(error, ENOTSUP,
+			RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
+			"enic: flowman is not initialized");
+	}
+

This function (query) does not check the return value of begin_fm(). I believe that is intentional. Instead, the driver checks it when the app creates a flow (see enic_fm_flow_create).

fm == NULL in this function likely means a bug in the app (e.g. passing a wrong pointer), or memory corruption, or ... Perhaps a debug assertion is more appropriate. Not sure..

Thanks.
-Hyong

Quoted 5 lines
drivers/net/enic/enic_fm_flow.c +0 -0
 	query = data;
 	fm_flow = flow->fm;

if (!fm_flow->counter_valid) {
--
2.34.1