Skip to contentSkip to conversation

Lenovo ThinkPad T14s EC thermal monitoring and thermal zone integration

PATCH In review Daniel Lezcano 5 participants 18 messages Jul 7 – Jul 8

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

v6 cover Lenovo ThinkPad T14s EC thermal monitoring and thermal zone integration

Hi,

This series extends the Lenovo ThinkPad T14s embedded controller driver with environmental monitoring capabilities and integrates the exposed sensors into the Linux thermal framework.

The EC provides access to several platform temperature sensors covering the SoC, keyboard area, bottom cover, charging circuitry, QTM module and SSD. These sensors are currently used by the firmware for thermal management but are not exposed to Linux.

The first patch adds hwmon support for the EC temperature sensors.

The second patch exposes the EC as a thermal sensor provider in the device tree and defines thermal zones for the keyboard skin temperature and the charging circuitry temperature. This allows the generic thermal framework to react to EC-reported temperatures and apply standard Linux thermal mitigation policies.

As the EC protocol is not fully decoded, the passive trip points get/set actions are missing, so it is not possible to program a threshold and receive an interrupt when crossed the way up or down. Consequently, the thermal zone related to the charging circuitry is polled every two seconds until we can set the trip points in the EC.

This series fixes critical thermal issues happening on this platform where a kernel compilation, or heavy workloads, lead to a system reboot.

Tested on a Lenovo ThinkPad T14s Gen 6 (Snapdragon X Elite).

Please make sure scmi-cpufreq.ko is loaded before testing

Thanks,

Daniel

---
Changelog:
v6:
- Added Reviewed-by tag (Dmitry Baryshkov)
- Removed required property for #thermal-sensor-cells (Krzysztof Kozlowski)
v5:
- Added Reviewed-by tag (Ilpo Järvinen)
- Added the '#thermal-sensor-cells' property DT binding (Sashiko)
v4:
- Added the missing HWMON_C_REGISTER_TZ attribute (Sashiko)
- Fixed dependency with HWMON (Sashiko)
- Added Tested-by tag (Neil Armstrong)
v3:
- Removed event based because trip point are not yet well supported
- Added an empty line after variable declaration (Ilpo Järvinen)
- Used MILLIDEGREE_PER_DEGREE from units.h (Ilpo Järvinen)
- Made switch consistent (Ilpo Järvinen)
v2:
- Fixed patch 1 subject prefix
- Removed the fan information part
- Added HWMON_T_ALARM
- Fixed DT change description to reflect what it does really

Daniel Lezcano (3):
dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal
sensor provider support
platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for
temperatures
arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin
and charging sensors

 .../lenovo,thinkpad-t14s-ec.yaml              |   4 +
 .../qcom/x1e78100-lenovo-thinkpad-t14s.dtsi   |  67 ++++++++-
 drivers/platform/arm64/Kconfig                |   1 +
 drivers/platform/arm64/lenovo-thinkpad-t14s.c | 131 ++++++++++++++++++
 4 files changed, 202 insertions(+), 1 deletion(-)
Signature · 1 line
2.53.0
#1 lore raw

PATCH v6 1/3 dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

Document the Lenovo ThinkPad T14s Embedded Controller as a thermal sensor provider by adding the '#thermal-sensor-cells' property.

This allows the EC temperature sensors to be referenced from thermal zones in the device tree.

---
 .../bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml +4 -0
index c87ccb5b3086..f677966b52a8 100644
@@ -26,6 +26,9 @@ properties:
 
   wakeup-source: true
 
+  "#thermal-sensor-cells":
+    const: 1
+
 required:
   - compatible
   - reg
@@ -45,6 +48,7 @@ examples:
             reg = <0x28>;
             interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
             wakeup-source;
+            #thermal-sensor-cells = <1>;
         };
     };
 ...
Signature · 1 line
2.53.0
#2 lore raw

Re: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The newly added '#thermal-sensor-cells' property is missing from the 'required' list. --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added '#thermal-sensor-cells' property is missing from the 'required' list. --

--- Patch [1]: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support --- commit 48ae118884c307667e25a720a62e87b8e32443c5
Author: Daniel Lezcano <[email protected]>

dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

This commit documents the Lenovo ThinkPad T14s Embedded Controller as a thermal sensor provider by adding the #thermal-sensor-cells property. This allows the EC temperature sensors to be referenced from thermal zones.

Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml properties: · line 34

Quoted 13 lines
Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml +3 -0
@@ -26,6 +26,9 @@ properties:
 
   wakeup-source: true
 
+  "#thermal-sensor-cells":
+    const: 1
+
 required:
   - compatible
   - reg

[Severity: Medium]
Should #thermal-sensor-cells be added to this required list?

When hardware gains new provider capabilities, omitting the corresponding standard properties from the required list allows incomplete device tree nodes to pass schema validation. Dependent thermal zones could fail at runtime if they attempt to reference the embedded controller and the property is missing.

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#3 lore raw

Re: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

Quoted 31 lines · On 7/7/26 21:30, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added '#thermal-sensor-cells' property is missing from the 'required' list. --

--- Patch [1]: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support --- commit 48ae118884c307667e25a720a62e87b8e32443c5
Author: Daniel Lezcano <[email protected]>

dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

This commit documents the Lenovo ThinkPad T14s Embedded Controller as a thermal sensor provider by adding the #thermal-sensor-cells property. This allows the EC temperature sensors to be referenced from thermal zones.

Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml properties: · line 34

Quoted 13 lines
Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml +3 -0
@@ -26,6 +26,9 @@ properties:
 
    wakeup-source: true
 
+  "#thermal-sensor-cells":
+    const: 1
+
  required:
    - compatible
    - reg

[Severity: Medium]
Should #thermal-sensor-cells be added to this required list?

Quoted 7 lines

When hardware gains new provider capabilities, omitting the corresponding standard properties from the required list allows incomplete device tree nodes to pass schema validation. Dependent thermal zones could fail at runtime if they attempt to reference the embedded controller and the property is missing.

[ ... ]

If I'm not wrong it is a false positive

#4 lore raw

Re: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

Quoted 36 lines · Daniel Lezcano
Quoted 35 lines · On 7/7/26 21:30, [email protected] wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added '#thermal-sensor-cells' property is missing from the 'required' list. --

--- Patch [1]: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support --- commit 48ae118884c307667e25a720a62e87b8e32443c5
Author: Daniel Lezcano <[email protected]>

dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

This commit documents the Lenovo ThinkPad T14s Embedded Controller as a thermal sensor provider by adding the #thermal-sensor-cells property. This allows the EC temperature sensors to be referenced from thermal zones.

Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml properties: · line 32

Quoted 11 lines
Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml +3 -0
@@ -26,6 +26,9 @@ properties:
    wakeup-source: true
+  "#thermal-sensor-cells":
+    const: 1
+
  required:
    - compatible
    - reg

[Severity: Medium]
Should #thermal-sensor-cells be added to this required list?

When hardware gains new provider capabilities, omitting the corresponding standard properties from the required list allows incomplete device tree nodes to pass schema validation. Dependent thermal zones could fail at runtime if they attempt to reference the embedded controller and the property is missing.

Quoted 5 lines
Quoted 1 line

[ ... ]

If I'm not wrong it is a false positive

Looks valid, my previous comment was not addressed, so you did not document here the ABI which was implemented (at least after quick look at hwmon code).

Best regards,
Krzysztof

#5 lore raw

PATCH v6 2/3 platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

In reply to Daniel Lezcano

Expose the Lenovo ThinkPad T14s EC environmental sensors through the hwmon subsystem.

The driver now registers a hwmon device providing access to six EC temperature sensors corresponding to the SoC, keyboard area, base cover, PMIC/charging circuitry, QTM module and SSD. Sensor labels are exported to allow user space to identify each measurement.

This allows standard monitoring tools such as lm-sensors to report platform temperatures.

---
 drivers/platform/arm64/Kconfig                |   1 +
 drivers/platform/arm64/lenovo-thinkpad-t14s.c | 131 ++++++++++++++++++
 2 files changed, 132 insertions(+)
drivers/platform/arm64/Kconfig +1 -0
index 10f905d7d6bf..121043348740 100644
@@ -75,6 +75,7 @@ config EC_LENOVO_THINKPAD_T14S
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on I2C
 	depends on INPUT
+	depends on HWMON
 	select INPUT_SPARSEKMAP
 	select LEDS_CLASS
 	select NEW_LEDS
drivers/platform/arm64/lenovo-thinkpad-t14s.c +131 -0

170 lines not on this page · raw message

Signature · 1 line
2.53.0
#6 lore raw

Re: [PATCH v6 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 8 lines

Expose the Lenovo ThinkPad T14s EC environmental sensors through the hwmon subsystem.

The driver now registers a hwmon device providing access to six EC temperature sensors corresponding to the SoC, keyboard area, base cover, PMIC/charging circuitry, QTM module and SSD. Sensor labels are exported to allow user space to identify each measurement.

Quoted 7 lines

This allows standard monitoring tools such as lm-sensors to report platform temperatures.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
#7 lore raw

Re: [PATCH v6 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

In reply to Daniel Lezcano
Quoted 33 lines · Daniel Lezcano
drivers/platform/arm64/lenovo-thinkpad-t14s.c +33 -0
+static const struct hwmon_ops t14s_ec_hwmon_ops = {
+	.is_visible = t14s_ec_hwmon_is_visible,
+	.read = t14s_ec_hwmon_read,
+	.read_string = t14s_ec_hwmon_read_string,
+};
+
+static const struct hwmon_channel_info *t14s_ec_hwmon_info[] = {
+	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
+	HWMON_CHANNEL_INFO(temp,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL),
+	NULL
+};
+
+static const struct hwmon_chip_info t14s_ec_chip_info = {
+	.ops = &t14s_ec_hwmon_ops,
+	.info = t14s_ec_hwmon_info,
+};
+
+static int t14s_ec_hwmon_probe(struct t14s_ec *ec)
+{
+	struct device *dev;
+	struct t14s_ec_hwmon_sys_thermx sys_thermx[] = {
+		{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
+		{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
+		{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
+		{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
+		{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
+		{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },

drivers/platform/arm64/lenovo-thinkpad-t14s.c static irqreturn_t t14s_ec_irq_handler(int irq, void *data) · line 680

Quoted 10 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +10 -0
+	};
+
+	ec->ec_hwmon.sys_thermx = devm_kmemdup_array(ec->dev, sys_thermx,
+						     ARRAY_SIZE(sys_thermx),
+						     sizeof(sys_thermx[0]), GFP_KERNEL);
+	if (!ec->ec_hwmon.sys_thermx)
+		return -ENOMEM;
+
+	dev = devm_hwmon_device_register_with_info(ec->dev, "t14s_ec", ec,
+						   &t14s_ec_chip_info, NULL);

Last time I commented this looks like actual ABI break. You did not respond to that, so I assume my finding was right, thus:
1. binding is not correct (although driver should be fixed, not binding)
2. the code still breaks users

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH v6 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

Quoted 41 lines · Krzysztof Kozlowski
Quoted 40 lines · Daniel Lezcano
drivers/platform/arm64/lenovo-thinkpad-t14s.c +40 -0
+static const struct hwmon_ops t14s_ec_hwmon_ops = {
+	.is_visible = t14s_ec_hwmon_is_visible,
+	.read = t14s_ec_hwmon_read,
+	.read_string = t14s_ec_hwmon_read_string,
+};
+
+static const struct hwmon_channel_info *t14s_ec_hwmon_info[] = {
+	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
+	HWMON_CHANNEL_INFO(temp,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL),
+	NULL
+};
+
+static const struct hwmon_chip_info t14s_ec_chip_info = {
+	.ops = &t14s_ec_hwmon_ops,
+	.info = t14s_ec_hwmon_info,
+};
+
+static int t14s_ec_hwmon_probe(struct t14s_ec *ec)
+{
+	struct device *dev;
+	struct t14s_ec_hwmon_sys_thermx sys_thermx[] = {
+		{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
+		{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
+		{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
+		{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
+		{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
+		{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },
+	};
+
+	ec->ec_hwmon.sys_thermx = devm_kmemdup_array(ec->dev, sys_thermx,
+						     ARRAY_SIZE(sys_thermx),
+						     sizeof(sys_thermx[0]), GFP_KERNEL);
+	if (!ec->ec_hwmon.sys_thermx)
+		return -ENOMEM;
Quoted 8 lines

drivers/platform/arm64/lenovo-thinkpad-t14s.c static irqreturn_t t14s_ec_irq_handler(int irq, void *data) · line 680

Quoted 3 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +3 -0
+
+	dev = devm_hwmon_device_register_with_info(ec->dev, "t14s_ec", ec,
+						   &t14s_ec_chip_info, NULL);

Last time I commented this looks like actual ABI break. You did not respond to that, so I assume my finding was right, thus:
1. binding is not correct (although driver should be fixed, not binding)
2. the code still breaks users

Sorry I misunderstood it was a question expecting an answer but an affirmation.

By ABI break do you mean:

* new driver with old DT will fail ?
* new DT with old driver will break ?

* If no thermal-cells is specified, new code will fail with -EINVAL -> is that one a problem ?

* If thermal-cells is specified, but no thermal zone, new code does not fail

* If thermal-cells is specified, old code does not fail

* If thermal-cells is not specified, but a thermal zone is specified, schema is not respected

Can you clarify ?

Thanks

#9 lore raw

Re: [PATCH v6 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

Quoted 51 lines · Daniel Lezcano
Quoted 41 lines · Krzysztof Kozlowski
Quoted 40 lines · Daniel Lezcano
drivers/platform/arm64/lenovo-thinkpad-t14s.c +40 -0
+static const struct hwmon_ops t14s_ec_hwmon_ops = {
+	.is_visible = t14s_ec_hwmon_is_visible,
+	.read = t14s_ec_hwmon_read,
+	.read_string = t14s_ec_hwmon_read_string,
+};
+
+static const struct hwmon_channel_info *t14s_ec_hwmon_info[] = {
+	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
+	HWMON_CHANNEL_INFO(temp,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL),
+	NULL
+};
+
+static const struct hwmon_chip_info t14s_ec_chip_info = {
+	.ops = &t14s_ec_hwmon_ops,
+	.info = t14s_ec_hwmon_info,
+};
+
+static int t14s_ec_hwmon_probe(struct t14s_ec *ec)
+{
+	struct device *dev;
+	struct t14s_ec_hwmon_sys_thermx sys_thermx[] = {
+		{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
+		{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
+		{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
+		{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
+		{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
+		{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },
+	};
+
+	ec->ec_hwmon.sys_thermx = devm_kmemdup_array(ec->dev, sys_thermx,
+						     ARRAY_SIZE(sys_thermx),
+						     sizeof(sys_thermx[0]), GFP_KERNEL);
+	if (!ec->ec_hwmon.sys_thermx)
+		return -ENOMEM;
Quoted 8 lines

drivers/platform/arm64/lenovo-thinkpad-t14s.c static irqreturn_t t14s_ec_irq_handler(int irq, void *data) · line 680

Quoted 3 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +3 -0
+
+	dev = devm_hwmon_device_register_with_info(ec->dev, "t14s_ec", ec,
+						   &t14s_ec_chip_info, NULL);

Last time I commented this looks like actual ABI break. You did not respond to that, so I assume my finding was right, thus:
1. binding is not correct (although driver should be fixed, not binding)
2. the code still breaks users

Quoted 4 lines

Sorry I misunderstood it was a question expecting an answer but an affirmation.

By ABI break do you mean:

Existing ABI contract is changed in an incompatible way, which has observable effects as below:

Quoted 2 lines

* new driver with old DT will fail ?

^^^ this one.

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH v6 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

Le 08/07/2026 à 10:24, Krzysztof Kozlowski a écrit :

Quoted 55 lines · Daniel Lezcano
Quoted 54 lines · Krzysztof Kozlowski
Quoted 41 lines · Daniel Lezcano
Quoted 40 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +40 -0
+static const struct hwmon_ops t14s_ec_hwmon_ops = {
+	.is_visible = t14s_ec_hwmon_is_visible,
+	.read = t14s_ec_hwmon_read,
+	.read_string = t14s_ec_hwmon_read_string,
+};
+
+static const struct hwmon_channel_info *t14s_ec_hwmon_info[] = {
+	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
+	HWMON_CHANNEL_INFO(temp,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL),
+	NULL
+};
+
+static const struct hwmon_chip_info t14s_ec_chip_info = {
+	.ops = &t14s_ec_hwmon_ops,
+	.info = t14s_ec_hwmon_info,
+};
+
+static int t14s_ec_hwmon_probe(struct t14s_ec *ec)
+{
+	struct device *dev;
+	struct t14s_ec_hwmon_sys_thermx sys_thermx[] = {
+		{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
+		{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
+		{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
+		{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
+		{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
+		{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },
+	};
+
+	ec->ec_hwmon.sys_thermx = devm_kmemdup_array(ec->dev, sys_thermx,
+						     ARRAY_SIZE(sys_thermx),
+						     sizeof(sys_thermx[0]), GFP_KERNEL);
+	if (!ec->ec_hwmon.sys_thermx)
+		return -ENOMEM;
Quoted 8 lines

drivers/platform/arm64/lenovo-thinkpad-t14s.c static irqreturn_t t14s_ec_irq_handler(int irq, void *data) · line 680

Quoted 3 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +3 -0
+
+	dev = devm_hwmon_device_register_with_info(ec->dev, "t14s_ec", ec,
+						   &t14s_ec_chip_info, NULL);

Last time I commented this looks like actual ABI break. You did not respond to that, so I assume my finding was right, thus:
1. binding is not correct (although driver should be fixed, not binding)
2. the code still breaks users

Sorry I misunderstood it was a question expecting an answer but an affirmation.

Quoted 8 lines
Quoted 1 line

By ABI break do you mean:

Existing ABI contract is changed in an incompatible way, which has observable effects as below:

Quoted 2 lines

* new driver with old DT will fail ?

^^^ this one.

When we are incrementally adding features to a platform and like here reverse engineering the device protocol of the EC. It is difficult to give a complete bindings as we are discovering things little by little. How to prevent handling all versions in the code when providing iterative completion in the bindings ?

Is it possible to have something like sysfs?
Documentation/ABI/[testing|stable|removed|obsolete]

but for DT bindings ?

#11 lore raw

Re: [PATCH v6 2/3] platform: arm64: lenovo-thinkpad-t14s-ec: Add hwmon support for temperatures

Quoted 65 lines · Daniel Lezcano

Le 08/07/2026 à 10:24, Krzysztof Kozlowski a écrit :

Quoted 62 lines · Daniel Lezcano
Quoted 51 lines · Krzysztof Kozlowski
Quoted 41 lines · Daniel Lezcano
Quoted 40 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +40 -0
+static const struct hwmon_ops t14s_ec_hwmon_ops = {
+	.is_visible = t14s_ec_hwmon_is_visible,
+	.read = t14s_ec_hwmon_read,
+	.read_string = t14s_ec_hwmon_read_string,
+};
+
+static const struct hwmon_channel_info *t14s_ec_hwmon_info[] = {
+	HWMON_CHANNEL_INFO(chip, HWMON_C_REGISTER_TZ),
+	HWMON_CHANNEL_INFO(temp,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL,
+			   HWMON_T_INPUT | HWMON_T_LABEL),
+	NULL
+};
+
+static const struct hwmon_chip_info t14s_ec_chip_info = {
+	.ops = &t14s_ec_hwmon_ops,
+	.info = t14s_ec_hwmon_info,
+};
+
+static int t14s_ec_hwmon_probe(struct t14s_ec *ec)
+{
+	struct device *dev;
+	struct t14s_ec_hwmon_sys_thermx sys_thermx[] = {
+		{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
+		{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
+		{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
+		{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
+		{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
+		{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },
+	};
+
+	ec->ec_hwmon.sys_thermx = devm_kmemdup_array(ec->dev, sys_thermx,
+						     ARRAY_SIZE(sys_thermx),
+						     sizeof(sys_thermx[0]), GFP_KERNEL);
+	if (!ec->ec_hwmon.sys_thermx)
+		return -ENOMEM;
Quoted 8 lines

drivers/platform/arm64/lenovo-thinkpad-t14s.c static irqreturn_t t14s_ec_irq_handler(int irq, void *data) · line 680

Quoted 3 lines
drivers/platform/arm64/lenovo-thinkpad-t14s.c +3 -0
+
+	dev = devm_hwmon_device_register_with_info(ec->dev, "t14s_ec", ec,
+						   &t14s_ec_chip_info, NULL);

Last time I commented this looks like actual ABI break. You did not respond to that, so I assume my finding was right, thus:
1. binding is not correct (although driver should be fixed, not binding)
2. the code still breaks users

Quoted 4 lines

Sorry I misunderstood it was a question expecting an answer but an affirmation.

By ABI break do you mean:

Existing ABI contract is changed in an incompatible way, which has observable effects as below:

Quoted 2 lines

* new driver with old DT will fail ?

Quoted 7 lines
Quoted 1 line

^^^ this one.

When we are incrementally adding features to a platform and like here reverse engineering the device protocol of the EC. It is difficult to give a complete bindings as we are discovering things little by little. How to prevent handling all versions in the code when providing iterative completion in the bindings ?

Provide backwards compatibility. Here you can check for th property to be present in DT.

Signature · 2 lines
With best wishes
Dmitry
#12 lore raw

PATCH v6 3/3 arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors

In reply to Daniel Lezcano

The Lenovo ThinkPad T14s embedded controller exposes several platform temperature sensors that are already used by the firmware for thermal management.

Expose the EC as a thermal sensor provider and describe the keyboard skin and charging circuitry sensors as thermal zones in the device tree.

The keyboard thermal zone defines passive and hot trip points, while the charging thermal zone also associates a cooling map with the CPU clusters, allowing the generic thermal framework to apply CPU throttling when the charging circuitry temperature exceeds the passive threshold.

This integrates the EC temperature sensors with the Linux thermal framework and enables platform thermal management using standard thermal zone definitions.

The EC protocol currently does not provide a mechanism to program trip points from Linux. Consequently, the thermal zones rely on periodic polling to detect threshold crossings.

Using the charging circuitry temperature for thermal mitigation provides a conservative approximation of the platform thermal state and prevents the platform from reaching critical temperatures under sustained heavy CPU load.

Without this change the platform reaches a critical thermal condition and resets under heavy load.

---
 .../qcom/x1e78100-lenovo-thinkpad-t14s.dtsi   | 67 ++++++++++++++++++-
 1 file changed, 66 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi +66 -1
index 5d49df41be02..ed5ba3a428a8 100644
@@ -979,7 +979,7 @@ &i2c6 {
 
 	status = "okay";
 
-	embedded-controller@28 {
+	ec: embedded-controller@28 {
 		compatible = "lenovo,thinkpad-t14s-ec";
 		reg = <0x28>;
 
@@ -988,6 +988,8 @@ embedded-controller@28 {
 		pinctrl-0 = <&ec_int_n_default>;
 		pinctrl-names = "default";
 
+		#thermal-sensor-cells = <1>;
+
 		wakeup-source;
 	};
 };
@@ -1729,3 +1731,66 @@ &usb_mp_qmpphy1 {
 
 	status = "okay";
 };
+
+&thermal_zones {
+	ec-keyboard-thermal {
+		polling-delay = <5000>;
+		polling-delay-passive = <1000>;
+
+		thermal-sensors = <&ec 1>;
+
+		trips {
+			trip-point0 {
+				temperature = <55000>;
+				hysteresis = <2000>;
+				type = "passive";
+			};
+
+			trip-point1 {
+				temperature = <62000>;
+				hysteresis = <0>;
+				type = "hot";
+			};
+		};
+	};
+
+	ec-charging-thermal {
+		/* EC trip points cannot yet be programmed. */
+		polling-delay = <5000>;
+		polling-delay-passive = <2000>;
+
+		thermal-sensors = <&ec 3>;
+
+		trips {
+			ec_charging_psv0: trip-point0 {
+				temperature = <55000>;
+				hysteresis = <0>;
+				type = "passive";
+			};
+
+			ec_charging_alrt0: trip-point1 {
+				temperature = <63000>;
+				hysteresis = <0>;
+				type = "hot";
+			};
+		};
+
+		cooling-maps {
+			map0 {
+				trip = <&ec_charging_psv0>;
+				cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu8 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu9 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu10 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+						 <&cpu11 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+			};
+		};
+	};
+};
Signature · 1 line
2.53.0
#13 lore raw

Re: [PATCH v6 3/3] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors

Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 14 lines

The Lenovo ThinkPad T14s embedded controller exposes several platform temperature sensors that are already used by the firmware for thermal management.

Expose the EC as a thermal sensor provider and describe the keyboard skin and charging circuitry sensors as thermal zones in the device tree.

The keyboard thermal zone defines passive and hot trip points, while the charging thermal zone also associates a cooling map with the CPU clusters, allowing the generic thermal framework to apply CPU throttling when the charging circuitry temperature exceeds the passive threshold.

Quoted 7 lines

This integrates the EC temperature sensors with the Linux thermal [ ... ]

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3
#14 lore raw
In reply to Daniel Lezcano
Quoted 24 lines · Daniel Lezcano

This series extends the Lenovo ThinkPad T14s embedded controller driver with environmental monitoring capabilities and integrates the exposed sensors into the Linux thermal framework.

The EC provides access to several platform temperature sensors covering the SoC, keyboard area, bottom cover, charging circuitry, QTM module and SSD. These sensors are currently used by the firmware for thermal management but are not exposed to Linux.

The first patch adds hwmon support for the EC temperature sensors.

The second patch exposes the EC as a thermal sensor provider in the device tree and defines thermal zones for the keyboard skin temperature and the charging circuitry temperature. This allows the generic thermal framework to react to EC-reported temperatures and apply standard Linux thermal mitigation policies.

As the EC protocol is not fully decoded, the passive trip points get/set actions are missing, so it is not possible to program a threshold and receive an interrupt when crossed the way up or down. Consequently, the thermal zone related to the charging circuitry is polled every two seconds until we can set the trip points in the EC.

Quoted 4 lines

This series fixes critical thermal issues happening on this platform where a kernel compilation, or heavy workloads, lead to a system reboot.

Thanks for working on this! I have a few comments/questions about this:

1. EC vs PMIC temperature sensors

AFAIK, the T14s (and actually most X1E laptops) have two sets of thermistors in each location: One is connected to the PMIC (called SYS_THERMx), and the other set is connected to the EC.

The SYS_THERMx sensors connected to the PMIC have been enabled for the T14s already over a year ago [1]. The reason this is not upstream is that we now been waiting 3 years for the corresponding ADC/thermal code to land upstream [2]. It seems pretty close now, the ADC part has landed and there is only the thermal part left [3].

The PMIC thermistor setup is likely going to be similar for most X1E laptops, so I think it would be preferable to use that instead of the EC sensors to implement additional temperature throttling. It also supports interrupts/trip points already, so it doesn't need polling.

The most recent proposed patch actually adds the SYS_THERMx thermal zones to all X1E-based devices [4], although I'm not sure if it would be better to keep that device-specific...

[1]: https://github.com/stephan-gh/linux/commit/c0ddc9fa96667d6b32d690ce6a3dcfc76aaabad6
[2]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[3]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[4]: https://lore.kernel.org/linux-arm-msm/[email protected]/

2. EC sensor mapping vs PMIC sensor mapping

In PATCH 2/3 you define:

	{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
	{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
	{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
	{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
	{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
	{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },

I'm not sure if this is correct. When comparing this with the data read from the sensors connected to the PMIC:

| Sensor          | PMIC Channel | EC (hwmon)   | PMIC (thermal)  | Delta    |
|-----------------|--------------|--------------|-----------------|----------|
| SOC             | SYS_THERM0   | 79.0°C       | 78.7°C          | +0.3°C   |
| Keyboard        | SYS_THERM1   | 68.0°C       | 70.1°C          | -2.1°C   |
| Base / Back     | SYS_THERM2   | 66.0°C       | 64.6°C          | +1.4°C   |
| Charging        | SYS_THERM3   | 73.0°C       | 73.8°C          | -0.8°C   |
| West / QTM      | SYS_THERM6   | 64.0°C       | 62.6°C          | +1.4°C   |
| SSD             | SYS_THERM7   | 31.0°C       | 67.1°C          | -36.1°C  |
| Modem           | SYS_THERM4   | N/A          | 31.6°C          | N/A      |
| East            | SYS_THERM5   | N/A          | 70.3°C          | N/A      |

The SSD delta of 36°C is definitely suspicious. I think "ssd"/T14S_EC_SYS_THERM7 in your EC driver patch is actually the modem sensor (SYS_THERM4).

If you look at a picture of the T14s mainboard
(https://www.notebookcheck.net/fileadmin/_processed_/d/c/csm_DSC_0003_aadae1ddd2.jpg)
and zoom in to the unpopulated modem sub-board left to the fan you can see the two thermistors RT601 and RT301. The SSD on the other hand sits almost directly next to the SoC on the right, so I wouldn't expect it to stay > 30°C cooler than its surroundings.

However, there are also two thermistors next to the SSD, see e.g. this close-up picture of the mainboard:
https://download.lenovo.com/Images/Parts/5B21P83385/5B21P83385_A.jpg
This means that the SSD is probably one of the other mappings. If the thermistors are consecutively numbered in the EC firmware, the SSD (RT8203) might be actually the third sensor ("base"/T14S_EC_SYS_THERM2). I'm not sure how to figure out the proper mapping.

The back of the mainboard is completely covered with tape
(https://download.lenovo.com/Images/Parts/5B21P83377/5B21P83377_B.jpg)
so it's impossible to see anything there.

3. Active vs passive throttling

Are you matching the Windows cooling/throttling setup here? If not, have you considered how this interacts with the fan control applied by the EC? I'm a bit worried that this might lead to unexpected performance regressions if we start throttling before the EC runs the fan at full speed.

Thanks,
Stephan

#15 lore raw

Hi Stephan,

Quoted 25 lines · Stephan Gerhold
Quoted 24 lines · Daniel Lezcano

This series extends the Lenovo ThinkPad T14s embedded controller driver with environmental monitoring capabilities and integrates the exposed sensors into the Linux thermal framework.

The EC provides access to several platform temperature sensors covering the SoC, keyboard area, bottom cover, charging circuitry, QTM module and SSD. These sensors are currently used by the firmware for thermal management but are not exposed to Linux.

The first patch adds hwmon support for the EC temperature sensors.

The second patch exposes the EC as a thermal sensor provider in the device tree and defines thermal zones for the keyboard skin temperature and the charging circuitry temperature. This allows the generic thermal framework to react to EC-reported temperatures and apply standard Linux thermal mitigation policies.

As the EC protocol is not fully decoded, the passive trip points get/set actions are missing, so it is not possible to program a threshold and receive an interrupt when crossed the way up or down. Consequently, the thermal zone related to the charging circuitry is polled every two seconds until we can set the trip points in the EC.

Quoted 6 lines
Quoted 4 lines

This series fixes critical thermal issues happening on this platform where a kernel compilation, or heavy workloads, lead to a system reboot.

Thanks for working on this! I have a few comments/questions about this:

Thanks for jumping in the discussion

Quoted 5 lines

1. EC vs PMIC temperature sensors

AFAIK, the T14s (and actually most X1E laptops) have two sets of thermistors in each location: One is connected to the PMIC (called SYS_THERMx), and the other set is connected to the EC.

From the schematics I have in my possession, the SYS_THERMx are connected to the EC, at least this is how they are named. May be it is the other set with different numbers.

I'm curious to know why this mirroring ?

Quoted 5 lines

The SYS_THERMx sensors connected to the PMIC have been enabled for the T14s already over a year ago [1]. The reason this is not upstream is that we now been waiting 3 years for the corresponding ADC/thermal code to land upstream [2]. It seems pretty close now, the ADC part has landed and there is only the thermal part left [3].

Right, I have to pick this one.

Quoted 4 lines

The PMIC thermistor setup is likely going to be similar for most X1E laptops, so I think it would be preferable to use that instead of the EC sensors to implement additional temperature throttling. It also supports interrupts/trip points already, so it doesn't need polling.

I definitively second that

Quoted 34 lines

The most recent proposed patch actually adds the SYS_THERMx thermal zones to all X1E-based devices [4], although I'm not sure if it would be better to keep that device-specific...

[1]: https://github.com/stephan-gh/linux/commit/c0ddc9fa96667d6b32d690ce6a3dcfc76aaabad6
[2]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[3]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[4]: https://lore.kernel.org/linux-arm-msm/[email protected]/

2. EC sensor mapping vs PMIC sensor mapping

In PATCH 2/3 you define:

	{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
	{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
	{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
	{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
	{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
	{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },

I'm not sure if this is correct. When comparing this with the data read from the sensors connected to the PMIC:

| Sensor          | PMIC Channel | EC (hwmon)   | PMIC (thermal)  | Delta    |
|-----------------|--------------|--------------|-----------------|----------|
| SOC             | SYS_THERM0   | 79.0°C       | 78.7°C          | +0.3°C   |
| Keyboard        | SYS_THERM1   | 68.0°C       | 70.1°C          | -2.1°C   |
| Base / Back     | SYS_THERM2   | 66.0°C       | 64.6°C          | +1.4°C   |
| Charging        | SYS_THERM3   | 73.0°C       | 73.8°C          | -0.8°C   |
| West / QTM      | SYS_THERM6   | 64.0°C       | 62.6°C          | +1.4°C   |
| SSD             | SYS_THERM7   | 31.0°C       | 67.1°C          | -36.1°C  |
| Modem           | SYS_THERM4   | N/A          | 31.6°C          | N/A      |
| East            | SYS_THERM5   | N/A          | 70.3°C          | N/A      |
Quoted 3 lines

The SSD delta of 36°C is definitely suspicious. I think "ssd"/T14S_EC_SYS_THERM7 in your EC driver patch is actually the modem sensor (SYS_THERM4).

Yes probably, it was unclear from the documentation. I may have mixed some info.

The SoC sensor seems to be hotter than the Charging sensor. I'm a bit surprised because I've always seen charging hotter than the rest.

Quoted 19 lines

If you look at a picture of the T14s mainboard
(https://www.notebookcheck.net/fileadmin/_processed_/d/c/csm_DSC_0003_aadae1ddd2.jpg)
and zoom in to the unpopulated modem sub-board left to the fan you can see the two thermistors RT601 and RT301. The SSD on the other hand sits almost directly next to the SoC on the right, so I wouldn't expect it to stay > 30°C cooler than its surroundings.

However, there are also two thermistors next to the SSD, see e.g. this close-up picture of the mainboard:
https://download.lenovo.com/Images/Parts/5B21P83385/5B21P83385_A.jpg
This means that the SSD is probably one of the other mappings. If the thermistors are consecutively numbered in the EC firmware, the SSD (RT8203) might be actually the third sensor ("base"/T14S_EC_SYS_THERM2). I'm not sure how to figure out the proper mapping.

The back of the mainboard is completely covered with tape
(https://download.lenovo.com/Images/Parts/5B21P83377/5B21P83377_B.jpg)
so it's impossible to see anything there.

Quoted 7 lines

3. Active vs passive throttling

Are you matching the Windows cooling/throttling setup here? If not, have you considered how this interacts with the fan control applied by the EC? I'm a bit worried that this might lead to unexpected performance regressions if we start throttling before the EC runs the fan at full speed.

For the moment, I would say fixing the critical issue is the highest priority. With the 'charging' sensor with a 55°C trip point, AFAICT the fan is at full speed before this trip is reached.

Then we may want to take control of the fan and add active trip and passive trip.

This autonomous EC / PMIC mix sounds a bit strange to me :/

#16 lore raw
Quoted 41 lines · Daniel Lezcano
Quoted 25 lines · Stephan Gerhold
Quoted 24 lines · Daniel Lezcano

This series extends the Lenovo ThinkPad T14s embedded controller driver with environmental monitoring capabilities and integrates the exposed sensors into the Linux thermal framework.

The EC provides access to several platform temperature sensors covering the SoC, keyboard area, bottom cover, charging circuitry, QTM module and SSD. These sensors are currently used by the firmware for thermal management but are not exposed to Linux.

The first patch adds hwmon support for the EC temperature sensors.

The second patch exposes the EC as a thermal sensor provider in the device tree and defines thermal zones for the keyboard skin temperature and the charging circuitry temperature. This allows the generic thermal framework to react to EC-reported temperatures and apply standard Linux thermal mitigation policies.

As the EC protocol is not fully decoded, the passive trip points get/set actions are missing, so it is not possible to program a threshold and receive an interrupt when crossed the way up or down. Consequently, the thermal zone related to the charging circuitry is polled every two seconds until we can set the trip points in the EC.

Quoted 6 lines
Quoted 4 lines

This series fixes critical thermal issues happening on this platform where a kernel compilation, or heavy workloads, lead to a system reboot.

Thanks for working on this! I have a few comments/questions about this:

Thanks for jumping in the discussion

Quoted 5 lines

1. EC vs PMIC temperature sensors

AFAIK, the T14s (and actually most X1E laptops) have two sets of thermistors in each location: One is connected to the PMIC (called SYS_THERMx), and the other set is connected to the EC.

Quoted 6 lines

From the schematics I have in my possession, the SYS_THERMx are connected to the EC, at least this is how they are named. May be it is the other set with different numbers.

I'm curious to know why this mirroring ?

AFAICT the SYS_THERMx thermistors all go to the PMC838C PMIC on the T14s. The EC thermistors are on a separate page, search for "RT8203" for example.

I'm not sure why this mirroring exists, but even QC's Hamoa/X1E CRD has that. IIRC it is not always there though, the Purwa/X1P CRD has the sensors only connected to the EC (maybe for some minor cost savings?).

I believe on some devices the OS (Windows/Linux) even needs to send temperatures (e.g. CPU/GPU temperature) to the EC for it to work correctly. Not sure if the T14s needs/uses that though. I was mostly looking at the CRD thermal setup a year ago...

Quoted 53 lines
Quoted 5 lines

The SYS_THERMx sensors connected to the PMIC have been enabled for the T14s already over a year ago [1]. The reason this is not upstream is that we now been waiting 3 years for the corresponding ADC/thermal code to land upstream [2]. It seems pretty close now, the ADC part has landed and there is only the thermal part left [3].

Right, I have to pick this one.

Quoted 4 lines

The PMIC thermistor setup is likely going to be similar for most X1E laptops, so I think it would be preferable to use that instead of the EC sensors to implement additional temperature throttling. It also supports interrupts/trip points already, so it doesn't need polling.

I definitively second that

Quoted 34 lines

The most recent proposed patch actually adds the SYS_THERMx thermal zones to all X1E-based devices [4], although I'm not sure if it would be better to keep that device-specific...

[1]: https://github.com/stephan-gh/linux/commit/c0ddc9fa96667d6b32d690ce6a3dcfc76aaabad6
[2]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[3]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[4]: https://lore.kernel.org/linux-arm-msm/[email protected]/

2. EC sensor mapping vs PMIC sensor mapping

In PATCH 2/3 you define:

	{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
	{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
	{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
	{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
	{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
	{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },

I'm not sure if this is correct. When comparing this with the data read from the sensors connected to the PMIC:

| Sensor          | PMIC Channel | EC (hwmon)   | PMIC (thermal)  | Delta    |
|-----------------|--------------|--------------|-----------------|----------|
| SOC             | SYS_THERM0   | 79.0°C       | 78.7°C          | +0.3°C   |
| Keyboard        | SYS_THERM1   | 68.0°C       | 70.1°C          | -2.1°C   |
| Base / Back     | SYS_THERM2   | 66.0°C       | 64.6°C          | +1.4°C   |
| Charging        | SYS_THERM3   | 73.0°C       | 73.8°C          | -0.8°C   |
| West / QTM      | SYS_THERM6   | 64.0°C       | 62.6°C          | +1.4°C   |
| SSD             | SYS_THERM7   | 31.0°C       | 67.1°C          | -36.1°C  |
| Modem           | SYS_THERM4   | N/A          | 31.6°C          | N/A      |
| East            | SYS_THERM5   | N/A          | 70.3°C          | N/A      |
Quoted 3 lines

The SSD delta of 36°C is definitely suspicious. I think "ssd"/T14S_EC_SYS_THERM7 in your EC driver patch is actually the modem sensor (SYS_THERM4).

Quoted 6 lines

Yes probably, it was unclear from the documentation. I may have mixed some info.

The SoC sensor seems to be hotter than the Charging sensor. I'm a bit surprised because I've always seen charging hotter than the rest.

I captured the above while actively stressing the CPU, so presumably the SoC was heating up more quickly than the charging in that situation. Just a few minutes earlier it was like this in idle state with charging indeed warmer than SoC:

| Sensor          | EC (hwmon)   | PMIC (thermal)  | Delta    |
|-----------------|--------------|-----------------|----------|
| SOC             | 35.0°C       | 35.8°C          | -0.8°C   |
| Keyboard        | 32.0°C       | 33.0°C          | -1.0°C   |
| Base / Back     | 33.0°C       | 31.9°C          | +1.1°C   |
| Charging        | 37.0°C       | 38.2°C          | -1.2°C   |
| West / QTM      | 31.0°C       | 35.7°C          | -4.7°C   |
| SSD             | 25.0°C       | 34.0°C          | -9.0°C   |
| Modem           | N/A          | 26.2°C          | N/A      |
| East            | N/A          | 33.1°C          | N/A      |
Quoted 28 lines
Quoted 20 lines

If you look at a picture of the T14s mainboard
(https://www.notebookcheck.net/fileadmin/_processed_/d/c/csm_DSC_0003_aadae1ddd2.jpg)
and zoom in to the unpopulated modem sub-board left to the fan you can see the two thermistors RT601 and RT301. The SSD on the other hand sits almost directly next to the SoC on the right, so I wouldn't expect it to stay > 30°C cooler than its surroundings.

However, there are also two thermistors next to the SSD, see e.g. this close-up picture of the mainboard:
https://download.lenovo.com/Images/Parts/5B21P83385/5B21P83385_A.jpg
This means that the SSD is probably one of the other mappings. If the thermistors are consecutively numbered in the EC firmware, the SSD (RT8203) might be actually the third sensor ("base"/T14S_EC_SYS_THERM2). I'm not sure how to figure out the proper mapping.

The back of the mainboard is completely covered with tape
(https://download.lenovo.com/Images/Parts/5B21P83377/5B21P83377_B.jpg)
so it's impossible to see anything there.

Quoted 7 lines

3. Active vs passive throttling

Are you matching the Windows cooling/throttling setup here? If not, have you considered how this interacts with the fan control applied by the EC? I'm a bit worried that this might lead to unexpected performance regressions if we start throttling before the EC runs the fan at full speed.

Quoted 3 lines

For the moment, I would say fixing the critical issue is the highest priority. With the 'charging' sensor with a 55°C trip point, AFAICT the fan is at full speed before this trip is reached.

Agreed.

I'm not sure about the fan speed, I never checked properly but my gut feeling is that the fan runs faster in Windows and never runs full speed in Linux. (Are there fan profiles maybe? Not sure. Maybe I'm imagining it. :-))

Quoted 6 lines

Then we may want to take control of the fan and add active trip and passive trip.

This autonomous EC / PMIC mix sounds a bit strange to me :/

Right, it's all quite complicated. :/ Ideally, we would be able to figure out the exact thresholds for the fan control in the EC firmware, so that we can set the throttling temperature to be shortly above that..

Thanks,
Stephan

#17 lore raw
Quoted 170 lines · Stephan Gerhold
Quoted 41 lines · Daniel Lezcano
Quoted 25 lines · Stephan Gerhold
Quoted 24 lines · Daniel Lezcano

This series extends the Lenovo ThinkPad T14s embedded controller driver with environmental monitoring capabilities and integrates the exposed sensors into the Linux thermal framework.

The EC provides access to several platform temperature sensors covering the SoC, keyboard area, bottom cover, charging circuitry, QTM module and SSD. These sensors are currently used by the firmware for thermal management but are not exposed to Linux.

The first patch adds hwmon support for the EC temperature sensors.

The second patch exposes the EC as a thermal sensor provider in the device tree and defines thermal zones for the keyboard skin temperature and the charging circuitry temperature. This allows the generic thermal framework to react to EC-reported temperatures and apply standard Linux thermal mitigation policies.

As the EC protocol is not fully decoded, the passive trip points get/set actions are missing, so it is not possible to program a threshold and receive an interrupt when crossed the way up or down. Consequently, the thermal zone related to the charging circuitry is polled every two seconds until we can set the trip points in the EC.

Quoted 6 lines
Quoted 4 lines

This series fixes critical thermal issues happening on this platform where a kernel compilation, or heavy workloads, lead to a system reboot.

Thanks for working on this! I have a few comments/questions about this:

Thanks for jumping in the discussion

Quoted 5 lines

1. EC vs PMIC temperature sensors

AFAIK, the T14s (and actually most X1E laptops) have two sets of thermistors in each location: One is connected to the PMIC (called SYS_THERMx), and the other set is connected to the EC.

Quoted 6 lines

From the schematics I have in my possession, the SYS_THERMx are connected to
the EC, at least this is how they are named. May be it is the other set with different numbers.

I'm curious to know why this mirroring ?

AFAICT the SYS_THERMx thermistors all go to the PMC838C PMIC on the T14s. The EC thermistors are on a separate page, search for "RT8203" for example.

I'm not sure why this mirroring exists, but even QC's Hamoa/X1E CRD has that. IIRC it is not always there though, the Purwa/X1P CRD has the sensors only connected to the EC (maybe for some minor cost savings?).

I believe on some devices the OS (Windows/Linux) even needs to send temperatures (e.g. CPU/GPU temperature) to the EC for it to work correctly. Not sure if the T14s needs/uses that though. I was mostly looking at the CRD thermal setup a year ago...

Quoted 53 lines
Quoted 5 lines

The SYS_THERMx sensors connected to the PMIC have been enabled for the T14s already over a year ago [1]. The reason this is not upstream is that we now been waiting 3 years for the corresponding ADC/thermal code to land upstream [2]. It seems pretty close now, the ADC part has landed and there is only the thermal part left [3].

Right, I have to pick this one.

Quoted 4 lines

The PMIC thermistor setup is likely going to be similar for most X1E laptops, so I think it would be preferable to use that instead of the EC sensors to implement additional temperature throttling. It also supports interrupts/trip points already, so it doesn't need polling.

I definitively second that

Quoted 34 lines

The most recent proposed patch actually adds the SYS_THERMx thermal zones to all X1E-based devices [4], although I'm not sure if it would be better to keep that device-specific...

[1]: https://github.com/stephan-gh/linux/commit/c0ddc9fa96667d6b32d690ce6a3dcfc76aaabad6
[2]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[3]: https://lore.kernel.org/linux-arm-msm/[email protected]/
[4]: https://lore.kernel.org/linux-arm-msm/[email protected]/

2. EC sensor mapping vs PMIC sensor mapping

In PATCH 2/3 you define:

	{ .label = "soc",	.reg = T14S_EC_SYS_THERM0 },
	{ .label = "keyboard",	.reg = T14S_EC_SYS_THERM1 },
	{ .label = "base",	.reg = T14S_EC_SYS_THERM2 },
	{ .label = "charging",	.reg = T14S_EC_SYS_THERM3 },
	{ .label = "qtm",	.reg = T14S_EC_SYS_THERM6 },
	{ .label = "ssd",	.reg = T14S_EC_SYS_THERM7 },

I'm not sure if this is correct. When comparing this with the data read from the sensors connected to the PMIC:

| Sensor          | PMIC Channel | EC (hwmon)   | PMIC (thermal)  | Delta    |
|-----------------|--------------|--------------|-----------------|----------|
| SOC             | SYS_THERM0   | 79.0°C       | 78.7°C          | +0.3°C   |
| Keyboard        | SYS_THERM1   | 68.0°C       | 70.1°C          | -2.1°C   |
| Base / Back     | SYS_THERM2   | 66.0°C       | 64.6°C          | +1.4°C   |
| Charging        | SYS_THERM3   | 73.0°C       | 73.8°C          | -0.8°C   |
| West / QTM      | SYS_THERM6   | 64.0°C       | 62.6°C          | +1.4°C   |
| SSD             | SYS_THERM7   | 31.0°C       | 67.1°C          | -36.1°C  |
| Modem           | SYS_THERM4   | N/A          | 31.6°C          | N/A      |
| East            | SYS_THERM5   | N/A          | 70.3°C          | N/A      |
Quoted 3 lines

The SSD delta of 36°C is definitely suspicious. I think "ssd"/T14S_EC_SYS_THERM7 in your EC driver patch is actually the modem sensor (SYS_THERM4).

Quoted 6 lines

Yes probably, it was unclear from the documentation. I may have mixed some info.

The SoC sensor seems to be hotter than the Charging sensor. I'm a bit surprised because I've always seen charging hotter than the rest.

I captured the above while actively stressing the CPU, so presumably the SoC was heating up more quickly than the charging in that situation. Just a few minutes earlier it was like this in idle state with charging indeed warmer than SoC:

| Sensor          | EC (hwmon)   | PMIC (thermal)  | Delta    |
|-----------------|--------------|-----------------|----------|
| SOC             | 35.0°C       | 35.8°C          | -0.8°C   |
| Keyboard        | 32.0°C       | 33.0°C          | -1.0°C   |
| Base / Back     | 33.0°C       | 31.9°C          | +1.1°C   |
| Charging        | 37.0°C       | 38.2°C          | -1.2°C   |
| West / QTM      | 31.0°C       | 35.7°C          | -4.7°C   |
| SSD             | 25.0°C       | 34.0°C          | -9.0°C   |
| Modem           | N/A          | 26.2°C          | N/A      |
| East            | N/A          | 33.1°C          | N/A      |
Quoted 28 lines
Quoted 20 lines

If you look at a picture of the T14s mainboard
(https://www.notebookcheck.net/fileadmin/_processed_/d/c/csm_DSC_0003_aadae1ddd2.jpg)
and zoom in to the unpopulated modem sub-board left to the fan you can see the two thermistors RT601 and RT301. The SSD on the other hand sits almost directly next to the SoC on the right, so I wouldn't expect it to stay > 30°C cooler than its surroundings.

However, there are also two thermistors next to the SSD, see e.g. this close-up picture of the mainboard:
https://download.lenovo.com/Images/Parts/5B21P83385/5B21P83385_A.jpg
This means that the SSD is probably one of the other mappings. If the thermistors are consecutively numbered in the EC firmware, the SSD (RT8203) might be actually the third sensor ("base"/T14S_EC_SYS_THERM2). I'm not sure how to figure out the proper mapping.

The back of the mainboard is completely covered with tape
(https://download.lenovo.com/Images/Parts/5B21P83377/5B21P83377_B.jpg)
so it's impossible to see anything there.

Quoted 7 lines

3. Active vs passive throttling

Are you matching the Windows cooling/throttling setup here? If not, have you considered how this interacts with the fan control applied by the EC? I'm a bit worried that this might lead to unexpected performance regressions if we start throttling before the EC runs the fan at full speed.

Quoted 3 lines

For the moment, I would say fixing the critical issue is the highest priority. With the 'charging' sensor with a 55°C trip point, AFAICT the fan is at full speed before this trip is reached.

Quoted 6 lines

Agreed.

I'm not sure about the fan speed, I never checked properly but my gut feeling is that the fan runs faster in Windows and never runs full speed in Linux. (Are there fan profiles maybe? Not sure. Maybe I'm imagining it. :-))

When I did some tests with the EC and the fan rpm count, it reports a constant augmentation of RPM up to 3600 when starting a CPU workload. So I guess 3600 is the max but may be it can go above. I don't know.

Or Windows has control of the fan and is more aggressive by going to 3600 RPM more often so giving the illusion it turns faster.

Without technical details, it is hard to say.

Quoted 9 lines
Quoted 5 lines

Then we may want to take control of the fan and add active trip and passive trip.

This autonomous EC / PMIC mix sounds a bit strange to me :/

Right, it's all quite complicated. :/ Ideally, we would be able to figure out the exact thresholds for the fan control in the EC firmware, so that we can set the throttling temperature to be shortly above that..

Perhaps, with a dual boot Windows / Linux, we can read the i2c transfer between windows and the EC to figure it out. Unfortunately, I don't have enough bandwidth to investigate that now