nvme: don't reference NS after unlocking in nvme_ns_head_ctrl_ioctl()
PATCH 1/1 nvme: don't reference NS after unlocking in nvme_ns_head_ctrl_ioctl()
In nvme_ns_head_ctrl_ioctl(), once we drop the SRCU read lock we should not reference the NS to lookup the controller, so use the available controller pointer directly.
drivers/nvme/host/ioctl.c +1 -1
@@ -699,7 +699,7 @@ static int nvme_ns_head_ctrl_ioctl(struct nvme_ns *ns, unsigned int cmd,nvme_get_ctrl (ns->ctrl);srcu_read_unlock (&head->srcu, srcu_idx); - ret =nvme_ctrl_ioctl (ns->ctrl, cmd, argp, open_for_write); + ret =nvme_ctrl_ioctl (ctrl, cmd, argp, open_for_write);nvme_put_ctrl (ctrl);return ret;
Signature · 1 line
2.43.7
Quoted 3 lines · John Garry
In
nvme_ns_head_ctrl_ioctl(), once we drop the SRCU read lock we should not reference the NS to lookup the controller, so use the available controller pointer directly.
Looks good:
Quoted 3 lines · John Garry
In
nvme_ns_head_ctrl_ioctl(), once we drop the SRCU read lock we should not reference the NS to lookup the controller, so use the available controller pointer directly.
Thanks, applied to nvme-7.3.
Quoted 11 lines · John Garry
In
nvme_ns_head_ctrl_ioctl(), once we drop the SRCU read lock we should not reference the NS to lookup the controller, so use the available controller pointer directly.Signed-off-by John Garry <[email protected]>drivers/nvme/host/ioctl.c +0
-0
drivers/nvme/host/ioctl.c static int nvme_ns_head_ctrl_ioctl(struct nvme_ns *ns, unsigned int cmd, · line 705
Quoted 8 lines
drivers/nvme/host/ioctl.c +1
-1@@ -699,7 +699,7 @@ static int nvme_ns_head_ctrl_ioctl(struct nvme_ns *ns, unsigned int cmd,nvme_get_ctrl (ns->ctrl);srcu_read_unlock (&head->srcu, srcu_idx); - ret =nvme_ctrl_ioctl (ns->ctrl, cmd, argp, open_for_write); + ret =nvme_ctrl_ioctl (ctrl, cmd, argp, open_for_write);nvme_put_ctrl (ctrl);return ret;
Cheers,
Hannes
Signature · 4 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich