Skip to contentSkip to conversation

dt-bindings: soc: ti: Convert OMAP DSP and IVA to DT schema

PATCH In review Eduard Bostina 2 participants 5 messages Jul 8 – Jul 11 Device tree bindings

lore
Share & tools
lore
#0 lore raw

v3 cover dt-bindings: soc: ti: Convert OMAP DSP and IVA to DT schema

This series converts the Texas Instruments DSP and IVA Device Tree bindings from text format to DT schema.

These conversions are grouped together because the IVA schema explicitly depends on the DSP schema. The DSP is defined as a child node within the IVA subsystem.

Changes in v3:
- Squashed the 5-patch series back down to 2 patches
- IVA schema: Added an 'allOf' block to make 'ti,hwmods' conditionally required. It is required for older platforms (ti,iva1, ti,iva2.1, ti,iva2.2), but left optional for the ti-sysc architecture (ti,ivahd).

Changes in v2:
- Expanded from a 2 patch to a 5 patch series.
- Moved both the DSP and IVA binding files from bindings/arm/omap/ to bindings/soc/ti/
- Patches 1 and 3: 1:1 conversions of the old txt files.
- Patches 2 and 4: Make 'ti,hwmods' optional to fix dtbs_check warnings.
- Patch 5: Documents the DSP child node in the IVA schema to fix dtbs_check warnings.

Eduard Bostina (2):
dt-bindings: soc: ti: Convert DSP to DT schema
dt-bindings: soc: ti: Convert IVA to DT schema

 .../devicetree/bindings/arm/omap/dsp.txt      | 14 -----
 .../devicetree/bindings/arm/omap/iva.txt      | 19 ------
 .../devicetree/bindings/soc/ti/ti,iva.yaml    | 61 +++++++++++++++++++
 .../bindings/soc/ti/ti,omap3-c64.yaml         | 31 ++++++++++
 4 files changed, 92 insertions(+), 33 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt
 delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt
 create mode 100644 Documentation/devicetree/bindings/soc/ti/ti,iva.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/ti/ti,omap3-c64.yaml
Signature · 1 line
2.43.0
#1 lore raw

PATCH v3 1/2 dt-bindings: soc: ti: Convert DSP to DT schema

Convert the Texas Instruments DSP bindings to DT schema.

During the conversion, the following updates were made:
- Moved the binding to bindings/soc/ti/
- Make the 'ti,hwmods' property optional to resolve dtbs_check warnings, as several in-tree device trees currently omit it. A review of the ti-sysc driver (drivers/bus/ti-sysc.c) shows that the property is not strictly required for probing. The driver only reads it to populate the 'ddata->legacy_mode' flag. If the property is absent, the probe sequence continues normally without error.

---
 .../devicetree/bindings/arm/omap/dsp.txt      | 14 ---------
 .../bindings/soc/ti/ti,omap3-c64.yaml         | 31 +++++++++++++++++++
 2 files changed, 31 insertions(+), 14 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt
 create mode 100644 Documentation/devicetree/bindings/soc/ti/ti,omap3-c64.yaml
Documentation/devicetree/bindings/arm/omap/dsp.txt deleted +0 -14
deleted file mode 100644
index d3830a32ce08..000000000000
@@ -1,14 +0,0 @@
-* TI - DSP (Digital Signal Processor)
-
-TI DSP included in OMAP SoC
-
-Required properties:
-- compatible : Should be "ti,omap3-c64" for OMAP3 & 4
-- ti,hwmods: "dsp"
-
-Examples:
-
-dsp {
-    compatible = "ti,omap3-c64";
-    ti,hwmods = "dsp";
-};
Documentation/devicetree/bindings/soc/ti/ti,omap3-c64.yaml new file +31 -0
new file mode 100644
index 000000000000..09d0ebf2cb13
@@ -0,0 +1,31 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/ti/ti,omap3-c64.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DSP (Digital Signal Processor)
+
+maintainers:
+  - Eduard Bostina <[email protected]>
+
+properties:
+  compatible:
+    const: ti,omap3-c64
+
+  ti,hwmods:
+    description: Name of the hwmod associated to the dsp
+    $ref: /schemas/types.yaml#/definitions/string
+    const: dsp
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    dsp {
+        compatible = "ti,omap3-c64";
+        ti,hwmods = "dsp";
+    };
Signature · 1 line
2.43.0
Reviewed-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: soc: ti: Convert DSP to DT schema

Quoted 11 lines · Eduard Bostina

Convert the Texas Instruments DSP bindings to DT schema.

During the conversion, the following updates were made:
- Moved the binding to bindings/soc/ti/
- Make the 'ti,hwmods' property optional to resolve dtbs_check warnings, as several in-tree device trees currently omit it. A review of the ti-sysc driver (drivers/bus/ti-sysc.c) shows that the property is not strictly required for probing. The driver only reads it to populate the 'ddata->legacy_mode' flag. If the property is absent, the probe sequence continues normally without error.

Text feels early wrapped, please fix your editor for any future commits. No need to resend just for that.

https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Best regards,
Krzysztof

#3 lore raw

PATCH v3 2/2 dt-bindings: soc: ti: Convert IVA to DT schema

In reply to Eduard Bostina

Convert the Texas Instruments IVA bindings to DT schema.

During the conversion, the following updates were made:
- Moved the binding to bindings/soc/ti/
- Removed 'ti,iva' from the example as it is undocumented and unused.
- Make the 'ti,hwmods' property conditionally required. Modern ti-sysc deployments do not require it for probing, but older OMAP2/3 platforms relying on omap_device.c still need it.
- Documented the 'dsp' child node, which is actively used in the OMAP3 device tree (omap3.dtsi) but was missing from the old txt binding.

---
 .../devicetree/bindings/arm/omap/iva.txt      | 19 ------
 .../devicetree/bindings/soc/ti/ti,iva.yaml    | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 19 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt
 create mode 100644 Documentation/devicetree/bindings/soc/ti/ti,iva.yaml
Documentation/devicetree/bindings/arm/omap/iva.txt deleted +0 -19
deleted file mode 100644
index 6d6295171358..000000000000
@@ -1,19 +0,0 @@
-* TI - IVA (Imaging and Video Accelerator) subsystem
-
-The IVA contain various audio, video or imaging HW accelerator
-depending of the version.
-
-Required properties:
-- compatible : Should be:
-  - "ti,ivahd" for OMAP4
-  - "ti,iva2.2" for OMAP3
-  - "ti,iva2.1" for OMAP2430
-  - "ti,iva1" for OMAP2420
-- ti,hwmods: "iva"
-
-Examples:
-
-iva {
-    compatible = "ti,ivahd", "ti,iva";
-    ti,hwmods = "iva";
-};
Documentation/devicetree/bindings/soc/ti/ti,iva.yaml new file +61 -0

61 lines not on this page · raw message

Signature · 1 line
2.43.0
Reviewed-by on v3 2/2
#4 lore raw

Re: [PATCH v3 2/2] dt-bindings: soc: ti: Convert IVA to DT schema

Quoted 12 lines · Eduard Bostina

Convert the Texas Instruments IVA bindings to DT schema.

During the conversion, the following updates were made:
- Moved the binding to bindings/soc/ti/
- Removed 'ti,iva' from the example as it is undocumented and unused.
- Make the 'ti,hwmods' property conditionally required. Modern ti-sysc deployments do not require it for probing, but older OMAP2/3 platforms relying on omap_device.c still need it.
- Documented the 'dsp' child node, which is actively used in the OMAP3 device tree (omap3.dtsi) but was missing from the old txt binding.

Quoted 7 lines
---
 .../devicetree/bindings/arm/omap/iva.txt      | 19 ------
 .../devicetree/bindings/soc/ti/ti,iva.yaml    | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 19 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt
 create mode 100644 Documentation/devicetree/bindings/soc/ti/ti,iva.yaml

Best regards,
Krzysztof