Skip to contentSkip to conversation

usb: xhci: sideband: add missing kernel-doc parameters

PATCH In review Rosen Penev 2 participants 2 messages Jun 4 – Jul 8

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: xhci: sideband: add missing kernel-doc parameters

Add @imod_interval and @intr_num to xhci_sideband_create_interrupter(), and @type and @notify_client to xhci_sideband_register().

Fixes de66754e9f80 ("xhci: sideband: add initial api to register a secondary interrupter entity")
Assisted-by opencode:big-pickle
---
 drivers/usb/host/xhci-sideband.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/host/xhci-sideband.c +4 -0
index 23153e136d4b..d892567079b7 100644
@@ -308,6 +308,8 @@ EXPORT_SYMBOL_GPL(xhci_sideband_check);
  * @sb: sideband instance for this usb device
  * @num_seg: number of event ring segments to allocate
  * @ip_autoclear: IP autoclearing support such as MSI implemented
+ * @imod_interval: interrupt moderation interval
+ * @intr_num: interrupter number
  *
  * Sets up a xhci interrupter that can be used for this sideband accessed usb
  * device. Transfer events for this device can be routed to this interrupters
@@ -389,6 +391,8 @@ EXPORT_SYMBOL_GPL(xhci_sideband_interrupter_id);
 /**
  * xhci_sideband_register - register a sideband for a usb device
  * @intf: usb interface associated with the sideband device
+ * @type: sideband type
+ * @notify_client: callback for notifying the client of events
  *
  * Allows for clients to utilize XHCI interrupters and fetch transfer and event
  * ring parameters for executing data transfers.
Signature · 1 line
2.54.0
#1 lore raw
Quoted 3 lines · Rosen Penev

Add @imod_interval and @intr_num to xhci_sideband_create_interrupter(), and @type and @notify_client to xhci_sideband_register().

Why? This says what it does, but not why you are doing this.

thanks,

greg k-h