ARM: dts: helios4: add regulator supplies
Subsystems (2)
v2 cover ARM: dts: helios4: add regulator supplies
This series adds missing vcc-supply properties to the EEPROM and GPIO expander on the Helios4, adds SATA regulator supplies.
v2: remove thermal patch
Rosen Penev (3):
ARM: dts: helios4: add vcc-supply to EEPROM
ARM: dts: helios4: add vcc-supply to GPIO expander
ARM: dts: helios4: add SATA regulator supplies
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)
Signature · 1 line
2.55.0
PATCH v2 1/3 ARM: dts: helios4: add vcc-supply to EEPROM
The at24 driver requests a 'vcc' supply for the EEPROM, producing 'supply vcc not found, using dummy regulator' at boot when the property is missing.
The EEPROM sits on the Helios 4 and is powered by the same always-on 3.3V rail used by other on-board I2C devices. Add vcc-supply = <®_3p3v> to silence the warning.
--- arch/arm/boot/dts/marvell/armada-388-helios4.dts | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/boot/dts/marvell/armada-388-helios4.dts +4 -0
@@ -201,6 +201,10 @@ temp_sensor: temp@4c { reg = <0x4c>; vcc-supply = <®_3p3v>; }; + + eeprom@53 { + vcc-supply = <®_3p3v>; + }; }; i2c@11100 {
Signature · 1 line
2.55.0
PATCH v2 2/3 ARM: dts: helios4: add vcc-supply to GPIO expander
In reply to Rosen PenevThe pca953x driver requests a 'vcc' supply, producing:
pca953x 0-0020: supply vcc not found, using dummy regulator
The PCA9655 (PCA9555-compatible) expander is powered by the same always-on 3.3V rail as the other I2C devices on the bus. Add vcc-supply = <®_3p3v> to silence the warning.
--- arch/arm/boot/dts/marvell/armada-388-helios4.dts | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/marvell/armada-388-helios4.dts +1 -0
@@ -169,6 +169,7 @@ expander0: gpio-expander@20 { gpio-controller; #gpio-cells = <2>; reg = <0x20>; + vcc-supply = <®_3p3v>; pinctrl-names = "default"; pinctrl-0 = <&pca0_pins>; interrupt-parent = <&gpio0>;
Signature · 1 line
2.55.0
PATCH v2 3/3 ARM: dts: helios4: add SATA regulator supplies
In reply to Rosen PenevThe ahci-mvebu driver and libahci_platform request three supplies on SATA controller and port nodes:
- ahci-supply (controller power)
- phy-supply (PHY power)
- target-supply (disk power per port)
Without them the regulator core prints notices at boot, e.g.:
supply ahci not found, using dummy regulator supply phy not found, using dummy regulator supply target not found, using dummy regulator
The SATA controller and PHY inside the Armada 388 SoC are powered by the 3.3V I/O rail; the four disk bays are powered by the 5V HDD rail. Wire the existing fixed regulators accordingly.
--- arch/arm/boot/dts/marvell/armada-388-helios4.dts | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/boot/dts/marvell/armada-388-helios4.dts +8 -0
@@ -222,13 +222,17 @@ sata@a8000 { status = "okay"; #address-cells = <1>; #size-cells = <0>; + ahci-supply = <®_3p3v>; + phy-supply = <®_3p3v>; sata0: sata-port@0 { reg = <0>; + target-supply = <®_5p0v_hdd>; }; sata1: sata-port@1 { reg = <1>; + target-supply = <®_5p0v_hdd>; }; };
@@ -236,13 +240,17 @@ sata@e0000 { status = "okay"; #address-cells = <1>; #size-cells = <0>; + ahci-supply = <®_3p3v>; + phy-supply = <®_3p3v>; sata2: sata-port@0 { reg = <0>; + target-supply = <®_5p0v_hdd>; }; sata3: sata-port@1 { reg = <1>; + target-supply = <®_5p0v_hdd>; }; };
Signature · 1 line
2.55.0
[email protected]
AI reviewRe: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The struct device reference acquired by of_find_device_by_node() is never released, causing a memory leak. --
--- Patch [1]: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies --- commit 737d149c64d97348e97b79fed6b2378d4f1a140f
Author: Rosen Penev <[email protected]>
ARM: dts: helios4: add SATA regulator supplies
The ahci-mvebu driver and libahci_platform request three supplies on SATA controller and port nodes to avoid regulator core boot notices. The SATA controller and PHY are powered by the 3.3V I/O rail, while the four disk bays are powered by the 5V HDD rail.
Quoted 5 lines
arch/arm/boot/dts/marvell/armada-388-helios4.dts +0
-0
arch/arm/boot/dts/marvell/armada-388-helios4.dts sata@a8000 { · line 225
Quoted 9 lines
arch/arm/boot/dts/marvell/armada-388-helios4.dts +3
-0@@ -217,13 +217,17 @@ sata@a8000 { status = "okay"; #address-cells = <1>; #size-cells = <0>; + ahci-supply = <®_3p3v>; + phy-supply = <®_3p3v>; sata0: sata-port@0 { reg = <0>; + target-supply = <®_5p0v_hdd>;
[Severity: High]
This is a pre-existing issue and was not introduced by this patch, but doesn't adding these supplies increase the chance of memory leaks during probe deferrals?
In drivers/ata/libahci_platform.c:ahci_platform_get_resources(), the device reference acquired by of_find_device_by_node() is never released:
port_dev = of_find_device_by_node(child);
if (port_dev) {
rc = ahci_platform_get_regulator(hpriv, port,
&port_dev->dev);
if (rc == -EPROBE_DEFER)
goto err_out;
}If the newly added target-supply regulators return -EPROBE_DEFER, the probe fails and is retried. This unconditionally leaks a struct platform_device reference on every retry because put_device() is never called for port_dev.
Quoted 1 line
arch/arm/boot/dts/marvell/armada-388-helios4.dts +0
-0};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Re: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies
Quoted 5 lines · On Wed, Jul 8, 2026 at 6:02 PM <[email protected]> wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The struct device reference acquired byof_find_device_by_node()is never released, causing a memory leak.
Not relevant.
Quoted 53 lines
--
--- Patch [1]: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies --- commit
737d149c64d97348e97b79fed6b2378d4f1a140f
Author: Rosen Penev <[email protected]>ARM: dts: helios4: add SATA regulator supplies
The ahci-mvebu driver and
libahci_platformrequest three supplies on SATA controller and port nodes to avoid regulator core boot notices. The SATA controller and PHY are powered by the 3.3V I/O rail, while the four disk bays are powered by the 5V HDD rail.Quoted 5 lines
arch/arm/boot/dts/marvell/armada-388-helios4.dts +0
-0arch/arm/boot/dts/marvell/armada-388-helios4.dts sata@a8000 { · line 225
Quoted 9 lines
arch/arm/boot/dts/marvell/armada-388-helios4.dts +3
-0@@ -217,13 +217,17 @@ sata@a8000 { status = "okay"; #address-cells = <1>; #size-cells = <0>; + ahci-supply = <®_3p3v>; + phy-supply = <®_3p3v>; sata0: sata-port@0 { reg = <0>; + target-supply = <®_5p0v_hdd>;[Severity: High]
This is a pre-existing issue and was not introduced by this patch, but doesn't adding these supplies increase the chance of memory leaks during probe deferrals?In drivers/ata/libahci_platform.c:ahci_platform_get_resources(), the device reference acquired by
of_find_device_by_node()is never released:port_dev = of_find_device_by_node(child); if (port_dev) { rc = ahci_platform_get_regulator(hpriv, port, &port_dev->dev); if (rc == -EPROBE_DEFER) goto err_out; }If the newly added target-supply regulators return -EPROBE_DEFER, the probe fails and is retried. This unconditionally leaks a struct
platform_devicereference on every retry becauseput_device()is never called forport_dev.arch/arm/boot/dts/marvell/armada-388-helios4.dts sata@a8000 { · line 226
Quoted 1 line
arch/arm/boot/dts/marvell/armada-388-helios4.dts +0
-0};--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Gregory CLEMENT
maintainerHi Rosen Penev,
Quoted 10 lines
This series adds missing vcc-supply properties to the EEPROM and GPIO expander on the Helios4, adds SATA regulator supplies.
v2: remove thermal patch
Rosen Penev (3):
ARM: dts: helios4: add vcc-supply to EEPROM
ARM: dts: helios4: add vcc-supply to GPIO expander
ARM: dts: helios4: add SATA regulator supplies
Applied on mvebu/dt
Thanks,
Gregory
Quoted 6 lines
arch/arm/boot/dts/marvell/armada-388-helios4.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+)Signature · 1 line
2.55.0
Signature · 3 lines
Grégory CLEMENT, Bootlin Embedded Linux and Kernel engineering https://bootlin.com