Skip to contentSkip to conversation

ata: libahci_platform: use of_platform_device_create() return value

PATCH In review Rosen Penev 3 participants 6 messages Jul 9

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ata: libahci_platform: use of_platform_device_create() return value

of_platform_device_create() already returns the struct platform_device pointer, so there is no need for a separate of_find_device_by_node() call. Use the return value directly.

Avoids having to free the reference from of_find_device_by_node().

Assisted-by opencode:big-pickle
---
 drivers/ata/libahci_platform.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/ata/libahci_platform.c +1 -4
index 6e072d681341..2aa3df58fc9a 100644
@@ -617,10 +617,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
 			mask_port_map |= BIT(port);
 
 #ifdef CONFIG_OF_ADDRESS
-			of_platform_device_create(child, NULL, NULL);
-
-			port_dev = of_find_device_by_node(child);
-
+			port_dev = of_platform_device_create(child, NULL, NULL);
 			if (port_dev) {
 				rc = ahci_platform_get_regulator(hpriv, port,
 								&port_dev->dev);
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 5 lines · Rosen Penev

of_platform_device_create() already returns the struct platform_device pointer, so there is no need for a separate of_find_device_by_node() call. Use the return value directly.

Avoids having to free the reference from of_find_device_by_node().

Looks OK to me, but how is the above comment relevant? I do not see any change that can be described with this sentence. Maybe remove it? (I can do it when applying)

Quoted 23 lines
Assisted-by opencode:big-pickle
---
 drivers/ata/libahci_platform.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/ata/libahci_platform.c +1 -4
index 6e072d681341..2aa3df58fc9a 100644
@@ -617,10 +617,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
 			mask_port_map |= BIT(port);
 
 #ifdef CONFIG_OF_ADDRESS
-			of_platform_device_create(child, NULL, NULL);
-
-			port_dev = of_find_device_by_node(child);
-
+			port_dev = of_platform_device_create(child, NULL, NULL);
 			if (port_dev) {
 				rc = ahci_platform_get_regulator(hpriv, port,
 								&port_dev->dev);
Signature · 2 lines
Damien Le Moal
Western Digital Research
#2 lore raw
In reply to Rosen Penev
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Using the return value of `of_platform_device_create()` breaks target regulator fetching during…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Using the return value of of_platform_device_create() breaks target regulator fetching during driver rebind or probe deferral, leading to unpowered SATA ports. --

--- Patch [1]: [PATCH] ata: libahci_platform: use of_platform_device_create() return value --- commit b10e7693c196a90e6a36f9889202414e7cb20fc9
Author: Rosen Penev <[email protected]>

ata: libahci_platform: use of_platform_device_create() return value

This commit updates ahci_platform_get_resources() to use the return value of of_platform_device_create() directly, removing the subsequent call to of_find_device_by_node() to avoid needing to free the reference.

Quoted 4 lines
drivers/ata/libahci_platform.c +0 -0
@@ -617,10 +617,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
 			mask_port_map |= BIT(port);

drivers/ata/libahci_platform.c struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, · line 623

Quoted 10 lines
drivers/ata/libahci_platform.c +1 -4
 
 #ifdef CONFIG_OF_ADDRESS
-			of_platform_device_create(child, NULL, NULL);
-
-			port_dev = of_find_device_by_node(child);
-
+			port_dev = of_platform_device_create(child, NULL, NULL);
 			if (port_dev) {
 				rc = ahci_platform_get_regulator(hpriv, port,
 								&port_dev->dev);

[Severity: High]
Does this change break regulator fetching during a probe deferral?

When of_platform_device_create() successfully creates the device on the first probe attempt, it sets the OF_POPULATED flag on the child device node.

If a subsequent initialization step triggers a probe deferral (for instance, returning -EPROBE_DEFER), the probe is aborted. However, the driver's cleanup path does not depopulate the platform device, so the OF_POPULATED flag remains set on the child node.

During the second probe attempt, of_platform_device_create() sees the OF_POPULATED flag and returns NULL.

Because port_dev is now NULL, the block above is bypassed, and ahci_platform_get_regulator() is silently skipped. This leaves the SATA port without its required target power regulator.

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#3 lore raw
Quoted 41 lines · On Wed, Jul 8, 2026 at 6:50 PM <[email protected]> wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Using the return value of of_platform_device_create() breaks target regulator fetching during driver rebind or probe deferral, leading to unpowered SATA ports. --

--- Patch [1]: [PATCH] ata: libahci_platform: use of_platform_device_create() return value --- commit b10e7693c196a90e6a36f9889202414e7cb20fc9
Author: Rosen Penev <[email protected]>

ata: libahci_platform: use of_platform_device_create() return value

This commit updates ahci_platform_get_resources() to use the return value of of_platform_device_create() directly, removing the subsequent call to of_find_device_by_node() to avoid needing to free the reference.

Quoted 4 lines
drivers/ata/libahci_platform.c +0 -0
@@ -617,10 +617,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
                      mask_port_map |= BIT(port);

drivers/ata/libahci_platform.c struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, · line 623

Quoted 10 lines
drivers/ata/libahci_platform.c +1 -4
 
 #ifdef CONFIG_OF_ADDRESS
-                     of_platform_device_create(child, NULL, NULL);
-
-                     port_dev = of_find_device_by_node(child);
-
+                     port_dev = of_platform_device_create(child, NULL, NULL);
                      if (port_dev) {
                              rc = ahci_platform_get_regulator(hpriv, port,
                                                              &port_dev->dev);

[Severity: High]
Does this change break regulator fetching during a probe deferral?

When of_platform_device_create() successfully creates the device on the first probe attempt, it sets the OF_POPULATED flag on the child device node.

If a subsequent initialization step triggers a probe deferral (for instance, returning -EPROBE_DEFER), the probe is aborted. However, the driver's cleanup path does not depopulate the platform device, so the OF_POPULATED flag remains set on the child node.

Quoted 6 lines

During the second probe attempt, of_platform_device_create() sees the OF_POPULATED flag and returns NULL.

Because port_dev is now NULL, the block above is bypassed, and ahci_platform_get_regulator() is silently skipped. This leaves the SATA port without its required target power regulator.

Welp. So much for that.

Quoted 3 lines

--
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1

maintainer
#4 lore raw
Quoted 42 lines · Rosen Penev
Quoted 41 lines · On Wed, Jul 8, 2026 at 6:50 PM <[email protected]> wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Using the return value of of_platform_device_create() breaks target regulator fetching during driver rebind or probe deferral, leading to unpowered SATA ports. --

--- Patch [1]: [PATCH] ata: libahci_platform: use of_platform_device_create() return value --- commit b10e7693c196a90e6a36f9889202414e7cb20fc9
Author: Rosen Penev <[email protected]>

ata: libahci_platform: use of_platform_device_create() return value

This commit updates ahci_platform_get_resources() to use the return value of of_platform_device_create() directly, removing the subsequent call to of_find_device_by_node() to avoid needing to free the reference.

Quoted 4 lines
drivers/ata/libahci_platform.c +0 -0
@@ -617,10 +617,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
                      mask_port_map |= BIT(port);

drivers/ata/libahci_platform.c struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, · line 623

Quoted 10 lines
drivers/ata/libahci_platform.c +1 -4
 
 #ifdef CONFIG_OF_ADDRESS
-                     of_platform_device_create(child, NULL, NULL);
-
-                     port_dev = of_find_device_by_node(child);
-
+                     port_dev = of_platform_device_create(child, NULL, NULL);
                      if (port_dev) {
                              rc = ahci_platform_get_regulator(hpriv, port,
                                                              &port_dev->dev);

[Severity: High]
Does this change break regulator fetching during a probe deferral?

When of_platform_device_create() successfully creates the device on the first probe attempt, it sets the OF_POPULATED flag on the child device node.

If a subsequent initialization step triggers a probe deferral (for instance, returning -EPROBE_DEFER), the probe is aborted. However, the driver's cleanup path does not depopulate the platform device, so the OF_POPULATED flag remains set on the child node.

Quoted 7 lines
Quoted 6 lines

During the second probe attempt, of_platform_device_create() sees the OF_POPULATED flag and returns NULL.

Because port_dev is now NULL, the block above is bypassed, and ahci_platform_get_regulator() is silently skipped. This leaves the SATA port without its required target power regulator.

Welp. So much for that.

Indeed. Not a great API... So we would need a pattern like:

		if (of_node_check_flag(child, OF_POPULATED))
			port_dev = of_find_device_by_node(child);
		else
			port_dev = of_platform_device_create(child, NULL, NULL);

Which kind of makes the patch not needed. Let's drop it ?

Signature · 2 lines
Damien Le Moal
Western Digital Research
#5 lore raw
Quoted 52 lines · Damien Le Moal
Quoted 42 lines · Rosen Penev
Quoted 41 lines · On Wed, Jul 8, 2026 at 6:50 PM <[email protected]> wrote:

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Using the return value of of_platform_device_create() breaks target regulator fetching during driver rebind or probe deferral, leading to unpowered SATA ports. --

--- Patch [1]: [PATCH] ata: libahci_platform: use of_platform_device_create() return value --- commit b10e7693c196a90e6a36f9889202414e7cb20fc9
Author: Rosen Penev <[email protected]>

ata: libahci_platform: use of_platform_device_create() return value

This commit updates ahci_platform_get_resources() to use the return value of of_platform_device_create() directly, removing the subsequent call to of_find_device_by_node() to avoid needing to free the reference.

Quoted 4 lines
drivers/ata/libahci_platform.c +0 -0
@@ -617,10 +617,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
                      mask_port_map |= BIT(port);

drivers/ata/libahci_platform.c struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev, · line 623

Quoted 10 lines
drivers/ata/libahci_platform.c +1 -4
 
 #ifdef CONFIG_OF_ADDRESS
-                     of_platform_device_create(child, NULL, NULL);
-
-                     port_dev = of_find_device_by_node(child);
-
+                     port_dev = of_platform_device_create(child, NULL, NULL);
                      if (port_dev) {
                              rc = ahci_platform_get_regulator(hpriv, port,
                                                              &port_dev->dev);

[Severity: High]
Does this change break regulator fetching during a probe deferral?

When of_platform_device_create() successfully creates the device on the first probe attempt, it sets the OF_POPULATED flag on the child device node.

If a subsequent initialization step triggers a probe deferral (for instance, returning -EPROBE_DEFER), the probe is aborted. However, the driver's cleanup path does not depopulate the platform device, so the OF_POPULATED flag remains set on the child node.

Quoted 7 lines
Quoted 6 lines

During the second probe attempt, of_platform_device_create() sees the OF_POPULATED flag and returns NULL.

Because port_dev is now NULL, the block above is bypassed, and ahci_platform_get_regulator() is silently skipped. This leaves the SATA port without its required target power regulator.

Welp. So much for that.

Quoted 8 lines

Indeed. Not a great API... So we would need a pattern like:

                if (of_node_check_flag(child, OF_POPULATED))
                        port_dev = of_find_device_by_node(child);
                else
                        port_dev = of_platform_device_create(child, NULL, NULL);

Which kind of makes the patch not needed. Let's drop it ?

Yes.

Quoted 4 lines

--
Damien Le Moal
Western Digital Research