ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT
PATCH 1/1 ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT
Make the Kconfig item for cirrus_scodec visible if CONFIG_KUNIT is enabled. This is so that its KUnit test can be enabled by KUnit scripts without requiring a large amount of irrelevant additional components.
The general rule for KUNIT_ALL_TESTS is that it should only enable tests for components that are already selected. However, the UML environment does not support ACPI, which means the HDA codec drivers that use cirrus_scodec cannot be selected. But cirrus_scodec does not need ACPI.
By making the Kconfig option visible if CONFIG_KUNIT, the KUnit test can be enabled with only the minimal set of functionality that is required for cirrus_scodec.
This is still compliant with the KUNIT_ALL_TESTS rule "only tests for enabled modules" because by default cirrus_scodec will only be enabled if the drivers that use it are enabled. It must be intentionally enabled to force it to be included for testing.
--- sound/hda/codecs/side-codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/hda/codecs/side-codecs/Kconfig +1 -1
@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only config SND_HDA_CIRRUS_SCODEC - tristate + tristate "Cirrus side-codec library" if KUNIT config SND_HDA_CIRRUS_SCODEC_KUNIT_TEST tristate "KUnit test for Cirrus side-codec library" if !KUNIT_ALL_TESTS
Signature · 1 line
2.47.3
Quoted 16 lines · Richard Fitzgerald
Make the
Kconfigitem forcirrus_scodecvisible ifCONFIG_KUNITis enabled. This is so that its KUnit test can be enabled by KUnit scripts without requiring a large amount of irrelevant additional components.The general rule for
KUNIT_ALL_TESTSis that it should only enable tests for components that are already selected. However, the UML environment does not support ACPI, which means the HDA codec drivers that usecirrus_scodeccannot be selected. Butcirrus_scodecdoes not need ACPI.By making the
Kconfigoption visible ifCONFIG_KUNIT, the KUnit test can be enabled with only the minimal set of functionality that is required forcirrus_scodec.
Quoted 6 lines
This is still compliant with the
KUNIT_ALL_TESTSrule "only tests for enabled modules" because by defaultcirrus_scodecwill only be enabled if the drivers that use it are enabled. It must be intentionally enabled to force it to be included for testing.Signed-off-by Richard Fitzgerald <[email protected]>
Applied now. Thanks.
Takashi