Skip to contentSkip to conversation

dt-bindings: pinctrl: mt7622: allow gpio-hogs

PATCH In review Chen-Yu Yeh 3 participants 3 messages Jul 9 – Jul 25

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: pinctrl: mt7622: allow gpio-hogs

Commit 6e3b067d3c5e ("arm64: dts: mediatek: mt7622: Align GPIO hog name with bindings") renamed the asm_sel GPIO hog to asm-sel-hog to follow the GPIO hog naming convention, but the mt7622 pinctrl binding only allows child nodes matching '-pins(-[a-z]+)?$', causing a dtbs_check warning:

mt7622-bananapi-bpi-r64.dtb: pinctrl@10211000 (mediatek,mt7622-pinctrl):
'asm-sel-hog' does not match any of the regexes:
'-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'

Allow gpio-hog nodes in the pinctrl node, following the same pattern as commit 9322da935c9a ("dt-bindings: pinctrl: mt7988: allow gpio-hogs").

---
 .../devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml +5 -0
index 6b925c5099cc..021307b6d801 100644
@@ -65,6 +65,11 @@ then:
     - "#interrupt-cells"
 
 patternProperties:
+  "-hog(-[0-9]+)?$":
+    type: object
+    required:
+      - gpio-hog
+
   '-pins(-[a-z]+)?$':
     type: object
     additionalProperties: false
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Chen-Yu Yeh

Commit 6e3b067d3c5e ("arm64: dts: mediatek: mt7622: Align GPIO hog name with bindings") renamed the asm_sel GPIO hog to asm-sel-hog to follow the GPIO hog naming convention, but the mt7622 pinctrl binding only allows child nodes matching '-pins(-[a-z]+)?$', causing a dtbs_check warning:

mt7622-bananapi-bpi-r64.dtb: pinctrl@10211000 (mediatek,mt7622-pinctrl):
'asm-sel-hog' does not match any of the regexes:
'-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'

Quoted 9 lines

Allow gpio-hog nodes in the pinctrl node, following the same pattern as commit 9322da935c9a ("dt-bindings: pinctrl: mt7988: allow gpio-hogs").

---
 .../devicetree/bindings/pinctrl/mediatek,mt7622-pinctrl.yaml | 5 +++++
 1 file changed, 5 insertions(+)
maintainer
#2 lore raw
In reply to Chen-Yu Yeh
Quoted 10 lines · Chen-Yu Yeh

Commit 6e3b067d3c5e ("arm64: dts: mediatek: mt7622: Align GPIO hog name with bindings") renamed the asm_sel GPIO hog to asm-sel-hog to follow the GPIO hog naming convention, but the mt7622 pinctrl binding only allows child nodes matching '-pins(-[a-z]+)?$', causing a dtbs_check warning:

mt7622-bananapi-bpi-r64.dtb: pinctrl@10211000 (mediatek,mt7622-pinctrl):
'asm-sel-hog' does not match any of the regexes:
'-pins(-[a-z]+)?$', '^pinctrl-[0-9]+$'

Quoted 5 lines

Allow gpio-hog nodes in the pinctrl node, following the same pattern as commit 9322da935c9a ("dt-bindings: pinctrl: mt7988: allow gpio-hogs").

Patch applied.

Yours,
Linus Walleij