Skip to contentSkip to conversation

dt-bindings: rtc: Convert rtc-cmos binding to YAML

PATCH Applied Teja Sai Charan B 4 participants 4 messages Jul 9 – Aug 20

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: rtc: Convert rtc-cmos binding to YAML

From: Teja Sai Charan Bellamkonda <[email protected]>

Convert the rtc-cmos devicetree bindings to dt schema.

The original text binding documents only the motorola,mc146818 compatible. Existing in-tree Devicetree sources also use the intel,ce4100-rtc compatible together with the motorola,mc146818 fallback, but this was not documented. Document the Intel variant in the schema so that these existing configurations are accepted during schema validation.

---

Changes in v2:
- Allow intel,ce4100-rtc compatible used by existing DTS files

Changes in v3:
- Drop accidentally added result.txt
- Fix example unit-address to match reg property

---
 .../devicetree/bindings/rtc/rtc-cmos.txt      | 27 --------
 .../devicetree/bindings/rtc/rtc-cmos.yaml     | 63 +++++++++++++++++++
 2 files changed, 63 insertions(+), 27 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-cmos.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
Documentation/devicetree/bindings/rtc/rtc-cmos.txt deleted +0 -27
deleted file mode 100644
index 7d7b5f6bda65..000000000000
@@ -1,27 +0,0 @@
- Motorola mc146818 compatible RTC
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-Required properties:
-  - compatible : "motorola,mc146818"
-  - reg : should contain registers location and length.
-
-Optional properties:
-  - interrupts : should contain interrupt.
-  - ctrl-reg : Contains the initial value of the control register also
-    called "Register B".
-  - freq-reg : Contains the initial value of the frequency register also
-    called "Register A".
-
-"Register A" and "B" are usually initialized by the firmware (BIOS for
-instance). If this is not done, it can be performed by the driver.
-
-ISA Example:
-
-	rtc@70 {
-	         compatible = "motorola,mc146818";
-	         interrupts = <8 3>;
-	         interrupt-parent = <&ioapic1>;
-	         ctrl-reg = <2>;
-	         freq-reg = <0x26>;
-	         reg = <1 0x70 2>;
-	 };
Documentation/devicetree/bindings/rtc/rtc-cmos.yaml new file +63 -0

63 lines not on this page · raw message

Signature · 1 line
2.43.0
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 4 lines

From: Teja Sai Charan Bellamkonda <[email protected]>

Convert the rtc-cmos devicetree bindings to dt schema.

Quoted 8 lines

The original text binding documents only the motorola,mc146818 compatible. Existing in-tree Devicetree sources also use the intel,ce4100-rtc compatible together with the motorola,mc146818 fallback, but this was not documented. Document the Intel variant in the schema so that these existing configurations are accepted during schema validation.

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v3 1/1
#2 lore raw
In reply to Teja Sai Charan B
Quoted 11 lines · Teja Sai Charan B

From: Teja Sai Charan Bellamkonda <[email protected]>

Convert the rtc-cmos devicetree bindings to dt schema.

The original text binding documents only the motorola,mc146818 compatible. Existing in-tree Devicetree sources also use the intel,ce4100-rtc compatible together with the motorola,mc146818 fallback, but this was not documented. Document the Intel variant in the schema so that these existing configurations are accepted during schema validation.

Quoted 3 lines

---

Best regards,
Krzysztof

maintainer Applied
#3 lore raw
In reply to Teja Sai Charan B
Quoted 10 lines · Teja Sai Charan B

Convert the rtc-cmos devicetree bindings to dt schema.

The original text binding documents only the motorola,mc146818 compatible. Existing in-tree Devicetree sources also use the intel,ce4100-rtc compatible together with the motorola,mc146818 fallback, but this was not documented. Document the Intel variant in the schema so that these existing configurations are accepted during schema validation.

[...]

Applied, thanks!

[1/1] dt-bindings: rtc: Convert rtc-cmos binding to YAML

      https://git.kernel.org/abelloni/c/745ca1b959d9

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com