Skip to contentSkip to conversation

arm64/pcie/pmu: Add pci id for LECARC pcie pmu

PATCH Superseded Braden Zhang 3 participants 3 messages Jul 10

Subsystems (2)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64/pcie/pmu: Add pci id for LECARC pcie pmu

From: Brett Zhou <[email protected]>

This patch adds support for the PCIe PMU found
on LECARC SoCs, which utilize the DesignWare PCIe Controller IP

---

---
Changes in v2:
- Format: repalce space with tab to separate the macro name and the value.
- Link to v1: https://patch.msgid.link/[email protected]

To: Bjorn Helgaas <[email protected]>
To: Jingoo Han <[email protected]>
To: Manivannan Sadhasivam <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 include/linux/pci_ids.h  | 1 +
 include/linux/pcie-dwc.h | 2 ++
 2 files changed, 3 insertions(+)
include/linux/pci_ids.h +1 -0
index 1c9d40e09107..eb0020f9d366 100644
@@ -173,6 +173,7 @@
 #define PCI_VENDOR_ID_DYNALINK		0x0675
 #define PCI_DEVICE_ID_DYNALINK_IS64PH	0x1702
 
+#define PCI_VENDOR_ID_LECARC		0x0720
 #define PCI_VENDOR_ID_UBIQUITI		0x0777
 
 #define PCI_VENDOR_ID_BERKOM			0x0871
include/linux/pcie-dwc.h +2 -0
index 8ff778e7aec0..1a31fe4db228 100644
@@ -32,6 +32,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
 	  .vsec_id = 0x02, .vsec_rev = 0x4 },
 	{ .vendor_id = PCI_VENDOR_ID_SAMSUNG,
 	  .vsec_id = 0x02, .vsec_rev = 0x4 },
+	{ .vendor_id = PCI_VENDOR_ID_LECARC,
+	  .vsec_id = 0x02, .vsec_rev = 0x4 },
 	{}
 };
 

---
base-commit: a635d6748234582ea287c5ffeae28b9b23f91c7e
change-id: 20260710-pcie-pmu-5ef78c56c3b6

Best regards,

Signature · 1 line
Braden Zhang <[email protected]>
#1 lore raw
Sashiko has reviewed this patch and found no issues. It looks great!
Quoted 6 lines

From: Brett Zhou <[email protected]>

This patch adds support for the PCIe PMU found
on LECARC SoCs, which utilize the DesignWare PCIe Controller IP

Sashiko has reviewed this patch and found no issues. It looks great!

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
#2 lore raw
In reply to Braden Zhang
Quoted 8 lines · Braden Zhang

From: Brett Zhou <[email protected]>

This patch adds support for the PCIe PMU found
on LECARC SoCs, which utilize the DesignWare PCIe Controller IP

---

Bad S-o-B chain ("---" shouldn't be in the middle because things after "---" get dropped).

Since PCI_VENDOR_ID_LECARC is only used in one place, please put the #define in include/linux/pcie-dwc.h for now, per comment at the top of pci_ids.h.

Is this all that's needed to enable the PMU on LECARC PCIe controllers? I see that the SoC uses DesignWare PCIe IP; is there already a native DWC driver that can operate this controller?

Update the subject line and commit log to follow the style of previous pcie-dwc.h changes.

Quoted 49 lines

---
Changes in v2:
- Format: repalce space with tab to separate the macro name and the value.
- Link to v1: https://patch.msgid.link/[email protected]

To: Bjorn Helgaas <[email protected]>
To: Jingoo Han <[email protected]>
To: Manivannan Sadhasivam <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 include/linux/pci_ids.h  | 1 +
 include/linux/pcie-dwc.h | 2 ++
 2 files changed, 3 insertions(+)
include/linux/pci_ids.h +1 -0
index 1c9d40e09107..eb0020f9d366 100644
@@ -173,6 +173,7 @@
 #define PCI_VENDOR_ID_DYNALINK		0x0675
 #define PCI_DEVICE_ID_DYNALINK_IS64PH	0x1702
 
+#define PCI_VENDOR_ID_LECARC		0x0720
 #define PCI_VENDOR_ID_UBIQUITI		0x0777
 
 #define PCI_VENDOR_ID_BERKOM			0x0871
include/linux/pcie-dwc.h +2 -1
index 8ff778e7aec0..1a31fe4db228 100644
@@ -32,6 +32,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
 	  .vsec_id = 0x02, .vsec_rev = 0x4 },
 	{ .vendor_id = PCI_VENDOR_ID_SAMSUNG,
 	  .vsec_id = 0x02, .vsec_rev = 0x4 },
+	{ .vendor_id = PCI_VENDOR_ID_LECARC,
+	  .vsec_id = 0x02, .vsec_rev = 0x4 },
 	{}
 };
 
 
---

base-commit: a635d6748234582ea287c5ffeae28b9b23f91c7e
change-id: 20260710-pcie-pmu-5ef78c56c3b6

Best regards,

Signature · 1 line
Braden Zhang <[email protected]>