package/mpd: fix build failure w/ fmt 12.2.0
PATCH v2 1/1 package/mpd: fix build failure w/ fmt 12.2.0
Building mpd with fmt 12.2.0 fails with:
../src/net/ToString.cxx: In function 'std::string ToString(SocketAddress)':
../src/net/ToString.cxx:80:37: error: 'format' is not a member of 'fmt'
80 | return fmt::format("[{}]:{}", host, serv);
| ^~~~~~
../src/net/ToString.cxx:84:29: error: 'format' is not a member of 'fmt'
84 | return fmt::format("{}:{}", host, serv);
| ^~~~~~
Root cause is an API change in fmt:
Made the <fmt/core.h> header equivalent to <fmt/base.h> by default. Code that relied on <fmt/core.h> pulling in <fmt/format.h> must now either include <fmt/format.h> directly or define FMT_DEPRECATED_HEAVY_CORE to opt back in. (https://github.com/fmtlib/fmt/releases#release-12.2.0)
Add a patch containing the corresponding upstream commit
(https://github.com/MusicPlayerDaemon/MPD/commit/88d5b52).
--- ...pport-use-fmt-format.h-not-fmt-core..patch | 220 ++++++++++++++++++ 1 file changed, 220 insertions(+) create mode 100644 package/mpd/0002-libfmt-12.2.0-support-use-fmt-format.h-not-fmt-core..patch
package/mpd/0002-libfmt-12.2.0-support-use-fmt-format.h-not-fmt-core..patch new file +220 -0
@@ -0,0 +1,220 @@ +Building mpd 0.24.12 with fmt 12.2.0 fails with: + +../src/net/ToString.cxx: In function 'std::string ToString(SocketAddress)': +../src/net/ToString.cxx:80:37: error: 'format' is not a member of 'fmt' + 80 | return fmt::format("[{}]:{}", host, serv); + | ^~~~~~ +../src/net/ToString.cxx:84:29: error: 'format' is not a member of 'fmt' + 84 | return fmt::format("{}:{}", host, serv); + | ^~~~~~ + +Root cause is an API change in fmt: + +Made the <fmt/core.h> header equivalent to <fmt/base.h> by default. Code +that relied on <fmt/core.h> pulling in <fmt/format.h> must now either +include <fmt/format.h> directly or define FMT_DEPRECATED_HEAVY_CORE to +opt back in. (https://github.com/fmtlib/fmt/releases#release-12.2.0) + +Add the corresponding upstream fix in this patch. + +Upstream: https://github.com/MusicPlayerDaemon/MPD/commit/88d5b52 +Signed-off-by: Andreas Ziegler <[email protected]> +--- +From 88d5b5248d71862815da336cfd1c6f66626bb4d4 Mon Sep 17 00:00:00 2001 +From: Rudi Heitbaum <[email protected]> +Date: Thu, 18 Jun 2026 13:32:33 +0000 +Subject: [PATCH] libfmt 12.2.0 support: use fmt/format.h not fmt/core.h + +Since libfmt 12.2.0, fmt/core.h is a shim that only includes +fmt/base.h which does not provide fmt::format(). Include +fmt/format.h directly in files that call fmt::format(). + +Signed-off-by: Rudi Heitbaum <[email protected]> +--- + src/input/plugins/AlsaInputPlugin.cxx | 2 +- + src/input/plugins/QobuzClient.cxx | 2 +- + src/input/plugins/QobuzLoginRequest.cxx | 2 +- + src/input/plugins/QobuzTrackRequest.cxx | 2 +- + src/lib/avahi/Publisher.cxx | 2 +- + src/lib/nfs/FileReader.cxx | 2 +- + src/net/ToString.cxx | 2 +- + src/output/plugins/httpd/HttpdClient.cxx | 2 +- + src/output/plugins/httpd/IcyMetaDataServer.cxx | 2 +- + src/song/AddedSinceSongFilter.cxx | 2 +- + src/song/AudioFormatSongFilter.cxx | 2 +- + src/song/ModifiedSinceSongFilter.cxx | 2 +- + src/storage/plugins/NfsStorage.cxx | 2 +- + 13 files changed, 13 insertions(+), 13 deletions(-) + +diff --git a/src/input/plugins/AlsaInputPlugin.cxx b/src/input/plugins/AlsaInputPlugin.cxx +index 6bf8034dc..5fc8dd99a 100644 +--- a/src/input/plugins/AlsaInputPlugin.cxx ++++ b/src/input/plugins/AlsaInputPlugin.cxx +@@ -27,7 +27,7 @@ + + #include <alsa/asoundlib.h> + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <cassert> + +diff --git a/src/input/plugins/QobuzClient.cxx b/src/input/plugins/QobuzClient.cxx +index 233c1bbad..92de56695 100644 +--- a/src/input/plugins/QobuzClient.cxx ++++ b/src/input/plugins/QobuzClient.cxx +@@ -5,7 +5,7 @@ + #include "lib/crypto/MD5.hxx" + #include "thread/ScopeUnlock.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <cassert> + #include <stdexcept> +diff --git a/src/input/plugins/QobuzLoginRequest.cxx b/src/input/plugins/QobuzLoginRequest.cxx +index 41d4dcabf..7e2e6b64c 100644 +--- a/src/input/plugins/QobuzLoginRequest.cxx ++++ b/src/input/plugins/QobuzLoginRequest.cxx +@@ -6,7 +6,7 @@ + #include "QobuzSession.hxx" + #include "lib/curl/Form.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + #include <nlohmann/json.hpp> + + #include <cassert> +diff --git a/src/input/plugins/QobuzTrackRequest.cxx b/src/input/plugins/QobuzTrackRequest.cxx +index 59b6cf480..3de5e7ea0 100644 +--- a/src/input/plugins/QobuzTrackRequest.cxx ++++ b/src/input/plugins/QobuzTrackRequest.cxx +@@ -5,7 +5,7 @@ + #include "QobuzErrorParser.hxx" + #include "QobuzClient.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + #include <nlohmann/json.hpp> + + using std::string_view_literals::operator""sv; +diff --git a/src/lib/avahi/Publisher.cxx b/src/lib/avahi/Publisher.cxx +index 1ac4d61e6..174f57198 100644 +--- a/src/lib/avahi/Publisher.cxx ++++ b/src/lib/avahi/Publisher.cxx +@@ -13,7 +13,7 @@ + #include <avahi-common/malloc.h> + #include <avahi-common/alternative.h> + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <cassert> + +diff --git a/src/lib/nfs/FileReader.cxx b/src/lib/nfs/FileReader.cxx +index 20b79ce3c..2678039e2 100644 +--- a/src/lib/nfs/FileReader.cxx ++++ b/src/lib/nfs/FileReader.cxx +@@ -10,7 +10,7 @@ + + #include <nfsc/libnfs.h> // for struct nfs_stat_64 + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <cassert> + #include <cstring> +diff --git a/src/net/ToString.cxx b/src/net/ToString.cxx +index 41421d8e5..046257cb2 100644 +--- a/src/net/ToString.cxx ++++ b/src/net/ToString.cxx +@@ -6,7 +6,7 @@ + #include "SocketAddress.hxx" + #include "IPv4Address.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <algorithm> + #include <cassert> +diff --git a/src/output/plugins/httpd/HttpdClient.cxx b/src/output/plugins/httpd/HttpdClient.cxx +index 7192b6ae4..5b23a385c 100644 +--- a/src/output/plugins/httpd/HttpdClient.cxx ++++ b/src/output/plugins/httpd/HttpdClient.cxx +@@ -13,7 +13,7 @@ + #include "util/StringSplit.hxx" + #include "Log.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <cassert> + +diff --git a/src/output/plugins/httpd/IcyMetaDataServer.cxx b/src/output/plugins/httpd/IcyMetaDataServer.cxx +index 0314089f1..0796bffcb 100644 +--- a/src/output/plugins/httpd/IcyMetaDataServer.cxx ++++ b/src/output/plugins/httpd/IcyMetaDataServer.cxx +@@ -5,7 +5,7 @@ + #include "tag/Tag.hxx" + #include "util/TruncateString.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <iterator> + +diff --git a/src/song/AddedSinceSongFilter.cxx b/src/song/AddedSinceSongFilter.cxx +index efc394fd0..dfe397542 100644 +--- a/src/song/AddedSinceSongFilter.cxx ++++ b/src/song/AddedSinceSongFilter.cxx +@@ -6,7 +6,7 @@ + #include "time/ISO8601.hxx" + #include "util/StringBuffer.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + using std::string_view_literals::operator""sv; + +diff --git a/src/song/AudioFormatSongFilter.cxx b/src/song/AudioFormatSongFilter.cxx +index 69bd2b1a8..c1f209730 100644 +--- a/src/song/AudioFormatSongFilter.cxx ++++ b/src/song/AudioFormatSongFilter.cxx +@@ -5,7 +5,7 @@ + #include "LightSong.hxx" + #include "util/StringBuffer.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + using std::string_view_literals::operator""sv; + +diff --git a/src/song/ModifiedSinceSongFilter.cxx b/src/song/ModifiedSinceSongFilter.cxx +index 43879c789..715f65e15 100644 +--- a/src/song/ModifiedSinceSongFilter.cxx ++++ b/src/song/ModifiedSinceSongFilter.cxx +@@ -6,7 +6,7 @@ + #include "time/ISO8601.hxx" + #include "util/StringBuffer.hxx" + +-#include <fmt/core.h> ++#include <fmt/format.h> + + using std::string_view_literals::operator""sv; + +diff --git a/src/storage/plugins/NfsStorage.cxx b/src/storage/plugins/NfsStorage.cxx +index 106afe788..b69ee807c 100644 +--- a/src/storage/plugins/NfsStorage.cxx ++++ b/src/storage/plugins/NfsStorage.cxx +@@ -29,7 +29,7 @@ extern "C" { + #include <nfsc/libnfs-raw-nfs.h> + } + +-#include <fmt/core.h> ++#include <fmt/format.h> + + #include <cassert> + #include <string> +-- +2.53.0 +
Signature · 6 lines
2.53.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 1/1 package/mpd: update to version 0.24.13
Version 0.24.13 change log:
* configuration
- add range checks to number parser
- copy replay_gain_mode when creating a new partition
* storage
- curl: eliminate auth probe requests
* decoder
- opus: do not add 5 dB to Opus header playback gain
* tags:
- id3: limit ID3 tags to 4 MB
* output
- pipewire: fix file descriptor leak bug after connect failure
- pipewire: support the "media.album" tag
* systemd: allow AF_NETLINK when UPnP is enabled
In addition, the fix for fmt 12.2.0 is also included in this release
(https://github.com/MusicPlayerDaemon/MPD/commit/88d5b52).
Fixes:
../src/net/ToString.cxx: In function 'std::string ToString(SocketAddress)':
../src/net/ToString.cxx:80:37: error: 'format' is not a member of 'fmt'
80 | return fmt::format("[{}]:{}", host, serv);
| ^~~~~~
--- package/mpd/mpd.hash | 2 +- package/mpd/mpd.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/mpd/mpd.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated after checking pgp signature -sha256 14223ca883c35fbf711994bcf745726cecc9d898e3d3964265cf3a2c7519a360 mpd-0.24.12.tar.xz +sha256 9f215a081cc1f7c98fcccc6620f4cb705b14ba2d87fd99e062dd0804e2e3d96e mpd-0.24.13.tar.xz sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING
package/mpd/mpd.mk +1 -1
@@ -5,7 +5,7 @@ ################################################################################ MPD_VERSION_MAJOR = 0.24 -MPD_VERSION = $(MPD_VERSION_MAJOR).12 +MPD_VERSION = $(MPD_VERSION_MAJOR).13 MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz MPD_SITE = https://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR) MPD_DEPENDENCIES = host-pkgconf fmt
Signature · 6 lines
2.53.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot