Skip to contentSkip to conversation

Enable Ethernet boot on SK-AM62A-LP

PATCH Superseded Chintan Vankar 3 participants 12 messages Jul 10 – Jul 15 Arm (32-bit)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Enable Ethernet boot on SK-AM62A-LP

This series enables Ethernet boot on SK-AM62A-LP. The series is based on commit 'a18265f1ccb7' of origin/next branch of U-Boot repo.

Link to v1:
https://lore.kernel.org/all/[email protected]/

Logs:
https://gist.github.com/chintan013/db875ef8b703094af70ca681659ba7f0

Changes from v1 to v2:
-> Removed the duplicate config options from r5 and a53 defconfig. -> Updated commit message for [PATCH 1/3].

Chintan Vankar (3):
configs: am62ax_evm_r5_ethboot: Enable config options required for
Ethernet boot
configs: am62ax_evm_a53_ethboot: Enable config options required to
enable Ethernet boot
arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

 arch/arm/dts/k3-am62a7-r5-sk.dts         |  5 +++++
 configs/am62ax_evm_a53_ethboot_defconfig | 10 ++++++++++
 configs/am62ax_evm_r5_ethboot_defconfig  | 22 ++++++++++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 configs/am62ax_evm_a53_ethboot_defconfig
 create mode 100644 configs/am62ax_evm_r5_ethboot_defconfig
Signature · 1 line
2.34.1
#1 lore raw

PATCH v2 1/3 configs: am62ax_evm_r5_ethboot: Enable config options required for Ethernet boot

The R5 SPL SRAM size is limited and cannot accommodate both MMC boot and Ethernet boot config options simultaneously. Add a dedicated defconfig that enables the Ethernet boot on SK-AM62A-LP for R5 SPL stage.

---

Link to v1:
https://lore.kernel.org/all/[email protected]/

Changes from v1 to v2:
-> Removed the duplicate config options.
-> Updated commit message for [PATCH 1/3].

 configs/am62ax_evm_r5_ethboot_defconfig | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 configs/am62ax_evm_r5_ethboot_defconfig
configs/am62ax_evm_r5_ethboot_defconfig new file +22 -0
new file mode 100644
index 00000000000..2986feef29a
@@ -0,0 +1,22 @@
+#include <configs/am62ax_evm_r5_defconfig>
+
+# CONFIG_NO_NET is not set
+CONFIG_SPL_GPIO=y
+CONFIG_SPL_MMC=n
+CONFIG_SPL_BOARD_INIT=y
+CONFIG_SPL_STACK_R_ADDR=0x82000000
+CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x200000
+CONFIG_SPL_DMA=y
+CONFIG_SPL_ENV_SUPPORT=y
+CONFIG_SPL_ETH=y
+CONFIG_SPL_I2C=y
+CONFIG_NET=y
+CONFIG_SPL_NET=y
+CONFIG_SPL_NET_VCI_STRING="AM62AX U-Boot R5 SPL"
+CONFIG_CMD_DHCP=y
+CONFIG_SPL_SYSCON=y
+CONFIG_DMA_CHANNELS=y
+CONFIG_TI_K3_NAVSS_UDMA=y
+CONFIG_DM_I2C=y
+CONFIG_PHY_TI_DP83867=y
+CONFIG_TI_AM65_CPSW_NUSS=y
Signature · 1 line
2.34.1
Reviewed-by on v2 1/3
#2 lore raw

Re: [PATCH v2 1/3] configs: am62ax_evm_r5_ethboot: Enable config options required for Ethernet boot

configs/am62ax_evm_r5_ethboot_defconfig line 6

Quoted 12 lines · Chintan Vankar
configs/am62ax_evm_r5_ethboot_defconfig new file +6 -0
new file mode 100644
index 000000000000..2986feef29a5
@@ -0,0 +1,22 @@
+#include <configs/am62ax_evm_r5_defconfig>
+
+# CONFIG_NO_NET is not set
+CONFIG_SPL_GPIO=y
+CONFIG_SPL_MMC=n
+CONFIG_SPL_BOARD_INIT=y

We already enable SPL_BOARD_INIT for the r5 and a53 defconfigs, rest looks good to me.

Signature · 1 line
Anshul Dalal <[email protected]>
#3 lore raw

PATCH v2 2/3 configs: am62ax_evm_a53_ethboot: Enable config options required to enable Ethernet boot

In reply to Chintan Vankar

Enable config options required to enable Ethernet boot on SK-AM62A-LP for A53 SPL stage.

---

Link to v1:
https://lore.kernel.org/all/[email protected]/

Changes from v1 to v2:
-> Removed the duplicate config options.

 configs/am62ax_evm_a53_ethboot_defconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)
 create mode 100644 configs/am62ax_evm_a53_ethboot_defconfig
configs/am62ax_evm_a53_ethboot_defconfig new file +10 -0
new file mode 100644
index 00000000000..a3ac67feb85
@@ -0,0 +1,10 @@
+#include <configs/am62ax_evm_a53_defconfig>
+
+CONFIG_SPL_DRIVERS_MISC=y
+CONFIG_SPL_BOARD_INIT=y
+CONFIG_SPL_DMA=y
+CONFIG_SPL_ENV_SUPPORT=y
+CONFIG_SPL_ETH=y
+CONFIG_SPL_NET=y
+CONFIG_SPL_NET_VCI_STRING="AM62AX U-Boot A53 SPL"
+CONFIG_SPL_SYSCON=y
Signature · 1 line
2.34.1
Reviewed-by on v2 2/3
#4 lore raw

Re: [PATCH v2 2/3] configs: am62ax_evm_a53_ethboot: Enable config options required to enable Ethernet boot

Quoted 2 lines · Chintan Vankar

Enable config options required to enable Ethernet boot on SK-AM62A-LP for A53 SPL stage.

Signature · 1 line
Anshul Dalal <[email protected]>
#5 lore raw

PATCH v2 3/3 arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

In reply to Chintan Vankar

Enable DM services for main_pktdma during R5 SPL stage.

---

Link to v1:
https://lore.kernel.org/all/[email protected]/

Changes from v1 to v2:
- No changes.

 arch/arm/dts/k3-am62a7-r5-sk.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/dts/k3-am62a7-r5-sk.dts +5 -0
index 4570ff6edbf..9c2a6bf89a9 100644
@@ -42,3 +42,8 @@
 	status = "okay";
 	bootph-pre-ram;
 };
+
+&main_pktdma {
+	ti,sci = <&dm_tifs>;
+	bootph-all;
+};
Signature · 1 line
2.34.1
#6 lore raw

Re: [PATCH v2 3/3] arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

arch/arm/dts/k3-am62a7-r5-sk.dts line 49

Quoted 13 lines · Chintan Vankar
arch/arm/dts/k3-am62a7-r5-sk.dts +5 -0
index 4570ff6edbf7..9c2a6bf89a92 100644
@@ -42,3 +42,8 @@
 	status = "okay";
 	bootph-pre-ram;
 };
+
+&main_pktdma {
+	ti,sci = <&dm_tifs>;
+	bootph-all;
+};

We should have this as part of 'k3-am62a7-r5.dtsi' so that other boards can also get OOB ethernet boot by just modifying their defconfig.

Signature · 1 line
Anshul Dalal <[email protected]>
#7 lore raw

Re: [PATCH v2 3/3] arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

Quoted 18 lines · Anshul Dalal

arch/arm/dts/k3-am62a7-r5-sk.dts line 49

Quoted 13 lines · Chintan Vankar
arch/arm/dts/k3-am62a7-r5-sk.dts +5 -0
index 4570ff6edbf7..9c2a6bf89a92 100644
@@ -42,3 +42,8 @@
 	status = "okay";
 	bootph-pre-ram;
 };
+
+&main_pktdma {
+	ti,sci = <&dm_tifs>;
+	bootph-all;
+};

We should have this as part of 'k3-am62a7-r5.dtsi' so that other boards can also get OOB ethernet boot by just modifying their defconfig.

You can set the boot phase tag in the Linux/upstream device tree. This is also what is done for other nodes required for booting.

#8 lore raw

Re: [PATCH v2 3/3] arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

Hello Wadim, Anshul,

Quoted 22 lines · Wadim Egorov
Quoted 18 lines · Anshul Dalal

arch/arm/dts/k3-am62a7-r5-sk.dts line 49

Quoted 13 lines · Chintan Vankar
arch/arm/dts/k3-am62a7-r5-sk.dts +5 -0
index 4570ff6edbf7..9c2a6bf89a92 100644
@@ -42,3 +42,8 @@
  	status = "okay";
  	bootph-pre-ram;
  };
+
+&main_pktdma {
+	ti,sci = <&dm_tifs>;
+	bootph-all;
+};

We should have this as part of 'k3-am62a7-r5.dtsi' so that other boards can also get OOB ethernet boot by just modifying their defconfig.

Quoted 1 line

You can set the boot phase tag in the Linux/upstream device tree. This is also what is done for other nodes required for booting.

I agree with you, I have enabled boot phase tag in a similar manner, I added the "bootph-all" property along with the "ti,sci" property there was no specific reason to add "bootph-all" property. I will go with your approach.

Regards,
Chintan.

Tested-by on the v2 series
#9 lore raw
In reply to Chintan Vankar
Quoted 6 lines · Chintan Vankar

This series enables Ethernet boot on SK-AM62A-LP. The series is based on commit 'a18265f1ccb7' of origin/next branch of U-Boot repo.

Link to v1:
https://lore.kernel.org/all/[email protected]/

Quoted 6 lines

Logs:
https://gist.github.com/chintan013/db875ef8b703094af70ca681659ba7f0

Changes from v1 to v2:
-> Removed the duplicate config options from r5 and a53 defconfig. -> Updated commit message for [PATCH 1/3].

Tested on AM62A EVM with the below patch applied:
https://lore.kernel.org/all/[email protected]/

Logs:
https://gist.github.com/ArchUsr64/3265edca99084022a128bb51cd142cb5

Signature · 1 line
Anshul Dalal <[email protected]>
#10 lore raw
In reply to Chintan Vankar
Quoted 9 lines · Chintan Vankar

This series enables Ethernet boot on SK-AM62A-LP. The series is based on commit 'a18265f1ccb7' of origin/next branch of U-Boot repo.

Link to v1:
https://lore.kernel.org/all/[email protected]/

Logs:
https://gist.github.com/chintan013/db875ef8b703094af70ca681659ba7f0

I forgot to mention in my last reply but with ethernet boot added, it would be helpful to document it in the respective board RST as well.

Quoted 17 lines

Changes from v1 to v2:
-> Removed the duplicate config options from r5 and a53 defconfig. -> Updated commit message for [PATCH 1/3].

Chintan Vankar (3):
configs: am62ax_evm_r5_ethboot: Enable config options required for
Ethernet boot
configs: am62ax_evm_a53_ethboot: Enable config options required to
enable Ethernet boot
arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

 arch/arm/dts/k3-am62a7-r5-sk.dts         |  5 +++++
 configs/am62ax_evm_a53_ethboot_defconfig | 10 ++++++++++
 configs/am62ax_evm_r5_ethboot_defconfig  | 22 ++++++++++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 configs/am62ax_evm_a53_ethboot_defconfig
 create mode 100644 configs/am62ax_evm_r5_ethboot_defconfig
#11 lore raw

Hello Anshul,

Quoted 7 lines · Anshul Dalal
Quoted 6 lines · Chintan Vankar

This series enables Ethernet boot on SK-AM62A-LP. The series is based on commit 'a18265f1ccb7' of origin/next branch of U-Boot repo.

Link to v1:
https://lore.kernel.org/all/[email protected]/

Quoted 7 lines
Quoted 3 lines

Logs:
https://gist.github.com/chintan013/db875ef8b703094af70ca681659ba7f0

I forgot to mention in my last reply but with ethernet boot added, it would be helpful to document it in the respective board RST as well.

Thanks for testing the feature, I will add the documentation in next version.

Regards,
Chintan.

Quoted 18 lines
Quoted 17 lines

Changes from v1 to v2:
-> Removed the duplicate config options from r5 and a53 defconfig. -> Updated commit message for [PATCH 1/3].

Chintan Vankar (3):
configs: am62ax_evm_r5_ethboot: Enable config options required for
Ethernet boot
configs: am62ax_evm_a53_ethboot: Enable config options required to
enable Ethernet boot
arm: dts: k3-am62a7-sk-u-boot: Enable DM services for main_pktdma

  arch/arm/dts/k3-am62a7-r5-sk.dts         |  5 +++++
  configs/am62ax_evm_a53_ethboot_defconfig | 10 ++++++++++
  configs/am62ax_evm_r5_ethboot_defconfig  | 22 ++++++++++++++++++++++
  3 files changed, 37 insertions(+)

create mode 100644 configs/am62ax_evm_a53_ethboot_defconfig create mode 100644 configs/am62ax_evm_r5_ethboot_defconfig