Skip to contentSkip to conversation

netfilter: x_physdev: masks are not c-strings

PATCH New Florian Westphal 1 participant 1 message Jul 10

Subsystems (2)
lore
Share & tools
lore

Florian Westphal

author maintainer
#0 lore raw

PATCH 1/1 netfilter: x_physdev: masks are not c-strings

... and must not be subjected to the 'nul terminated' constraint. If the interface name is 15 characters long, the mask is 16-bytes '0xff' (to cover for \0) and the valid device name is rejected.

Fixes 8df772afc9d0 ("netfilter: x_physdev: reject empty or not-nul terminated device names")

---
I'm dumb. I pushed a test case to iptables.git and will include this in todays nf -> net batch.

 net/netfilter/xt_physdev.c | 5 -----
 1 file changed, 5 deletions(-)
net/netfilter/xt_physdev.c +0 -5
index dd98f758176c..a388881c68d4 100644
@@ -130,11 +130,6 @@ static int physdev_mt_check(const struct xt_mtchk_param *par)
 		if (X(physoutdev))
 			return -ENAMETOOLONG;
 	}
-
-	if (X(in_mask))
-		return -ENAMETOOLONG;
-	if (X(out_mask))
-		return -ENAMETOOLONG;
 #undef X
 
 	if (!brnf_probed) {
Signature · 1 line
2.54.0