KVM: x86: Fix null pointer dereference in trace_kvm_inj_exception
PATCH 1/1 KVM: x86: Fix null pointer dereference in trace_kvm_inj_exception
The trace_kvm_inj_exception tracepoint takes as arguments the exception vector, whether the exception has an error code (and subsequently, the error code), and whether it is being reinjected. The error code is formatted to the trace log as a string using __print_symbolic, which takes an integer value and an array of structs containing a mask value and a string. An empty struct is being passed, which makes the kernel derefence a NULL pointer when the error code is 0. Remove this stray struct in the invocation of __print_symbolic.
--- arch/x86/kvm/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/trace.h +1 -1
@@ -490,7 +490,7 @@ TRACE_EVENT(kvm_inj_exception,TP_printk ("%s%s%s%s%s" ,__print_symbolic (__entry->exception, kvm_trace_sym_exc), !__entry->has_error ?"" :" (" , - !__entry->has_error ?"" :__print_symbolic (__entry->error_code, { }), + !__entry->has_error ?"" :__print_symbolic (__entry->error_code), !__entry->has_error ?"" :")" , __entry->reinjected ?" [reinjected]" :"" ) );
Signature · 1 line
2.55.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The proposed fix is based on a false premise. The commit message incorrectly claims the original…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The proposed fix is based on a false premise. The commit message incorrectly claims the original code causes a kernel NULL pointer dereference, but the original code safely handled the empty struct.
- [Low] Removing the variadic argument from the __print_symbolic macro causes a syntax error during macro expansion, which unconditionally breaks the kernel build.
--
--- Patch [1]: [PATCH] KVM: x86: Fix null pointer dereference in trace_kvm_inj_exception --- commit ed0cb139106d0eebc245569ae242561a63dc2bb7
Author: Daniel Paziyski <[email protected]>
KVM: x86: Fix null pointer dereference in trace_kvm_inj_exception
This patch modifies the kvm_inj_exception tracepoint to remove an empty struct passed to __print_symbolic for formatting the exception error code.
Quoted 3 lines
An empty struct is being passed, which makes the
kernel derefence a NULL pointer when the error code is 0. Remove this stray struct in the invocation of__print_symbolic.
[Severity: Medium]
Is this description of a null pointer dereference accurate?
Looking at how __print_symbolic expands, the empty struct { } safely initializes the first element's name pointer to NULL. When trace_print_symbols_seq() is called, it handles this gracefully:
kernel/trace/trace_output.c:trace_print_symbols_seq() {
...
for (i = 0; symbol_array[i].name; i++) {
...
}Since the name field is NULL for the first element, the loop is bypassed entirely and the function safely falls back to printing the error code as a hex string without dereferencing a NULL pointer.
arch/x86/kvm/trace.h TRACE_EVENT(kvm_inj_exception, · line 493
Quoted 9 lines
arch/x86/kvm/trace.h +1
-1@@ -490,7 +490,7 @@ TRACE_EVENT(kvm_inj_exception, TP_printk("%s%s%s%s%s", __print_symbolic(__entry->exception, kvm_trace_sym_exc), !__entry->has_error ? "" : " (", - !__entry->has_error ? "" : __print_symbolic(__entry->error_code, { }), + !__entry->has_error ? "" : __print_symbolic(__entry->error_code),
[Severity: Low]
Will this change break the kernel build?
The __print_symbolic macro expects a symbol_array as the second argument. By omitting it, the preprocessor will expand the macro to something similar to:
static const struct trace_print_flags symbols[] = { , { -1, NULL }};
Does this result in a syntax error during macro expansion due to the missing expression before the comma?
Quoted 3 lines
arch/x86/kvm/trace.h +0
-0!__entry->has_error ?"" :")" , __entry->reinjected ? " [reinjected]" : "") );
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Sean Christopherson
maintainerQuoted 6 lines · On Fri, Jul 10, 2026, [email protected] wrote:
Quoted 3 lines
An empty struct is being passed, which makes the
kernel derefence a NULL pointer when the error code is 0. Remove this stray struct in the invocation of__print_symbolic.[Severity: Medium]
Is this description of a null pointer dereference accurate?
Yes, it is. Sashiko apparently applied to an old base (pre-7.1). As of commit 754e38d2d1ae ("tracing: Use explicit array size instead of sentinel elements in symbol printing") (spoiler alert), trace_print_symbols_seq() is:
for (i = 0; i < symbol_array_size; i++) {
if (val != symbol_array[i].mask)
continue;
trace_seq_puts(p, symbol_array[i].name);
break;
}Quoted 14 lines
Looking at how
__print_symbolicexpands, the empty struct { } safely initializes the first element's name pointer to NULL. Whentrace_print_symbols_seq()is called, it handles this gracefully:kernel/trace/trace_output.c:trace_print_symbols_seq() { ... for (i = 0; symbol_array[i].name; i++) { ... }Since the name field is NULL for the first element, the loop is bypassed entirely and the function safely falls back to printing the error code as a hex string without dereferencing a NULL pointer.
Quoted 12 lines
arch/x86/kvm/trace.h TRACE_EVENT(kvm_inj_exception, · line 493
Quoted 9 lines
arch/x86/kvm/trace.h +1
-1@@ -490,7 +490,7 @@ TRACE_EVENT(kvm_inj_exception, TP_printk("%s%s%s%s%s", __print_symbolic(__entry->exception, kvm_trace_sym_exc), !__entry->has_error ? "" : " (", - !__entry->has_error ? "" : __print_symbolic(__entry->error_code, { }), + !__entry->has_error ? "" : __print_symbolic(__entry->error_code),[Severity: Low]
Will this change break the kernel build?
No, beacuse again, Sashiko applied to an old base for some reason.
Sean Christopherson
maintainer+The Other Thomas
Just as an FYI, commit 754e38d2d1ae ("tracing: Use explicit array size instead of sentinel elements in symbol printing") broke KVM abuse of __print_symbolic() where KVM deliberately passed in an "null" array to avoid printing 0x0 when there is no error code.
I did a half-assed search through the other usage of __print_symbolic() and didn't see anything, but just in case someone else comes complaining...
Quoted 8 lines · Daniel Paziyski
The
trace_kvm_inj_exceptiontracepoint takes as arguments the exception vector, whether the exception has an error code (and subsequently, the error code), and whether it is being reinjected. The error code is formatted to the trace log as a string using__print_symbolic, which takes an integer value and an array of structs containing a mask value and a string. An empty struct is being passed, which makes the kernel derefence a NULL pointer when the error code is 0. Remove this stray struct in the invocation of__print_symbolic.
In the future please provide a splat in the changelog, especially in this age of agentic bug hunters that are prone to making things up. My initial reaction to this was "no way". Thankfully, I tried reproducing the bug before making an ass out of myself :-)
BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: Oops: 0000 [#1] SMP CPU: 20 UID: 0 PID: 791 Comm: less Not tainted 7.2.0-rc2-3ffd29d795c9-x86_trace_ex_null_ptr_deref-vm #401 PREEMPT Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 RIP: 0010:strlen+0x0/0x20 Call Trace: <TASK> trace_seq_puts+0x18/0x80 trace_print_symbols_seq+0x68/0xa0 trace_raw_output_kvm_inj_exception+0x64/0xf0 [kvm] s_show+0x47/0x110 seq_read_iter+0x2a5/0x4c0 seq_read+0xfd/0x130 vfs_read+0xb6/0x330 ? vfs_write+0x2f2/0x3f0 ksys_read+0x61/0xd0 do_syscall_64+0xb7/0x570 entry_SYSCALL_64_after_hwframe+0x4b/0x53 RIP: 0033:0x7ff283714862 </TASK>
I'll also massage the changelog to explain why KVM is absuing __print_symbolic() (see commit 21d4c575eb4a ("KVM: x86: Print error code in exception injection tracepoint iff valid")).
No need for a v2, I'll fixup when applying.
Thanks!
Quoted 21 lines
Signed-off-by Daniel Paziyski <[email protected]>--- arch/x86/kvm/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/kvm/trace.h +1
-1@@ -490,7 +490,7 @@ TRACE_EVENT(kvm_inj_exception,TP_printk ("%s%s%s%s%s" ,__print_symbolic (__entry->exception, kvm_trace_sym_exc), !__entry->has_error ?"" :" (" , - !__entry->has_error ?"" :__print_symbolic (__entry->error_code, { }), + !__entry->has_error ?"" :__print_symbolic (__entry->error_code), !__entry->has_error ?"" :")" , __entry->reinjected ?" [reinjected]" :"" ) );Signature · 1 line
2.55.0
Thank you for the response!
Thomas Weißschuh
Reviewed-byHi Sean,
Quoted 1 line · Sean Christopherson
+The Other Thomas
Thanks for the forward.
Quoted 50 lines
Just as an FYI, commit
754e38d2d1ae("tracing: Use explicit array size instead of sentinel elements in symbol printing") broke KVM abuse of__print_symbolic()where KVM deliberately passed in an "null" array to avoid printing0x0when there is no error code.I did a half-assed search through the other usage of
__print_symbolic()and didn't see anything, but just in case someone else comes complaining...Quoted 8 lines · Daniel Paziyski
The
trace_kvm_inj_exceptiontracepoint takes as arguments the exception vector, whether the exception has an error code (and subsequently, the error code), and whether it is being reinjected. The error code is formatted to the trace log as a string using__print_symbolic, which takes an integer value and an array of structs containing a mask value and a string. An empty struct is being passed, which makes the kernel derefence a NULL pointer when the error code is 0. Remove this stray struct in the invocation of__print_symbolic.Fixes 754e38d2d1ae ("tracing: Use explicit array size instead of sentinel elements in symbol printing")In the future please provide a splat in the changelog, especially in this age of agentic bug hunters that are prone to making things up. My initial reaction to this was "no way". Thankfully, I tried reproducing the bug before making an ass out of myself :-)
BUG: kernel NULL pointer dereference, address: 0000000000000000 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: Oops: 0000 [#1] SMP CPU: 20 UID: 0 PID: 791 Comm: less Not tainted 7.2.0-rc2-3ffd29d795c9-x86_trace_ex_null_ptr_deref-vm #401 PREEMPT Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 RIP: 0010:strlen+0x0/0x20 Call Trace: <TASK> trace_seq_puts+0x18/0x80 trace_print_symbols_seq+0x68/0xa0 trace_raw_output_kvm_inj_exception+0x64/0xf0 [kvm] s_show+0x47/0x110 seq_read_iter+0x2a5/0x4c0 seq_read+0xfd/0x130 vfs_read+0xb6/0x330 ? vfs_write+0x2f2/0x3f0 ksys_read+0x61/0xd0 do_syscall_64+0xb7/0x570 entry_SYSCALL_64_after_hwframe+0x4b/0x53 RIP: 0033:0x7ff283714862 </TASK>
Quoted 9 lines
I'll also massage the changelog to explain why KVM is absuing
__print_symbolic()(see commit21d4c575eb4a("KVM: x86: Print error code in exception injection tracepoint iff valid")).No need for a v2, I'll fixup when applying.
Thanks!
Quoted 1 line
Signed-off-by Daniel Paziyski <[email protected]>
Quoted 4 lines
Quoted 4 lines
--- arch/x86/kvm/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 10 lines
arch/x86/kvm/trace.h TRACE_EVENT(kvm_inj_exception, · line 493
Quoted 10 lines
arch/x86/kvm/trace.h +1
-1@@ -490,7 +490,7 @@ TRACE_EVENT(kvm_inj_exception, TP_printk("%s%s%s%s%s", __print_symbolic(__entry->exception, kvm_trace_sym_exc), !__entry->has_error ? "" : " (", - !__entry->has_error ? "" : __print_symbolic(__entry->error_code, { }), + !__entry->has_error ? "" : __print_symbolic(__entry->error_code),
You could use a printf precision to reduce the hackery and get the desired behavior:
TP_printk("...%.*s...",
...
__entry->has_error && __entry->error_code != 0 ? 100 : 0,
__print_symbolic(__entry->error_code),
...(Unfortunately Linux printf does not handle negative precisions correctly.)
Quoted 6 lines
Quoted 6 lines
arch/x86/kvm/trace.h +0
-0!__entry->has_error ?"" :")" , __entry->reinjected ? " [reinjected]" : "") );Signature · 1 line
2.55.0
Quoted 10 lines · Daniel Paziyski
The
trace_kvm_inj_exceptiontracepoint takes as arguments the exception vector, whether the exception has an error code (and subsequently, the error code), and whether it is being reinjected. The error code is formatted to the trace log as a string using__print_symbolic, which takes an integer value and an array of structs containing a mask value and a string. An empty struct is being passed, which makes the kernel derefence a NULL pointer when the error code is 0. Remove this stray struct in the invocation of__print_symbolic.[...]
Applied to kvm-x86 fixes, thanks!
[1/1] KVM: x86: Fix null pointer dereference in trace_kvm_inj_exception
https://github.com/kvm-x86/linux/commit/9c66085e6dcf