arm64: allwinner: h616: Support Video Engine
Subsystems (5)
Chen-Yu Tsai
maintainerv3 cover arm64: allwinner: h616: Support Video Engine
Hi folks,
This is v3 of my Allwinner H616 Cedrus series. The series is ready to be merged.
Changes since v2:
- Dropped "drivers:" from cedrus driver patch subject
Changes since v1:
- Fixed IOMMU ports on H616 (patch 7)
- Updated comment about VP9 on H616
This series adds support for the Cedar video engine found in the Allwinner H616 SoC. On the way, it also fixes some issues with the DT representation for the Allwinner H6 SoC.
Patch 1 fixes the video engine's number of IOMMU endpoints on the H6 in the DT binding.
Patch 2 fixes the video engine's number of SRAM regions on the H6 in the DT binding.
Patch 3 adds a new compatible for the H616's video engine.
Patch 4 adds the new compatible for the H616's video engine to the cedrus driver.
Patch 5 adds the video engine's missing SRAM region to the H6 dtsi.
Patch 6 adds the video engine's missing IOMMU endpoint to the H6 dtsi.
Patch 7 adds a device node for the video engine to the H616 dtsi.
Patches 1-4 should go through the media tree, while patches 5-7 will go through the soc tree via the sunxi tree.
Please have a look.
Thanks
ChenYu
Chen-Yu Tsai (6):
dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6
dt-bindings: media: sun4i-a10-video-engine: Fix SRAM count for H6
dt-bindings: media: sun4i-a10-video-engine: Add H616 compatible
staging: media: sunxi: cedrus: add H616 variant
arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video
engine
arm64: dts: allwinner: sun50i-h6: Add missing IOMMU for video engine
Jernej Skrabec (1):
arm64: dts: allwinner: sun50i-h616: Add video engine
.../allwinner,sun4i-a10-video-engine.yaml | 45 ++++++++++++++++++- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 4 +- .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 12 +++++ drivers/staging/media/sunxi/cedrus/cedrus.c | 4 ++ 4 files changed, 61 insertions(+), 4 deletions(-)
Signature · 1 line
2.47.3
Chen-Yu Tsai
maintainerPATCH v3 1/7 dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6
On the H6 SoC, the Video Engine has two memory ports, thus two IOMMU connections. The secondary one that is missing is likely used for reading reference frames. The newer H616 is the same. On the other hand, the D1 only has one memory port.
Add the missing IOMMU connection for the Video Engine.
--- .../allwinner,sun4i-a10-video-engine.yaml | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +20 -1
@@ -55,7 +55,10 @@ properties: description: Phandle to the device SRAM iommus: - maxItems: 1 + minItems: 1 + items: + - description: VE port on IOMMU + - description: VE_R port on IOMMU memory-region: maxItems: 1
@@ -82,6 +85,22 @@ required: - resets - allwinner,sram +allOf: + - if: + properties: + compatible: + contains: + enum: + - allwinner,sun50i-h6-video-engine + then: + properties: + iommus: + minItems: 2 + else: + properties: + iommus: + maxItems: 1 + additionalProperties: false examples:
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 1/7] dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Validation failure: sun50i-h6.dtsi fails dtbs_check due to the new minItems: 2 constraint. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Validation failure: sun50i-h6.dtsi fails dtbs_check due to the new minItems: 2 constraint. --
--- Patch [1]: [PATCH v3 1/7] dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6 --- commit 17817354e28859038f6eb81e492f4c4b1bc51a02
Author: Chen-Yu Tsai <[email protected]>
dt-bindings: media: sun4i-a10-video-engine: Fix IOMMU count for H6
This commit updates the device tree binding for the sun4i-a10-video-engine to specify that the H6 SoC requires two IOMMU connections. It adds a conditional schema block enforcing a minimum of two items for the iommus property on H6 devices.
Quoted 4 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +0
-0
[ ... ]
Quoted 5 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +1
-0@@ -72,6 +75,22 @@ required: - resets - allwinner,sram +allOf:
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml required: · line 88
Quoted 10 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +10
-0+ - if: + properties: + compatible: + contains: + enum: + - allwinner,sun50i-h6-video-engine + then: + properties: + iommus: + minItems: 2
[Severity: Low]
Will this strict constraint cause dtbs_check failures for existing device trees?
Looking at the H6 dtsi file, the video-codec node only provides a single IOMMU connection:
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi:video-codec@1c0e000 {
...
iommus = <&iommu 3>;
};Since this commit enforces minItems: 2 without simultaneously updating the device tree, will it cause make dtbs_check to report validation errors for the H6 SoC?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Chen-Yu Tsai
maintainerPATCH v3 2/7 dt-bindings: media: sun4i-a10-video-engine: Fix SRAM count for H6
In reply to Chen-Yu TsaiOn the H6, the SRAM C region includes an alias of part of the VE SRAM used by the video engine. This region should also be claimed so that no access happens through the alias window.
Add a second SRAM region phandle to the video engine for the H6.
--- .../allwinner,sun4i-a10-video-engine.yaml | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +20 -1
@@ -48,11 +48,15 @@ properties: allwinner,sram: $ref: /schemas/types.yaml#/definitions/phandle-array + minItems: 1 items: - items: - description: phandle to SRAM - description: register value for device - description: Phandle to the device SRAM + - items: + - description: phandle to SRAM alias + - description: register value for device + description: Phandle to the device SRAM(s) iommus: minItems: 1
@@ -101,6 +105,21 @@ allOf: iommus: maxItems: 1 + - if: + properties: + compatible: + contains: + enum: + - allwinner,sun50i-h6-video-engine + then: + properties: + allwinner,sram: + minItems: 2 + else: + properties: + allwinner,sram: + maxItems: 1 + additionalProperties: false examples:
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 2/7] dt-bindings: media: sun4i-a10-video-engine: Fix SRAM count for H6
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
New issues:
- [Medium] The binding enforces a second SRAM item for the H6 SoC, but the in-tree device tree is not updated, causing validation failures.
Pre-existing issues:
- [High] The device tree binding requires claiming a second SRAM alias for the H6 video engine, but the SRAM driver hardcodes parsing only the first region. --
--- Patch [2]: [PATCH v3 2/7] dt-bindings: media: sun4i-a10-video-engine: Fix SRAM count for H6 --- commit b3f1ab3ef227838179ad2332d41536525f39d18a
Author: Chen-Yu Tsai <[email protected]>
dt-bindings: media: sun4i-a10-video-engine: Fix SRAM count for H6
On the H6, the SRAM C region includes an alias of part of the VE SRAM used by the video engine. This commit adds a second SRAM region phandle requirement to the video engine for the H6 to claim this alias window.
Quoted 4 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +0
-0
[ ... ]
Quoted 4 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +0
-0@@ -91,6 +95,21 @@ allOf: iommus: maxItems: 1
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml allOf: · line 107
Quoted 10 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +10
-0+ - if: + properties: + compatible: + contains: + enum: + - allwinner,sun50i-h6-video-engine + then: + properties: + allwinner,sram: + minItems: 2
[Severity: High]
This is a pre-existing issue, but does adding the DT binding property solve the hardware aliasing issue without implementing the necessary driver parser changes?
Looking at sunxi_sram_of_parse() in drivers/soc/sunxi/sunxi_sram.c, it hardcodes index 0 when parsing the 'allwinner,sram' property:
drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_of_parse() {
...
ret = of_parse_phandle_with_fixed_args(node, "allwinner,sram", 1, 0,
...
}When the Cedrus driver probes, it calls sunxi_sram_claim(), which relies on sunxi_sram_of_parse() and only claims the single region returned, leaving the alias window unprotected.
Without claiming the alias window, could another subsystem claim and use the overlapping SRAM region concurrently, leading to silent memory corruption?
[Severity: Medium]
Will this new constraint cause validation failures (make dtbs_check) for the existing in-tree device tree?
It appears the H6 device tree node video-codec@1c0e000 in arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi currently only provides a single SRAM item:
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi:video-codec@1c0e000 {
...
allwinner,sram = <&ve_sram 1>;
...
}Should the in-tree device tree be updated alongside this binding change to satisfy the new minItems constraint?
Quoted 4 lines
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +4
-0+ else: + properties: + allwinner,sram: + maxItems: 1
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Chen-Yu Tsai
maintainerPATCH v3 3/7 dt-bindings: media: sun4i-a10-video-engine: Add H616 compatible
In reply to Chen-Yu TsaiThe H616 contains a video engine similar to past SoCs.
Add a new compatible for it.
--- .../bindings/media/allwinner,sun4i-a10-video-engine.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/media/allwinner,sun4i-a10-video-engine.yaml +3 -0
@@ -24,6 +24,7 @@ properties: - allwinner,sun50i-a64-video-engine - allwinner,sun50i-h5-video-engine - allwinner,sun50i-h6-video-engine + - allwinner,sun50i-h616-video-engine reg: maxItems: 1
@@ -96,6 +97,7 @@ allOf: contains: enum: - allwinner,sun50i-h6-video-engine + - allwinner,sun50i-h616-video-engine then: properties: iommus:
@@ -111,6 +113,7 @@ allOf: contains: enum: - allwinner,sun50i-h6-video-engine + - allwinner,sun50i-h616-video-engine then: properties: allwinner,sram:
Signature · 1 line
2.47.3
Chen-Yu Tsai
maintainerPATCH v3 4/7 staging: media: sunxi: cedrus: add H616 variant
In reply to Chen-Yu TsaiThe Allwinner H616 SoC has a video engine hardware block like the one found on previous generations such as the H6. In addition to the currently supported features of the H6, it also includes a VP9 decoder. Support for VP9 will be added separately.
Add the compatible for the H616 variant, using the H6 variant data.
---
Changes since v2:
- Drop "drivers:" from subject
Changes since v1:
- Updated commit message on VP9 decoder status
--- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/staging/media/sunxi/cedrus/cedrus.c +4 -0
@@ -696,6 +696,10 @@ static const struct of_device_id cedrus_dt_match[] = { .compatible = "allwinner,sun50i-h6-video-engine", .data = &sun50i_h6_cedrus_variant, }, + { + .compatible = "allwinner,sun50i-h616-video-engine", + .data = &sun50i_h6_cedrus_variant, + }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, cedrus_dt_match);
Signature · 1 line
2.47.3
Chen-Yu Tsai
maintainerPATCH v3 5/7 arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine
In reply to Chen-Yu TsaiThe SRAM C region contains a partial alias to the VE SRAM already referenced by the video engine. To avoid access through this alias window, the region should also be claimed by the video engine.
Add a reference to the SRAM C region to the video engine node.
--- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -1
@@ -205,7 +205,7 @@ video-codec@1c0e000 { clock-names = "ahb", "mod", "ram"; resets = <&ccu RST_BUS_VE>; interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; - allwinner,sram = <&ve_sram 1>; + allwinner,sram = <&ve_sram 1>, <&de2_sram 1>; iommus = <&iommu 3>; };
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] The newly added `<&de2_sram 1>` phandle is silently ignored by the OS because the SRAM driver…
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added <&de2_sram 1> phandle is silently ignored by the OS because the SRAM driver hardcodes parsing to only the first array element.
- [Medium] Assigning de2_sram to the Video Engine creates an unresolvable resource conflict with the Display Engine, guaranteeing a probe failure if the SRAM driver were to parse it. --
--- Patch [5]: [PATCH v3 5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine --- commit dbe16923a66cbda638350c813c16a8b1c65e3b6b
Author: Chen-Yu Tsai <[email protected]>
arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine
The SRAM C region contains a partial alias to the VE SRAM already referenced by the video engine. To avoid access through this alias window, the region should also be claimed by the video engine.
Add a reference to the SRAM C region to the video engine node.
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0
-0
[ ... ]
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi video-codec@1c0e000 { · line 208
Quoted 6 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1
-1@@ -205,7 +205,7 @@ video-codec@1c0e000 { clock-names = "ahb", "mod", "ram"; resets = <&ccu RST_BUS_VE>; interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; - allwinner,sram = <&ve_sram 1>; + allwinner,sram = <&ve_sram 1>, <&de2_sram 1>;
[Severity: Medium]
Will this second phandle actually be parsed by the OS?
Looking at the driver code in drivers/soc/sunxi/sunxi_sram.c, it seems the parser hardcodes the index to 0:
drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_of_parse() {
...
ret = of_parse_phandle_with_fixed_args(node, "allwinner,sram", 1, 0,
&args);
...
}Does the driver need to be updated to parse multiple SRAM elements so this alias window is actually closed?
[Severity: Medium]
If the driver is updated to parse this second element, will it cause a probe failure due to a resource conflict?
The de2_sram region is already claimed by the Display Engine (bus@1000000). Looking at sunxi_sram_claim(), the API enforces strict exclusive ownership:
drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_claim() {
...
if (sram_desc->claimed) {
spin_unlock(&sram_lock);
return -EBUSY;
}
...
}If both the Display Engine and Video Engine try to claim de2_sram, won't the second device to probe be rejected with -EBUSY?
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0
-0iommus = <&iommu 3>; };
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
Chen-Yu Tsai
maintainerPATCH v3 6/7 arm64: dts: allwinner: sun50i-h6: Add missing IOMMU for video engine
In reply to Chen-Yu TsaiThe video engine on the H6 actually has two IOMMU ports. The one already listed is simply named "VE" in the user manual. The missing one is named "VE_R" and is probably either read-only or used for reference frames. Either way, it should be listed.
Add a reference to the "VE_R" IOMMU port to the video engine node.
--- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1 -1
@@ -206,7 +206,7 @@ video-codec@1c0e000 { resets = <&ccu RST_BUS_VE>; interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; allwinner,sram = <&ve_sram 1>, <&de2_sram 1>; - iommus = <&iommu 3>; + iommus = <&iommu 3>, <&iommu 1>; }; gpu: gpu@1800000 {
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 6/7] arm64: dts: allwinner: sun50i-h6: Add missing IOMMU for video engine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The second SRAM region (`de2_sram`) added to the `video-codec` node is never claimed by the…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The second SRAM region (de2_sram) added to the video-codec node is never claimed by the video engine driver or the SRAM subsystem, failing to fulfill the commit message's goal. --
--- Patch [6]: [PATCH v3 6/7] arm64: dts: allwinner: sun50i-h6: Add missing IOMMU for video engine --- commit 92e4c0595ba5187a0f4f259f15e3d844654fec5a
Author: Chen-Yu Tsai <[email protected]>
arm64: dts: allwinner: sun50i-h6: Add missing IOMMU for video engine
The video engine on the H6 actually has two IOMMU ports. The one already listed is simply named "VE" in the user manual. The missing one is named "VE_R" and is probably either read-only or used for reference frames.
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi video-codec@1c0e000 { · line 208
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +0
-0@@ -206,7 +206,7 @@ video-codec@1c0e000 { resets = <&ccu RST_BUS_VE>; interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>; allwinner,sram = <&ve_sram 1>, <&de2_sram 1>;
[Severity: Medium]
Will the second SRAM region (<&de2_sram 1>) be claimed by the video engine driver or the SRAM subsystem?
Looking at the cedrus driver, it invokes sunxi_sram_claim() exactly once during probe without handling multiple SRAM alias claims:
drivers/staging/media/sunxi/cedrus/cedrus_hw.c:cedrus_hw_probe() {
...
ret = sunxi_sram_claim(dev->dev);
...
}This calls sunxi_sram_of_parse(), which hardcodes the index to 0, completely ignoring any subsequent SRAM properties:
drivers/soc/sunxi/sunxi_sram.c:sunxi_sram_of_parse() {
...
ret = of_parse_phandle_with_fixed_args(node, "allwinner,sram", 1, 0,
&args);
...
}Could this leave the SRAM alias window unclaimed?
Quoted 3 lines
arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi +1
-1- iommus = <&iommu 3>; + iommus = <&iommu 3>, <&iommu 1>; };
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6
Chen-Yu Tsai
maintainerPATCH v3 7/7 arm64: dts: allwinner: sun50i-h616: Add video engine
In reply to Chen-Yu TsaiFrom: Jernej Skrabec <[email protected]>
The H616 SoC has a video engine, and two SRAM regions needed by it.
Add the video engine to the dtsi file.
---
Changes since v1:
- Corrected second IOMMU port
--- arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +12 -0
@@ -175,6 +175,18 @@ crypto: crypto@1904000 { resets = <&ccu RST_BUS_CE>; }; + video-codec@1c0e000 { + compatible = "allwinner,sun50i-h616-video-engine"; + reg = <0x01c0e000 0x2000>; + clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>, + <&ccu CLK_MBUS_VE>; + clock-names = "ahb", "mod", "ram"; + resets = <&ccu RST_BUS_VE>; + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>; + iommus = <&iommu 3>, <&iommu 2>; + allwinner,sram = <&ve_sram 1>, <&sram_c 1>; + }; + syscon: syscon@3000000 { compatible = "allwinner,sun50i-h616-system-control"; reg = <0x03000000 0x1000>;
Signature · 1 line
2.47.3
[email protected]
AI reviewRe: [PATCH v3 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added `video-codec` node references an undefined `ve_sram` phandle, causing a device tree…
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added video-codec node references an undefined ve_sram phandle, causing a device tree compilation error, and a structurally incorrect sram_c phandle. --
--- Patch [7]: [PATCH v3 7/7] arm64: dts: allwinner: sun50i-h616: Add video engine --- commit 47b5fe1ab74e2eb5363068c14fed457f3e1ad7e1
Author: Jernej Skrabec <[email protected]>
arm64: dts: allwinner: sun50i-h616: Add video engine
This commit adds the video engine node to the sun50i-h616 dtsi file. It defines the clocks, resets, interrupts, iommus, and SRAM regions required by the video engine hardware.
Quoted 8 lines
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +0
-0@@ -175,6 +175,18 @@ crypto: crypto@1904000 { resets = <&ccu RST_BUS_CE>; };
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi crypto: crypto@1904000 { · line 187
Quoted 10 lines
arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi +10
-0+ video-codec@1c0e000 { + compatible = "allwinner,sun50i-h616-video-engine"; + reg = <0x01c0e000 0x2000>; + clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>, + <&ccu CLK_MBUS_VE>; + clock-names = "ahb", "mod", "ram"; + resets = <&ccu RST_BUS_VE>; + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>; + iommus = <&iommu 3>, <&iommu 2>; + allwinner,sram = <&ve_sram 1>, <&sram_c 1>;
[Severity: Low]
Will this cause a device tree compilation error? The &ve_sram phandle doesn't appear to be defined, which could prevent the device tree from building.
Also, does the &sram_c phandle reference the parent mmio-sram node instead of a valid sram-section child node? If it points to the parent, sunxi_sram_of_parse() might return -EINVAL during driver probe.
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=7
Re: (subset) [PATCH v3 0/7] arm64: allwinner: h616: Support Video Engine
In reply to Chen-Yu TsaiQuoted 11 lines · Chen-Yu Tsai
This is v3 of my Allwinner H616 Cedrus series. The series is ready to be merged.
Changes since v2:
- Dropped "drivers:" from cedrus driver patch subjectChanges since v1:
- Fixed IOMMU ports on H616 (patch 7)
- Updated comment about VP9 on H616[...]
Applied to sunxi/dt-for-7.4 in sunxi, thanks!
[5/7] arm64: dts: allwinner: sun50i-h6: Add missing SRAM region for video engine
https://git.kernel.org/sunxi/linux/c/d7287d940f3c [6/7] arm64: dts: allwinner: sun50i-h6: Add missing IOMMU for video engine https://git.kernel.org/sunxi/linux/c/965a49fc413d [7/7] arm64: dts: allwinner: sun50i-h616: Add video engine https://git.kernel.org/sunxi/linux/c/eabc3c090e81
Best regards,
Signature · 1 line
Chen-Yu Tsai <[email protected]>