Skip to contentSkip to conversation

staging: rtl8723bs: rename MACREG macros to snake_case

PATCH In review Bohdan D. Marcus 2 participants 2 messages Jul 12 – Jul 17 Staging

lore
Share & tools
lore

Bohdan D. Marcus

author
#0 lore raw

PATCH 1/1 staging: rtl8723bs: rename MACREG macros to snake_case

Fix checkpatch.pl warnings regarding CamelCase naming:
CHECK: Avoid CamelCase: <_Read_MACREG>
CHECK: Avoid CamelCase: <_Write_MACREG>

Rename _Read_MACREG and _Write_MACREG to read_macreg and write_macreg respectively to comply with the Linux kernel coding style.

Signed-off-by Bohdan D. Marcus <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c         | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_cmd.h      | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +2 -2
index b932670f5..f3b8a2bdf 100644
@@ -11,8 +11,8 @@
 #include <linux/delay.h>
 
 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
-	{GEN_CMD_CODE(_Write_MACREG), NULL},
+	{GEN_CMD_CODE(read_macreg), NULL}, /*0*/
+	{GEN_CMD_CODE(write_macreg), NULL},
 	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
 	{GEN_CMD_CODE(_Write_BBREG), NULL},
 	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
drivers/staging/rtl8723bs/include/rtw_cmd.h +2 -2
index f78aa0d7a..72403b96d 100644
@@ -630,8 +630,8 @@ struct _cmd_callback {
 };
 
 enum {
-	GEN_CMD_CODE(_Read_MACREG),	/*0*/
-	GEN_CMD_CODE(_Write_MACREG),
+	GEN_CMD_CODE(read_macreg),	/*0*/
+	GEN_CMD_CODE(write_macreg),
 	GEN_CMD_CODE(_Read_BBREG),
 	GEN_CMD_CODE(_Write_BBREG),
 	GEN_CMD_CODE(_Read_RFREG),
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +1 -1
index cb23c6939..59d9d35e4 100644
@@ -675,7 +675,7 @@ void rtw_dummy_event_callback(struct adapter *adapter, u8 *pbuf);
 void rtw_fwdbg_event_callback(struct adapter *adapter, u8 *pbuf);
 
 enum {
-	GEN_EVT_CODE(_Read_MACREG) = 0, /*0*/
+	GEN_EVT_CODE(read_macreg) = 0, /*0*/
 	GEN_EVT_CODE(_Read_BBREG),
 	GEN_EVT_CODE(_Read_RFREG),
 	GEN_EVT_CODE(_Read_EEPROM),
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 20 lines · Bohdan D. Marcus

Fix checkpatch.pl warnings regarding CamelCase naming:
CHECK: Avoid CamelCase: <_Read_MACREG>
CHECK: Avoid CamelCase: <_Write_MACREG>

Rename _Read_MACREG and _Write_MACREG to read_macreg and write_macreg respectively to comply with the Linux kernel coding style.

Signed-off-by Bohdan D. Marcus <[email protected]>
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c         | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_cmd.h      | 4 ++--
 drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
drivers/staging/rtl8723bs/core/rtw_cmd.c +0 -0
index b932670f5..f3b8a2bdf 100644

drivers/staging/rtl8723bs/core/rtw_cmd.c line 15

Quoted 7 lines
drivers/staging/rtl8723bs/core/rtw_cmd.c +2 -2
@@ -11,8 +11,8 @@
 #include <linux/delay.h>
 
 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
-	{GEN_CMD_CODE(_Write_MACREG), NULL},
+	{GEN_CMD_CODE(read_macreg), NULL}, /*0*/
+	{GEN_CMD_CODE(write_macreg), NULL},

Why just these 2? Why not make a patch series to fix up all of these, one patch per name?

thanks,
greg k-h