dt-bindings: net: microchip,lan78xx: convert to DT schema
PATCH v4 1/1 dt-bindings: net: microchip,lan78xx: convert to DT schema
Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding documentation from plain text to DT schema.
Restoring a mistakenly deleted email in MAINTAINERS file and fixing microchip,lan7800.yaml.
---
Changes in v3:
- Restoring an erroneously deleted email in a MAINTAINERS file.
- The local-mac-address was deleted.
- The missing email was added to the maintainers section.
Link to v3: https://lore.kernel.org/netdev/[email protected]
.../bindings/net/microchip,lan7800.yaml | 89 +++++++++++++++++++ .../bindings/net/microchip,lan78xx.txt | 53 ----------- MAINTAINERS | 2 +- 3 files changed, 90 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt
Documentation/devicetree/bindings/net/microchip,lan7800.yaml new file +89 -0
@@ -0,0 +1,89 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller + +maintainers: + - Thangaraj Samynathan <[email protected]> + - Rengarajan Sundararajan <[email protected]> + +description: + The LAN7800/LAN7801/LAN7850 devices are usually configured by + programming their OTP or with an external EEPROM, but some + platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree + properties, if present, override the OTP and EEPROM. + +allOf: + - $ref: /schemas/usb/usb-device.yaml# + - $ref: /schemas/net/ethernet-controller.yaml# + +properties: + compatible: + enum: + - usb424,7800 + - usb424,7801 + - usb424,7850 + + reg: + maxItems: 1 + description: USB port number + + mdio: + $ref: /schemas/net/mdio.yaml# + unevaluatedProperties: false + + patternProperties: + "^ethernet-phy(@[0-9a-f]+)?$": + $ref: /schemas/net/ethernet-phy.yaml# + unevaluatedProperties: false + type: object + + properties: + microchip,led-modes: + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 1 + maxItems: 4 + description: + Array of LED mode values for each of up to 4 LEDs. + Omitted LEDs are turned off. Allowed values are defined + in include/dt-bindings/net/microchip-lan78xx.h. + + required: + - reg + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/net/microchip-lan78xx.h> + + usb { + #address-cells = <1>; + #size-cells = <0>; + + ethernet@1 { + compatible = "usb424,7800"; + reg = <1>; + local-mac-address = [00 11 22 33 44 55]; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + ethernet-phy@1 { + reg = <1>; + microchip,led-modes = < + LAN78XX_LINK_1000_ACTIVITY + LAN78XX_LINK_10_100_ACTIVITY + >; + }; + }; + }; + }; +...
Documentation/devicetree/bindings/net/microchip,lan78xx.txt deleted +0 -53
53 lines not on this page · raw message
MAINTAINERS +1 -1
@@ -27931,7 +27931,7 @@ M: Rengarajan Sundararajan <[email protected]> M: [email protected] L: [email protected] S: Maintained -F: Documentation/devicetree/bindings/net/microchip,lan78xx.txt +F: Documentation/devicetree/bindings/net/microchip,lan7800.yaml F: drivers/net/usb/lan78xx.* F: include/dt-bindings/net/microchip-lan78xx.h
Signature · 1 line
2.52.0
Quoted 9 lines · Mikhail Lukianchikov
Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding documentation from plain text to DT schema.
Restoring a mistakenly deleted email in
MAINTAINERSfile and fixing microchip,lan7800.yaml.Signed-off-by Mikhail Lukianchikov <[email protected]>---
Changes in v3:
Best regards,
Krzysztof
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Commit message includes inaccurate claims regarding changes to the MAINTAINERS file. --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Commit message includes inaccurate claims regarding changes to the MAINTAINERS file. --
--- Patch [1]: [PATCH v4] dt-bindings: net: microchip,lan78xx: convert to DT schema --- commit f1714d97cf714d559260a426c4169db231384ff6
Author: Mikhail Lukianchikov <[email protected]>
dt-bindings: net: microchip,lan78xx: convert to DT schema
This commit converts the Microchip LAN78xx family binding documentation from plain text to DT schema. It also updates the MAINTAINERS file to point to the new yaml file.
Quoted 2 lines
Restoring a mistakenly deleted email in
MAINTAINERSfile and fixing microchip,lan7800.yaml.
[Severity: Medium]
Is this commit message description accurate for the changes included in this patch?
Looking at the diff for the MAINTAINERS file, the patch only updates the file path from .txt to .yaml:
MAINTAINERS M: Rengarajan Sundararajan <[email protected]> · line 27934
Quoted 10 lines
MAINTAINERS +1
-1@@ -27931,7 +27931,7 @@ M: Rengarajan Sundararajan <[email protected]> M: [email protected] L: [email protected] S: Maintained -F: Documentation/devicetree/bindings/net/microchip,lan78xx.txt +F: Documentation/devicetree/bindings/net/microchip,lan7800.yaml
It does not appear to restore or add any email addresses. Could this text in the commit description be an accidental inclusion of a changelog note meant for below the '---' line?
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Sun, 12 Jul 2026 17:38:21 +0600 you wrote:
Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding documentation from plain text to DT schema.
Restoring a mistakenly deleted email in
MAINTAINERSfile and fixing microchip,lan7800.yaml.Signed-off-by Mikhail Lukianchikov <[email protected]>[...]
Here is the summary with links:
- [v4] dt-bindings: net: microchip,lan78xx: convert to DT schema
https://git.kernel.org/netdev/net-next/c/c86cfc982957
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html