arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
Subsystems (5)
Marek Vasut
maintainercover arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
This stm32mp25xx-dhcos-bb board is a stack of DHCOS SoM based on STM32MP25xx SoC (1200MHz / crypto capabilities) populated on SoM Breakout Board, the stm32mp255c-dhcos-dhsbc is the SoM populated on DHSBC carrier board. The stm32mp23xx-dhcos-bb is a stack with STM32MP23xx SoC.
The SoM contains the following peripherals:
- STPMIC (power delivery)
- 4GiB LPDDR4 memory
- eMMC and SDIO WiFi module
The Breakout Board carrier board contains the following peripherals:
- USB-C peripheral port, power supply plug
The DHSBC carrier board contains the following peripherals:
- Two RGMII Ethernet ports
- MicroSD slot
- LVDS connector
- MIPI CSI2 connector
- USB-A Host port, USB-C power supply plug
- USB-C / DP port
- Expansion connector
Marek Vasut (10):
dt-bindings: arm: stm32: Document STM32MP23xx/STM32MP25xx DHCOS SoM
and Breakout Board and DHSBC
dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
arm64: dts: st: Fix SDMMC1 indent on stm32mp231
arm64: dts: st: Fix SDMMC1 indent on stm32mp251
arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp231
arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp251
arm64: dts: st: Add OMM node on stm32mp231
arm64: dts: st: Add pinmux nodes for DH electronics
STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx
DHCOS SoM and Breakout Board and DHSBC
MAINTAINERS: Add DH electronics DHCOS SoM entry and fix email address
.../devicetree/bindings/arm/stm32/stm32.yaml | 18 + .../bindings/gpio/gpio-pca95xx.yaml | 3 + MAINTAINERS | 3 +- arch/arm64/boot/dts/st/Makefile | 10 + arch/arm64/boot/dts/st/stm32mp231.dtsi | 86 ++- arch/arm64/boot/dts/st/stm32mp23xc.dtsi | 7 + .../boot/dts/st/stm32mp23xx-dhcos-bb.dts | 15 + .../boot/dts/st/stm32mp23xx-dhcos-som.dtsi | 51 ++ arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 564 ++++++++++++++++++ arch/arm64/boot/dts/st/stm32mp251.dtsi | 32 +- ...mp255c-dhcos-dhsbc-overlay-imx219-x10.dtso | 111 ++++ .../boot/dts/st/stm32mp255c-dhcos-dhsbc.dts | 189 ++++++ arch/arm64/boot/dts/st/stm32mp25xc.dtsi | 7 + .../boot/dts/st/stm32mp25xx-dhcos-bb.dts | 15 + .../boot/dts/st/stm32mp25xx-dhcos-som.dtsi | 51 ++ .../boot/dts/st/stm32mp2xxx-dhcos-som.dtsi | 442 ++++++++++++++ 16 files changed, 1601 insertions(+), 3 deletions(-) create mode 100644 arch/arm64/boot/dts/st/stm32mp23xc.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts create mode 100644 arch/arm64/boot/dts/st/stm32mp23xx-dhcos-som.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc-overlay-imx219-x10.dtso create mode 100644 arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts create mode 100644 arch/arm64/boot/dts/st/stm32mp25xc.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts create mode 100644 arch/arm64/boot/dts/st/stm32mp25xx-dhcos-som.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signature · 1 line
2.53.0
Marek Vasut
maintainerPATCH 1/10 dt-bindings: arm: stm32: Document STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
This stm32mp25xx-dhcos-bb board is a stack of DHCOS SoM based on STM32MP25xx SoC (1200MHz / crypto capabilities) populated on SoM Breakout Board, the stm32mp255c-dhcos-dhsbc is the SoM populated on DHSBC carrier board. The stm32mp23xx-dhcos-bb is a stack with STM32MP23xx SoC.
The SoM contains the following peripherals:
- STPMIC (power delivery)
- 4GiB LPDDR4 memory
- eMMC and SDIO WiFi module
The Breakout Board carrier board contains the following peripherals:
- USB-C peripheral port, power supply plug
The DHSBC carrier board contains the following peripherals:
- Two RGMII Ethernet ports
- MicroSD slot
- LVDS connector
- MIPI CSI2 connector
- USB-A Host port, USB-C power supply plug
- USB-C / DP port
- Expansion connector
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- .../devicetree/bindings/arm/stm32/stm32.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
Documentation/devicetree/bindings/arm/stm32/stm32.yaml +18 -0
@@ -196,6 +196,18 @@ properties: - const: ultratronik,stm32mp157c-ultra-fly-sbc - const: st,stm32mp157 + - description: DH STM32MP251 DHCOS SoM based Boards + items: + - const: dh,stm32mp251a-dhcos-bb + - const: dh,stm32mp251a-dhcos-som + - const: st,stm32mp251 + + - description: DH STM32MP255 DHCOS SoM based Boards + items: + - const: dh,stm32mp255c-dhcos-dhsbc + - const: dh,stm32mp255c-dhcos-som + - const: st,stm32mp255 + - description: ST STM32MP257 based Boards items: - enum:
@@ -203,6 +215,12 @@ properties: - st,stm32mp257f-ev1 - const: st,stm32mp257 + - description: DH STM32MP231 DHCOS SoM based Boards + items: + - const: dh,stm32mp231a-dhcos-bb + - const: dh,stm32mp231a-dhcos-som + - const: st,stm32mp231 + - description: ST STM32MP235 based Boards items: - enum:
Signature · 1 line
2.53.0
Re: [PATCH 01/10] dt-bindings: arm: stm32: Document STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
Documentation/devicetree/bindings/arm/stm32/stm32.yaml properties: · line 222
Quoted 12 lines · Marek Vasut
- description: ST STM32MP257 based Boards
items:
- enum:Documentation/devicetree/bindings/arm/stm32/stm32.yaml +5
-0@@ -203,6 +215,12 @@ properties: - st,stm32mp257f-ev1 - const: st,stm32mp257 + - description: DH STM32MP231 DHCOS SoM based Boards + items: + - const: dh,stm32mp231a-dhcos-bb + - const: dh,stm32mp231a-dhcos-som + - const: st,stm32mp231
This should be after st,stm32mp157 group and before st,stm32mp251 to be sorted by fallback compatible.
Anyway, not a big deal, so:
Best regards,
Krzysztof
Marek Vasut
maintainerRe: [PATCH 01/10] dt-bindings: arm: stm32: Document STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
Quoted 17 lines · Krzysztof Kozlowski
Documentation/devicetree/bindings/arm/stm32/stm32.yaml properties: · line 222
Quoted 12 lines · Marek Vasut
- description: ST STM32MP257 based Boards
items:
- enum:Documentation/devicetree/bindings/arm/stm32/stm32.yaml +5
-0@@ -203,6 +215,12 @@ properties: - st,stm32mp257f-ev1 - const: st,stm32mp257 + - description: DH STM32MP231 DHCOS SoM based Boards + items: + - const: dh,stm32mp231a-dhcos-bb + - const: dh,stm32mp231a-dhcos-som + - const: st,stm32mp231This should be after st,stm32mp157 group and before st,stm32mp251 to be sorted by fallback compatible.
Quoted 1 line
Anyway, not a big deal, so:
I'll send a sort patch for this schema file shortly and then a V2 of this series once I get a bit more feedback.
Marek Vasut
maintainerPATCH 2/10 dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
In reply to Marek VasutThe Kinetic Technologies KTS1622 is a 16-bit general-purpose I/O expander via the I2C bus for microcontrollers when additional I/Os are needed while keeping interconnections to the minimum. Datasheet comparison suggests that it is compatible with TCAL6416, add the compatible string and TCAL6416 as a fallback compatible.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +3 -0
@@ -22,6 +22,9 @@ properties: - items: - const: diodes,pi4ioe5v6534q - const: nxp,pcal6534 + - items: + - const: kinetic,kts1622 + - const: ti,tcal6416 - items: - enum: - exar,xra1202
Signature · 1 line
2.53.0
Re: [PATCH 02/10] dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
Quoted 5 lines · Marek Vasut
The Kinetic Technologies KTS1622 is a 16-bit general-purpose I/O expander via the I2C bus for microcontrollers when additional I/Os are needed while keeping interconnections to the minimum. Datasheet comparison suggests that it is compatible with TCAL6416, add the compatible string and TCAL6416 as a fallback compatible.
Your commit msgs feel too early wrapped.
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Quoted 2 lines
Signed-off-by Marek Vasut <[email protected]>
Best regards,
Krzysztof
Bartosz Golaszewski
maintainerRe: [PATCH 02/10] dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
In reply to Marek VasutQuoted 39 lines · Marek Vasut
The Kinetic Technologies KTS1622 is a 16-bit general-purpose I/O expander via the I2C bus for microcontrollers when additional I/Os are needed while keeping interconnections to the minimum. Datasheet comparison suggests that it is compatible with TCAL6416, add the compatible string and TCAL6416 as a fallback compatible.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +3
-1@@ -22,6 +22,9 @@ properties: - items: - const: diodes,pi4ioe5v6534q - const: nxp,pcal6534 + - items: + - const: kinetic,kts1622 + - const: ti,tcal6416 - items: - enum: - exar,xra1202 --
Quoted 3 lines
2.53.0
I applied this. I would have sent a b4 notification but got this instead:
$ b4 ty -all
Auto-thankanating commits in gpio/for-next
Found 9 of your commits since 1.week
Calculating patch hashes, may take a moment...
Located: [PATCH 00/10] arm64: dts: st: Add support for DH
electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and
DHSBC
---
Generating 1 thank-you letters
Writing: ./marex_nabladev_com_patch_00_10_arm64_dts_st_add_support_for_dh_electronics_stm32mp23xx_stm32mp25xx_dhcos_som_and_breakout_board_and_dhsbc.thanks
Traceback (most recent call last):
File "/usr/bin/b4", line 8, in <module>
sys.exit(cmd())
~~~^^
File "/usr/lib/python3/dist-packages/b4/command.py", line 417, in cmd
cmdargs.func(cmdargs)
~~~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/command.py", line 113, in cmd_ty
b4.ty.main(cmdargs)
~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 681, in main
auto_thankanator(cmdargs)
~~~~~~~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 386, in auto_thankanator
send_messages(applied, wantbranch, cmdargs)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 452, in send_messages
with open(outfile, 'wb') as fh:
~~~~^^^^^^^^^^^^^^^
OSError: [Errno 36] File name too long:
'./marex_nabladev_com_patch_00_10_arm64_dts_st_add_support_for_dh_electronics_stm32mp23xx_stm32mp25xx_dhcos_som_and_breakout_board_and_dhsbc.thanks'Bart
Marek Vasut
maintainerRe: [PATCH 02/10] dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
Quoted 69 lines · Bartosz Golaszewski
Quoted 39 lines · Marek Vasut
The Kinetic Technologies KTS1622 is a 16-bit general-purpose I/O expander via the I2C bus for microcontrollers when additional I/Os are needed while keeping interconnections to the minimum. Datasheet comparison suggests that it is compatible with TCAL6416, add the compatible string and TCAL6416 as a fallback compatible.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +3
-1@@ -22,6 +22,9 @@ properties: - items: - const: diodes,pi4ioe5v6534q - const: nxp,pcal6534 + - items: + - const: kinetic,kts1622 + - const: ti,tcal6416 - items: - enum: - exar,xra1202 --Quoted 3 lines
2.53.0
I applied this. I would have sent a b4 notification but got this instead:
$ b4 ty -all Auto-thankanating commits in gpio/for-next Found 9 of your commits since 1.week Calculating patch hashes, may take a moment... Located: [PATCH 00/10] arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC --- Generating 1 thank-you letters Writing: ./marex_nabladev_com_patch_00_10_arm64_dts_st_add_support_for_dh_electronics_stm32mp23xx_stm32mp25xx_dhcos_som_and_breakout_board_and_dhsbc.thanks Traceback (most recent call last): File "/usr/bin/b4", line 8, in <module> sys.exit(cmd()) ~~~^^ File "/usr/lib/python3/dist-packages/b4/command.py", line 417, in cmd cmdargs.func(cmdargs) ~~~~~~~~~~~~^^^^^^^^^ File "/usr/lib/python3/dist-packages/b4/command.py", line 113, in cmd_ty b4.ty.main(cmdargs) ~~~~~~~~~~^^^^^^^^^ File "/usr/lib/python3/dist-packages/b4/ty.py", line 681, in main auto_thankanator(cmdargs) ~~~~~~~~~~~~~~~~^^^^^^^^^
Quoted 8 lines
File "/usr/lib/python3/dist-packages/b4/ty.py", line 386, in auto_thankanator
send_messages(applied, wantbranch, cmdargs)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 452, in send_messages
with open(outfile, 'wb') as fh:
~~~~^^^^^^^^^^^^^^^
OSError: [Errno 36] File name too long:
'./marex_nabladev_com_patch_00_10_arm64_dts_st_add_support_for_dh_electronics_stm32mp23xx_stm32mp25xx_dhcos_som_and_breakout_board_and_dhsbc.thanks'B4 bug ?
Re: [PATCH 02/10] dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
In reply to Marek VasutQuoted 39 lines · Marek Vasut
The Kinetic Technologies KTS1622 is a 16-bit general-purpose I/O expander via the I2C bus for microcontrollers when additional I/Os are needed while keeping interconnections to the minimum. Datasheet comparison suggests that it is compatible with TCAL6416, add the compatible string and TCAL6416 as a fallback compatible.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +3
-1@@ -22,6 +22,9 @@ properties: - items: - const: diodes,pi4ioe5v6534q - const: nxp,pcal6534 + - items: + - const: kinetic,kts1622 + - const: ti,tcal6416 - items: - enum: - exar,xra1202 --
Quoted 3 lines
2.53.0
Hi Konstantin!
I applied this patch with b4 and tried to generate the .thanks email. It failed like so:
$ b4 ty -all
Auto-thankanating commits in gpio/for-next
Found 9 of your commits since 1.week
Calculating patch hashes, may take a moment...
Located: [PATCH 00/10] arm64: dts: st: Add support for DH
electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and
DHSBC
---
Generating 1 thank-you letters
Writing: ./marex_nabladev_com_patch_00_10_arm64_dts_st_add_support_for_dh_electronics_stm32mp23xx_stm32mp25xx_dhcos_som_and_breakout_board_and_dhsbc.thanks
Traceback (most recent call last):
File "/usr/bin/b4", line 8, in <module>
sys.exit(cmd())
~~~^^
File "/usr/lib/python3/dist-packages/b4/command.py", line 417, in cmd
cmdargs.func(cmdargs)
~~~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/command.py", line 113, in cmd_ty
b4.ty.main(cmdargs)
~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 681, in main
auto_thankanator(cmdargs)
~~~~~~~~~~~~~~~~^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 386, in auto_thankanator
send_messages(applied, wantbranch, cmdargs)
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/b4/ty.py", line 452, in send_messages
with open(outfile, 'wb') as fh:
~~~~^^^^^^^^^^^^^^^
OSError: [Errno 36] File name too long:
'./marex_nabladev_com_patch_00_10_arm64_dts_st_add_support_for_dh_electronics_stm32mp23xx_stm32mp25xx_dhcos_som_and_breakout_board_and_dhsbc.thanks'The name is under the 255 byte limit, is this a b4 bug/limitation?
Thanks,
Bart
Marek Vasut
maintainerPATCH 3/10 arm64: dts: st: Fix SDMMC1 indent on stm32mp231
In reply to Marek VasutDrop bogus space. No functional change.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/stm32mp231.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/st/stm32mp231.dtsi +1 -1
@@ -720,7 +720,7 @@ sdmmc1: mmc@48220000 { reg = <0x48220000 0x400>, <0x44230400 0x8>; arm,primecell-periphid = <0x00353180>; interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&rcc CK_KER_SDMMC1 >; + clocks = <&rcc CK_KER_SDMMC1>; clock-names = "apb_pclk"; resets = <&rcc SDMMC1_R>; cap-sd-highspeed;
Signature · 1 line
2.53.0
Marek Vasut
maintainerPATCH 4/10 arm64: dts: st: Fix SDMMC1 indent on stm32mp251
In reply to Marek VasutDrop bogus space. No functional change.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/stm32mp251.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/st/stm32mp251.dtsi +1 -1
@@ -1657,7 +1657,7 @@ sdmmc1: mmc@48220000 { arm,primecell-periphid = <0x00353180>; reg = <0x48220000 0x400>, <0x44230400 0x8>; interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&rcc CK_KER_SDMMC1 >; + clocks = <&rcc CK_KER_SDMMC1>; clock-names = "apb_pclk"; resets = <&rcc SDMMC1_R>; cap-sd-highspeed;
Signature · 1 line
2.53.0
Marek Vasut
maintainerPATCH 5/10 arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp231
In reply to Marek VasutAdd DT nodes for the remaining SDMMC controllers 2 and 3.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/stm32mp231.dtsi | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/st/stm32mp231.dtsi +30 -0
@@ -730,6 +730,36 @@ sdmmc1: mmc@48220000 { status = "disabled"; }; + sdmmc2: mmc@48230000 { + compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell"; + arm,primecell-periphid = <0x00353180>; + reg = <0x48230000 0x400>, <0x44230800 0x8>; + interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&rcc CK_KER_SDMMC2>; + clock-names = "apb_pclk"; + resets = <&rcc SDMMC2_R>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <166000000>; + access-controllers = <&rifsc 77>; + status = "disabled"; + }; + + sdmmc3: mmc@48240000 { + compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell"; + arm,primecell-periphid = <0x00353180>; + reg = <0x48240000 0x400>, <0x44230c00 0x8>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&rcc CK_KER_SDMMC3>; + clock-names = "apb_pclk"; + resets = <&rcc SDMMC3_R>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <166000000>; + access-controllers = <&rifsc 78>; + status = "disabled"; + }; + ethernet1: ethernet@482c0000 { compatible = "st,stm32mp25-dwmac", "snps,dwmac-5.20"; reg = <0x482c0000 0x4000>;
Signature · 1 line
2.53.0
Marek Vasut
maintainerPATCH 6/10 arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp251
In reply to Marek VasutAdd DT nodes for the remaining SDMMC controllers 2 and 3.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/stm32mp251.dtsi | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/st/stm32mp251.dtsi +30 -0
@@ -1667,6 +1667,36 @@ sdmmc1: mmc@48220000 { status = "disabled"; }; + sdmmc2: mmc@48230000 { + compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell"; + arm,primecell-periphid = <0x00353180>; + reg = <0x48230000 0x400>, <0x44230800 0x8>; + interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&rcc CK_KER_SDMMC2>; + clock-names = "apb_pclk"; + resets = <&rcc SDMMC2_R>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <166000000>; + access-controllers = <&rifsc 77>; + status = "disabled"; + }; + + sdmmc3: mmc@48240000 { + compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell"; + arm,primecell-periphid = <0x00353180>; + reg = <0x48240000 0x400>, <0x44230c00 0x8>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&rcc CK_KER_SDMMC3>; + clock-names = "apb_pclk"; + resets = <&rcc SDMMC3_R>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <166000000>; + access-controllers = <&rifsc 78>; + status = "disabled"; + }; + ethernet1: ethernet@482c0000 { compatible = "st,stm32mp25-dwmac", "snps,dwmac-5.20"; reg = <0x482c0000 0x4000>;
Signature · 1 line
2.53.0
Alexandre TORGUE
maintainerRe: [PATCH 06/10] arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp251
Hi Marek
Quoted 29 lines · Marek Vasut
Add DT nodes for the remaining SDMMC controllers 2 and 3.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- arch/arm64/boot/dts/st/stm32mp251.dtsi | 30 ++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)arch/arm64/boot/dts/st/stm32mp251.dtsi +1
-0@@ -1667,6 +1667,36 @@ sdmmc1: mmc@48220000 { status = "disabled"; }; + sdmmc2: mmc@48230000 {
arch/arm64/boot/dts/st/stm32mp251.dtsi sdmmc1: mmc@48220000 { · line 1680
Quoted 10 lines
arch/arm64/boot/dts/st/stm32mp251.dtsi +10
-0+ compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell"; + arm,primecell-periphid = <0x00353180>; + reg = <0x48230000 0x400>, <0x44230800 0x8>; + interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&rcc CK_KER_SDMMC2>; + clock-names = "apb_pclk"; + resets = <&rcc SDMMC2_R>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <166000000>;
I merged some weeks ago a patch introducing SDMCC2. max-freq is 120000000. I'll keep this patch adding SDMMC3, and increasing SDMMC2 max freq.
Quoted 22 lines
arch/arm64/boot/dts/st/stm32mp251.dtsi +19
-0+ access-controllers = <&rifsc 77>; + status = "disabled"; + }; + + sdmmc3: mmc@48240000 { + compatible = "st,stm32mp25-sdmmc2", "arm,pl18x", "arm,primecell"; + arm,primecell-periphid = <0x00353180>; + reg = <0x48240000 0x400>, <0x44230c00 0x8>; + interrupts = <GIC_SPI 214 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&rcc CK_KER_SDMMC3>; + clock-names = "apb_pclk"; + resets = <&rcc SDMMC3_R>; + cap-sd-highspeed; + cap-mmc-highspeed; + max-frequency = <166000000>; + access-controllers = <&rifsc 78>; + status = "disabled"; + }; + ethernet1: ethernet@482c0000 { compatible = "st,stm32mp25-dwmac", "snps,dwmac-5.20"; reg = <0x482c0000 0x4000>;
Marek Vasut
maintainerPATCH 7/10 arm64: dts: st: Add OMM node on stm32mp231
In reply to Marek VasutAdd Octo Memory Manager (OMM) entry on stm32mp231 and its two OSPI instance.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/stm32mp231.dtsi | 54 ++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
arch/arm64/boot/dts/st/stm32mp231.dtsi +54 -0
@@ -222,6 +222,60 @@ hpdma3: dma-controller@40420000 { #dma-cells = <3>; }; + ommanager: ommanager@40500000 { + compatible = "st,stm32mp25-omm"; + reg = <0x40500000 0x400>, <0x60000000 0x10000000>; + reg-names = "regs", "memory_map"; + ranges = <0 0 0x40430000 0x400>, + <1 0 0x40440000 0x400>; + clocks = <&rcc CK_BUS_OSPIIOM>, + <&scmi_clk CK_SCMI_OSPI1>, + <&scmi_clk CK_SCMI_OSPI2>; + clock-names = "omm", "ospi1", "ospi2"; + resets = <&rcc OSPIIOM_R>, + <&scmi_reset RST_SCMI_OSPI1>, + <&scmi_reset RST_SCMI_OSPI2>; + reset-names = "omm", "ospi1", "ospi2"; + access-controllers = <&rifsc 111>; + power-domains = <&cluster_pd>; + #address-cells = <2>; + #size-cells = <1>; + st,syscfg-amcr = <&syscfg 0x2c00 0x7>; + status = "disabled"; + + ospi1: spi@0 { + compatible = "st,stm32mp25-ospi"; + reg = <0 0 0x400>; + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&hpdma 2 0x62 0x3121>, + <&hpdma 2 0x42 0x3112>; + dma-names = "tx", "rx"; + clocks = <&scmi_clk CK_SCMI_OSPI1>; + resets = <&scmi_reset RST_SCMI_OSPI1>, + <&scmi_reset RST_SCMI_OSPI1DLL>; + access-controllers = <&rifsc 74>; + power-domains = <&cluster_pd>; + st,syscfg-dlyb = <&syscfg 0x1000>; + status = "disabled"; + }; + + ospi2: spi@1 { + compatible = "st,stm32mp25-ospi"; + reg = <1 0 0x400>; + interrupts = <GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>; + dmas = <&hpdma 3 0x62 0x3121>, + <&hpdma 3 0x42 0x3112>; + dma-names = "tx", "rx"; + clocks = <&scmi_clk CK_SCMI_OSPI2>; + resets = <&scmi_reset RST_SCMI_OSPI2>, + <&scmi_reset RST_SCMI_OSPI2DLL>; + access-controllers = <&rifsc 75>; + power-domains = <&cluster_pd>; + st,syscfg-dlyb = <&syscfg 0x1400>; + status = "disabled"; + }; + }; + rifsc: bus@42080000 { compatible = "st,stm32mp25-rifsc", "simple-bus"; reg = <0x42080000 0x1000>;
Signature · 1 line
2.53.0
Marek Vasut
maintainerPATCH 8/10 arm64: dts: st: Add pinmux nodes for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
In reply to Marek VasutAdd new pinmux nodes for DH electronics STM32MP2 DHCOS SoM and BB board. The following pinmux nodes are added:
- ETH2 pins
- I2C8 pins
- MCO1 pins
- SDMMC1,2,3 pins
- SPI1,8 pins
- UART8,9 pins
- USART1,2,6 pins
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 564 ++++++++++++++++++ 1 file changed, 564 insertions(+)
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +564 -0
@@ -182,6 +182,30 @@ pins5 { }; }; + /omit-if-no-ref/ + eth2_mdio_pins_a: eth2-mdio-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 4, AF11)>; /* ETH_MDC */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins2 { + pinmux = <STM32_PINMUX('C', 5, AF10)>; /* ETH_MDIO */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + }; + + /omit-if-no-ref/ + eth2_mdio_sleep_pins_a: eth2-mdio-sleep-0 { + pins { + pinmux = <STM32_PINMUX('C', 6, ANALOG)>, /* ETH_MDC */ + <STM32_PINMUX('C', 5, ANALOG)>; /* ETH_MDIO */ + }; + }; + /omit-if-no-ref/ eth2_rgmii_sleep_pins_a: eth2-rgmii-sleep-0 { pins {
@@ -203,6 +227,68 @@ pins { }; }; + /omit-if-no-ref/ + eth2_rgmii_pins_b: eth2-rgmii-1 { + pins1 { + pinmux = <STM32_PINMUX('C', 7, AF10)>, /* ETH_RGMII_TXD0 */ + <STM32_PINMUX('C', 8, AF10)>, /* ETH_RGMII_TXD1 */ + <STM32_PINMUX('C', 9, AF10)>, /* ETH_RGMII_TXD2 */ + <STM32_PINMUX('C', 10, AF10)>, /* ETH_RGMII_TXD3 */ + <STM32_PINMUX('C', 4, AF10)>; /* ETH_RGMII_TX_CTL */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 8, AF10)>, /* ETH_RGMII_CLK125 */ + <STM32_PINMUX('F', 7, AF10)>; /* ETH_MDC */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins3 { + pinmux = <STM32_PINMUX('G', 0, AF10)>, /* ETH_RGMII_RXD0 */ + <STM32_PINMUX('C', 12, AF10)>, /* ETH_RGMII_RXD1 */ + <STM32_PINMUX('F', 9, AF10)>, /* ETH_RGMII_RXD2 */ + <STM32_PINMUX('C', 11, AF10)>, /* ETH_RGMII_RXD3 */ + <STM32_PINMUX('C', 3, AF10)>; /* ETH_RGMII_RX_CTL */ + bias-disable; + }; + pins4 { + pinmux = <STM32_PINMUX('F', 6, AF10)>; /* ETH_RGMII_RX_CLK */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + eth2_rgmii_sleep_pins_b: eth2-rgmii-sleep-1 { + pins { + pinmux = <STM32_PINMUX('C', 7, ANALOG)>, /* ETH_RGMII_TXD0 */ + <STM32_PINMUX('C', 8, ANALOG)>, /* ETH_RGMII_TXD1 */ + <STM32_PINMUX('C', 9, ANALOG)>, /* ETH_RGMII_TXD2 */ + <STM32_PINMUX('C', 10, ANALOG)>, /* ETH_RGMII_TXD3 */ + <STM32_PINMUX('C', 4, ANALOG)>, /* ETH_RGMII_TX_CTL */ + <STM32_PINMUX('F', 8, ANALOG)>, /* ETH_RGMII_CLK125 */ + <STM32_PINMUX('F', 7, ANALOG)>, /* ETH_RGMII_GTX_CLK */ + <STM32_PINMUX('G', 0, ANALOG)>, /* ETH_RGMII_RXD0 */ + <STM32_PINMUX('C', 12, ANALOG)>, /* ETH_RGMII_RXD1 */ + <STM32_PINMUX('F', 9, ANALOG)>, /* ETH_RGMII_RXD2 */ + <STM32_PINMUX('C', 11, ANALOG)>, /* ETH_RGMII_RXD3 */ + <STM32_PINMUX('C', 3, ANALOG)>, /* ETH_RGMII_RX_CTL */ + <STM32_PINMUX('F', 6, ANALOG)>; /* ETH_RGMII_RX_CLK */ + }; + }; + + /omit-if-no-ref/ + mco1_pins_a: mco1-0 { + pins { + pinmux = <STM32_PINMUX('I', 6, AF1)>; /* MCO1 */ + bias-disable; + drive-push-pull; + slew-rate = <2>; + }; + }; + /omit-if-no-ref/ i2c2_pins_a: i2c2-0 { pins {
@@ -394,6 +480,26 @@ pins2 { }; }; + /omit-if-no-ref/ + sdmmc1_b4_pins_b: sdmmc1-b4-1 { + pins1 { + pinmux = <STM32_PINMUX('E', 4, AF10)>, /* SDMMC1_D0 */ + <STM32_PINMUX('E', 5, AF10)>, /* SDMMC1_D1 */ + <STM32_PINMUX('E', 0, AF10)>, /* SDMMC1_D2 */ + <STM32_PINMUX('E', 1, AF10)>, /* SDMMC1_D3 */ + <STM32_PINMUX('E', 2, AF10)>; /* SDMMC1_CMD */ + slew-rate = <1>; + drive-push-pull; + bias-disable; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 3, AF10)>; /* SDMMC1_CK */ + slew-rate = <2>; + drive-push-pull; + bias-disable; + }; + }; + /omit-if-no-ref/ sdmmc1_b4_od_pins_a: sdmmc1-b4-od-0 { pins1 {
@@ -419,6 +525,31 @@ pins3 { }; }; + /omit-if-no-ref/ + sdmmc1_b4_od_pins_b: sdmmc1-b4-od-1 { + pins1 { + pinmux = <STM32_PINMUX('E', 4, AF10)>, /* SDMMC1_D0 */ + <STM32_PINMUX('E', 5, AF10)>, /* SDMMC1_D1 */ + <STM32_PINMUX('E', 0, AF10)>, /* SDMMC1_D2 */ + <STM32_PINMUX('E', 1, AF10)>; /* SDMMC1_D3 */ + slew-rate = <1>; + drive-push-pull; + bias-disable; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 3, AF10)>; /* SDMMC1_CK */ + slew-rate = <2>; + drive-push-pull; + bias-disable; + }; + pins3 { + pinmux = <STM32_PINMUX('E', 2, AF10)>; /* SDMMC1_CMD */ + slew-rate = <1>; + drive-open-drain; + bias-disable; + }; + }; + /omit-if-no-ref/ sdmmc1_b4_sleep_pins_a: sdmmc1-b4-sleep-0 { pins {
@@ -431,6 +562,187 @@ pins { }; }; + /omit-if-no-ref/ + sdmmc2_b4_pins_a: sdmmc2-b4-0 { + pins1 { + pinmux = <STM32_PINMUX('E', 13, AF12)>, /* SDMMC2_D0 */ + <STM32_PINMUX('E', 11, AF12)>, /* SDMMC2_D1 */ + <STM32_PINMUX('E', 8, AF12)>, /* SDMMC2_D2 */ + <STM32_PINMUX('E', 12, AF12)>, /* SDMMC2_D3 */ + <STM32_PINMUX('E', 15, AF12)>; /* SDMMC2_CMD */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 14, AF12)>; /* SDMMC2_CK */ + slew-rate = <2>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc2_b4_od_pins_a: sdmmc2-b4-od-0 { + pins1 { + pinmux = <STM32_PINMUX('E', 13, AF12)>, /* SDMMC2_D0 */ + <STM32_PINMUX('E', 11, AF12)>, /* SDMMC2_D1 */ + <STM32_PINMUX('E', 8, AF12)>, /* SDMMC2_D2 */ + <STM32_PINMUX('E', 12, AF12)>; /* SDMMC2_D3 */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 14, AF12)>; /* SDMMC2_CK */ + slew-rate = <2>; + drive-push-pull; + bias-pull-up; + }; + pins3 { + pinmux = <STM32_PINMUX('E', 15, AF12)>; /* SDMMC2_CMD */ + slew-rate = <1>; + drive-open-drain; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc2_b4_sleep_pins_a: sdmmc2-b4-sleep-0 { + pins { + pinmux = <STM32_PINMUX('E', 13, ANALOG)>, /* SDMMC2_D0 */ + <STM32_PINMUX('E', 11, ANALOG)>, /* SDMMC2_D1 */ + <STM32_PINMUX('E', 8, ANALOG)>, /* SDMMC2_D2 */ + <STM32_PINMUX('E', 12, ANALOG)>, /* SDMMC2_D3 */ + <STM32_PINMUX('E', 14, ANALOG)>, /* SDMMC2_CK */ + <STM32_PINMUX('E', 15, ANALOG)>; /* SDMMC2_CMD */ + }; + }; + + /omit-if-no-ref/ + sdmmc2_d47_pins_a: sdmmc2-d47-0 { + pins { + pinmux = <STM32_PINMUX('E', 10, AF12)>, /* SDMMC2_D4 */ + <STM32_PINMUX('E', 9, AF12)>, /* SDMMC2_D5 */ + <STM32_PINMUX('E', 6, AF12)>, /* SDMMC2_D6 */ + <STM32_PINMUX('E', 7, AF12)>; /* SDMMC2_D7 */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc2_d47_sleep_pins_a: sdmmc2-d47-sleep-0 { + pins { + pinmux = <STM32_PINMUX('E', 10, ANALOG)>, /* SDMMC2_D4 */ + <STM32_PINMUX('E', 9, ANALOG)>, /* SDMMC2_D5 */ + <STM32_PINMUX('E', 6, ANALOG)>, /* SDMMC2_D6 */ + <STM32_PINMUX('E', 7, ANALOG)>; /* SDMMC2_D7 */ + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_pins_a: sdmmc3-b4-0 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('I', 11, AF10)>, /* SDMMC3_D3 */ + <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */ + slew-rate = <0>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('B', 13, AF10)>; /* SDMMC3_CK */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_pins_b: sdmmc3-b4-1 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, AF12)>, /* SDMMC3_D3 */ + <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */ + slew-rate = <0>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('B', 13, AF10)>; /* SDMMC3_CK */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_od_pins_b: sdmmc3-b4-od-1 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, AF10)>; /* SDMMC3_D3 */ + slew-rate = <2>; + drive-push-pull; + bias-disable; + }; + pins2 { + pinmux = <STM32_PINMUX('B', 13, AF10)>; /* SDMMC3_CK */ + slew-rate = <3>; + drive-push-pull; + bias-disable; + }; + pins3 { + pinmux = <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */ + slew-rate = <2>; + drive-open-drain; + bias-disable; + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_sleep_pins_b: sdmmc3-b4-sleep-1 { + pins { + pinmux = <STM32_PINMUX('B', 14, ANALOG)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, ANALOG)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, ANALOG)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, ANALOG)>, /* SDMMC3_D3 */ + <STM32_PINMUX('B', 13, ANALOG)>, /* SDMMC3_CK */ + <STM32_PINMUX('D', 12, ANALOG)>; /* SDMMC3_CMD */ + }; + }; + + /omit-if-no-ref/ + spi1_pins_a: spi1-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 6, AF3)>, /* SPI1_SCK */ + <STM32_PINMUX('H', 7, AF2)>; /* SPI1_MOSI */ + drive-push-pull; + bias-disable; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('H', 8, AF2)>; /* SPI1_MISO */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + spi1_sleep_pins_a: spi1-sleep-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 6, ANALOG)>, /* SPI1_SCK */ + <STM32_PINMUX('H', 7, ANALOG)>, /* SPI1_MOSI */ + <STM32_PINMUX('H', 8, ANALOG)>; /* SPI1_MISO */ + }; + }; + /omit-if-no-ref/ spi3_pins_a: spi3-0 { pins1 {
@@ -471,6 +783,50 @@ pins { }; }; + /omit-if-no-ref/ + usart1_pins_a: usart1-0 { + pins1 { + pinmux = <STM32_PINMUX('A', 3, AF6)>, /* USART1_TX */ + <STM32_PINMUX('A', 1, AF5)>; /* USART1_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('A', 2, AF6)>, /* USART1_RX */ + <STM32_PINMUX('A', 7, AF6)>; /* USART1_CTS_NSS */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + usart1_idle_pins_a: usart1-idle-0 { + pins1 { + pinmux = <STM32_PINMUX('A', 3, ANALOG)>, /* USART1_TX */ + <STM32_PINMUX('A', 7, ANALOG)>; /* USART1_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('A', 1, AF5)>; /* USART1_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('A', 2, AF6)>; /* USART1_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + usart1_sleep_pins_a: usart1-sleep-0 { + pins { + pinmux = <STM32_PINMUX('A', 3, ANALOG)>, /* USART1_TX */ + <STM32_PINMUX('A', 1, ANALOG)>, /* USART1_RTS */ + <STM32_PINMUX('A', 7, ANALOG)>, /* USART1_CTS_NSS */ + <STM32_PINMUX('A', 2, ANALOG)>; /* USART1_RX */ + }; + }; + /omit-if-no-ref/ usart2_pins_a: usart2-0 { pins1 {
@@ -504,6 +860,50 @@ pins { }; }; + /omit-if-no-ref/ + usart2_pins_b: usart2-1 { + pins1 { + pinmux = <STM32_PINMUX('A', 4, AF6)>, /* USART2_TX */ + <STM32_PINMUX('A', 5, AF6)>; /* USART2_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('A', 8, AF8)>, /* USART2_RX */ + <STM32_PINMUX('A', 9, AF6)>; /* USART2_CTS_NSS */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + usart2_idle_pins_b: usart2-idle-1 { + pins1 { + pinmux = <STM32_PINMUX('A', 4, ANALOG)>, /* USART2_TX */ + <STM32_PINMUX('A', 9, ANALOG)>; /* USART2_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('A', 5, AF6)>; /* USART2_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('A', 8, AF8)>; /* USART2_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + usart2_sleep_pins_b: usart2-sleep-1 { + pins { + pinmux = <STM32_PINMUX('A', 4, ANALOG)>, /* USART2_TX */ + <STM32_PINMUX('A', 5, ANALOG)>, /* USART2_RTS */ + <STM32_PINMUX('A', 9, ANALOG)>, /* USART2_CTS_NSS */ + <STM32_PINMUX('A', 8, ANALOG)>; /* USART2_RX */ + }; + }; + /omit-if-no-ref/ usart6_pins_a: usart6-0 { pins1 {
@@ -547,6 +947,127 @@ pins { <STM32_PINMUX('F', 14, ANALOG)>; /* USART6_RX */ }; }; + + /omit-if-no-ref/ + usart6_pins_b: usart6-1 { + pins1 { + pinmux = <STM32_PINMUX('F', 5, AF6)>; /* USART6_TX */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 4, AF6)>; /* USART6_RX */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + usart6_idle_pins_b: usart6-idle-1 { + pins1 { + pinmux = <STM32_PINMUX('F', 5, ANALOG)>; /* USART6_TX */ + }; + pins2 { + pinmux = <STM32_PINMUX('F', 4, AF6)>; /* USART6_RX */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + usart6_sleep_pins_b: usart6-sleep-1 { + pins { + pinmux = <STM32_PINMUX('F', 5, ANALOG)>, /* USART6_TX */ + <STM32_PINMUX('F', 4, ANALOG)>; /* USART6_RX */ + }; + }; + + /omit-if-no-ref/ + uart8_pins_a: uart8-0 { + pins1 { + pinmux = <STM32_PINMUX('I', 11, AF5)>, /* UART8_TX */ + <STM32_PINMUX('B', 15, AF3)>; /* UART8_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 11, AF6)>, /* UART8_RX */ + <STM32_PINMUX('H', 5, AF6)>; /* UART8_CTS_NSS */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart8_idle_pins_a: uart8-idle-0 { + pins1 { + pinmux = <STM32_PINMUX('I', 11, ANALOG)>, /* UART8_TX */ + <STM32_PINMUX('H', 5, ANALOG)>; /* UART8_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('B', 15, AF3)>; /* UART8_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('F', 11, AF6)>; /* UART8_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart8_sleep_pins_a: uart8-sleep-0 { + pins { + pinmux = <STM32_PINMUX('I', 11, ANALOG)>, /* UART8_TX */ + <STM32_PINMUX('B', 15, ANALOG)>, /* UART8_RTS */ + <STM32_PINMUX('H', 5, ANALOG)>, /* UART8_CTS_NSS */ + <STM32_PINMUX('F', 11, ANALOG)>; /* UART8_RX */ + }; + }; + + /omit-if-no-ref/ + uart9_pins_a: uart9-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 8, AF6)>, /* UART9_TX */ + <STM32_PINMUX('F', 12, AF6)>; /* UART9_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('I', 5, AF6)>, /* UART9_RX */ + <STM32_PINMUX('G', 7, AF6)>; /* UART9_CTS_NSS */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart9_idle_pins_a: uart9-idle-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 8, ANALOG)>, /* UART9_TX */ + <STM32_PINMUX('G', 7, ANALOG)>; /* UART9_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('F', 12, AF6)>; /* UART9_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('I', 5, AF6)>; /* UART9_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart9_sleep_pins_a: uart9-sleep-0 { + pins { + pinmux = <STM32_PINMUX('G', 8, ANALOG)>, /* UART9_TX */ + <STM32_PINMUX('F', 12, ANALOG)>, /* UART9_RTS */ + <STM32_PINMUX('G', 7, ANALOG)>, /* UART9_CTS_NSS */ + <STM32_PINMUX('I', 5, ANALOG)>; /* UART9_RX */ + }; + }; }; &pinctrl_z {
@@ -569,6 +1090,25 @@ pins { }; }; + /omit-if-no-ref/ + i2c8_pins_b: i2c8-1 { + pins { + pinmux = <STM32_PINMUX('Z', 4, AF8)>, /* I2C1_SCL */ + <STM32_PINMUX('Z', 9, AF8)>; /* I2C1_SDA */ + bias-disable; + drive-open-drain; + slew-rate = <0>; + }; + }; + + /omit-if-no-ref/ + i2c8_sleep_pins_b: i2c8-sleep-1 { + pins { + pinmux = <STM32_PINMUX('Z', 4, ANALOG)>, /* I2C1_SCL */ + <STM32_PINMUX('Z', 9, ANALOG)>; /* I2C1_SDA */ + }; + }; + /omit-if-no-ref/ spi8_pins_a: spi8-0 { pins1 {
@@ -592,4 +1132,28 @@ pins1 { <STM32_PINMUX('Z', 1, ANALOG)>; /* SPI8_MISO */ }; }; + + /omit-if-no-ref/ + spi8_pins_b: spi8-1 { + pins1 { + pinmux = <STM32_PINMUX('Z', 5, AF3)>, /* SPI8_SCK */ + <STM32_PINMUX('Z', 7, AF3)>; /* SPI8_MOSI */ + drive-push-pull; + bias-disable; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('Z', 8, AF3)>; /* SPI8_MISO */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + spi8_sleep_pins_b: spi8-sleep-1 { + pins1 { + pinmux = <STM32_PINMUX('Z', 5, ANALOG)>, /* SPI8_SCK */ + <STM32_PINMUX('Z', 7, ANALOG)>, /* SPI8_MOSI */ + <STM32_PINMUX('Z', 8, ANALOG)>; /* SPI8_MISO */ + }; + }; };
Signature · 1 line
2.53.0
[email protected]
AI reviewRe: [PATCH 08/10] arm64: dts: st: Add pinmux nodes for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider: - [High] Conflicting alternate function (AF) configurations for SDMMC3_D3 between active and open-drain…
Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] Conflicting alternate function (AF) configurations for SDMMC3_D3 between active and open-drain states.
- [High] The eth2_rgmii_pins_b node is missing the st,io-sync = "data on both edges"; property required for Double Data Rate (DDR) signaling in RGMII.
- [Medium] Active and sleep pinmux configurations for ETH2 MDIO use conflicting pins for ETH_MDC.
- [Low] Misleading inline comments in DT pinmux nodes copy-pasted from other nodes.
--
--- Patch [8]: [PATCH 08/10] arm64: dts: st: Add pinmux nodes for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board --- commit c98eed614c4613fe217412814e7be996b10ee304
Author: Marek Vasut <[email protected]>
arm64: dts: st: Add pinmux nodes for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
This patch adds new pinmux nodes for the DH electronics STM32MP2 DHCOS SoM and Breakout Board. It includes configurations for ETH2, I2C8, MCO1, SDMMC, SPI, UART, and USART interfaces.
Quoted 16 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +8
-0@@ -182,6 +182,30 @@ pins5 { }; }; + /omit-if-no-ref/ + eth2_mdio_pins_a: eth2-mdio-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 4, AF11)>; /* ETH_MDC */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + };
[ ... ]
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins5 { · line 204
Quoted 4 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +4
-0+ /omit-if-no-ref/ + eth2_mdio_sleep_pins_a: eth2-mdio-sleep-0 { + pins { + pinmux = <STM32_PINMUX('C', 6, ANALOG)>, /* ETH_MDC */
[Severity: Medium]
In eth2_mdio_pins_a, ETH_MDC is mapped to PG4. Does this mismatched pinmux configuration leave PG4 misconfigured and incorrectly apply analog mode to PC6 instead of PG4 during power management transitions?
Quoted 3 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +3
-0+ <STM32_PINMUX('C', 5, ANALOG)>; /* ETH_MDIO */ + }; + };
[ ... ]
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins { · line 232
Quoted 3 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +3
-0+ /omit-if-no-ref/ + eth2_rgmii_pins_b: eth2-rgmii-1 { + pins1 {
[Severity: High]
This node configures the RGMII data pins, but it doesn't include the st,io-sync = "data on both edges"; property required for Double Data Rate (DDR) signaling. Will this cause the MAC to use Single Data Rate sampling instead of RGMII DDR mode, resulting in timing violations?
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins { · line 244
Quoted 12 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +12
-0+ pinmux = <STM32_PINMUX('C', 7, AF10)>, /* ETH_RGMII_TXD0 */ + <STM32_PINMUX('C', 8, AF10)>, /* ETH_RGMII_TXD1 */ + <STM32_PINMUX('C', 9, AF10)>, /* ETH_RGMII_TXD2 */ + <STM32_PINMUX('C', 10, AF10)>, /* ETH_RGMII_TXD3 */ + <STM32_PINMUX('C', 4, AF10)>; /* ETH_RGMII_TX_CTL */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 8, AF10)>, /* ETH_RGMII_CLK125 */ + <STM32_PINMUX('F', 7, AF10)>; /* ETH_MDC */
[Severity: Low]
This isn't a bug, but should this be labeled ETH_RGMII_GTX_CLK rather than ETH_MDC, to match the sleep state configuration for PF7 below?
Quoted 4 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +4
-0+ bias-disable; + drive-push-pull; + slew-rate = <3>; + };
[ ... ]
Quoted 8 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +8
-0+ /omit-if-no-ref/ + sdmmc3_b4_pins_b: sdmmc3-b4-1 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, AF12)>, /* SDMMC3_D3 */ + <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */
[ ... ]
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins { · line 691
Quoted 7 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +7
-0+ /omit-if-no-ref/ + sdmmc3_b4_od_pins_b: sdmmc3-b4-od-1 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, AF10)>; /* SDMMC3_D3 */
[Severity: High]
The active state node (sdmmc3_b4_pins_b) configures PD14 with AF12 for SDMMC3_D3. Does configuring PD14 with AF10 here in the open-drain state disconnect the data line from the SDMMC controller during operations that use open-drain mode?
Quoted 4 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +4
-0+ slew-rate = <2>; + drive-push-pull; + bias-disable; + };
[ ... ]
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins { · line 1097
Quoted 5 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +5
-0+ /omit-if-no-ref/ + i2c8_pins_b: i2c8-1 { + pins { + pinmux = <STM32_PINMUX('Z', 4, AF8)>, /* I2C1_SCL */ + <STM32_PINMUX('Z', 9, AF8)>; /* I2C1_SDA */
[Severity: Low]
This isn't a bug, but the comments label these pins as I2C1 instead of I2C8. Were these comments copied from an earlier I2C1 node?
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins { · line 1108
Quoted 11 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +11
-0+ bias-disable; + drive-open-drain; + slew-rate = <0>; + }; + }; + + /omit-if-no-ref/ + i2c8_sleep_pins_b: i2c8-sleep-1 { + pins { + pinmux = <STM32_PINMUX('Z', 4, ANALOG)>, /* I2C1_SCL */ + <STM32_PINMUX('Z', 9, ANALOG)>; /* I2C1_SDA */
[Severity: Low]
This isn't a bug, but the same typo labels these pins as I2C1 instead of I2C8.
Quoted 2 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +2
-0+ }; + };
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=8
Alexandre TORGUE
maintainerRe: [PATCH 08/10] arm64: dts: st: Add pinmux nodes for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
In reply to Marek VasutHi Marek
Quoted 46 lines · Marek Vasut
Add new pinmux nodes for DH electronics STM32MP2 DHCOS SoM and BB board. The following pinmux nodes are added:
- ETH2 pins
- I2C8 pins
- MCO1 pins
- SDMMC1,2,3 pins
- SPI1,8 pins
- UART8,9 pins
- USART1,2,6 pinsSigned-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 564 ++++++++++++++++++ 1 file changed, 564 insertions(+)arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +10
-0@@ -182,6 +182,30 @@ pins5 { }; }; + /omit-if-no-ref/ + eth2_mdio_pins_a: eth2-mdio-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 4, AF11)>; /* ETH_MDC */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins2 { + pinmux = <STM32_PINMUX('C', 5, AF10)>; /* ETH_MDIO */
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins5 { · line 204
Quoted 10 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +10
-0+ bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + }; + + /omit-if-no-ref/ + eth2_mdio_sleep_pins_a: eth2-mdio-sleep-0 { + pins { + pinmux = <STM32_PINMUX('C', 6, ANALOG)>, /* ETH_MDC */
I assume it is G4 for MDC ? If yes I fix it when I apply.
Quoted 608 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +544
-0+ <STM32_PINMUX('C', 5, ANALOG)>; /* ETH_MDIO */ + }; + }; + /omit-if-no-ref/ eth2_rgmii_sleep_pins_a: eth2-rgmii-sleep-0 { pins {@@ -203,6 +227,68 @@ pins { }; }; + /omit-if-no-ref/ + eth2_rgmii_pins_b: eth2-rgmii-1 { + pins1 { + pinmux = <STM32_PINMUX('C', 7, AF10)>, /* ETH_RGMII_TXD0 */ + <STM32_PINMUX('C', 8, AF10)>, /* ETH_RGMII_TXD1 */ + <STM32_PINMUX('C', 9, AF10)>, /* ETH_RGMII_TXD2 */ + <STM32_PINMUX('C', 10, AF10)>, /* ETH_RGMII_TXD3 */ + <STM32_PINMUX('C', 4, AF10)>; /* ETH_RGMII_TX_CTL */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 8, AF10)>, /* ETH_RGMII_CLK125 */ + <STM32_PINMUX('F', 7, AF10)>; /* ETH_MDC */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins3 { + pinmux = <STM32_PINMUX('G', 0, AF10)>, /* ETH_RGMII_RXD0 */ + <STM32_PINMUX('C', 12, AF10)>, /* ETH_RGMII_RXD1 */ + <STM32_PINMUX('F', 9, AF10)>, /* ETH_RGMII_RXD2 */ + <STM32_PINMUX('C', 11, AF10)>, /* ETH_RGMII_RXD3 */ + <STM32_PINMUX('C', 3, AF10)>; /* ETH_RGMII_RX_CTL */ + bias-disable; + }; + pins4 { + pinmux = <STM32_PINMUX('F', 6, AF10)>; /* ETH_RGMII_RX_CLK */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + eth2_rgmii_sleep_pins_b: eth2-rgmii-sleep-1 { + pins { + pinmux = <STM32_PINMUX('C', 7, ANALOG)>, /* ETH_RGMII_TXD0 */ + <STM32_PINMUX('C', 8, ANALOG)>, /* ETH_RGMII_TXD1 */ + <STM32_PINMUX('C', 9, ANALOG)>, /* ETH_RGMII_TXD2 */ + <STM32_PINMUX('C', 10, ANALOG)>, /* ETH_RGMII_TXD3 */ + <STM32_PINMUX('C', 4, ANALOG)>, /* ETH_RGMII_TX_CTL */ + <STM32_PINMUX('F', 8, ANALOG)>, /* ETH_RGMII_CLK125 */ + <STM32_PINMUX('F', 7, ANALOG)>, /* ETH_RGMII_GTX_CLK */ + <STM32_PINMUX('G', 0, ANALOG)>, /* ETH_RGMII_RXD0 */ + <STM32_PINMUX('C', 12, ANALOG)>, /* ETH_RGMII_RXD1 */ + <STM32_PINMUX('F', 9, ANALOG)>, /* ETH_RGMII_RXD2 */ + <STM32_PINMUX('C', 11, ANALOG)>, /* ETH_RGMII_RXD3 */ + <STM32_PINMUX('C', 3, ANALOG)>, /* ETH_RGMII_RX_CTL */ + <STM32_PINMUX('F', 6, ANALOG)>; /* ETH_RGMII_RX_CLK */ + }; + }; + + /omit-if-no-ref/ + mco1_pins_a: mco1-0 { + pins { + pinmux = <STM32_PINMUX('I', 6, AF1)>; /* MCO1 */ + bias-disable; + drive-push-pull; + slew-rate = <2>; + }; + }; + /omit-if-no-ref/ i2c2_pins_a: i2c2-0 { pins {@@ -394,6 +480,26 @@ pins2 { }; }; + /omit-if-no-ref/ + sdmmc1_b4_pins_b: sdmmc1-b4-1 { + pins1 { + pinmux = <STM32_PINMUX('E', 4, AF10)>, /* SDMMC1_D0 */ + <STM32_PINMUX('E', 5, AF10)>, /* SDMMC1_D1 */ + <STM32_PINMUX('E', 0, AF10)>, /* SDMMC1_D2 */ + <STM32_PINMUX('E', 1, AF10)>, /* SDMMC1_D3 */ + <STM32_PINMUX('E', 2, AF10)>; /* SDMMC1_CMD */ + slew-rate = <1>; + drive-push-pull; + bias-disable; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 3, AF10)>; /* SDMMC1_CK */ + slew-rate = <2>; + drive-push-pull; + bias-disable; + }; + }; + /omit-if-no-ref/ sdmmc1_b4_od_pins_a: sdmmc1-b4-od-0 { pins1 {@@ -419,6 +525,31 @@ pins3 { }; }; + /omit-if-no-ref/ + sdmmc1_b4_od_pins_b: sdmmc1-b4-od-1 { + pins1 { + pinmux = <STM32_PINMUX('E', 4, AF10)>, /* SDMMC1_D0 */ + <STM32_PINMUX('E', 5, AF10)>, /* SDMMC1_D1 */ + <STM32_PINMUX('E', 0, AF10)>, /* SDMMC1_D2 */ + <STM32_PINMUX('E', 1, AF10)>; /* SDMMC1_D3 */ + slew-rate = <1>; + drive-push-pull; + bias-disable; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 3, AF10)>; /* SDMMC1_CK */ + slew-rate = <2>; + drive-push-pull; + bias-disable; + }; + pins3 { + pinmux = <STM32_PINMUX('E', 2, AF10)>; /* SDMMC1_CMD */ + slew-rate = <1>; + drive-open-drain; + bias-disable; + }; + }; + /omit-if-no-ref/ sdmmc1_b4_sleep_pins_a: sdmmc1-b4-sleep-0 { pins {@@ -431,6 +562,187 @@ pins { }; }; + /omit-if-no-ref/ + sdmmc2_b4_pins_a: sdmmc2-b4-0 { + pins1 { + pinmux = <STM32_PINMUX('E', 13, AF12)>, /* SDMMC2_D0 */ + <STM32_PINMUX('E', 11, AF12)>, /* SDMMC2_D1 */ + <STM32_PINMUX('E', 8, AF12)>, /* SDMMC2_D2 */ + <STM32_PINMUX('E', 12, AF12)>, /* SDMMC2_D3 */ + <STM32_PINMUX('E', 15, AF12)>; /* SDMMC2_CMD */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 14, AF12)>; /* SDMMC2_CK */ + slew-rate = <2>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc2_b4_od_pins_a: sdmmc2-b4-od-0 { + pins1 { + pinmux = <STM32_PINMUX('E', 13, AF12)>, /* SDMMC2_D0 */ + <STM32_PINMUX('E', 11, AF12)>, /* SDMMC2_D1 */ + <STM32_PINMUX('E', 8, AF12)>, /* SDMMC2_D2 */ + <STM32_PINMUX('E', 12, AF12)>; /* SDMMC2_D3 */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 14, AF12)>; /* SDMMC2_CK */ + slew-rate = <2>; + drive-push-pull; + bias-pull-up; + }; + pins3 { + pinmux = <STM32_PINMUX('E', 15, AF12)>; /* SDMMC2_CMD */ + slew-rate = <1>; + drive-open-drain; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc2_b4_sleep_pins_a: sdmmc2-b4-sleep-0 { + pins { + pinmux = <STM32_PINMUX('E', 13, ANALOG)>, /* SDMMC2_D0 */ + <STM32_PINMUX('E', 11, ANALOG)>, /* SDMMC2_D1 */ + <STM32_PINMUX('E', 8, ANALOG)>, /* SDMMC2_D2 */ + <STM32_PINMUX('E', 12, ANALOG)>, /* SDMMC2_D3 */ + <STM32_PINMUX('E', 14, ANALOG)>, /* SDMMC2_CK */ + <STM32_PINMUX('E', 15, ANALOG)>; /* SDMMC2_CMD */ + }; + }; + + /omit-if-no-ref/ + sdmmc2_d47_pins_a: sdmmc2-d47-0 { + pins { + pinmux = <STM32_PINMUX('E', 10, AF12)>, /* SDMMC2_D4 */ + <STM32_PINMUX('E', 9, AF12)>, /* SDMMC2_D5 */ + <STM32_PINMUX('E', 6, AF12)>, /* SDMMC2_D6 */ + <STM32_PINMUX('E', 7, AF12)>; /* SDMMC2_D7 */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc2_d47_sleep_pins_a: sdmmc2-d47-sleep-0 { + pins { + pinmux = <STM32_PINMUX('E', 10, ANALOG)>, /* SDMMC2_D4 */ + <STM32_PINMUX('E', 9, ANALOG)>, /* SDMMC2_D5 */ + <STM32_PINMUX('E', 6, ANALOG)>, /* SDMMC2_D6 */ + <STM32_PINMUX('E', 7, ANALOG)>; /* SDMMC2_D7 */ + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_pins_a: sdmmc3-b4-0 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('I', 11, AF10)>, /* SDMMC3_D3 */ + <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */ + slew-rate = <0>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('B', 13, AF10)>; /* SDMMC3_CK */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_pins_b: sdmmc3-b4-1 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, AF12)>, /* SDMMC3_D3 */ + <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */ + slew-rate = <0>; + drive-push-pull; + bias-pull-up; + }; + pins2 { + pinmux = <STM32_PINMUX('B', 13, AF10)>; /* SDMMC3_CK */ + slew-rate = <1>; + drive-push-pull; + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_od_pins_b: sdmmc3-b4-od-1 { + pins1 { + pinmux = <STM32_PINMUX('B', 14, AF10)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, AF10)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, AF10)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, AF10)>; /* SDMMC3_D3 */ + slew-rate = <2>; + drive-push-pull; + bias-disable; + }; + pins2 { + pinmux = <STM32_PINMUX('B', 13, AF10)>; /* SDMMC3_CK */ + slew-rate = <3>; + drive-push-pull; + bias-disable; + }; + pins3 { + pinmux = <STM32_PINMUX('D', 12, AF10)>; /* SDMMC3_CMD */ + slew-rate = <2>; + drive-open-drain; + bias-disable; + }; + }; + + /omit-if-no-ref/ + sdmmc3_b4_sleep_pins_b: sdmmc3-b4-sleep-1 { + pins { + pinmux = <STM32_PINMUX('B', 14, ANALOG)>, /* SDMMC3_D0 */ + <STM32_PINMUX('D', 13, ANALOG)>, /* SDMMC3_D1 */ + <STM32_PINMUX('B', 12, ANALOG)>, /* SDMMC3_D2 */ + <STM32_PINMUX('D', 14, ANALOG)>, /* SDMMC3_D3 */ + <STM32_PINMUX('B', 13, ANALOG)>, /* SDMMC3_CK */ + <STM32_PINMUX('D', 12, ANALOG)>; /* SDMMC3_CMD */ + }; + }; + + /omit-if-no-ref/ + spi1_pins_a: spi1-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 6, AF3)>, /* SPI1_SCK */ + <STM32_PINMUX('H', 7, AF2)>; /* SPI1_MOSI */ + drive-push-pull; + bias-disable; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('H', 8, AF2)>; /* SPI1_MISO */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + spi1_sleep_pins_a: spi1-sleep-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 6, ANALOG)>, /* SPI1_SCK */ + <STM32_PINMUX('H', 7, ANALOG)>, /* SPI1_MOSI */ + <STM32_PINMUX('H', 8, ANALOG)>; /* SPI1_MISO */ + }; + }; + /omit-if-no-ref/ spi3_pins_a: spi3-0 { pins1 {@@ -471,6 +783,50 @@ pins { }; }; + /omit-if-no-ref/ + usart1_pins_a: usart1-0 { + pins1 { + pinmux = <STM32_PINMUX('A', 3, AF6)>, /* USART1_TX */ + <STM32_PINMUX('A', 1, AF5)>; /* USART1_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('A', 2, AF6)>, /* USART1_RX */ + <STM32_PINMUX('A', 7, AF6)>; /* USART1_CTS_NSS */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + usart1_idle_pins_a: usart1-idle-0 { + pins1 { + pinmux = <STM32_PINMUX('A', 3, ANALOG)>, /* USART1_TX */ + <STM32_PINMUX('A', 7, ANALOG)>; /* USART1_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('A', 1, AF5)>; /* USART1_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('A', 2, AF6)>; /* USART1_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + usart1_sleep_pins_a: usart1-sleep-0 { + pins { + pinmux = <STM32_PINMUX('A', 3, ANALOG)>, /* USART1_TX */ + <STM32_PINMUX('A', 1, ANALOG)>, /* USART1_RTS */ + <STM32_PINMUX('A', 7, ANALOG)>, /* USART1_CTS_NSS */ + <STM32_PINMUX('A', 2, ANALOG)>; /* USART1_RX */ + }; + }; + /omit-if-no-ref/ usart2_pins_a: usart2-0 { pins1 {@@ -504,6 +860,50 @@ pins { }; }; + /omit-if-no-ref/ + usart2_pins_b: usart2-1 { + pins1 { + pinmux = <STM32_PINMUX('A', 4, AF6)>, /* USART2_TX */ + <STM32_PINMUX('A', 5, AF6)>; /* USART2_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('A', 8, AF8)>, /* USART2_RX */ + <STM32_PINMUX('A', 9, AF6)>; /* USART2_CTS_NSS */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + usart2_idle_pins_b: usart2-idle-1 { + pins1 { + pinmux = <STM32_PINMUX('A', 4, ANALOG)>, /* USART2_TX */ + <STM32_PINMUX('A', 9, ANALOG)>; /* USART2_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('A', 5, AF6)>; /* USART2_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('A', 8, AF8)>; /* USART2_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + usart2_sleep_pins_b: usart2-sleep-1 { + pins { + pinmux = <STM32_PINMUX('A', 4, ANALOG)>, /* USART2_TX */ + <STM32_PINMUX('A', 5, ANALOG)>, /* USART2_RTS */ + <STM32_PINMUX('A', 9, ANALOG)>, /* USART2_CTS_NSS */ + <STM32_PINMUX('A', 8, ANALOG)>; /* USART2_RX */ + }; + }; + /omit-if-no-ref/ usart6_pins_a: usart6-0 { pins1 {@@ -547,6 +947,127 @@ pins { <STM32_PINMUX('F', 14, ANALOG)>; /* USART6_RX */ }; }; + + /omit-if-no-ref/ + usart6_pins_b: usart6-1 { + pins1 { + pinmux = <STM32_PINMUX('F', 5, AF6)>; /* USART6_TX */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 4, AF6)>; /* USART6_RX */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + usart6_idle_pins_b: usart6-idle-1 { + pins1 { + pinmux = <STM32_PINMUX('F', 5, ANALOG)>; /* USART6_TX */ + }; + pins2 { + pinmux = <STM32_PINMUX('F', 4, AF6)>; /* USART6_RX */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + usart6_sleep_pins_b: usart6-sleep-1 { + pins { + pinmux = <STM32_PINMUX('F', 5, ANALOG)>, /* USART6_TX */ + <STM32_PINMUX('F', 4, ANALOG)>; /* USART6_RX */ + }; + }; + + /omit-if-no-ref/ + uart8_pins_a: uart8-0 { + pins1 { + pinmux = <STM32_PINMUX('I', 11, AF5)>, /* UART8_TX */ + <STM32_PINMUX('B', 15, AF3)>; /* UART8_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('F', 11, AF6)>, /* UART8_RX */ + <STM32_PINMUX('H', 5, AF6)>; /* UART8_CTS_NSS */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart8_idle_pins_a: uart8-idle-0 { + pins1 { + pinmux = <STM32_PINMUX('I', 11, ANALOG)>, /* UART8_TX */ + <STM32_PINMUX('H', 5, ANALOG)>; /* UART8_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('B', 15, AF3)>; /* UART8_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('F', 11, AF6)>; /* UART8_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart8_sleep_pins_a: uart8-sleep-0 { + pins { + pinmux = <STM32_PINMUX('I', 11, ANALOG)>, /* UART8_TX */ + <STM32_PINMUX('B', 15, ANALOG)>, /* UART8_RTS */ + <STM32_PINMUX('H', 5, ANALOG)>, /* UART8_CTS_NSS */ + <STM32_PINMUX('F', 11, ANALOG)>; /* UART8_RX */ + }; + }; + + /omit-if-no-ref/ + uart9_pins_a: uart9-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 8, AF6)>, /* UART9_TX */ + <STM32_PINMUX('F', 12, AF6)>; /* UART9_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins2 { + pinmux = <STM32_PINMUX('I', 5, AF6)>, /* UART9_RX */ + <STM32_PINMUX('G', 7, AF6)>; /* UART9_CTS_NSS */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart9_idle_pins_a: uart9-idle-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 8, ANALOG)>, /* UART9_TX */ + <STM32_PINMUX('G', 7, ANALOG)>; /* UART9_CTS_NSS */ + }; + pins2 { + pinmux = <STM32_PINMUX('F', 12, AF6)>; /* UART9_RTS */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + }; + pins3 { + pinmux = <STM32_PINMUX('I', 5, AF6)>; /* UART9_RX */ + bias-pull-up; + }; + }; + + /omit-if-no-ref/ + uart9_sleep_pins_a: uart9-sleep-0 { + pins { + pinmux = <STM32_PINMUX('G', 8, ANALOG)>, /* UART9_TX */ + <STM32_PINMUX('F', 12, ANALOG)>, /* UART9_RTS */ + <STM32_PINMUX('G', 7, ANALOG)>, /* UART9_CTS_NSS */ + <STM32_PINMUX('I', 5, ANALOG)>; /* UART9_RX */ + }; + }; }; &pinctrl_z {@@ -569,6 +1090,25 @@ pins { }; }; + /omit-if-no-ref/ + i2c8_pins_b: i2c8-1 { + pins { + pinmux = <STM32_PINMUX('Z', 4, AF8)>, /* I2C1_SCL */ + <STM32_PINMUX('Z', 9, AF8)>; /* I2C1_SDA */ + bias-disable; + drive-open-drain; + slew-rate = <0>; + }; + }; + + /omit-if-no-ref/ + i2c8_sleep_pins_b: i2c8-sleep-1 { + pins { + pinmux = <STM32_PINMUX('Z', 4, ANALOG)>, /* I2C1_SCL */ + <STM32_PINMUX('Z', 9, ANALOG)>; /* I2C1_SDA */ + }; + }; + /omit-if-no-ref/ spi8_pins_a: spi8-0 { pins1 {@@ -592,4 +1132,28 @@ pins1 { <STM32_PINMUX('Z', 1, ANALOG)>; /* SPI8_MISO */ }; }; + + /omit-if-no-ref/ + spi8_pins_b: spi8-1 { + pins1 { + pinmux = <STM32_PINMUX('Z', 5, AF3)>, /* SPI8_SCK */ + <STM32_PINMUX('Z', 7, AF3)>; /* SPI8_MOSI */ + drive-push-pull; + bias-disable; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('Z', 8, AF3)>; /* SPI8_MISO */ + bias-disable; + }; + }; + + /omit-if-no-ref/ + spi8_sleep_pins_b: spi8-sleep-1 { + pins1 { + pinmux = <STM32_PINMUX('Z', 5, ANALOG)>, /* SPI8_SCK */ + <STM32_PINMUX('Z', 7, ANALOG)>, /* SPI8_MOSI */ + <STM32_PINMUX('Z', 8, ANALOG)>; /* SPI8_MISO */ + }; + }; };
Marek Vasut
maintainerRe: [PATCH 08/10] arm64: dts: st: Add pinmux nodes for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
On 9/28/26 11:02 AM, Alexandre TORGUE wrote:
Hello Alexandre,
Quoted 21 lines
Quoted 21 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +14
-0@@ -182,6 +182,30 @@ pins5 { }; }; + /omit-if-no-ref/ + eth2_mdio_pins_a: eth2-mdio-0 { + pins1 { + pinmux = <STM32_PINMUX('G', 4, AF11)>; /* ETH_MDC */ + bias-disable; + drive-push-pull; + slew-rate = <3>; + }; + pins2 { + pinmux = <STM32_PINMUX('C', 5, AF10)>; /* ETH_MDIO */ + bias-disable; + drive-push-pull; + slew-rate = <0>; + };
Quoted 8 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi pins5 { · line 204
Quoted 6 lines
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi +6
-0+ }; + + /omit-if-no-ref/ + eth2_mdio_sleep_pins_a: eth2-mdio-sleep-0 { + pins { + pinmux = <STM32_PINMUX('C', 6, ANALOG)>, /* ETH_MDC */I assume it is G4 for MDC ? If yes I fix it when I apply.
It is PG4 , thank you.
Marek Vasut
maintainerPATCH 9/10 arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
In reply to Marek VasutThis stm32mp25xx-dhcos-bb board is a stack of DHCOS SoM based on STM32MP25xx SoC (1200MHz / crypto capabilities) populated on SoM Breakout Board, the stm32mp255c-dhcos-dhsbc is the SoM populated on DHSBC carrier board. The stm32mp23xx-dhcos-bb is a stack with STM32MP23xx SoC.
The SoM contains the following peripherals:
- STPMIC (power delivery)
- 4GiB LPDDR4 memory
- eMMC and SDIO WiFi module
The Breakout Board carrier board contains the following peripherals:
- USB-C peripheral port, power supply plug
The DHSBC carrier board contains the following peripherals:
- Two RGMII Ethernet ports
- MicroSD slot
- LVDS connector
- MIPI CSI2 connector
- USB-A Host port, USB-C power supply plug
- USB-C / DP port
- Expansion connector
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- arch/arm64/boot/dts/st/Makefile | 10 + arch/arm64/boot/dts/st/stm32mp23xc.dtsi | 7 + .../boot/dts/st/stm32mp23xx-dhcos-bb.dts | 15 + .../boot/dts/st/stm32mp23xx-dhcos-som.dtsi | 51 ++ ...mp255c-dhcos-dhsbc-overlay-imx219-x10.dtso | 111 +++++ .../boot/dts/st/stm32mp255c-dhcos-dhsbc.dts | 189 ++++++++ arch/arm64/boot/dts/st/stm32mp25xc.dtsi | 7 + .../boot/dts/st/stm32mp25xx-dhcos-bb.dts | 15 + .../boot/dts/st/stm32mp25xx-dhcos-som.dtsi | 51 ++ .../boot/dts/st/stm32mp2xxx-dhcos-som.dtsi | 442 ++++++++++++++++++ 10 files changed, 898 insertions(+) create mode 100644 arch/arm64/boot/dts/st/stm32mp23xc.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts create mode 100644 arch/arm64/boot/dts/st/stm32mp23xx-dhcos-som.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc-overlay-imx219-x10.dtso create mode 100644 arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts create mode 100644 arch/arm64/boot/dts/st/stm32mp25xc.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts create mode 100644 arch/arm64/boot/dts/st/stm32mp25xx-dhcos-som.dtsi create mode 100644 arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi
arch/arm64/boot/dts/st/Makefile +10 -0
@@ -1,6 +1,16 @@ # SPDX-License-Identifier: GPL-2.0-only + +stm32mp255c-dhcos-dhsbc-overlay-imx219-x10-dtbs := \ + stm32mp255c-dhcos-dhsbc.dtb \ + stm32mp255c-dhcos-dhsbc-overlay-imx219-x10.dtbo + dtb-$(CONFIG_ARCH_STM32) += \ stm32mp215f-dk.dtb \ stm32mp235f-dk.dtb \ + stm32mp23xx-dhcos-bb.dtb \ + stm32mp25xx-dhcos-bb.dtb \ + stm32mp255c-dhcos-dhsbc.dtb \ + stm32mp255c-dhcos-dhsbc-overlay-imx219-x10.dtb \ + stm32mp255c-dhcos-dhsbc-overlay-imx219-x10.dtbo \ stm32mp257f-dk.dtb \ stm32mp257f-ev1.dtb
arch/arm64/boot/dts/st/stm32mp23xc.dtsi new file +7 -0
@@ -0,0 +1,7 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-3-Clause) +/* + * Copyright (C) 2026 Marek Vasut <[email protected]> + */ + +/ { +};
arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts new file +15 -0
@@ -0,0 +1,15 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-3-Clause) +/* + * Copyright (C) 2026 Marek Vasut <[email protected]> + */ + +/dts-v1/; + +#include "stm32mp235.dtsi" +#include "stm32mp23xc.dtsi" +#include "stm32mp23xx-dhcos-som.dtsi" + +/ { + model = "DH electronics STM32MP23xx DHCOS Breakout Board"; + compatible = "dh,stm32mp231a-dhcos-bb", "dh,stm32mp231a-dhcos-som", "st,stm32mp231"; +};
arch/arm64/boot/dts/st/stm32mp23xx-dhcos-som.dtsi new file +51 -0
51 lines not on this page · raw message
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc-overlay-imx219-x10.dtso new file +111 -0
111 lines not on this page · raw message
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts new file +189 -0
189 lines not on this page · raw message
arch/arm64/boot/dts/st/stm32mp25xc.dtsi new file +7 -0
@@ -0,0 +1,7 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-3-Clause) +/* + * Copyright (C) 2026 Marek Vasut <[email protected]> + */ + +/ { +};
arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts new file +15 -0
@@ -0,0 +1,15 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-3-Clause) +/* + * Copyright (C) 2025-2026 Marek Vasut <[email protected]> + */ + +/dts-v1/; + +#include "stm32mp255.dtsi" +#include "stm32mp25xc.dtsi" +#include "stm32mp25xx-dhcos-som.dtsi" + +/ { + model = "DH electronics STM32MP25xx DHCOS Breakout Board"; + compatible = "dh,stm32mp251a-dhcos-bb", "dh,stm32mp251a-dhcos-som", "st,stm32mp251"; +};
arch/arm64/boot/dts/st/stm32mp25xx-dhcos-som.dtsi new file +51 -0
51 lines not on this page · raw message
arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi new file +442 -0
442 lines not on this page · raw message
Signature · 1 line
2.53.0
[email protected]
AI reviewThank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [High] SoC hardware mismatch between included DTSI and root compatible string - [High] Incorrect SPI chip…
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] SoC hardware mismatch between included DTSI and root compatible string
- [High] Incorrect SPI chip select polarity (GPIO_ACTIVE_HIGH) breaks SPI communication
- [Low] Dangling uart8 alias in common DTSI file
--
--- Patch [9]: [PATCH 09/10] arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC --- commit 703b623c315fcfbe4a6aecf3454ed4e9fa856d0e
Author: Marek Vasut <[email protected]>
arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board and DHSBC
This commit adds device tree definitions for the DH electronics DHCOS system-on-module based on STM32MP25xx and STM32MP23xx SoCs. It also includes support for the corresponding Breakout Board and DHSBC carrier boards.
Quoted 6 lines
arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts new file +0
-0@@ -0,0 +1,15 @@
[ ... ]
arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts line 14
Quoted 7 lines
arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts new file +7
-0+#include "stm32mp235.dtsi" +#include "stm32mp23xc.dtsi" +#include "stm32mp23xx-dhcos-som.dtsi" + +/ { + model = "DH electronics STM32MP23xx DHCOS Breakout Board"; + compatible = "dh,stm32mp231a-dhcos-bb", "dh,stm32mp231a-dhcos-som", "st,stm32mp231";
[Severity: High]
Does this compatible string mismatch the included DTSI?
This file includes stm32mp235.dtsi, which usually defines additional hardware capabilities like secondary CPUs, but sets the root compatible to st,stm32mp231. If the board physically has a single-core SoC, could the kernel attempt to initialize non-existent hardware and fail?
Quoted 7 lines
arch/arm64/boot/dts/st/stm32mp23xx-dhcos-bb.dts new file +1
-0+};arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts new file +0
-0
[ ... ]
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts line 171
Quoted 5 lines
+&spi1 {
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts new file +4
-0+ pinctrl-names = "default", "sleep"; + pinctrl-0 = <&spi1_pins_a>; + pinctrl-1 = <&spi1_sleep_pins_a>; + cs-gpios = <&gpioh 3 0>;
[Severity: High]
Does this cs-gpios definition use the correct polarity?
The value 0 (GPIO_ACTIVE_HIGH) is specified, but standard SPI devices, including the st33htpm-spi TPM attached below, typically require an active-low chip select. Could this active-high polarity break communication with the TPM?
Quoted 5 lines
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts new file +5
-0+ status = "okay"; + + st33htph: tpm@0 { + compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi"; + reg = <0>;
[ ... ]
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts line 188
Quoted 5 lines
+&spi8 {
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts new file +4
-0+ pinctrl-names = "default", "sleep"; + pinctrl-0 = <&spi8_pins_b>; + pinctrl-1 = <&spi8_sleep_pins_b>; + cs-gpios = <&gpioz 6 0>;
[Severity: High]
Is the chip select polarity correct here as well?
This also specifies 0 (GPIO_ACTIVE_HIGH) for the SPI8 chip select.
Quoted 8 lines
arch/arm64/boot/dts/st/stm32mp255c-dhcos-dhsbc.dts new file +1
-0+};arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts new file +0
-0@@ -0,0 +1,15 @@
[ ... ]
arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts line 14
Quoted 7 lines
arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts new file +7
-0+#include "stm32mp255.dtsi" +#include "stm32mp25xc.dtsi" +#include "stm32mp25xx-dhcos-som.dtsi" + +/ { + model = "DH electronics STM32MP25xx DHCOS Breakout Board"; + compatible = "dh,stm32mp251a-dhcos-bb", "dh,stm32mp251a-dhcos-som", "st,stm32mp251";
[Severity: High]
Does this compatible string mismatch the included DTSI?
Similar to the mp23xx board, this includes stm32mp255.dtsi but declares the compatible string as st,stm32mp251.
Quoted 9 lines
arch/arm64/boot/dts/st/stm32mp25xx-dhcos-bb.dts new file +1
-0+};arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi new file +1
-0@@ -0,0 +1,442 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi line 11
Quoted 10 lines
arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi new file +10
-0+/* + * Copyright (C) 2025-2026 Marek Vasut <[email protected]> + */ + +/ { + aliases { + mmc0 = &sdmmc2; + mmc1 = &sdmmc3; + serial0 = &usart6; + serial1 = &uart8;
[Severity: Low]
Does this create a dangling alias on STM32MP23xx platforms?
Since this is a common DTSI file included by stm32mp23xx-dhcos-som.dtsi, assigning serial1 to uart8 might be problematic if uart8 does not exist on STM32MP23xx SoCs.
Quoted 2 lines
arch/arm64/boot/dts/st/stm32mp2xxx-dhcos-som.dtsi new file +2
-0+ eeprom0 = &eeprom0; + eeprom0wl = &eeprom0wl;
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9
Marek Vasut
maintainerPATCH 10/10 MAINTAINERS: Add DH electronics DHCOS SoM entry and fix email address
In reply to Marek VasutAdd another SoM type N: match and update email address to an up to date one in the process.
---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
@@ -7518,11 +7518,12 @@ F: drivers/iio/chemical/sen0322.c DH ELECTRONICS DHSOM SOM AND BOARD SUPPORT M: Christoph Niedermaier <[email protected]> -M: Marek Vasut <[email protected]> +M: Marek Vasut <[email protected]> L: [email protected] S: Maintained N: dhcom N: dhcor +N: dhcos N: dhsom DIALOG SEMICONDUCTOR DRIVERS
Signature · 1 line
2.53.0
Re: [PATCH 10/10] MAINTAINERS: Add DH electronics DHCOS SoM entry and fix email address
Quoted 26 lines · Marek Vasut
Add another SoM type N: match and update email address to an up to date one in the process.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)MAINTAINERS +0
-0
MAINTAINERS F: drivers/iio/chemical/sen0322.c · line 7523
Quoted 7 lines
MAINTAINERS +1
-1@@ -7518,11 +7518,12 @@ F: drivers/iio/chemical/sen0322.c DH ELECTRONICS DHSOM SOM AND BOARD SUPPORT M: Christoph Niedermaier <[email protected]> -M: Marek Vasut <[email protected]> +M: Marek Vasut <[email protected]> L: [email protected] S: Maintained
Commit is fine, but, assuming old address stops working, please send a patch changing address in other MAINTAINERS entry + mailmap entry, and in all of dt-bindings (one patch for DT is enough)
Best regards,
Krzysztof
Marek Vasut
maintainerRe: [PATCH 10/10] MAINTAINERS: Add DH electronics DHCOS SoM entry and fix email address
Quoted 28 lines · Krzysztof Kozlowski
Quoted 27 lines · Marek Vasut
Add another SoM type N: match and update email address to an up to date one in the process.
Signed-off-by Marek Vasut <[email protected]>---
Cc: Alexandre Torgue <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)MAINTAINERS +0
-0@@ -7518,11 +7518,12 @@ F: drivers/iio/chemical/sen0322.c
Quoted 10 lines
MAINTAINERS F: drivers/iio/chemical/sen0322.c · line 7523
Quoted 6 lines
MAINTAINERS +1
-1DH ELECTRONICS DHSOM SOM AND BOARD SUPPORT M: Christoph Niedermaier <[email protected]> -M: Marek Vasut <[email protected]> +M: Marek Vasut <[email protected]> L: [email protected] S: MaintainedCommit is fine, but, assuming old address stops working, please send a patch changing address in other
MAINTAINERSentry + mailmap entry, and in all of dt-bindings (one patch for DT is enough)
There is one more DRM entry, I will fix that up in a separate patch.
But since you brought this up -- what about the mail address used in copyright headers (comments) in various drivers, shall I simply remove it and be done with it (I think yes, but again, separate patchset) ?
Re: [PATCH 10/10] MAINTAINERS: Add DH electronics DHCOS SoM entry and fix email address
Quoted 3 lines · Marek Vasut
But since you brought this up -- what about the mail address used in copyright headers (comments) in various drivers, shall I simply remove it and be done with it (I think yes, but again, separate patchset) ?
1. In non-personal copyright headers: tricky to say, maybe using company email gave some attributions which now could be changed. I don't know... but I did update mine to @korg back in 2016 :)
2. In personal copyright headers, comments, MODULE_AUTHOR() etc: up to you, it's perfectly fine to update it so people can reach you with questions. Therefore some people update it, some people don't.
Best regards,
Krzysztof
Marek Vasut
maintainerHello Alexandre,
Quoted 10 lines · Marek Vasut
This stm32mp25xx-dhcos-bb board is a stack of DHCOS SoM based on STM32MP25xx SoC (1200MHz / crypto capabilities) populated on SoM Breakout Board, the stm32mp255c-dhcos-dhsbc is the SoM populated on DHSBC carrier board. The stm32mp23xx-dhcos-bb is a stack with STM32MP23xx SoC.
The SoM contains the following peripherals:
- STPMIC (power delivery)
- 4GiB LPDDR4 memory
- eMMC and SDIO WiFi module
Have you had a chance to look at this series ?
Marek Vasut
maintainerHello one more time,
Quoted 9 lines · Marek Vasut
Hello Alexandre,
Quoted 6 lines · Marek Vasut
This stm32mp25xx-dhcos-bb board is a stack of DHCOS SoM based on STM32MP25xx SoC (1200MHz / crypto capabilities) populated on SoM Breakout Board, the stm32mp255c-dhcos-dhsbc is the SoM populated on DHSBC carrier board. The stm32mp23xx-dhcos-bb is a stack with STM32MP23xx SoC.
Quoted 5 lines
Quoted 4 lines
The SoM contains the following peripherals:
- STPMIC (power delivery)
- 4GiB LPDDR4 memory
- eMMC and SDIO WiFi moduleHave you had a chance to look at this series ?
I would like to be sure this series does not slip through the cracks.
Thank you for your help !
Signature · 2 lines
Best regards, Marek Vasut
Alexandre TORGUE
maintainerHi Marek,
Quoted 23 lines · Marek Vasut
This stm32mp25xx-dhcos-bb board is a stack of DHCOS SoM based on STM32MP25xx SoC (1200MHz / crypto capabilities) populated on SoM Breakout Board, the stm32mp255c-dhcos-dhsbc is the SoM populated on DHSBC carrier board. The stm32mp23xx-dhcos-bb is a stack with STM32MP23xx SoC.
The SoM contains the following peripherals:
- STPMIC (power delivery)
- 4GiB LPDDR4 memory
- eMMC and SDIO WiFi moduleThe Breakout Board carrier board contains the following peripherals:
- USB-C peripheral port, power supply plugThe DHSBC carrier board contains the following peripherals:
- Two RGMII Ethernet ports
- MicroSD slot
- LVDS connector
- MIPI CSI2 connector
- USB-A Host port, USB-C power supply plug
- USB-C / DP port
- Expansion connector
Quoted 14 lines
Marek Vasut (10):
dt-bindings: arm: stm32: Document STM32MP23xx/STM32MP25xx DHCOS SoM
and Breakout Board and DHSBC
dt-bindings: gpio: pca95xx: Document Kinetic KTS1622
arm64: dts: st: Fix SDMMC1 indent on stm32mp231
arm64: dts: st: Fix SDMMC1 indent on stm32mp251
arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp231
arm64: dts: st: Add SDMMC2 and SDMMC3 nodes on stm32mp251
arm64: dts: st: Add OMM node on stm32mp231
arm64: dts: st: Add pinmux nodes for DH electronics
STM32MP23xx/STM32MP25xx DHCOS SoM and Breakout Board
arm64: dts: st: Add support for DH electronics STM32MP23xx/STM32MP25xx
DHCOS SoM and Breakout Board and DHSBC
MAINTAINERS: Add DH electronics DHCOS SoM entry and fix email address
Series applied on stm32-next. Some changes have been done due to conflict merge.
Thanks
Alex