staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
PATCH v3 1/1 staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
Collapse the static CamelCase helper function ReadChipVersion8723B() directly into the main rtl8723b_read_chip_version() function. This removes unnecessary code nesting and cleans up the CamelCase naming violation in a single atomic change.
---
Changes in v3:
- Merged the previous 2-patch series into a single patch as suggested by Nikolay. Completely removed the redundant helper instead of renaming it with '__' prefixes.
Changes in v2:
- Resent the series due to submission issues with v1 (no code changes).
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +1 -6
@@ -820,7 +820,7 @@ void Hal_ReadEFuse(hal_ReadEFuse_BT (padapter, _offset, _size_byte, pbuf); } -static void ReadChipVersion8723B (struct adapter *padapter) +void rtl8723b_read_chip_version (struct adapter *padapter) {u32 value32;struct hal_com_data *pHalData;
@@ -843,11 +843,6 @@ static void ReadChipVersion8723B(struct adapter *padapter) pHalData->PolarityCtl = ((value32 &WL_HWPDN_SL ) ?RT_POLARITY_HIGH_ACT :RT_POLARITY_LOW_ACT ); } -void rtl8723b_read_chip_version (struct adapter *padapter) -{ -ReadChipVersion8723B (padapter); -} -void rtl8723b_InitBeaconParameters (struct adapter *padapter) {struct hal_com_data *pHalData =GET_HAL_DATA (padapter);
Signature · 1 line
2.55.0
Greg KH
maintainerQuoted 12 lines · Arsenii Pashchenko
Collapse the static CamelCase helper function
ReadChipVersion8723B()directly into the mainrtl8723b_read_chip_version()function. This removes unnecessary code nesting and cleans up the CamelCase naming violation in a single atomic change.Signed-off-by Arsenii Pashchenko <[email protected]>---
Changes in v3:
- Merged the previous 2-patch series into a single patch as suggested by Nikolay. Completely removed the redundant helper instead of renaming it with '__' prefixes.
Quoted 5 lines
Changes in v2:
- Resent the series due to submission issues with v1 (no code changes).--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
The versioning goes below the --- line that is in the diff, don't create a new one please.
Perhaps use a tool like b4 to handle this all for you?
thanks,
greg k-h