Skip to contentSkip to conversation

removing the remaining blockdev_direct_IO users

DISCUSSION Christoph Hellwig 2 participants 6 messages Jul 10 – Jul 16

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

we have 7 users of blockdev_direct_IO and one of the lower-level __blockdev_direct_IO left, and I'd really like to get rid of them.

The filesystems are affs, fat, hfs, hfsplus, jfs, nilfs2, udf and ocfs2, and you are the relevant maintainers. In 7.2 exfat converted entirely to iomap, which would be a really good example for a "simple" file system. Another options especially for the file systems supporting foreign formats would be to just drop direct I/O support and reduce the support burden.

#1 lore raw
Quoted 5 lines · Christoph Hellwig

Hi all,

we have 7 users of blockdev_direct_IO and one of the lower-level __blockdev_direct_IO left, and I'd really like to get rid of them.

Quoted 8 lines

The filesystems are affs, fat, hfs, hfsplus, jfs, nilfs2, udf and ocfs2,
and you are the relevant maintainers.  In 7.2 exfat converted entirely
to iomap, which would be a really good example for a "simple" file system.  Another options especially for the file systems supporting foreign formats would be to just drop direct I/O support and reduce the support burden.

I like the idea. I think we can try to switch HFS/HFS+ and NILFS2 on iomap approach. Do you have some initial patches for this? Which particular commit(s) converted the exfat to iomap? It will be good to take a deeper look into this conversion to estimate the complexity of HFS/HFS+, NILFS2 modifications.

Thanks,
Slava.

#2 lore raw
Quoted 15 lines · Viacheslav Dubeyko
Quoted 5 lines · Christoph Hellwig

Hi all,

we have 7 users of blockdev_direct_IO and one of the lower-level __blockdev_direct_IO left, and I'd really like to get rid of them.

Quoted 8 lines

The filesystems are affs, fat, hfs, hfsplus, jfs, nilfs2, udf and ocfs2,
and you are the relevant maintainers.  In 7.2 exfat converted entirely
to iomap, which would be a really good example for a "simple" file system.  Another options especially for the file systems supporting foreign formats would be to just drop direct I/O support and reduce the support burden.

Quoted 5 lines

I like the idea. I think we can try to switch HFS/HFS+ and NILFS2 on iomap approach. Do you have some initial patches for this? Which particular commit(s) converted the exfat to iomap? It will be good to take a deeper look into this conversion to estimate the complexity of HFS/HFS+, NILFS2 modifications.

Almost all commits in fs/exfat/ in 7.2-rc1, starting with 623f0aa1eca5c2a94ca1e4e5de719d062eac3b6c

#3 lore raw
Quoted 29 lines · Christoph Hellwig
Quoted 19 lines · Viacheslav Dubeyko
Quoted 6 lines · Christoph Hellwig

Hi all,

we have 7 users of blockdev_direct_IO and one of the lower-level __blockdev_direct_IO left, and I'd really like to get rid of them.

Quoted 11 lines

The filesystems are affs, fat, hfs, hfsplus, jfs, nilfs2, udf and ocfs2,
and you are the relevant maintainers.  In 7.2 exfat converted entirely
to iomap, which would be a really good example for a "simple" file
system.  Another options especially for the file systems supporting
foreign formats would be to just drop direct I/O support and reduce
the support burden.

Quoted 8 lines

I like the idea. I think we can try to switch HFS/HFS+ and NILFS2 on
iomap approach. Do you have some initial patches for this? Which particular commit(s) converted the exfat to iomap? It will be good to
take a deeper look into this conversion to estimate the complexity of
HFS/HFS+, NILFS2 modifications.

Quoted 2 lines

Almost all commits in fs/exfat/ in 7.2-rc1, starting with 623f0aa1eca5c2a94ca1e4e5de719d062eac3b6c

OK. Thanks for sharing this. :) Let me take a look and spend some time on this. I should have a time for checking commits during this week. I hope so. :)

Thanks,
Slava.

#4 lore raw

Hi Christoph,

Quoted 34 lines · Viacheslav Dubeyko
Quoted 33 lines · Christoph Hellwig
Quoted 31 lines · Viacheslav Dubeyko
Quoted 7 lines · Christoph Hellwig

Hi all,

we have 7 users of blockdev_direct_IO and one of the lower- level
__blockdev_direct_IO left, and I'd really like to get rid of them.

Quoted 12 lines

The filesystems are affs, fat, hfs, hfsplus, jfs, nilfs2, udf and
ocfs2,
and you are the relevant maintainers.  In 7.2 exfat converted entirely
to iomap, which would be a really good example for a "simple" file
system.  Another options especially for the file systems supporting
foreign formats would be to just drop direct I/O support and reduce
the support burden.

I like the idea. I think we can try to switch HFS/HFS+ and NILFS2 on
iomap approach. Do you have some initial patches for this? Which particular commit(s) converted the exfat to iomap? It will be good
to
take a deeper look into this conversion to estimate the complexity
of
HFS/HFS+, NILFS2 modifications.

Quoted 9 lines
Quoted 2 lines

Almost all commits in fs/exfat/ in 7.2-rc1, starting with 623f0aa1eca5c2a94ca1e4e5de719d062eac3b6c

OK. Thanks for sharing this. :) Let me take a look and spend some time
on this. I should have a time for checking commits during this week. I
hope so. :)

I have a very initial state of patchset for HFS+ file system. I am testing it by xfstests now. As far as I can see, currently, this patchset introduced multiple xfstests failures. If you like I can share this patchset for discussion and review. Otherwise, let me fix the found xfstests failures at first and, then, I'll share the patchset for the review.

Thanks,
Slava.

#5 lore raw
Quoted 6 lines · Viacheslav Dubeyko

I have a very initial state of patchset for HFS+ file system. I am testing it by xfstests now. As far as I can see, currently, this patchset introduced multiple xfstests failures. If you like I can share this patchset for discussion and review. Otherwise, let me fix the found xfstests failures at first and, then, I'll share the patchset for the review.

The unfinished one isn't too interesting to review. But if you're stuck on failures you need help with, feel free to send it along with the question.