Skip to contentSkip to conversation

sched/deadline: Exclude special DL entities from bandwidth moves

PATCH RESEND New Guopeng Zhang 1 participant 1 message Jul 13 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 sched/deadline: Exclude special DL entities from bandwidth moves

From: Guopeng Zhang <[email protected]>

SUGOV special DL entities use fake/unused bandwidth. They are already excluded from regular DL admission control, affinity admission checks, rq bandwidth accounting, and root-domain rebuild accounting.

dl_task_needs_bw_move() misses the same exclusion. As a result, set_cpus_allowed_dl() and cpuset attach may treat a special DL entity as requiring a root-domain bandwidth move when its affinity mask no longer intersects the source root domain.

Return false for special DL entities so root-domain bandwidth move accounting follows the rest of the SUGOV special-entity handling.

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +1 -1
index a3003b0f4522..8ba01a0ce36b 100644
@@ -3354,7 +3354,7 @@ static void set_cpus_allowed_dl(struct task_struct *p,
 bool dl_task_needs_bw_move(struct task_struct *p,
 			   const struct cpumask *new_mask)
 {
-	if (!dl_task(p))
+	if (!dl_task(p) || dl_entity_is_special(&p->dl))
 		return false;
 
 	return !cpumask_intersects(task_rq(p)->rd->span, new_mask);
Signature · 1 line
2.43.0