Skip to contentSkip to conversation

RDMA/ionic: Fix NULL pointer dereferences

PATCH In review Kamal Heib 4 participants 13 messages Jul 9 – Jul 13

Subsystems (2)
lore
Share & tools
lore

Kamal Heib

author
#0 lore raw

cover RDMA/ionic: Fix NULL pointer dereferences

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
author
#1 lore raw

PATCH 1/2 RDMA/ionic: Fix potential NULL pointer dereference in ionic_query_device

The function ionic_query_device() calls ib_device_get_netdev() without checking the return value which could lead to NULL pointer dereference, Fix it by checking the return value and return -ENODEV if the 'ndev' is NULL.

Fixes 2075bbe8ef03 ("RDMA/ionic: Register device ops for miscellaneous functionality")
---
 drivers/infiniband/hw/ionic/ionic_ibdev.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/infiniband/hw/ionic/ionic_ibdev.c +3 -0
index b0449c75f893..8614546b2558 100644
@@ -32,6 +32,9 @@ static int ionic_query_device(struct ib_device *ibdev,
 		return err;
 
 	ndev = ib_device_get_netdev(ibdev, 1);
+	if (!ndev)
+		return -ENODEV;
+
 	addrconf_ifid_eui48((u8 *)&attr->sys_image_guid, ndev);
 	dev_put(ndev);
 	attr->max_mr_size = dev->lif_cfg.npts_per_lif * PAGE_SIZE / 2;
Signature · 1 line
2.55.0
author
#2 lore raw

PATCH 2/2 RDMA/ionic: Fix potential NULL pointer dereference in ionic_create_ibdev

The ionic_lif_netdev() function can return NULL if lif->netdev is not set, but the caller in ionic_create_ibdev() was not checking for this before dereferencing the returned pointer in addrconf_ifid_eui48().

Add a NULL check after calling ionic_lif_netdev() and return -ENODEV if no netdev is available.

Fixes 8d765af51a09 ("RDMA/ionic: Register auxiliary module for ionic ethernet adapter")
---
 drivers/infiniband/hw/ionic/ionic_ibdev.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/infiniband/hw/ionic/ionic_ibdev.c +5 -0
index 8614546b2558..c738eb5be085 100644
@@ -348,6 +348,11 @@ static struct ionic_ibdev *ionic_create_ibdev(struct ionic_aux_dev *ionic_adev)
 	ibdev->num_comp_vectors = dev->lif_cfg.eq_count - 2;
 
 	ndev = ionic_lif_netdev(ionic_adev->lif);
+	if (!ndev) {
+		rc = -ENODEV;
+		goto err_admin;
+	}
+
 	addrconf_ifid_eui48((u8 *)&ibdev->node_guid, ndev);
 	rc = ib_device_set_netdev(ibdev, ndev, 1);
 	/* ionic_lif_netdev() returns ndev with refcount held */
Signature · 1 line
2.55.0
Reviewed-by on v1 2/2
#3 lore raw

Re: [PATCH rdma-rc 2/2] RDMA/ionic: Fix potential NULL pointer dereference in ionic_create_ibdev

Quoted 10 lines · Kamal Heib

The ionic_lif_netdev() function can return NULL if lif->netdev is not set, but the caller in ionic_create_ibdev() was not checking for this before dereferencing the returned pointer in addrconf_ifid_eui48().

Add a NULL check after calling ionic_lif_netdev() and return -ENODEV if no netdev is available.

Fixes 8d765af51a09 ("RDMA/ionic: Register auxiliary module for ionic ethernet adapter")
Signature · 2 lines
Regards,
Kalesh AP
Reviewed-by on v1 1/2
#4 lore raw

Re: [PATCH rdma-rc 1/2] RDMA/ionic: Fix potential NULL pointer dereference in ionic_query_device

In reply to Kamal Heib
Quoted 8 lines · Kamal Heib

The function ionic_query_device() calls ib_device_get_netdev() without checking the return value which could lead to NULL pointer dereference, Fix it by checking the return value and return -ENODEV if the 'ndev' is NULL.

Fixes 2075bbe8ef03 ("RDMA/ionic: Register device ops for miscellaneous functionality")
Signature · 2 lines
Regards,
Kalesh AP
#5 lore raw
In reply to Kamal Heib
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
author
#6 lore raw
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Thanks for your review, after taking a deeper look:

For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in netdev via netdev_priv() and they are allocated/freed together, lif->netdev cannot be NULL if lif is valid, Please drop this patch.

For Patch 1 (ionic_query_device): This one should remain. ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in multiple code paths:

- Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
- No port_data: if (!ib_dev->port_data) return NULL;
- NULL netdev pointer stored in port_data

Also, the return value from ib_device_get_netdev() is being checked in multiple places in both drivers and the RDMA core.

Let me know what you think?

Thanks,
Kamal

Quoted 15 lines
Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
#7 lore raw
Quoted 20 lines · Kamal Heib
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Thanks for your review, after taking a deeper look:

For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in netdev via netdev_priv() and they are allocated/freed together, lif->netdev cannot be NULL if lif is valid, Please drop this patch.

For Patch 1 (ionic_query_device): This one should remain. ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in multiple code paths:

Quoted 8 lines

- Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
- No port_data: if (!ib_dev->port_data) return NULL;
- NULL netdev pointer stored in port_data

Also, the return value from ib_device_get_netdev() is being checked in multiple places in both drivers and the RDMA core.

Let me know what you think?

I think that you shouldn't copy/paste answers from your favorite AI tool.

Thanks

Quoted 20 lines

Thanks,
Kamal

Quoted 15 lines
Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
author
#8 lore raw
Quoted 25 lines · Leon Romanovsky
Quoted 24 lines · Kamal Heib
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Thanks for your review, after taking a deeper look:

For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in netdev via netdev_priv() and they are allocated/freed together, lif->netdev cannot be NULL if lif is valid, Please drop this patch.

For Patch 1 (ionic_query_device): This one should remain. ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in multiple code paths:

- Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
- No port_data: if (!ib_dev->port_data) return NULL;
- NULL netdev pointer stored in port_data

Quoted 9 lines
Quoted 4 lines

Also, the return value from ib_device_get_netdev() is being checked in multiple places in both drivers and the RDMA core.

Let me know what you think?

I think that you shouldn't copy/paste answers from your favorite AI tool.

Thanks

With all due respect..., Your response is not contributing to the discussion about the patch, if you don't like the change or you think that it is not justified, you can say so.

Quoted 21 lines
Quoted 20 lines

Thanks,
Kamal

Quoted 15 lines
Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
#9 lore raw
Quoted 31 lines · Kamal Heib
Quoted 30 lines · Leon Romanovsky
Quoted 28 lines · Kamal Heib
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Thanks for your review, after taking a deeper look:

For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in netdev via netdev_priv() and they are allocated/freed together, lif->netdev cannot be NULL if lif is valid, Please drop this patch.

For Patch 1 (ionic_query_device): This one should remain. ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in multiple code paths:

- Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
- No port_data: if (!ib_dev->port_data) return NULL;
- NULL netdev pointer stored in port_data

Also, the return value from ib_device_get_netdev() is being checked in multiple places in both drivers and the RDMA core.

Let me know what you think?

Quoted 8 lines
Quoted 4 lines

I think that you shouldn't copy/paste answers from your favorite AI tool.

Thanks

With all due respect..., Your response is not contributing to the discussion about the patch, if you don't like the change or you think that it is not justified, you can say so.

Kamal,

You pasted a response from Claude/Codex while at the same time, you are expecting me to spend time and effort explaining why all of it does not apply to the current code.

Thanks

Quoted 23 lines
Quoted 22 lines
Quoted 21 lines

Thanks,
Kamal

Quoted 15 lines
Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
author
#10 lore raw
Quoted 41 lines · Leon Romanovsky
Quoted 31 lines · Kamal Heib
Quoted 30 lines · Leon Romanovsky
Quoted 28 lines · Kamal Heib
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Thanks for your review, after taking a deeper look:

For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in netdev via netdev_priv() and they are allocated/freed together, lif->netdev cannot be NULL if lif is valid, Please drop this patch.

For Patch 1 (ionic_query_device): This one should remain. ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in multiple code paths:

- Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
- No port_data: if (!ib_dev->port_data) return NULL;
- NULL netdev pointer stored in port_data

Also, the return value from ib_device_get_netdev() is being checked in multiple places in both drivers and the RDMA core.

Let me know what you think?

Quoted 8 lines
Quoted 4 lines

I think that you shouldn't copy/paste answers from your favorite AI tool.

Thanks

With all due respect..., Your response is not contributing to the discussion about the patch, if you don't like the change or you think that it is not justified, you can say so.

Quoted 6 lines

Kamal,

You pasted a response from Claude/Codex while at the same time, you are expecting me to spend time and effort explaining why all of it does not apply to the current code.

Lean,

AI is havely used in multiple kernel development areas including RDMA. Also, I think you should already know that from the company that you work for...

Many respected kernel developers already using AI as productivity tool, Judging a patch based on whether AI may have used or not is not a valid argument, again if you don't like the change or you think it is not justified, you can say so.

Quoted 26 lines

Thanks

Quoted 23 lines
Quoted 22 lines
Quoted 21 lines

Thanks,
Kamal

Quoted 15 lines
Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0
#11 lore raw
Quoted 4 lines · Kamal Heib

Many respected kernel developers already using AI as productivity tool, Judging a patch based on whether AI may have used or not is not a valid argument, again if you don't like the change or you think it is not justified, you can say so.

Do not copy and paste email prose from a chatbot into and pretend like you wrote it and did the thinking. If I want to talk to a chatbot I have access to every one available here and don't need someone else to sit in the middle.

If you are going to use AI as a productivity tool then you are still expected to critically review anything it gives out before sticking it into an email, and I vasly prefer to see something like "I used XYZ to research this and it said Blah and I think it is right" before cut and pasting AI.

Jason

#12 lore raw
In reply to Kamal Heib
Quoted 51 lines · Kamal Heib
Quoted 41 lines · Leon Romanovsky
Quoted 31 lines · Kamal Heib
Quoted 30 lines · Leon Romanovsky
Quoted 28 lines · Kamal Heib
Quoted 8 lines · Leon Romanovsky
Quoted 2 lines · Kamal Heib

Fix two potential NULL pointer dereferences in the ionic driver by adding the missing NULL checks before dereferencing netdev pointers.

How is it possible to have ionic IB driver without netdev?

Thanks

Thanks for your review, after taking a deeper look:

For Patch 2 (ionic_create_ibdev): You are right. Since lif is embedded in netdev via netdev_priv() and they are allocated/freed together, lif->netdev cannot be NULL if lif is valid, Please drop this patch.

For Patch 1 (ionic_query_device): This one should remain. ib_device_get_netdev() is a core RDMA API that explicitly returns NULL in multiple code paths:

- Invalid port: if (!rdma_is_port_valid(ib_dev, port)) return NULL;
- No port_data: if (!ib_dev->port_data) return NULL;
- NULL netdev pointer stored in port_data

Also, the return value from ib_device_get_netdev() is being checked in multiple places in both drivers and the RDMA core.

Let me know what you think?

Quoted 8 lines
Quoted 4 lines

I think that you shouldn't copy/paste answers from your favorite AI tool.

Thanks

With all due respect..., Your response is not contributing to the discussion about the patch, if you don't like the change or you think that it is not justified, you can say so.

Quoted 6 lines

Kamal,

You pasted a response from Claude/Codex while at the same time, you are expecting me to spend time and effort explaining why all of it does not apply to the current code.

Lean,

Quoted 8 lines

AI is havely used in multiple kernel development areas including RDMA. Also, I think you should already know that from the company that you work for...

Many respected kernel developers already using AI as productivity tool, Judging a patch based on whether AI may have used or not is not a valid argument, again if you don't like the change or you think it is not justified, you can say so.

Like Jason wrote, we have no issue with patches developed with the assistance of AI. We do, however, object to AI-generated emails and replies.

Thanks

Quoted 29 lines
Quoted 28 lines

Thanks

Quoted 23 lines
Quoted 22 lines
Quoted 21 lines

Thanks,
Kamal

Quoted 15 lines
Quoted 14 lines

Kamal Heib (2):
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_query_device
RDMA/ionic: Fix potential NULL pointer dereference in
ionic_create_ibdev

 drivers/infiniband/hw/ionic/ionic_ibdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Signature · 1 line
2.55.0