Skip to contentSkip to conversation

mm: memcg-v1: make mem_cgroup_oom_notify_cb() return void

PATCH Applied Guopeng Zhang 6 participants 6 messages Jul 13 – Jul 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: memcg-v1: make mem_cgroup_oom_notify_cb() return void

From: Guopeng Zhang <[email protected]>

Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the int return type required by the old callback interface.

The function now has a single direct caller and no failure path. Make it return void.

---
 mm/memcontrol-v1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/memcontrol-v1.c +1 -2
index e8b6e1560278..73bea1b5c8dd 100644
@@ -752,7 +752,7 @@ static int compare_thresholds(const void *a, const void *b)
 	return 0;
 }
 
-static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
+static void mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
 {
 	struct mem_cgroup_eventfd_list *ev;
 
@@ -762,7 +762,6 @@ static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
 		eventfd_signal(ev->eventfd);
 
 	spin_unlock(&memcg_oom_lock);
-	return 0;
 }
 
 static void mem_cgroup_oom_notify(struct mem_cgroup *memcg)
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the int return type required by the old callback interface.

The function now has a single direct caller and no failure path. Make it return void.

Thanks!

Quoted 27 lines
---
 mm/memcontrol-v1.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
mm/memcontrol-v1.c +1 -2
index e8b6e1560278..73bea1b5c8dd 100644
@@ -752,7 +752,7 @@ static int compare_thresholds(const void *a, const void *b)
 	return 0;
 }
 
-static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
+static void mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
 {
 	struct mem_cgroup_eventfd_list *ev;
 
@@ -762,7 +762,6 @@ static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
 		eventfd_signal(ev->eventfd);
 
 	spin_unlock(&memcg_oom_lock);
-	return 0;
 }
 
 static void mem_cgroup_oom_notify(struct mem_cgroup *memcg)
Signature · 1 line
2.43.0
Signature · 2 lines
Michal Hocko
SUSE Labs
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Guopeng Zhang
Quoted 11 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the int return type required by the old callback interface.

The function now has a single direct caller and no failure path. Make it return void.

reviewer Reviewed-by on v1 1/1
#3 lore raw
In reply to Guopeng Zhang
Quoted 11 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the int return type required by the old callback interface.

Quoted 4 lines

The function now has a single direct caller and no failure path. Make it return void.

Reviewed-by on v1 1/1
#4 lore raw
In reply to Guopeng Zhang
Quoted 9 lines · On Mon, 13 Jul 2026 17:37:37 +0800 Guopeng Zhang <[email protected]>…

From: Guopeng Zhang <[email protected]>

Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the int return type required by the old callback interface.

The function now has a single direct caller and no failure path. Make it return void.

Makes sense to me.

Quoted 2 lines

Thanks,
SJ

[...]

maintainer Acked-by on v1 1/1
#5 lore raw
In reply to Guopeng Zhang
Quoted 11 lines · Guopeng Zhang

From: Guopeng Zhang <[email protected]>

Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the int return type required by the old callback interface.

The function now has a single direct caller and no failure path. Make it return void.