extrausers: Terminate set_user_group post-process command
PATCH 1/1 extrausers: Terminate set_user_group post-process command
From: Anis Chali <[email protected]>
Add the missing command separator to prevent the command from being concatenated with subsequent ROOTFS_POSTPROCESS_COMMAND entries.
--- meta/classes/extrausers.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/extrausers.bbclass +1 -1
@@ -23,7 +23,7 @@ inherit useradd_base PACKAGE_INSTALL:append = " ${@['', 'base-passwd shadow'][bool(d.getVar('EXTRA_USERS_PARAMS'))]}" # Image level user / group settings -ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group" +ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group;" # Image level user / group settings set_user_group () {
Quoted 15 lines · On Mon Jul 13, 2026 at 5:29 PM CEST, chalianis1 via lists.openembedded.org…
From: Anis Chali <[email protected]>
Add the missing command separator to prevent the command from being concatenated with subsequent
ROOTFS_POSTPROCESS_COMMANDentries.Signed-off-by Anis Chali <[email protected]>--- meta/classes/extrausers.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/extrausers.bbclass +0
-0
meta/classes/extrausers.bbclass inherit useradd_base · line 29
Quoted 8 lines
meta/classes/extrausers.bbclass +1
-1@@ -23,7 +23,7 @@ inherit useradd_base PACKAGE_INSTALL:append = " ${@['', 'base-passwd shadow'][bool(d.getVar('EXTRA_USERS_PARAMS'))]}" # Image level user / group settings -ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group" +ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group;" # Image level user / group settings set_user_group () {
Hello,
ROOTFS_POSTPROCESS_COMMAND is not a shell command delimited by ';' but a space separated list of bitbake recipes functions. So the ROOTFS_POSTPROCESS_COMMAND:append = " ..." is correct here. If you have concatenation problem, they are likely caused by the next function not ensuring the space separation.
Also, FYI, we have a master-first policy, to accept this patch, similar patches would have been sent to master and wrynose.
Regards,
Signature · 2 lines
Yoann Congal Smile ECS
Hello,
You are right but there is something weired, this variable is ';' delimited in many layers like meta-security, meta-virtualization, meta-oe... but in poky the delimiter is a space as specified in the doc, I will double check to fix things in my side like adding space before my command or even reparse the command.
Thank's.
Anis C.
________________________________
From: Yoann Congal <[email protected]>
Sent: Monday, July 20, 2026 12:15 AM
To: [email protected] <[email protected]>; [email protected] <[email protected]>
Cc: Anis Chali <[email protected]>
Subject: Re: [OE-core] [scarthgap][PATCH] extrausers: Terminate set_user_group post-process command
[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
Quoted 15 lines · On Mon Jul 13, 2026 at 5:29 PM CEST, chalianis1 via lists.openembedded.org…
From: Anis Chali <[email protected]>
Add the missing command separator to prevent the command from being concatenated with subsequent
ROOTFS_POSTPROCESS_COMMANDentries.Signed-off-by Anis Chali <[email protected]>--- meta/classes/extrausers.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/extrausers.bbclass +0
-0
meta/classes/extrausers.bbclass inherit useradd_base · line 29
Quoted 8 lines
meta/classes/extrausers.bbclass +1
-1@@ -23,7 +23,7 @@ inherit useradd_base PACKAGE_INSTALL:append = " ${@['', 'base-passwd shadow'][bool(d.getVar('EXTRA_USERS_PARAMS'))]}" # Image level user / group settings -ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group" +ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group;" # Image level user / group settings set_user_group () {
Hello,
ROOTFS_POSTPROCESS_COMMAND is not a shell command delimited by ';' but a space separated list of bitbake recipes functions. So the ROOTFS_POSTPROCESS_COMMAND:append = " ..." is correct here. If you have concatenation problem, they are likely caused by the next function not ensuring the space separation.
Also, FYI, we have a master-first policy, to accept this patch, similar patches would have been sent to master and wrynose.
Regards,
--
Yoann Congal
Smile ECS
Quoted 11 lines · Anis Chali
Hello,
You are right but there is something weired, this variable is ';' delimited in many layers like meta-security, meta-virtualization, meta-oe... but in poky the delimiter is a space as specified in the doc, I will double check to fix things in my side like adding space before my command or even reparse the command.
Thank's.
Anis C.
";" works as a separator but only because there is this compatibility
code: https://git.openembedded.org/openembedded-core/tree/meta/lib/oe/utils.py#n270
New code shouldn't use ";".
Regards,
Quoted 49 lines
________________________________
From: Yoann Congal <[email protected]>
Sent: Monday, July 20, 2026 12:15 AM
To: [email protected] <[email protected]>; [email protected] <[email protected]>
Cc: Anis Chali <[email protected]>
Subject: Re: [OE-core] [scarthgap][PATCH] extrausers: Terminateset_user_grouppost-process command[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
Quoted 15 lines · On Mon Jul 13, 2026 at 5:29 PM CEST, chalianis1 via lists.openembedded.org…
From: Anis Chali <[email protected]>
Add the missing command separator to prevent the command from being concatenated with subsequent
ROOTFS_POSTPROCESS_COMMANDentries.Signed-off-by Anis Chali <[email protected]>--- meta/classes/extrausers.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/extrausers.bbclass +0
-0meta/classes/extrausers.bbclass inherit useradd_base · line 29
Quoted 8 lines
meta/classes/extrausers.bbclass +1
-1@@ -23,7 +23,7 @@ inherit useradd_base PACKAGE_INSTALL:append = " ${@['', 'base-passwd shadow'][bool(d.getVar('EXTRA_USERS_PARAMS'))]}" # Image level user / group settings -ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group" +ROOTFS_POSTPROCESS_COMMAND:append = " set_user_group;" # Image level user / group settings set_user_group () {Hello,
ROOTFS_POSTPROCESS_COMMANDis not a shell command delimited by ';' but a space separated list of bitbake recipes functions. So the ROOTFS_POSTPROCESS_COMMAND:append = " ..." is correct here. If you have concatenation problem, they are likely caused by the next function not ensuring the space separation.Also, FYI, we have a master-first policy, to accept this patch, similar patches would have been sent to master and wrynose.
Regards,
--
Yoann Congal
Smile ECS
Signature · 2 lines
Yoann Congal Smile ECS