FAILED: patch "[PATCH] mm: shrinker: fix NULL pointer dereference in debugfs" failed to apply to 6.1-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 6.1-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
git checkout FETCH_HEAD
git cherry-pick -x e30453c61e185e914fde83c650e268067b140218
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2026071340-handed-risk-625c@gregkh' --subject-prefix 'PATCH 6.1.y' 'HEAD^..'
Possible dependencies:
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From e30453c61e185e914fde83c650e268067b140218 Mon Sep 17 00:00:00 2001
From: Qi Zheng <[email protected]>
Date: Wed, 17 Jun 2026 17:00:52 +0800
Subject: [PATCH] mm: shrinker: fix NULL pointer dereference in debugfs
shrinker_debugfs_add() creates both "count" and "scan" debugfs files unconditionally.
That assumes every shrinker implements both count_objects() and scan_objects(), which is not guaranteed. For example, the xen-backend shrinker sets count_objects() but leaves scan_objects() NULL, so writing to its scan file calls through a NULL function pointer and panics the kernel:
BUG: kernel NULL pointer dereference, address: 0000000000000000 RIP: 0010:0x0 Code: Unable to access opcode bytes at 0xffffffffffffffd6. Call Trace: <TASK> shrinker_debugfs_scan_write+0x12e/0x270 full_proxy_write+0x5f/0x90 vfs_write+0xde/0x420 ? filp_flush+0x75/0x90 ? filp_close+0x1d/0x30 ? do_dup2+0xb8/0x120 ksys_write+0x68/0xf0 ? filp_flush+0x75/0x90 do_syscall_64+0xb3/0x5b0 entry_SYSCALL_64_after_hwframe+0x76/0x7e
The count path has the same issue in principle if a shrinker omits count_objects().
To fix it, only create "count" and "scan" debugfs files when the corresponding callbacks are present.
mm/shrinker_debug.c +6 -4
@@ -183,10 +183,12 @@ int shrinker_debugfs_add(struct shrinker *shrinker) } shrinker->debugfs_entry = entry; -debugfs_create_file ("count" ,0440 , entry, shrinker, - &shrinker_debugfs_count_fops); -debugfs_create_file ("scan" ,0220 , entry, shrinker, - &shrinker_debugfs_scan_fops); +if (shrinker->count_objects) +debugfs_create_file ("count" ,0440 , entry, shrinker, + &shrinker_debugfs_count_fops); +if (shrinker->scan_objects) +debugfs_create_file ("scan" ,0220 , entry, shrinker, + &shrinker_debugfs_scan_fops);return 0 ; }
Sasha Levin
maintainerPATCH 1/2 mm: shrinkers: fix debugfs file permissions
From: John Keeping <[email protected]>
[ Upstream commit 2124f79de6a909630d1a62b01ecc32db9f967181 ]
The permissions for the files here are swapped as "count" is read-only and "scan" is write-only. While this doesn't really matter as these permissions don't stop the files being opened for reading/writing as appropriate, they are shown by "ls -l" and are confusing.
Stable-dep-of: e30453c61e18 ("mm: shrinker: fix NULL pointer dereference in debugfs")
--- mm/shrinker_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/shrinker_debug.c +2 -2
@@ -198,9 +198,9 @@ int shrinker_debugfs_add(struct shrinker *shrinker) } shrinker->debugfs_entry = entry; -debugfs_create_file ("count" ,0220 , entry, shrinker, +debugfs_create_file ("count" ,0440 , entry, shrinker, &shrinker_debugfs_count_fops); -debugfs_create_file ("scan" ,0440 , entry, shrinker, +debugfs_create_file ("scan" ,0220 , entry, shrinker, &shrinker_debugfs_scan_fops);return 0 ; }
Signature · 1 line
2.53.0
Sasha Levin
maintainerPATCH 2/2 mm: shrinker: fix NULL pointer dereference in debugfs
From: Qi Zheng <[email protected]>
[ Upstream commit e30453c61e185e914fde83c650e268067b140218 ]
shrinker_debugfs_add() creates both "count" and "scan" debugfs files unconditionally.
That assumes every shrinker implements both count_objects() and scan_objects(), which is not guaranteed. For example, the xen-backend shrinker sets count_objects() but leaves scan_objects() NULL, so writing to its scan file calls through a NULL function pointer and panics the kernel:
BUG: kernel NULL pointer dereference, address: 0000000000000000 RIP: 0010:0x0 Code: Unable to access opcode bytes at 0xffffffffffffffd6. Call Trace: <TASK> shrinker_debugfs_scan_write+0x12e/0x270 full_proxy_write+0x5f/0x90 vfs_write+0xde/0x420 ? filp_flush+0x75/0x90 ? filp_close+0x1d/0x30 ? do_dup2+0xb8/0x120 ksys_write+0x68/0xf0 ? filp_flush+0x75/0x90 do_syscall_64+0xb3/0x5b0 entry_SYSCALL_64_after_hwframe+0x76/0x7e
The count path has the same issue in principle if a shrinker omits count_objects().
To fix it, only create "count" and "scan" debugfs files when the corresponding callbacks are present.
--- mm/shrinker_debug.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
mm/shrinker_debug.c +6 -4
@@ -198,10 +198,12 @@ int shrinker_debugfs_add(struct shrinker *shrinker) } shrinker->debugfs_entry = entry; -debugfs_create_file ("count" ,0440 , entry, shrinker, - &shrinker_debugfs_count_fops); -debugfs_create_file ("scan" ,0220 , entry, shrinker, - &shrinker_debugfs_scan_fops); +if (shrinker->count_objects) +debugfs_create_file ("count" ,0440 , entry, shrinker, + &shrinker_debugfs_count_fops); +if (shrinker->scan_objects) +debugfs_create_file ("scan" ,0220 , entry, shrinker, + &shrinker_debugfs_scan_fops);return 0 ; }
Signature · 1 line
2.53.0