iio: light: vcnl4000: make read-only const array regulator_names static
Subsystems (2)
PATCH 1/1 iio: light: vcnl4000: make read-only const array regulator_names static
Don't populate the read-only const array regulator_names on the stack at run time, instead make it static const char * const
Signed-off-by Colin Ian King <[email protected]>
--- drivers/iio/light/vcnl4000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/vcnl4000.c +1 -1
@@ -1922,7 +1922,7 @@ static void vcnl4000_cleanup(void *data)static int vcnl4000_probe (struct i2c_client *client) { -const char *const regulator_names[] = {"vdd" ,"vio" ,"vled" }; +static const char *const regulator_names[] = {"vdd" ,"vio" ,"vled" };struct device *dev = &client->dev;struct vcnl4000_data *data;struct iio_dev *indio_dev;
Signature · 1 line
2.53.0
Quoted 2 lines · Colin Ian King
Don't populate the read-only const array
regulator_nameson the stack at run time, instead make it static const char * const
Makes sense
Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jonathan Cameron
AppliedQuoted 7 lines · On Tue, 14 Jul 2026 20:05:32 +0300 Andy Shevchenko…
Quoted 2 lines · Colin Ian King
Don't populate the read-only const array
regulator_nameson the stack at run time, instead make it static const char * constMakes sense
Reviewed-by Andy Shevchenko <[email protected]>
Applied.
Thanks
J