gpio: bd72720: make read-only const arrays regs static
Subsystems (3)
PATCH 1/1 gpio: bd72720: make read-only const arrays regs static
Don't populate the read-only const arrays regs on the stack at run time, instead make them static.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/gpio/gpio-bd72720.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-)
drivers/gpio/gpio-bd72720.c +15 -9
@@ -85,9 +85,11 @@ static int bd72720gpi_get(struct bd72720_gpio *bdgpio, unsigned int reg_offset)static int bd72720gpo_get (struct bd72720_gpio *bdgpio,unsigned int offset) { -const int regs[] = {BD72720_REG_GPIO1_CTRL ,BD72720_REG_GPIO2_CTRL , -BD72720_REG_GPIO3_CTRL ,BD72720_REG_GPIO4_CTRL , -BD72720_REG_GPIO5_CTRL ,BD72720_REG_EPDEN_CTRL }; +static const int regs[] = { +BD72720_REG_GPIO1_CTRL ,BD72720_REG_GPIO2_CTRL , +BD72720_REG_GPIO3_CTRL ,BD72720_REG_GPIO4_CTRL , +BD72720_REG_GPIO5_CTRL ,BD72720_REG_EPDEN_CTRL + };int ret, val; ret =regmap_read (bdgpio->regmap, regs[offset], &val);
@@ -111,9 +113,11 @@ static int bd72720gpo_set(struct gpio_chip *chip, unsigned int offset, int value) {struct bd72720_gpio *bdgpio =gpiochip_get_data (chip); -const int regs[] = {BD72720_REG_GPIO1_CTRL ,BD72720_REG_GPIO2_CTRL , -BD72720_REG_GPIO3_CTRL ,BD72720_REG_GPIO4_CTRL , -BD72720_REG_GPIO5_CTRL ,BD72720_REG_EPDEN_CTRL }; +static const int regs[] = { +BD72720_REG_GPIO1_CTRL ,BD72720_REG_GPIO2_CTRL , +BD72720_REG_GPIO3_CTRL ,BD72720_REG_GPIO4_CTRL , +BD72720_REG_GPIO5_CTRL ,BD72720_REG_EPDEN_CTRL + };if (BIT (offset) & bdgpio->gpio_is_input) {dev_dbg (bdgpio->dev,"pin %d not output.\n" , offset);
@@ -132,9 +136,11 @@ static int bd72720_gpio_set_config(struct gpio_chip *chip, unsigned int offset, unsigned long config) {struct bd72720_gpio *bdgpio =gpiochip_get_data (chip); -const int regs[] = {BD72720_REG_GPIO1_CTRL ,BD72720_REG_GPIO2_CTRL , -BD72720_REG_GPIO3_CTRL ,BD72720_REG_GPIO4_CTRL , -BD72720_REG_GPIO5_CTRL ,BD72720_REG_EPDEN_CTRL }; +static const int regs[] = { +BD72720_REG_GPIO1_CTRL ,BD72720_REG_GPIO2_CTRL , +BD72720_REG_GPIO3_CTRL ,BD72720_REG_GPIO4_CTRL , +BD72720_REG_GPIO5_CTRL ,BD72720_REG_EPDEN_CTRL + };/* * We can only set the output mode, which makes sense only when output
Signature · 1 line
2.53.0
Bartosz Golaszewski
AppliedQuoted 4 lines · Colin Ian King
Don't populate the read-only const arrays regs on the stack at run time, instead make them static.
Applied, thanks!
[1/1] gpio: bd72720: make read-only const arrays regs static
https://git.kernel.org/brgl/c/a8e59e3ac9f7f7154e0e80f45933799da8b4dc89
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>